Antoine du Hamel
29bb2bb57d
doc: use parenthesis instead of em dash
...
PR-URL: https://github.com/nodejs/node/pull/42202
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-03-03 19:45:30 +00:00
Richard Lau
2d6aea7ff5
build: drop shortened URL from lint-commit-message
...
The shortened link to the commit message guidelines no longer works
after they were moved from `docs/guides` to `docs/contributing`. Now
that `core-validate-commit` outputs an error message pointing to the
full URL of the commit message guidelines on failure we no longer need
to include the URL (shortened or otherwise) in the workflow title.
PR-URL: https://github.com/nodejs/node/pull/42168
Refs: https://github.com/nodejs/core-validate-commit/pull/95
Refs: https://github.com/nodejs/node/issues/41697
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-03 16:15:47 +00:00
Michael Dawson
59b2fe68cc
doc: add next-10 to strategic initiatives
...
It was suggested to me that adding the next-10
effort to the strategic initiatives would be a good
way to keep the TSC up to date an in the loop on
the effort.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42167
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-03-03 10:57:40 -05:00
Xuguang Mei
54bc3c9afa
stream: use .chunk when calling adapters's writev
...
Fix: https://github.com/nodejs/node/issues/42157
PR-URL: https://github.com/nodejs/node/pull/42161
Fixes: https://github.com/nodejs/node/issues/42157
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2022-03-03 04:53:59 +00:00
Rich Trott
010cb71416
url: fix url.parse() for @hostname
...
Make url.parse() behave more like browsers and WHATWHG URL when dealing
with URLs that of the format `http:@example.com`. This is the same as
`http://example.com `.
This issue was reported by P0cas. https://github.com/P0cas
PR-URL: https://github.com/nodejs/node/pull/42136
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-03-02 14:34:54 -08:00
Juan José Arboleda
7724e78e47
doc: add missing single-quotes to http.OutgoingMessage
...
PR-URL: https://github.com/nodejs/node/pull/42162
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-03-02 14:30:37 -05:00
apeltop
d50efc691c
doc: fix typos
...
PR-URL: https://github.com/nodejs/node/pull/42146
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-03-02 14:55:53 +00:00
Jacob Smith
b67300f561
doc: add JakobJingleheimer to collaborators list
...
Fixes: https://github.com/nodejs/node/issues/42079
PR-URL: https://github.com/nodejs/node/pull/42185
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-03-02 15:00:19 +01:00
Rafael Silva
db6490cba2
http2: close stream and session on frameError
...
PR-URL: https://github.com/nodejs/node/pull/42147
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-03-02 12:53:11 +00:00
Tobias Nießen
ef30a226ce
src: remove dead code in AddFingerprintDigest
...
This function is never called with md_size == 0, and it would make no
sense to do so in the future either.
PR-URL: https://github.com/nodejs/node/pull/42145
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-01 16:21:18 +00:00
Michael Dawson
a9c0689786
crypto: fix return type prob reported by coverity
...
Coverity correctly reported that the value returned
by BIO_get_mem_data could be negative and the type
provided for the return value was unsigned.
Fix up the type and check.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42135
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-01 09:05:29 -05:00
Nikolaos Papaspyrou
3ba41246d2
test: update V8 trace events test expectations
...
The event "V8.GCScavenger" is soon to be deprecated. Most of V8
trace events are either behind flags and disabled by default, or
are emitted infrequently. Instead of replacing "V8.GCScavenger"
with some other random event, this patch updates the tests to
check that there is some event in the category "v8" whose name
starts with "V8.".
PR-URL: https://github.com/nodejs/node/pull/42120
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2022-03-01 12:41:32 +01:00
Rich Trott
ce1c53665e
doc: remove reference to obsolete security program
...
The ecosystem security program via HackerOne is no longer a thing.
Remove mention of it from SECURITY.md.
PR-URL: https://github.com/nodejs/node/pull/42144
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2022-03-01 04:40:12 +00:00
Michael Dawson
b3723fac05
build: fix usage of input in feature action
...
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42150
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-02-28 17:28:36 +00:00
Michael Dawson
a62972ab28
build: increase max ops for stale feature action
...
Set the limit to match the number used in the
close stalled action. Required as not all eligeable
stale features are being processed.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42130
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-28 11:16:15 -05:00
Node.js GitHub Bot
4cb2a47867
tools: update lint-md rollup dependencies
...
Update to @rollup/plugin-commonjs@21.0.2 rollup@2.68 .0
PR-URL: https://github.com/nodejs/node/pull/42141
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 22:33:39 +00:00
Xuguang Mei
38626e7f5d
buffer: improve blob read performance
...
Fix: https://github.com/nodejs/node/issues/42108
PR-URL: https://github.com/nodejs/node/pull/42117
Fixes: https://github.com/nodejs/node/issues/42108
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-27 18:48:47 +00:00
小菜
04c68ba54a
http: add default argument for Agent.prototype.getName
...
PR-URL: https://github.com/nodejs/node/pull/41906
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Ricky Zhou <0x19951125@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-27 15:01:01 +00:00
Tobias Nießen
0f2ab70542
src: combine GetCurveASN1Name and GetCurveNistName
...
PR-URL: https://github.com/nodejs/node/pull/42118
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 14:24:52 +00:00
Tobias Nießen
0b5e8e01ab
src: simplify TLSWrap::SetSession
...
PR-URL: https://github.com/nodejs/node/pull/42087
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 14:07:42 +00:00
Tobias Nießen
2cdf8a44e9
src: prefer bool over int in crypto_common
...
PR-URL: https://github.com/nodejs/node/pull/42097
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 14:06:02 +00:00
Tobias Nießen
a41992de9e
src: simplify arg type of AddFingerprintDigest
...
PR-URL: https://github.com/nodejs/node/pull/42101
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 14:05:51 +00:00
Tobias Nießen
1ce42ec18b
src: do not ignore return value of BIO_reset
...
The USE macro indicates that a value is intentionally ignored. Instead,
CHECK that the function succeeds.
PR-URL: https://github.com/nodejs/node/pull/42103
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 14:05:42 +00:00
Tobias Nießen
f71fca769e
src: simplify GetExponentString
...
PR-URL: https://github.com/nodejs/node/pull/42121
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 14:05:34 +00:00
Livia Medeiros
80bfb9b21a
fs: adjust default length for fs.readSync and fsPromises/read
...
Makes default length reasonable when nonzero offset is set.
PR-URL: https://github.com/nodejs/node/pull/42128
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-02-27 12:56:09 +00:00
Yash Ladha
135fa65010
deps: update nghttp2 to 1.47.0
...
Added script to update nghttp2 in future. One can use
```sh
$ ./tools/update-nghttp2.sh 1.47.0
```
It will automatically copy and update the nghttps in deps.
Fixes: https://github.com/nodejs/node/issues/42089
PR-URL: https://github.com/nodejs/node/pull/42127
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 12:28:04 +00:00
Bradley Farias
f860b3810f
esm: fix relative imports for https
...
PR-URL: https://github.com/nodejs/node/pull/42119
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Ricky Zhou <0x19951125@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-02-27 09:20:42 +00:00
Node.js GitHub Bot
6b6bada16a
meta: update AUTHORS
...
PR-URL: https://github.com/nodejs/node/pull/42142
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-02-27 07:51:43 +00:00
Node.js GitHub Bot
a5ff22c98f
tools: update eslint to 8.10.0
...
PR-URL: https://github.com/nodejs/node/pull/42143
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-02-27 07:51:36 +00:00
Antoine du Hamel
6ee4228498
crypto: validate this value for webcrypto.getRandomValues
...
PR-URL: https://github.com/nodejs/node/pull/41760
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-02-26 17:12:48 +00:00
Filip Skokan
aa97c9d973
crypto: add KeyObject.prototype.equals method
...
PR-URL: https://github.com/nodejs/node/pull/42093
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-02-26 13:51:09 +00:00
Bryan English
bcc523e389
doc: add release key for Bryan English
...
Adds Bryan English and his public key to the README for releases.
PR-URL: https://github.com/nodejs/node/pull/42102
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com >
2022-02-26 08:48:37 -05:00
Gang Chen
de77515a77
lib: clean after the cancel algorithm throw error
...
PR-URL: https://github.com/nodejs/node/pull/41366
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
2022-02-26 13:19:42 +00:00
apeltop
5f21a2b746
doc: remove repeated a word
...
PR-URL: https://github.com/nodejs/node/pull/42138
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-26 10:52:52 +00:00
Xuguang Mei
150e3f7a05
perf_hooks: do not return all entries with getEntriesBy[Name|Type]
...
Fix: https://github.com/nodejs/node/issues/42028
PR-URL: https://github.com/nodejs/node/pull/42104
Fixes: https://github.com/nodejs/node/issues/42028
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-02-26 08:46:59 +00:00
npm team
1b8300b238
deps: upgrade npm to 8.5.2
...
PR-URL: https://github.com/nodejs/node/pull/42122
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-02-26 08:15:26 +01:00
Maël Nison
e84b635db4
build: add corepack to the auto-updated dependencies
...
PR-URL: https://github.com/nodejs/node/pull/42090
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-25 22:36:05 +00:00
Benjamin E. Coe
65b60b5676
errors: do not access .stack in debug
...
Refs: #41541
PR-URL: https://github.com/nodejs/node/pull/42096
Refs: https://github.com/nodejs/node/issues/41541
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-25 21:20:51 +00:00
Michael Dawson
5a65853063
build: last test of the stale feature action
...
- set the days so that we process ~ 40 issues
so that we can see what kind of feedback we get
on saying we are going to close stale feature requests
- set the label to stale instead of stalled so that
there is no race with the action that closes stalled
issues
- fix the links to the feature management doc
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42085
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2022-02-25 10:53:28 -05:00
Lu Yahan
2f7920c208
deps: V8: cherry-pick 77d515484864
...
Original commit message:
[riscv64] Move explicit specialization into .cc file
Building with Gcc-10 causes error "explicit specialization in non-namespace scope".
This change fixes it.
Bug: v8:12649
Change-Id: I36b2b042b336c2dfd32ba5541fdbbdb8dc8b4fd7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3473997
Reviewed-by: ji qiu <qiuji@iscas.ac.cn >
Commit-Queue: ji qiu <qiuji@iscas.ac.cn >
Cr-Commit-Position: refs/heads/main@{#79185}
Refs: https://github.com/v8/v8/commit/77d515484864984f721d6726610f314982ac44d2
PR-URL: https://github.com/nodejs/node/pull/42067
Refs: https://github.com/v8/v8/commit/b66334313c8bd73b253d0779f59f3e8656967043
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mary Marchini <oss@mmarchini.me >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Stewart X Addison <sxa@redhat.com >
2022-02-25 15:28:38 +00:00
Lu Yahan
92d6c40ae8
deps: V8: cherry-pick b66334313c8b
...
Original commit message:
[riscv64] use callee save register in regexp
Bug: v8:12502
Change-Id: I8d1b599fc945e276b70901953368768594470204
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3343861
Reviewed-by: ji qiu <qiuji@iscas.ac.cn >
Commit-Queue: ji qiu <qiuji@iscas.ac.cn >
Cr-Commit-Position: refs/heads/main@{#78421}
Refs: https://github.com/v8/v8/commit/b66334313c8bd73b253d0779f59f3e8656967043
PR-URL: https://github.com/nodejs/node/pull/42067
Refs: https://github.com/v8/v8/commit/77d515484864984f721d6726610f314982ac44d2
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mary Marchini <oss@mmarchini.me >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Stewart X Addison <sxa@redhat.com >
2022-02-25 15:28:37 +00:00
Robert Nagy
1b47866a1d
stream: allow returning null from pipeline tail
...
PR-URL: https://github.com/nodejs/node/pull/42078
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-02-25 13:31:20 +00:00
Balakrishna Avulapati
d5e94fa712
doc: make building with ninja more discoverable
...
Building with ninja would speed up the build
We have the documenation about building with ninja,
but not easily discoverable.
And present this early to the contributors.
PR-URL: https://github.com/nodejs/node/pull/41840
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2022-02-25 03:20:41 +00:00
Luigi Pinca
626367c4e3
test: deflake test-common-expect-warning
...
The subprocess might exit before the data is flushed. Run the assertion
after the `'end'` event is emitted.
PR-URL: https://github.com/nodejs/node/pull/42046
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-24 21:08:15 +01:00
Austin Kelleher
663a669b0b
node-api: fix typo in node_api.cc
...
PR-URL: https://github.com/nodejs/node/pull/42110
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2022-02-24 19:04:50 +01:00
Paolo Insogna
9be1dcff34
doc,tools: improve navigability of API docs
...
PR-URL: https://github.com/nodejs/node/pull/41404
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-24 12:00:42 +01:00
Shelley Vohr
0367b5c35e
src: allow preventing InitializeInspector in env
...
PR-URL: https://github.com/nodejs/node/pull/35025
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-23 23:32:30 +00:00
Benjamin Gruenbaum
7efef74585
module: prefer async/await in https imports
...
PR-URL: https://github.com/nodejs/node/pull/41950
Fixes: https://github.com/nodejs/node/issues/41950
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-23 23:59:52 +02:00
Benjamin Gruenbaum
fd3997bcc9
stream: port more test262 tests
...
Add some test262 tests for `every`, add some `length` checks.
Turns out properties need to be writable after all according to the
test262 tests.
PR-URL: https://github.com/nodejs/node/pull/41974
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-23 21:06:00 +00:00
Arnold Zokas
debd87cd9b
doc: document change to IncomingMessage.headers enumerability
...
The IncomingMessage.headers property was made non-enumerable
in PR #35281 .
PR-URL: https://github.com/nodejs/node/pull/42095
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Harshitha K P <harshitha014@gmail.com >
2022-02-23 18:16:50 +00:00