Xuguang Mei
54bc3c9afa
stream: use .chunk when calling adapters's writev
...
Fix: https://github.com/nodejs/node/issues/42157
PR-URL: https://github.com/nodejs/node/pull/42161
Fixes: https://github.com/nodejs/node/issues/42157
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2022-03-03 04:53:59 +00:00
Rich Trott
010cb71416
url: fix url.parse() for @hostname
...
Make url.parse() behave more like browsers and WHATWHG URL when dealing
with URLs that of the format `http:@example.com`. This is the same as
`http://example.com `.
This issue was reported by P0cas. https://github.com/P0cas
PR-URL: https://github.com/nodejs/node/pull/42136
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-03-02 14:34:54 -08:00
Rafael Silva
db6490cba2
http2: close stream and session on frameError
...
PR-URL: https://github.com/nodejs/node/pull/42147
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-03-02 12:53:11 +00:00
Xuguang Mei
38626e7f5d
buffer: improve blob read performance
...
Fix: https://github.com/nodejs/node/issues/42108
PR-URL: https://github.com/nodejs/node/pull/42117
Fixes: https://github.com/nodejs/node/issues/42108
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-27 18:48:47 +00:00
小菜
04c68ba54a
http: add default argument for Agent.prototype.getName
...
PR-URL: https://github.com/nodejs/node/pull/41906
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Ricky Zhou <0x19951125@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-27 15:01:01 +00:00
Livia Medeiros
80bfb9b21a
fs: adjust default length for fs.readSync and fsPromises/read
...
Makes default length reasonable when nonzero offset is set.
PR-URL: https://github.com/nodejs/node/pull/42128
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-02-27 12:56:09 +00:00
Bradley Farias
f860b3810f
esm: fix relative imports for https
...
PR-URL: https://github.com/nodejs/node/pull/42119
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Ricky Zhou <0x19951125@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-02-27 09:20:42 +00:00
Antoine du Hamel
6ee4228498
crypto: validate this value for webcrypto.getRandomValues
...
PR-URL: https://github.com/nodejs/node/pull/41760
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-02-26 17:12:48 +00:00
Filip Skokan
aa97c9d973
crypto: add KeyObject.prototype.equals method
...
PR-URL: https://github.com/nodejs/node/pull/42093
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-02-26 13:51:09 +00:00
Gang Chen
de77515a77
lib: clean after the cancel algorithm throw error
...
PR-URL: https://github.com/nodejs/node/pull/41366
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
2022-02-26 13:19:42 +00:00
Xuguang Mei
150e3f7a05
perf_hooks: do not return all entries with getEntriesBy[Name|Type]
...
Fix: https://github.com/nodejs/node/issues/42028
PR-URL: https://github.com/nodejs/node/pull/42104
Fixes: https://github.com/nodejs/node/issues/42028
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-02-26 08:46:59 +00:00
Benjamin E. Coe
65b60b5676
errors: do not access .stack in debug
...
Refs: #41541
PR-URL: https://github.com/nodejs/node/pull/42096
Refs: https://github.com/nodejs/node/issues/41541
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-25 21:20:51 +00:00
Robert Nagy
1b47866a1d
stream: allow returning null from pipeline tail
...
PR-URL: https://github.com/nodejs/node/pull/42078
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-02-25 13:31:20 +00:00
Benjamin Gruenbaum
7efef74585
module: prefer async/await in https imports
...
PR-URL: https://github.com/nodejs/node/pull/41950
Fixes: https://github.com/nodejs/node/issues/41950
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-23 23:59:52 +02:00
Benjamin Gruenbaum
fd3997bcc9
stream: port more test262 tests
...
Add some test262 tests for `every`, add some `length` checks.
Turns out properties need to be writable after all according to the
test262 tests.
PR-URL: https://github.com/nodejs/node/pull/41974
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-23 21:06:00 +00:00
madflow
60c71f35ee
process: fix named report export
...
PR-URL: https://github.com/nodejs/node/pull/41861
Fixes: https://github.com/nodejs/node/issues/41774
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-23 18:37:55 +02:00
meixg
dc28d6315d
repl: remove preview when press escape
...
Fix: https://github.com/nodejs/node/issues/42040
PR-URL: https://github.com/nodejs/node/pull/42053
Fixes: https://github.com/nodejs/node/issues/42040
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-02-22 17:30:02 -08:00
Antoine du Hamel
470c2845cc
crypto: clarify require("crypto").getRandomValues is Node.js specific
...
Refs: https://github.com/nodejs/node/pull/41779
Refs: https://github.com/nodejs/node/pull/41760
PR-URL: https://github.com/nodejs/node/pull/41782
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2022-02-22 17:51:50 +01:00
Paolo Insogna
45b5ca810a
net: add new options to net.Socket and net.Server
...
PR-URL: https://github.com/nodejs/node/pull/41310
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-22 10:58:30 +00:00
Michaël Zasso
4944ad0b9e
lib: enable fetch by default
...
PR-URL: https://github.com/nodejs/node/pull/41811
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
2022-02-21 12:34:13 +00:00
Antoine du Hamel
df0e665263
lib: add legacy built-in functions to primordials
...
PR-URL: https://github.com/nodejs/node/pull/42049
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-21 12:32:49 +01:00
Xuguang Mei
6abd71e2d9
perf_hooks: use arrays to store EntryBuffers
...
Also order entries by startTime when calling getEntriesByType.
Fix: https://github.com/nodejs/node/issues/42004
Fix: https://github.com/nodejs/node/issues/42024
PR-URL: https://github.com/nodejs/node/pull/42032
Fixes: https://github.com/nodejs/node/issues/42004
Fixes: https://github.com/nodejs/node/issues/42024
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-20 22:57:31 +00:00
Antoine du Hamel
53364a2ec6
tools: add console to the list of restricted globals
...
PR-URL: https://github.com/nodejs/node/pull/42012
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-19 19:00:55 +00:00
wbt
246227f4bc
fs: fix default length parameter for fs.read
...
Currently, specifying an `offset` without a `length`
throws an `ERR_OUT_OF_RANGE` error.
This commit provides a more sensible default.
This change should only affect cases
where no length is specified and a nonzero offset is,
which are currently throwing errors.
PR-URL: https://github.com/nodejs/node/pull/40349
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-19 18:22:46 +01:00
Antoine du Hamel
3a1a440802
esm: improve fetch_module test coverage and remove hack
...
PR-URL: https://github.com/nodejs/node/pull/41947
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
2022-02-19 16:35:46 +00:00
Jacob Smith
8843381d9f
esm: remove erroneous context.parentURL property passed to load hook
...
PR-URL: https://github.com/nodejs/node/pull/41975
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-18 18:55:58 +00:00
Michaël Zasso
68c4b8d56d
lib: add FormData global when fetch is enabled
...
PR-URL: https://github.com/nodejs/node/pull/41956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-18 15:46:32 +00:00
Antoine du Hamel
6e56badf18
worker: fix typo in debug statement
...
PR-URL: https://github.com/nodejs/node/pull/42011
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-02-18 11:37:45 +00:00
Antoine du Hamel
2ff61fd1cd
tools: add timers functions to the list of restricted globals
...
PR-URL: https://github.com/nodejs/node/pull/42013
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-18 11:37:36 +00:00
Antoine du Hamel
3aab9860d7
tools,lib: remove global and Intl from the list of globals
...
Refs: https://github.com/nodejs/node/pull/38230
Refs: https://github.com/nodejs/node/pull/38419
PR-URL: https://github.com/nodejs/node/pull/42014
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Shingo Inoue <leko.noor@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-02-18 11:37:26 +00:00
Xuguang Mei
7d75e3f542
debugger: add debugger alias for exec(expr)
...
https://github.com/nodejs/node/issues/41794
PR-URL: https://github.com/nodejs/node/pull/41907
Reviewed-By: Jan Krems <jan.krems@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-02-17 19:23:20 +00:00
Mestery
fdab137e64
lib: stop installing webcrypto if no_browser_globals is true
...
Refs: https://github.com/nodejs/node/pull/41969#issuecomment-1039448684
PR-URL: https://github.com/nodejs/node/pull/41971
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-17 07:04:39 +00:00
Sean Quinlan
26f9a91cc9
lib: allow respondWithNewView on byob auto allocated streams
...
Fixes: https://github.com/nodejs/node/issues/41886
PR-URL: https://github.com/nodejs/node/pull/41887
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-02-16 22:28:56 +00:00
Benjamin Gruenbaum
0a722973cb
events: set default handler value
...
Event handler like BroadcastChannel.onmessage and AbortSignal.onabort
have a default value of `null` but we return `undefined`.
Return `null` and add a test.
PR-URL: https://github.com/nodejs/node/pull/41970
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2022-02-16 19:36:20 +00:00
Darshan Sen
a82c1a1da7
lib: stop installing fetch if no_browser_globals is true
...
Fixes: https://github.com/nodejs/node/issues/41816
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/41969
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-02-16 16:53:43 +00:00
Antoine du Hamel
551ca6877c
lib: restrict usage of fetch related globals in core internals
...
PR-URL: https://github.com/nodejs/node/pull/41957
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2022-02-16 14:22:59 +01:00
Antoine du Hamel
daf8a468d5
doc: fix deprecation number
...
Refs: https://github.com/nodejs/node/pull/41872
Refs: https://github.com/nodejs/node/pull/41896
PR-URL: https://github.com/nodejs/node/pull/41990
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-02-15 19:55:56 +01:00
Marcos Bjoerkelund
cee626d0f5
fs: support copy of relative links with cp and cpSync
...
Fixes: https://github.com/nodejs/node/issues/41693
PR-URL: https://github.com/nodejs/node/pull/41819
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-02-15 12:14:04 +00:00
Xuguang Mei
9fb7ac3bbd
stream: need to cleanup event listeners if last stream is readable
...
fix: https://github.com/nodejs/node/issues/35452
PR-URL: https://github.com/nodejs/node/pull/41954
Fixes: https://github.com/nodejs/node/issues/35452
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2022-02-15 10:15:14 +00:00
Mestery
8e653d9898
build,tools: change the quotes in YAML
...
Remove useless quotes and use single quotes when needed.
PR-URL: https://github.com/nodejs/node/pull/41756
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
2022-02-14 19:09:17 +01:00
Benjamin Gruenbaum
aff8b874e3
fs: fix cb/sync writev empty array behavior
...
PR-URL: https://github.com/nodejs/node/pull/41932
Refs: https://github.com/nodejs/node/issues/41910
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-14 18:29:44 +02:00
Antoine du Hamel
849991c6c4
crypto: expose Web Crypto API on the global scope
...
PR-URL: https://github.com/nodejs/node/pull/41938
Refs: https://developer.mozilla.org/en-US/docs/Web/API/crypto_property
Refs: https://github.com/nodejs/node/pull/41782
Refs: https://w3c.github.io/webcrypto
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2022-02-14 16:14:49 +00:00
Valters Jansons
a987ba16f8
tls: avoid throw in onerror for bad TLSSocket obj
...
TLSWrap.onerror has a helpful debug() call built in to it. However in
case of a malformed TLSSocket object, where the `_tlsOptions` value is
an unexpected `undefined`, accessing `_tlsOptions.isServer` causes
a TypeError to be thrown.
This commit ensures that the debug() call properly logs the state as
'unknown', instead of the two 'server' and 'client' choices previously
available. Additionally, onerror branching is adjusted to allow such
`undefined` options object, by use of optional chaining.
Other methods are not being adjusted, as such a case of `undefined`
options is not viable during regular processing of the TLSSocket.
Fixes: https://github.com/nodejs/node/issues/41501
PR-URL: https://github.com/nodejs/node/pull/41523
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-02-14 08:08:37 +00:00
Benjamin Gruenbaum
60b8e79599
process: runtime deprecate multipleResolves
...
PR-URL: https://github.com/nodejs/node/pull/41896
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-13 23:30:36 +02:00
Benjamin Gruenbaum
ceaa299958
stream: revert revert map spec compliance
...
This reverts commit 91d28d8b46 .
PR-URL: https://github.com/nodejs/node/pull/41933
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2022-02-13 17:02:20 +00:00
Benjamin Gruenbaum
a137eca069
fs: fix writev empty array error behavior
...
PR-URL: https://github.com/nodejs/node/pull/41919
Fixes: https://github.com/nodejs/node/issues/41910
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
2022-02-12 17:57:52 +00:00
Michael Scovetta
30c742fe12
esm: fix typo in fetch_module
...
This PR fixes a minor typo in fetchModule's check for `[eval]` and
`[stdin]` parent names.
PR-URL: https://github.com/nodejs/node/pull/41924
Fixes: https://github.com/nodejs/node/issues/41922
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-02-12 16:45:30 +01:00
Mestery
998e5acc69
lib: move kEnumerableProperty to internal/util
...
PR-URL: https://github.com/nodejs/node/pull/41877
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-11 17:30:47 +00:00
Benjamin Gruenbaum
91d28d8b46
stream: revert map spec compliance
...
PR-URL: https://github.com/nodejs/node/pull/41931
Fixes: https://github.com/nodejs/node/issues/41926
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
2022-02-11 14:11:12 +01:00
小菜
08938a1531
fs: refactor to use ES2020 syntax
...
PR-URL: https://github.com/nodejs/node/pull/41903
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-11 14:02:12 +01:00