Node.js GitHub Bot
4cb2a47867
tools: update lint-md rollup dependencies
...
Update to @rollup/plugin-commonjs@21.0.2 rollup@2.68 .0
PR-URL: https://github.com/nodejs/node/pull/42141
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 22:33:39 +00:00
Yash Ladha
135fa65010
deps: update nghttp2 to 1.47.0
...
Added script to update nghttp2 in future. One can use
```sh
$ ./tools/update-nghttp2.sh 1.47.0
```
It will automatically copy and update the nghttps in deps.
Fixes: https://github.com/nodejs/node/issues/42089
PR-URL: https://github.com/nodejs/node/pull/42127
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 12:28:04 +00:00
Node.js GitHub Bot
a5ff22c98f
tools: update eslint to 8.10.0
...
PR-URL: https://github.com/nodejs/node/pull/42143
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-02-27 07:51:36 +00:00
Paolo Insogna
9be1dcff34
doc,tools: improve navigability of API docs
...
PR-URL: https://github.com/nodejs/node/pull/41404
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-24 12:00:42 +01:00
Node.js GitHub Bot
916227b3ed
tools: update lint-md-dependencies to rollup@2.67.3
...
PR-URL: https://github.com/nodejs/node/pull/42057
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-02-21 01:36:12 +00:00
Antoine du Hamel
5d4da62514
tools: lint deprecation codes
...
Add a rule to make sure deprecation codes are in order.
PR-URL: https://github.com/nodejs/node/pull/41992
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-19 18:14:09 +01:00
Antoine du Hamel
6700b5c9e1
tools: fix bugs in prefer-primordials linter rule
...
The ESLint rule would repport false positive if code is using an
identifier that happens to have the same name as a primordials member.
PR-URL: https://github.com/nodejs/node/pull/42010
Reviewed-By: Shingo Inoue <leko.noor@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-02-18 18:42:02 +00:00
Michaël Zasso
68c4b8d56d
lib: add FormData global when fetch is enabled
...
PR-URL: https://github.com/nodejs/node/pull/41956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-18 15:46:32 +00:00
Rich Trott
835cdd537b
tools: update remark-preset-lint-node to 3.3.1
...
PR-URL: https://github.com/nodejs/node/pull/41999
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-16 12:44:06 +01:00
Luigi Pinca
495825bc18
tools: update ESLint to 8.9.0
...
PR-URL: https://github.com/nodejs/node/pull/41973
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-02-15 05:17:13 -08:00
Node.js GitHub Bot
cc505a505a
tools: update lint-md-dependencies to rollup@2.67.2
...
PR-URL: https://github.com/nodejs/node/pull/41941
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-14 17:53:37 -08:00
Mestery
8e653d9898
build,tools: change the quotes in YAML
...
Remove useless quotes and use single quotes when needed.
PR-URL: https://github.com/nodejs/node/pull/41756
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
2022-02-14 19:09:17 +01:00
Ben Noordhuis
214d7da675
build: remove broken x32 arch support
...
I added support for x32 back in 2014 but it's been in a state of
disrepair ever since, not in the least because it was never a fully
supported architecture in upstream V8.
V8 dropped x32 support entirely in or around 2018 so the removal from
Node's build system is long overdue.
Refs: https://github.com/nodejs/node/issues/40576
PR-URL: https://github.com/nodejs/node/pull/41905
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-02-11 08:52:24 +00:00
Ikko Ashimine
0dce87e279
tools: fix typo in prefer-primordials.js
...
replacable -> replaceable
PR-URL: https://github.com/nodejs/node/pull/41891
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Qingyu Deng <i@ayase-lab.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-02-08 16:41:40 +00:00
Michael Dawson
5f348b4572
test: move test-crypto-engine to addon
...
Fixes: https://github.com/nodejs/node/issues/41633
Fixes: https://github.com/nodejs/node/issues/40958
- move test-crypto-engine so that dummy engine
is only built if tests are run
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/41830
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2022-02-07 17:29:54 -05:00
Node.js GitHub Bot
912c297b7a
tools: update lint-md-dependencies to rollup@2.67.0
...
PR-URL: https://github.com/nodejs/node/pull/41737
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-05 04:44:31 -08:00
Node.js GitHub Bot
fadd442fb5
tools: update doc to rehype-stringify@9.0.3
...
PR-URL: https://github.com/nodejs/node/pull/41854
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-05 12:43:00 +00:00
Michaël Zasso
8a3f28a05c
tools: add v8-embedder-state-scope.h to distributed headers
...
PR-URL: https://github.com/nodejs/node/pull/41610
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2022-02-02 17:25:04 +01:00
Michaël Zasso
86b77f7d0f
tools,doc: use V8::DisposePlatform
...
V8::ShutdownPlatform has been deprecated and does the same.
PR-URL: https://github.com/nodejs/node/pull/41610
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2022-02-02 17:25:01 +01:00
Michaël Zasso
30c4e1d952
tools: update V8 gypfiles for 9.8
...
PR-URL: https://github.com/nodejs/node/pull/41610
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2022-02-02 17:24:58 +01:00
Michaël Zasso
6ec2253926
lib: add fetch
...
Fixes: https://github.com/nodejs/node/issues/19393
PR-URL: https://github.com/nodejs/node/pull/41749
Refs: https://github.com/nodejs/undici/pull/1183
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Gus Caplan <me@gus.host >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2022-02-01 08:17:50 +00:00
Node.js GitHub Bot
39e26ae2e5
tools: update eslint to 8.8.0
...
PR-URL: https://github.com/nodejs/node/pull/41738
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-01-29 19:34:51 +00:00
himself65
2818fa6089
build: check if python is a executable program
...
After Windows 10 version 1903, placeholder files named "python.exe"
and "python3.exe" appear, not executable programs, and open the
MS Store when running without parameters.
Fixes: https://github.com/nodejs/node/issues/36694
Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update
PR-URL: https://github.com/nodejs/node/pull/36696
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-01-29 01:31:12 +00:00
Tobias Nießen
334fb38435
tools: use Set instead of { [key]: true } object
...
Refs: https://github.com/nodejs/node/pull/41675
PR-URL: https://github.com/nodejs/node/pull/41695
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-01-28 16:41:16 +00:00
Tobias Nießen
400b7c242b
tools: use Set instead of { [key]: true } object
...
PR-URL: https://github.com/nodejs/node/pull/41675
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-01-24 11:46:47 +00:00
Tobias Nießen
c18ca140a1
tools: fix typo in tools/code_cache/README.md
...
PR-URL: https://github.com/nodejs/node/pull/41657
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-01-23 12:31:42 +01:00
Node.js GitHub Bot
b09d1f4f04
tools: update lint-md-dependencies to rollup@2.65.0
...
PR-URL: https://github.com/nodejs/node/pull/41638
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Yash Ladha <yash@yashladha.in >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2022-01-23 00:55:09 +00:00
alexcfyung and Gaby Baghdadi
ec1364b6ae
build: enable zoslib installation on z/OS
...
zoslib is a C/C++ runtime library and an extended implementation
of the z/OS LE C Runtime Library.
PR-URL: https://github.com/nodejs/node/pull/41493
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com >
2022-01-21 14:21:52 -05:00
Michaël Zasso
1ad44094a2
tools: update V8 gypfiles for 9.7
...
PR-URL: https://github.com/nodejs/node/pull/40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-01-20 10:40:28 +01:00
Shi Pujin
81e88f27b7
build: add loong64 configure
...
PR-URL: https://github.com/nodejs/node/pull/41323
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Mary Marchini <oss@mmarchini.me >
2022-01-18 19:39:50 +00:00
Michael Dawson
a199387f04
doc: make contributing info more discoverable
...
There are been several discussions in recent PRs about
the docs related to contributing not being very discoverable.
Move these docs from doc/guides/ to doc/contributing.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/41408
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is >
Reviewed-By: Mary Marchini <oss@mmarchini.me >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-01-18 14:24:30 -05:00
Node.js GitHub Bot
cc97ea5df6
tools: update lint-md-dependencies
...
Update to @rollup/plugin-node-resolve@13.1.3, rollup@2.64 .0, and
to-vfile@7.2.3.
PR-URL: https://github.com/nodejs/node/pull/41440
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-01-18 06:55:57 -08:00
Rich Trott
6beee312a4
tools: bump eslint from 8.6.0 to 8.7.0
...
PR-URL: https://github.com/nodejs/node/pull/41570
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2022-01-18 05:21:01 +00:00
Node.js GitHub Bot
5f4f8d417a
tools: update doc to highlight.js@11.4.0 to-vfile@7.2.3
...
PR-URL: https://github.com/nodejs/node/pull/41441
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-01-17 15:20:02 +00:00
Antoine du Hamel
87325917ec
doc: clarify module system selection
...
Refs: https://github.com/nodejs/node/pull/41345#discussion_r777115823
PR-URL: https://github.com/nodejs/node/pull/41383
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
2022-01-17 11:36:19 +01:00
Rich Trott
426df1b836
tools: fix small not-quite-a-bug in find-inactive-tsc.mjs
...
The current code attempts to count votes from people who were not
members at the start of the 3 month period, resulting in `NaN` being
tallied for their votes.
PR-URL: https://github.com/nodejs/node/pull/41469
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Tierney Cyren <hello@bnb.im >
2022-01-14 06:22:42 +00:00
Rich Trott
4b1ee04153
build: fix workflow access to git history
...
Refs: https://github.com/nodejs/node/pull/41466
PR-URL: https://github.com/nodejs/node/pull/41472
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
2022-01-13 15:08:44 +00:00
Rich Trott and Tobias Nießen
500241d50d
tools: replace for loop with map()
...
Refs: https://github.com/nodejs/node/pull/41406#discussion_r778979676
Co-authored-by: Tobias Nießen <tniessen@tnie.de >
PR-URL: https://github.com/nodejs/node/pull/41451
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
2022-01-12 22:10:39 -08:00
Rich Trott
c8d38e4933
tools: use GITHUB_ACTIONS env var in inactivity scripts
...
Don't rewrite the README if we're not running inside a GitHub Action.
PR-URL: https://github.com/nodejs/node/pull/41422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-01-10 10:14:31 +00:00
Rich Trott
e247089057
tools: replace while+exec() with matchAll()
...
PR-URL: https://github.com/nodejs/node/pull/41406
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-01-09 03:46:56 +00:00
Rich Trott
95e1f92722
tools: fix argv bug in find-inactive-tsc.mjs
...
The argument supplied is expected to be text, not numeric.
This wasn't causing issues with the automated job because it does not
send an argument. It uses the default.
PR-URL: https://github.com/nodejs/node/pull/41394
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
2022-01-07 02:01:18 +00:00
David Sanders
79b21eead2
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
...
PR-URL: https://github.com/nodejs/node/pull/41235
Refs: https://github.com/nodejs/node/pull/18621
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2022-01-06 15:24:36 +00:00
Rich Trott
55ceaec111
tools,benchmark,lib,test: enable no-case-declarations lint rule
...
PR-URL: https://github.com/nodejs/node/pull/41385
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Ricky Zhou <0x19951125@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2022-01-05 07:42:19 -08:00
Rich Trott
e7d4e6b680
tools: remove conditional assignment in custom ESLint rule
...
These changes no-duplicate-require.js so that it doesn't use an
assignment in a conditional, which can be easy to misread as a
comparison rather than an assignment. It also means we change a do/while
(which we don't use much in our code) to the much more common while
construct.
PR-URL: https://github.com/nodejs/node/pull/41325
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-01-05 06:11:29 -08:00
Node.js GitHub Bot
1344b36fe3
tools: update lint-md-dependencies to @rollup/plugin-node-resolve@13.1.2
...
PR-URL: https://github.com/nodejs/node/pull/41369
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-01-05 11:54:02 +01:00
Node.js GitHub Bot
513e9fd0b6
tools: update doc to rehype-raw@6.1.1
...
PR-URL: https://github.com/nodejs/node/pull/41367
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2022-01-04 19:34:36 -08:00
Rich Trott
5f07d00c60
tools: remove last of error-masking in commit-queue.sh
...
Remove the lats of the unintentional error-masking in commit-queue.sh.
With this change, `tools/lint-sh.js . --from-npx` at last passes.
PR-URL: https://github.com/nodejs/node/pull/41356
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-01-01 17:25:36 +00:00
Node.js GitHub Bot
9b637ca255
tools: update eslint to 8.6.0
...
PR-URL: https://github.com/nodejs/node/pull/41368
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-01-01 17:25:28 +00:00
Rich Trott
e7a924e086
tools: do not mask errors on multiple commit retrieval
...
In commit-queue.sh, the assignment to `commits` will succeed and the
script will continue if one of the two `git` commands fails, even with
`-e` set. Split it into three separate assignments so that failures in
the `git` commands will be clearly logged and cause the script to exit
with a failure status code.
PR-URL: https://github.com/nodejs/node/pull/41340
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
2021-12-30 05:57:57 +00:00
Benjamin Gruenbaum and Robert Nagy
b97b81d4ec
stream: add map method to Readable
...
Implement the map method on readable stream. This starts the alignment
with the tc39-iterator-helpers proposal and adds a `.map` method to
every Node.js readable stream.
Co-Authored-By: Robert Nagy <ronag@icloud.com >
PR-URL: https://github.com/nodejs/node/pull/40815
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2021-12-29 20:32:36 +01:00