Matteo Collina
302c19b006
process: triggerAsyncId can be undefined
...
Fixes: https://github.com/nodejs/node/issues/14386
Fixes: https://github.com/nodejs/node/issues/14381
PR-URL: https://github.com/nodejs/node/pull/14387
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2017-07-20 16:18:14 -04:00
Matteo Collina
6fce1a314e
zlib: check if the stream is destroyed before push
...
If the stream is destroyed while the transform is still being
applied, push() should not be called, and the internal state
should be cleared.
Refs: https://github.com/koajs/compress/issues/60
PR-URL: https://github.com/nodejs/node/pull/14330
Backport-PR-URL: https://github.com/nodejs/node/pull/14396
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Conflicts:
lib/zlib.js
2017-07-20 13:45:09 -04:00
Jeremiah Senkpiel
7c3fed56dd
Working on v8.2.1
...
PR-URL: https://github.com/nodejs/node/pull/13744
2017-07-19 17:45:15 -04:00
Jeremiah Senkpiel
eb66efd605
2017-07-19, Version 8.2.0 (Current)
...
Big thanks to @addaleax who prepared the vast majority of this release.
Notable changes:
* **Async Hooks**
* Multiple improvements to Promise support in `async_hooks` have been made.
* **Build**
* The compiler version requirement to build Node with GCC has been raised to
GCC 4.9.4.
[[`820b011ed6`](https://github.com/nodejs/node/commit/820b011ed6 )]
[#13466 ](https://github.com/nodejs/node/pull/13466 )
* **Cluster**
* Users now have more fine-grained control over the inspector port used by
individual cluster workers. Previously, cluster workers would simply
increment from the master's debug port.
[[`dfc46e262a`](https://github.com/nodejs/node/commit/dfc46e262a )]
[#14140 ](https://github.com/nodejs/node/pull/14140 )
* **DNS**
* The server used for DNS queries can now use a custom port.
[[`ebe7bb29aa`](https://github.com/nodejs/node/commit/ebe7bb29aa )]
[#13723 ](https://github.com/nodejs/node/pull/13723 )
* Support for `dns.resolveAny()` has been added.
[[`6e30e2558e`](https://github.com/nodejs/node/commit/6e30e2558e )]
[#13137 ](https://github.com/nodejs/node/pull/13137 )
* **npm**
* The `npm` CLI has been updated to version 5.3.0. In particular, it now comes
with the `npx` binary, which is also shipped with Node.
[[`dc3f6b9ac1`](https://github.com/nodejs/node/commit/dc3f6b9ac1 )]
[#14235 ](https://github.com/nodejs/node/pull/14235 )
* `npm` Changelogs:
- [v5.0.4](https://github.com/npm/npm/releases/tag/v5.0.4 )
- [v5.1.0](https://github.com/npm/npm/releases/tag/v5.1.0 )
- [v5.2.0](https://github.com/npm/npm/releases/tag/v5.2.0 )
- [v5.3.0](https://github.com/npm/npm/releases/tag/v5.3.0 )
PR-URL: https://github.com/nodejs/node/pull/13744
v8.2.0
2017-07-19 16:46:11 -04:00
Anna Henningsen
64867a9c3b
doc: fix inspectPort documentation in cluster.md
...
- Add missing `changes:` entry
- Use full sentences
- Use proper indentation
Ref: https://github.com/nodejs/node/pull/14140
PR-URL: https://github.com/nodejs/node/pull/14349
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2017-07-19 15:03:02 -04:00
Gergely Nemeth
740ab3d0cb
test: add test for http outgoing internal headers
...
PR-URL: https://github.com/nodejs/node/pull/13980
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
2017-07-19 15:03:02 -04:00
Zhang Weijie
7936f919c1
test: use regex error check in test-crypto-random
...
Replace constructor in assert.throws() to a regular expression to check
the error thrown in a test in test-crypto-random.
PR-URL: https://github.com/nodejs/node/pull/14273
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:03:02 -04:00
shaman
e650fe07f4
test: check error with regex in test-signal-safety
...
Change TypeError to a regular expression in assert.throws() in
test/parallel/test-signal-safety.js.
PR-URL: https://github.com/nodejs/node/pull/14285
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:03:01 -04:00
Rich Trott
8010b2148f
lib: update indentation of ternaries
...
In preparation for stricter indentation linting and to increase code
clarity, update indentation for ternaries in lib.
PR-URL: https://github.com/nodejs/node/pull/14247
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:03:01 -04:00
Michael Dawson
48c6dbdddf
doc: add guidance on testing new errors
...
PR-URL: https://github.com/nodejs/node/pull/14207
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:03:00 -04:00
Ben Noordhuis
e3ed425da7
src: fix memory leak in DH key setters
...
Fix a memory leak in dh.setPublicKey() and dh.setPrivateKey() where the
old keys weren't freed.
Fixes: https://github.com/nodejs/node/issues/8377
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:03:00 -04:00
Ben Noordhuis
83234db1eb
src: reduce allocations in exportPublicKey()
...
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:59 -04:00
Ben Noordhuis
62be8efd83
src: guard against double free in randomBytes()
...
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:59 -04:00
Ben Noordhuis
5caaf83ee9
src: simplify PBKDF2Request
...
This also renames a misnamed variable `error_` to `success_`.
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:59 -04:00
Ben Noordhuis
7d445906da
src: remove PBKDF2Request::release()
...
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:58 -04:00
Ben Noordhuis
2d2d75903d
src: avoid heap allocation in crypto.pbkdf2()
...
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:58 -04:00
Ben Noordhuis
36e1351f6c
src: make array arg length compile-time checkable
...
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:57 -04:00
Ben Noordhuis
3286f6a1f7
src: refactor PBKDF2Request
...
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:57 -04:00
Ben Noordhuis
27efc1a2e1
src: remove extra heap allocations in DH functions
...
Replace allocate + Encode() + free patterns by calls to Malloc +
the Buffer::New() overload that takes ownership of the pointer.
Avoids unnecessary heap allocations and copying around of data.
DRY the accessor functions for the prime, generator, public key and
private key properties; deletes about 40 lines of quadruplicated code.
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:56 -04:00
Ben Noordhuis
814f4f1314
src: avoid heap allocation in hmac.digest()
...
Add a test that ensures the second call to .digest() returns an empty
HMAC, like it did before. No comment on whether that is the right
behavior or not.
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:56 -04:00
Ben Noordhuis
23d9e7ee4c
src: remove extra heap allocation in GetSession()
...
Don't allocate + copy + free; allocate and fill in place, then hand off
the pointer to Buffer::New().
Avoids unnecessary heap allocations in the following methods:
- crypto.CryptoStream#getSession()
- tls.TLSSocket#getSession()
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:55 -04:00
Ben Noordhuis
fc7d8c0244
src: make CipherBase::kind_ const
...
The cipher kind doesn't change over the lifetime of the cipher so make
it const.
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:55 -04:00
Ben Noordhuis
e59858bdb9
src: remove unused Local
...
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:54 -04:00
Ben Noordhuis
8826617485
src: remove superfluous cipher_ data member
...
The EVP_CIPHER can be reconstructed from the EVP_CIPHER_CTX instance,
no need to store it separately.
This brought to light the somewhat dubious practice of accessing the
EVP_CIPHER after the EVP_CIPHER_CTX instance had been destroyed.
It's mostly harmless due to the static nature of built-in EVP_CIPHER
instances but it segfaults when the cipher is provided by an ENGINE
and the ENGINE is unloaded because its reference count drops to zero.
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:54 -04:00
Ben Noordhuis
c84d0cd168
src: don't heap allocate GCM cipher auth tag
...
Fix a memory leak by removing the heap allocation altogether.
Fixes: https://github.com/nodejs/node/issues/13917
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:53 -04:00
Ben Noordhuis
3d4692b67a
src: avoid heap allocation in sign.final()
...
Put the 8 kB initial buffer on the stack first and don't copy it to the
heap until its exact size is known (which is normally much smaller.)
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:53 -04:00
Ben Noordhuis
63a640cabf
src: remove unneeded const_cast
...
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:53 -04:00
Ben Noordhuis
5f57b896ac
src: remove extra heap allocations in CipherBase
...
Don't allocate + copy + free; allocate and fill in place, then hand off
the pointer to Buffer::New().
Avoids unnecessary heap allocations in the following methods:
- crypto.Cipher#final()
- crypto.Cipher#update()
- crypto.Cipheriv#final()
- crypto.Cipheriv#update()
- crypto.Decipher#final()
- crypto.Decipher#update()
- crypto.Decipheriv#final()
- crypto.Decipheriv#update()
- crypto.privateDecrypt()
- crypto.privateEncrypt()
- crypto.publicDecrypt()
- crypto.publicEncrypt()
PR-URL: https://github.com/nodejs/node/pull/14122
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:52 -04:00
Nikolai Vavilov
5ed2b79bcc
build: prevent VsDevCmd.bat from changing cwd
...
VsDevCmd.bat changes the current working directory to
"%USERPROFILE%\Source" if it exists. Setting VSCMD_START_DIR overrides
this behavior.
PR-URL: https://github.com/nodejs/node/pull/14303
Fixes: https://github.com/nodejs/node/issues/14300
Refs: https://developercommunity.visualstudio.com/content/problem/26780/vsdevcmdbat-changes-the-current-working-directory.html
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:52 -04:00
Sam Roberts
2b86e6b850
gyp: implement LD/LDXX for ninja and FIPS
...
The ability to set the link rule is used for FIPS, and needs to set
both the `ld =` and `ldxx =` variables in the ninja build file to link
c++ (node) and c (openssl-cli, etc.) executables.
URL: https://github.com/nodejs/node/pull/14227
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:51 -04:00
Roee Kasher
442aa9e34b
http: OutgoingMessage change writable after end
...
When an OutgoingMessage is closed (for example, using the `end`
method), its 'writable' property should be changed to false - since it
is not writable anymore. The 'writable' property should have the
opposite value of the 'finished' property.
PR-URL: https://github.com/nodejs/node/pull/14024
Fixes: https://github.com/nodejs/node/issues/14023
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2017-07-19 15:02:51 -04:00
Gibson Fahnestock
abd901d3a2
doc: move LTS README link to increase prominence
...
PR-URL: https://github.com/nodejs/node/pull/14259
Fixes: https://github.com/nodejs/node/issues/10718
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:50 -04:00
Kat Marchán
51da7a1db9
deps: hotfix to bump npx version
...
This includes a critical fix to get npx working on Windows
PR-URL: https://github.com/nodejs/node/pull/14235
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:50 -04:00
Kat Marchán
32f02abef9
build: add npx to installers
...
PR-URL: https://github.com/nodejs/node/pull/14235
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:49 -04:00
Kat Marchán
900c2b4142
deps: upgrade npm to 5.3.0
...
PR-URL: https://github.com/nodejs/node/pull/14235
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:49 -04:00
Bradley Farias
fd17f08243
url: do not use HandleScope in ToObject
...
It is not needed / invalidates the returned value unlike EscapableHandleScope
PR-URL: https://github.com/nodejs/node/pull/14096
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-19 15:02:48 -04:00
Superwoods
7fc04ae7c1
test: use regex error checks in test-util-format
...
Replace constructor with regular expression for second argument
to assert.throws() in test-util-format.
PR-URL: https://github.com/nodejs/node/pull/14299
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2017-07-19 15:02:48 -04:00
boydfd
5d06d0b607
test: change style in test-cli-bad-options
...
Replace string concatenation in test/parallel/test-cli-bad-options.js
with template literal. Adjust argument layout for readability.
PR-URL: https://github.com/nodejs/node/pull/14274
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2017-07-19 15:02:47 -04:00
vercent deng
bf55439828
test: use template literals in test-writewrap
...
Use template literals instead of string concatenation in
test/async-hooks/test-writewrap.js.
PR-URL: https://github.com/nodejs/node/pull/14292
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2017-07-19 15:02:47 -04:00
xinglong.wangwxl
cb1c134422
test: improve regexps for error checking
...
test/parallel/test-catpto-random.js contains an object called
errorMesssage that contains regular expressions.They are only partially
matching regular expressions. Make them match the entire error message.
PR-URL: https://github.com/nodejs/node/pull/14271
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2017-07-19 15:02:46 -04:00
weiyuanyue
d02f2b9f28
test: replace string concatenation with template
...
Replace string concatenation with template literals in
test/async-hooks/verify-graph.js.
PR-URL: https://github.com/nodejs/node/pull/14279
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
2017-07-19 15:02:46 -04:00
blade254353074
7c74402d3e
test: use template literals as appropriate
...
Replace string concatenation with template string literals in
test-graph.signal.js.
PR-URL: https://github.com/nodejs/node/pull/14289
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2017-07-19 15:02:45 -04:00
tobewhatwewant
b0946d07e0
test: use template literal for string concat
...
In test/parallel/test-repl-persistent-history.js, replace string
concatenation with a template literal.
PR-URL: https://github.com/nodejs/node/pull/14288
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Refael Ackermann <refack@gmail.com >
2017-07-19 15:02:45 -04:00
jiangplus
36ef7e0b40
test: simplify string concatenation
...
Replace string concatenation with template literals.
Updated `test/parallel/test-http-multi-line-headers.js`
PR-URL: https://github.com/nodejs/node/pull/14278
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: David Cai <davidcai1993@yahoo.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
2017-07-19 15:02:44 -04:00
kadoufall
7945debe52
util: delete unused argument 'depth'
...
In lib/util.js, Line 1056, there is a 'depth' argument that is unused
for 'process.versions[exports.inspect.custom]', so delete it.
PR-URL: https://github.com/nodejs/node/pull/14267
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Refael Ackermann <refack@gmail.com >
2017-07-19 15:02:44 -04:00
Bang Wu
1205b1246b
test: use regexp to confir error message
...
In test/parallel/test-stream-writable-null.js, use a regular expression
to validate error message in assert.throws() call.
PR-URL: https://github.com/nodejs/node/pull/14268
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
2017-07-19 15:02:44 -04:00
akira.xue
8756686fa7
test: use regluar expression in vm test
...
update test/parallel/test-vm-create-context-arg.js
in line 27 to change `TypeError` to the regular expression
with the `/^TypeError: sandbox must be an object$/`.
PR-URL: https://github.com/nodejs/node/pull/14266
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2017-07-19 15:02:43 -04:00
Flandre
cb92035ba7
test: use regular expression to match error msg
...
PR-URL: https://github.com/nodejs/node/pull/14265
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2017-07-19 15:02:43 -04:00
Song, Bintao Garfield
253e4d062d
test: replace string concat with template literal
...
Replace the string concat at test/addons-napi/test_reference/test.js.
PR-URL: https://github.com/nodejs/node/pull/14269
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2017-07-19 15:02:42 -04:00
Fraser Xu
7eafd966c2
test: check complete error message
...
In test-stream-writable-change-default-encoding, use a regular
expression to match the complete error message.
PR-URL: https://github.com/nodejs/node/pull/14264
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Bryan English <bryan@bryanenglish.com >
2017-07-19 15:02:42 -04:00