BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
39,495 Commits 266 Branches 972 Tags
478ca18fd78dc3bba321ea4dee6dbbd2a2000d4c
Commit Graph
181 Commits
Author SHA1 Message Date
Luigi Pinca 08638b74ec Revert "test: remove test-crypto-keygen flaky designation" 
This reverts commit 893c000046.

Refs: https://github.com/nodejs/node/pull/48575#issuecomment-1620267554
PR-URL: https://github.com/nodejs/node/pull/48652
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
 2023-07-05 16:30:30 +00:00
Luigi Pinca 893c000046 test: remove test-crypto-keygen flaky designation 
PR-URL: https://github.com/nodejs/node/pull/48575
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2023-06-29 08:47:12 +00:00
Luigi Pinca 300634d33d test: remove test-timers-immediate-queue flaky designation 
PR-URL: https://github.com/nodejs/node/pull/48575
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2023-06-29 08:47:11 +00:00
Luigi Pinca c308054aaa test: mark test-child-process-stdio-reuse-readable-stdio flaky 
Refs: https://github.com/nodejs/node/issues/48300#issuecomment-1604531463
Refs: https://github.com/nodejs/reliability/issues/597#issue-1772339022
PR-URL: https://github.com/nodejs/node/pull/48537
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-06-25 11:08:07 +00:00
Moshe Atlow c6e7e42733 test: mark test-child-process-pipe-dataflow as flaky 
PR-URL: https://github.com/nodejs/node/pull/48334
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-06-04 20:58:45 +00:00
Abdirahim Musse 959142a465 test: skip test-http-pipeline-flood on IBM i 
PR-URL: https://github.com/nodejs/node/pull/48048
Refs: https://github.com/nodejs/node/issues/48047
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-22 11:50:10 +00:00
Yagiz Nizipli 62fd6bc4aa test: move test-cluster-primary-error flaky test 
PR-URL: https://github.com/nodejs/node/pull/48039
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
 2023-05-17 13:26:05 +00:00
Yagiz Nizipli 08e1564474 test: mark test/parallel/test-file-write-stream4 as flaky 
PR-URL: https://github.com/nodejs/node/pull/47423
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2023-04-10 17:46:07 +00:00
Michaël Zasso 65b79aba0f test: skip test-wasm-web-api on ARM 
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: https://github.com/nodejs/node/pull/47299
Refs: https://github.com/nodejs/node/pull/47251
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-03-30 12:09:32 +02:00
Stefan Stojanovic 13767a4675 test: fix test-child-process-exec-cwd 
Refs: https://github.com/nodejs/node/pull/47020
Refs: https://github.com/nodejs/build/issues/3046
PR-URL: https://github.com/nodejs/node/pull/47235
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-03-27 11:20:08 +00:00
Stefan Stojanovic f08655532b test: skip broken tests win arm64 
PR-URL: https://github.com/nodejs/node/pull/47020
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-03-22 10:54:49 +00:00
Vita Batrla 21fcfcdd5d test: fix test-net-connect-reset-until-connected 
Fixes: https://github.com/nodejs/node/issues/43446
PR-URL: https://github.com/nodejs/node/pull/46781
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-02-25 18:53:11 +00:00
Rich Trott badc631d77 test: remove flaky designation for test-worker-http2-stream-terminate 
Closes: https://github.com/nodejs/node/issues/43084
PR-URL: https://github.com/nodejs/node/pull/45438
Fixes: https://github.com/nodejs/node/issues/43084
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-11-14 17:19:48 +00:00
Rich Trott 6a22b77bba test: fix flaky test-repl-sigint-nested-eval 
There is a race condition where process.kill can be sent before the
target is ready to receive the signal.

Fixes: https://github.com/nodejs/node/issues/41123
PR-URL: https://github.com/nodejs/node/pull/45354
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2022-11-13 02:56:08 +00:00
Richard Lau 261176b04d test: mark connection leak test flaky on IBM i 
Mark `test-http-pipeline-requests-connection-leak` flaky on IBM i.

PR-URL: https://github.com/nodejs/node/pull/44215
Refs: https://github.com/nodejs/node/issues/43509
Refs: https://github.com/nodejs/node/issues/39683
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-08-14 04:30:11 +00:00
Luigi Pinca b2f4a55770 test: remove test-http-client-response-timeout flaky designation 
The issue was fixed by https://github.com/nodejs/node/pull/43890.

Fixes: https://github.com/nodejs/node/issues/43680
PR-URL: https://github.com/nodejs/node/pull/44145
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
 2022-08-07 12:26:50 +00:00
Adam Majer ddd9c70674 net, dns: socket should handle its output as input 
As a consequence of https://github.com/nodejs/node/issues/43014 ,
server sockets and others, once connected, report string family
names. But when feeding these to Socket.connect(), it passes
these to host resolution with a string for family while a numeric
family is expected internally. This results in wrong hints flags
to be set and resolution to fail.

As solution, is to add ability to handle both numeric and string
family names when doing lookup and connect.

Fixes: https://github.com/nodejs/node/issues/44003
PR-URL: https://github.com/nodejs/node/pull/44083
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-08-03 23:46:31 +00:00
Tobias Nießen a6e3d3b52b test: mark test-http-client-response-timeout flaky 
Refs: https://github.com/nodejs/node/issues/43680

PR-URL: https://github.com/nodejs/node/pull/43792
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
 2022-07-12 20:45:47 +01:00
Feng Yu 71cbab6043 test: mark test-net-connect-reset-until-connected flaky on freebsd 
PR-URL: https://github.com/nodejs/node/pull/43613
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-07-12 04:11:25 +01:00
Finn Yu 2bd940c0cb test: mark test-worker-http2-stream-terminate flaky on all platforms 
PR-URL: https://github.com/nodejs/node/pull/43620
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2022-07-01 19:20:05 +01:00
Feng Yu ea99431586 test: mark flaky tests on smartos 
PR-URL: https://github.com/nodejs/node/pull/43596
Refs: https://github.com/nodejs/node/issues/43457
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-06-28 18:06:48 +01:00
F3n67u bc5f9e1a35 test: mark test-http-server-request-timeouts-mixed flaky on macOS 
PR-URL: https://github.com/nodejs/node/pull/43597
Refs: https://github.com/nodejs/node/issues/43465
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2022-06-28 13:03:19 +02:00
Filip Skokan 2609dc631c test: skip test-net-connect-reset-until-connected on SmartOS 
Refs: #43446

PR-URL: https://github.com/nodejs/node/pull/43449
Refs: https://github.com/nodejs/node/issues/43446
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-06-19 10:02:50 +01:00
Darshan Sen 61c7103ed0 test: mark test-worker-http2-stream-terminate flaky on Windows 
The test is causing a lot of CI failures, so I'd say that we should mark
this test flaky until someone comes up with a proper fix.

Refs: https://github.com/nodejs/node/issues/43084
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/43425
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2022-06-18 01:49:44 +01:00
Antoine du Hamel 70b516e4db dns: accept 'IPv4' and 'IPv6' for family 
Refs: https://github.com/nodejs/node/issues/43014

PR-URL: https://github.com/nodejs/node/pull/43054
Fixes: https://github.com/nodejs/node/issues/43014
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2022-06-15 18:02:01 -04:00
Tobias Nießen 0fc455a219 test: reduce impact of flaky HTTP server tests 
Refs: https://github.com/nodejs/node/issues/42741

PR-URL: https://github.com/nodejs/node/pull/42926
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-02 19:33:42 +02:00
Rich Trott dde2f78887 test: remove test-stdout-close-catch flaky designation 
The corresponding issue was closed 3 months ago and it has apparently
been a long time since the failure has been seen in CI.

Refs: https://github.com/nodejs/node/issues/28803

PR-URL: https://github.com/nodejs/node/pull/42045
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-02-19 05:13:22 +00:00
Richard Lau bbd7cf7257 test: fix names of tests marked flaky on IBM i 
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.

Refs: https://github.com/nodejs/node/pull/41812
Refs: https://github.com/nodejs/node/issues/39683

PR-URL: https://github.com/nodejs/node/pull/41984
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2022-02-15 15:19:56 +00:00
Rich Trott 30bdee20ee test: remove test-worker-memory flaky designation 
Judging from https://github.com/nodejs/reliability/issues, this hasn't
failed in CI since November 2021.

Closes: https://github.com/nodejs/node/issues/23277

PR-URL: https://github.com/nodejs/node/pull/41867
Fixes: https://github.com/nodejs/node/issues/23277
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2022-02-06 06:22:51 -08:00
Michael Dawson 1387bb5ca8 test: exclude ibm i tests until we resolve 
Refs: https://github.com/nodejs/node/issues/39683

These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41812
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-02-01 18:19:25 -05:00
Michael Dawson 7faf76315e test: mark test-fs-rmdir-recursive flaky on win 
Refs: https://github.com/nodejs/node/issues/41201

From recent reliability reports this is now the most
common failure by far in CI runs. Mark the test as
flaky until the issue is resolved.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41533
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-01-31 14:38:05 -05:00
Michael Dawson c85e67b600 test: mark test-repl-sigint-nested-eval as flaky 
Refs: https://github.com/nodejs/node/issues/41123

- This is one of the remaining high occurance flaky
  tests from the reliability reports and recent
  failures in the CI. Mark as flaky until issue
  is resolved under referenced issue.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41302
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-01-04 15:59:25 -05:00
Michael Dawson eee1a6f42a test: mark test-crypto-keygen slow on windows 
Refs: https://github.com/nodejs/node/issues/41206

This test seems to be failing regularly on
windows with a timeout. Mark it slow to reduce
CI noise until it gets investigated.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41207
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-12-21 09:32:59 -05:00
James M Snell 09b57f7909 test: mark test-domain-error-types flaky 
Refs: https://github.com/nodejs/node/issues/39368
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39369
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-07-13 07:27:44 -07:00
Xu Meng db9cf52dcf test: check the different error code on IBM i 
Fixes: https://github.com/nodejs/node/issues/36925

PR-URL: https://github.com/nodejs/node/pull/38159
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-04-11 21:28:22 -05:00
Rich Trott 20009d7dee test: remove FLAKY status for test-async-hooks-http-parser-destroy 
This CI test failure hasn't been reported for some time.

Closes: https://github.com/nodejs/node/issues/26610

PR-URL: https://github.com/nodejs/node/pull/37636
Fixes: https://github.com/nodejs/node/issues/26610
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-03-08 09:38:47 -08:00
Rich Trott 5cea29b294 test: remove FLAKY status for fixed test 
test-worker-message-port-transfer-terminate was fixed in
25447d82d3 but the status file was not updated to reflect this.

PR-URL: https://github.com/nodejs/node/pull/37633
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-03-08 09:36:47 -08:00
Rich Trott f108778153 test: clear flaky designation for test-stream-pipeline-http2 
It hasn't failed for a long time.

Closes: https://github.com/nodejs/node/issues/20750

PR-URL: https://github.com/nodejs/node/pull/37631
Fixes: https://github.com/nodejs/node/issues/20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
 2021-03-08 06:24:25 -08:00
Rich Trott cd4b09589a test: clear FLAKY designation for test-http2-pipe 
It hasn't failed in a long time.

Refs: https://github.com/nodejs/node/issues/20750

PR-URL: https://github.com/nodejs/node/pull/37631
Fixes: https://github.com/nodejs/node/issues/20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
 2021-03-08 06:24:23 -08:00
Rich Trott 2748b0ad5a test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls 
The test does not seem to have failed since the issue was first reported
in 2019.

Closes: https://github.com/nodejs/node/issues/30845

PR-URL: https://github.com/nodejs/node/pull/37533
Fixes: https://github.com/nodejs/node/issues/30845
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-03-01 12:19:43 -08:00
Rich Trott 80098e605c test: remove FLAKY for test-http2-compat-client-upload-reject 
As far as I know, this test hasn't failed since around the time it was
first reported in 2019.

Closes: https://github.com/nodejs/node/issues/30847

PR-URL: https://github.com/nodejs/node/pull/37462
Fixes: https://github.com/nodejs/node/issues/30847
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-02-23 15:08:27 -08:00
Rich Trott 1d2ba1eb74 test: remove FLAKY designation for test-http2-client-upload-reject 
The test hasn't failed in a long time as far as I can tell. The issue
may have been fixed by various event updates/changes to http2 and
related systems.

PR-URL: https://github.com/nodejs/node/pull/37461
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-02-22 17:14:46 -08:00
Rich Trott 32482a828b test: remove FLAKY for test-domain-error-types 
PR-URL: https://github.com/nodejs/node/pull/37458
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-02-22 17:13:08 -08:00
Darshan Sen 4411a99dcd test: fix flaky test-webcrypto-encrypt-decrypt-aes 
* Use a copy of plaintext to prevent tampering of the original
* Since subtle.decrypt returns a Promise containing an ArrayBuffer and
  ArrayBuffers cannot be modified directly, create a Buffer from it
  right away so that the modification in the next line works as intended

Fixes: https://github.com/nodejs/node/issues/35586

PR-URL: https://github.com/nodejs/node/pull/37380
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2021-02-18 11:56:23 -05:00
Michaël Zasso fa3997d75a test: mark test-return-on-exit as flaky 
It fails sporadically in debug builds because the
"--stress-compaction --gc-interval=100" flags make Node.js crash.

Refs: https://github.com/nodejs/node/pull/36139

PR-URL: https://github.com/nodejs/node/pull/36139
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
 2021-02-11 19:11:49 +01:00
Rich Trott e331046a29 test: skip tests consistently in parallel.status 
Some tests are marked SKIP,FLAKY (resulting in yellow/unstable CI when
they fail) and others are marked SKIP (which means the results don't
affect CI at all). There doesn't seem to be any reason for the
difference. Mark them all as SKIP as IBM i for consistency and to have
the luxury of a green daily CI. We'll want these to be at least
SKIP,FLAKY (and preferably not skipped at all) before IBM i is
supported.

PR-URL: https://github.com/nodejs/node/pull/37035
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2021-01-27 20:49:06 +02:00
Richard Lau 863ec7dbaa test: mark flaky tests on IBM i 
PR-URL: https://github.com/nodejs/node/pull/36986
Refs: https://github.com/nodejs/node/issues/34410
Refs: https://github.com/nodejs/node/issues/36925
Refs: https://github.com/nodejs/node/issues/36929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-01-19 06:41:39 -08:00
Rod Vagg 5716130d1e Revert "test: mark test-cluster-bind-privileged-port flaky on arm" 
This reverts commit a45a404197.

Solved by marking ports <1024 as privileged on Docker containers.

Ref: https://github.com/nodejs/node/pull/36850
Ref: https://github.com/nodejs/node/issues/36847
Ref: https://github.com/nodejs/build/pull/2521

PR-URL: https://github.com/nodejs/node/pull/36884
Refs: https://github.com/nodejs/node/pull/36850
Refs: https://github.com/nodejs/node/issues/36847
Refs: https://github.com/nodejs/build/pull/2521
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-01-18 11:46:03 +01:00
James M Snell a45a404197 test: mark test-cluster-bind-privileged-port flaky on arm 
Per rvagg:
```
Persistent failure, even after restarts of the whole cluster. #36478 was
merged into this test yesterday but the parent commit still has the
failures.

What has changed is the Docker version. They all got an upgrade to
5:20.10.2~3-0~raspbian-buster and this is all running inside containers.
It's going to be the newest version of Docker running in our CI and I
wonder whether we're going to see similar failures when we upgrade other
hosts or if this is going to be restricted to ARM.

Other than that, I'm not sure what this could be. It seems like a
straightforward test that shouldn't fail, maybe Docker has introduced
something new for unprivileged port binding inside containers?
```

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/36850
Refs: https://github.com/nodejs/node/issues/36847
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
 2021-01-08 15:26:32 -08:00
Rich Trott 7c808170f5 test: remove test-http2-client-upload as flaky 
The test has not failed in quite some time (as far as I can tell) on CI.
Optimistically removing it.

Refs: https://github.com/nodejs/node/pull/29889

PR-URL: https://github.com/nodejs/node/pull/36496
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-12-15 03:40:55 -08:00