Tobias Nießen
4808dbdd9a
doc: fix typo in section on microtask order
...
PR-URL: https://github.com/nodejs/node/pull/59932
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-10-07 17:29:42 +02:00
Node.js GitHub Bot
badbba2da9
deps: update googletest to 50b8600
...
PR-URL: https://github.com/nodejs/node/pull/59955
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2025-10-07 17:29:42 +02:00
jhofstee
816e1befb1
zlib: reduce code duplication
...
The offset in the allocated memory was calculated in alloc and free,
this makes it a single constant so it only needs to be defined once.
PR-URL: https://github.com/nodejs/node/pull/57810
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2025-10-07 17:29:42 +02:00
hqzing
53cb9f3b6c
build: add the missing macro definitions for OpenHarmony
...
PR-URL: https://github.com/nodejs/node/pull/59804
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2025-10-07 17:29:42 +02:00
René
d6e303d645
doc: update V8 fast API guidance
...
PR-URL: https://github.com/nodejs/node/pull/58999
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2025-10-07 17:29:41 +02:00
Yoo
3a3220a2f0
dgram: restore buffer optimization in fixBufferList
...
Restore the Buffer.isBuffer() check to avoid unnecessary Buffer.from()
calls when the input is already a Buffer. This improves performance
by 30-50% for buffer-heavy UDP operations.
Includes benchmark test for fixBufferList function to verify the
performance improvements across different data types and chunk sizes.
PR-URL: https://github.com/nodejs/node/pull/59934
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2025-10-07 17:29:41 +02:00
Eric Rannaud
5bf21a4309
vm: explain how to share promises between contexts w/ afterEvaluate
...
PR-URL: https://github.com/nodejs/node/pull/59801
Fixes: https://github.com/nodejs/node/issues/59541
Refs: https://issues.chromium.org/issues/441679231
Refs: https://groups.google.com/g/v8-dev/c/YIeRg8CUNS8/m/rEQdFuNZAAAJ
Refs: https://tc39.es/ecma262/#sec-newpromiseresolvethenablejob
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2025-10-07 17:29:41 +02:00
Eric Rannaud
312b33a083
vm: "afterEvaluate", evaluate() return a promise from the outer context
...
Consider the default context A with a microtask queue QA, and a
context B with its own microtask queue QB.
Context B is constructed with vm.createContext(..., {microtaskMode:
"afterEvaluate"}). The evaluation in context B can be performed via
vm.Script or vm.SourceTextModule.
The standard (https://tc39.es/ecma262/#sec-newpromiseresolvethenablejob )
dictates that, when resolving a {promise} with {resolution}, from any
context, the {then} method on {promise} should be called within a task
enqueued on the microtask queue from the context associated with {then}.
Specifically, after evaluating a script or module in context B, any
promises created within B, if later resolved within A, will result in a
task to be enqueued back onto QB, even long after we are done evaluating
any code within B.
This creates a challenge for users of node:vm in "afterEvaluate" mode.
In ContextifyScript::EvalMachine() and in ModuleWrap::Evaluate(), we
only drain the microtask queue QB a single time after running the script
or evaluating the module. After that point, the queue will not be
drained unless another script or module is evaluated in the same
context.
In the following scenario, prior to this patch, the log statement will
not be printed:
const microtaskMode = "afterEvaluate";
const context = vm.createContext({}, {microtaskMode});
const source = "";
const module = new vm.SourceTextModule(source, {context});
await module.link(() => null);
await module.evaluate();
console.log("NOT PRINTED");
Within `evaluate()`, there is this `await` statement:
await this[kWrap].evaluate(timeout, breakOnSigint)
Since the promise returned by ModuleWrap::Evaluate() is the top-level
capability for {module}, a promise created within B, V8 will enqueue a
task on QB. But since this is after the PerformCheckpoint() call in
ModuleWrap::Evaluate(), the task in QB is never run. In the meantime,
since QA is empty, the Node process simply exits (with a warning about
the unsettled promise, if it happened to be a top-level await).
While being unable to do `await module.evaluate()` is clearly a problem,
more generally, it is intended that in "afterEvaluate" mode, promises
created in the inner context cannot make progress if, and until, the
microtask queue of the inner context is checkpointed.
Therefore, to address this issue, the fix is narrow:
When the module has its own microtask queue, i.e. in "afterEvaluate"
mode, the inner-context promise returned by
v8::SourceTextModule::Evaluate() is first resolved to an outer-context
promise, then we checkpoint the microtask queue of the inner context,
then we return the outer-context promise we just built.
This ensures that in the statement `await this[kWrap].evaluate(...)`,
the promise returned can be resolved within the outer context, without
involving the microtask queue in the inner context.
Fixes: https://github.com/nodejs/node/issues/59541
Refs: https://issues.chromium.org/issues/441679231
Refs: https://groups.google.com/g/v8-dev/c/YIeRg8CUNS8/m/rEQdFuNZAAAJ
PR-URL: https://github.com/nodejs/node/pull/59801
Refs: https://tc39.es/ecma262/#sec-newpromiseresolvethenablejob
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2025-10-07 17:29:41 +02:00
Eric Rannaud
ca1942c9d5
test: testcase demonstrating issue 59541
...
Check that we lose the execution flow in the outer context, upon
resolving a promise created in in the inner context.
PR-URL: https://github.com/nodejs/node/pull/59801
Fixes: https://github.com/nodejs/node/issues/59541
Refs: https://issues.chromium.org/issues/441679231
Refs: https://groups.google.com/g/v8-dev/c/YIeRg8CUNS8/m/rEQdFuNZAAAJ
Refs: https://tc39.es/ecma262/#sec-newpromiseresolvethenablejob
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2025-10-07 17:29:40 +02:00
Miguel Marcondes Filho
34c686be2b
lib: update inspect output format for subclasses
...
PR-URL: https://github.com/nodejs/node/pull/59687
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2025-10-07 17:29:40 +02:00
Tobias Nießen
c9cde35c4d
src: simplify is_callable by making it a concept
...
Using a C++20 `concept` here makes `is_callable` much simpler
than relying on SFINAE. It is equivalent for function types,
`std::function`, lambdas, and classes with `operator()`,
regardless of argument or return types.
PR-URL: https://github.com/nodejs/node/pull/58169
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2025-10-07 17:29:40 +02:00
Moonki Choi
892b425ee1
src: rename private fields to follow naming convention
...
PR-URL: https://github.com/nodejs/node/pull/59923
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-10-07 17:29:40 +02:00
Ugaitz Urien
09bdcce6b8
diagnostics_channel: fix race condition with diagnostics_channel and GC
...
PR-URL: https://github.com/nodejs/node/pull/59910
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2025-10-07 17:29:40 +02:00
Node.js GitHub Bot
48aaf98a08
deps: update archs files for openssl-3.5.3
...
PR-URL: https://github.com/nodejs/node/pull/59901
Reviewed-By: Richard Lau <richard.lau@ibm.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2025-10-07 17:29:39 +02:00
Node.js GitHub Bot
e02a562ea6
deps: upgrade openssl sources to openssl-3.5.3
...
PR-URL: https://github.com/nodejs/node/pull/59901
Reviewed-By: Richard Lau <richard.lau@ibm.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2025-10-07 17:29:39 +02:00
Joyee Cheung
2bf0a9318f
meta: add .npmrc with ignore-scripts=true
...
If any depdencies actually need to run the scripts, the corresponding
script can add --no-ignore-scripts.
PR-URL: https://github.com/nodejs/node/pull/59914
Reviewed-By: Richard Lau <richard.lau@ibm.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2025-10-07 17:29:39 +02:00
Tim Perry
af8b5fa29d
http: add shouldUpgradeCallback to let servers control HTTP upgrades
...
Previously, you could either add no 'upgrade' event handler, in which
case all upgrades were ignored, or add an 'upgrade' handler and all
upgrade attempts would effectively succeed and skip normal request
handling. This change adds a new shouldUpgradeCallback option to HTTP
servers, which receives the request details and returns a boolean that
controls whether the request should be upgraded.
PR-URL: https://github.com/nodejs/node/pull/59824
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-10-07 17:29:38 +02:00
Richard Lau
c42c1204c7
tools: fix tools/make-v8.sh for clang
...
Update `tools/make-v8.sh` so that it can work with either `gcc` or
`clang`.
Adds:
- clang settings when CC/CXX environment variables set to clang/clang++.
- Turns off warnings as errors.
Removes:
- goma settings.
- Machine specific settings (moved to Jenkins job configuration).
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5541431
PR-URL: https://github.com/nodejs/node/pull/59893
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-10-07 17:29:38 +02:00
Gerhard Stöbich
85818db93c
fs,win: do not add a second trailing slash in readdir
...
Do not add a trailing slash if it was not removed by resolve in
ToNamespacedPath.
PR-URL: https://github.com/nodejs/node/pull/59847
Fixes: https://github.com/nodejs/node/issues/58223
Refs: https://github.com/nodejs/node/pull/56110
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com >
2025-10-07 17:29:38 +02:00
Michael Smith
36b68db7f5
src: reduce the nearest parent package JSON cache size
...
PR-URL: https://github.com/nodejs/node/pull/59888
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2025-10-07 17:29:38 +02:00
Moonki Choi
26b40bad02
src: replace FIXED_ONE_BYTE_STRING with Environment-cached strings
...
PR-URL: https://github.com/nodejs/node/pull/59891
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2025-10-07 17:29:38 +02:00
Matteo Collina
ba00875f01
stream: use new AsyncResource instead of bind
...
The bind method uses ObjectDefineProperty that shows up
in flamegraphs. This changes it to avoid the utility.
Signed-off-by: Matteo Collina <hello@matteocollina.com >
PR-URL: https://github.com/nodejs/node/pull/59867
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
2025-10-07 17:29:37 +02:00
Mert Can Altin
6d24b88fbc
node-api: added SharedArrayBuffer api
...
PR-URL: https://github.com/nodejs/node/pull/59071
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-10-07 17:29:37 +02:00
Nam Yooseong
28ef564ecd
typings: remove unused imports
...
PR-URL: https://github.com/nodejs/node/pull/59880
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-10-07 17:29:37 +02:00
Ulises Gascón
0a3a3f729e
doc: add security escalation policy
...
PR-URL: https://github.com/nodejs/node/pull/59806
Refs: https://github.com/openjs-foundation/cross-project-council/pull/1588
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Richard Lau <richard.lau@ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2025-10-07 17:29:37 +02:00
René
a33ed9bf96
inspector: ensure adequate memory allocation for Binary::toBase64
...
PR-URL: https://github.com/nodejs/node/pull/59870
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2025-10-07 17:29:37 +02:00
방진혁
758271ae66
http: optimize checkIsHttpToken for short strings
...
Use lookup table instead of regex for strings shorter than 10
characters to improve performance for common short header names
while maintaining compatibility.
PR-URL: https://github.com/nodejs/node/pull/59832
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev >
Reviewed-By: Tim Perry <pimterry@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2025-10-07 17:29:36 +02:00
Bruno Rodrigues
a71dd592e3
benchmark: calibrate config dgram multi-buffer
...
PR-URL: https://github.com/nodejs/node/pull/59696
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2025-10-07 17:29:36 +02:00
Mikhail
f88752ddb6
url: replaced slice with at
...
PR-URL: https://github.com/nodejs/node/pull/59181
Reviewed-By: Jordan Harband <ljharb@gmail.com >
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com >
Reviewed-By: Daniel Lemire <daniel@lemire.me >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2025-10-07 17:29:36 +02:00
yusheng chen
8fd669c70d
doc: type improvement of file http.md
...
`outgoingMessage.setHeader` and `outgoingMessage.getHeader` section
PR-URL: https://github.com/nodejs/node/pull/58189
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2025-10-07 17:29:36 +02:00
Ruben Bridgewater
f2fbcc576d
util: fix debuglog.enabled not being present with callback logger
...
The method returned by the callback is missing the .enabled property.
This is added in a consistent way that it also verifies that it's a
getter.
Fixes: https://github.com/nodejs/node/issues/56676
PR-URL: https://github.com/nodejs/node/pull/59858
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2025-10-07 17:29:35 +02:00
Ruben Bridgewater
e790eb6b50
repl: fix cpu overhead pasting big strings to the REPL
...
Pasting input should not trigger any completions and other
calculations. This is now handled by just writing the string to the
terminal in case the user is pasting. As soon as pasting is done,
the completions will be re-enabled.
Fixes: https://github.com/nodejs/node/issues/40626
Fixes: https://github.com/nodejs/node/issues/43343
PR-URL: https://github.com/nodejs/node/pull/59857
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2025-10-07 17:29:35 +02:00
Anna Henningsen
34dcb7dc32
src: create strings in FIXED_ONE_BYTE_STRING as internalized
...
These string keys can generally be assumed to be long-lived.
PR-URL: https://github.com/nodejs/node/pull/59826
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-10-07 17:29:35 +02:00
Anna Henningsen
4d748add05
src: remove std::array overload of FIXED_ONE_BYTE_STRING
...
This overload was only used in one place, in a cold path, and in
particular in a place where the compiler would be able to generate
the exact same code using just a call to `.size()`.
PR-URL: https://github.com/nodejs/node/pull/59826
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-10-07 17:29:35 +02:00
Jeetu Suthar
4cc84c96f4
node-api: make napi_delete_reference use node_api_basic_env
...
PR-URL: https://github.com/nodejs/node/pull/59684
Refs: https://github.com/nodejs/node/issues/59583
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com >
2025-10-07 17:29:35 +02:00
Nam Yooseong
16c4b466f4
benchmark: calibrate config cluster/echo.js
...
PR-URL: https://github.com/nodejs/node/pull/59836
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
2025-10-07 17:29:34 +02:00
simon-id
24c224960c
url: add type checking to urlToHttpOptions()
...
PR-URL: https://github.com/nodejs/node/pull/59753
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Bryan English <bryan@bryanenglish.com >
2025-10-07 17:29:34 +02:00
Nam Yooseong
9833dc6060
doc: rephrase dynamic import() description
...
The description is updated to clarify that dynamic import() is
asynchronous, dynamic, and works in both CJS and ESM contexts.
The new phrasing also avoids implying it is the only method for
loading ES modules in CommonJS.
Fixes: https://github.com/nodejs/node/issues/59077
PR-URL: https://github.com/nodejs/node/pull/59224
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2025-10-07 17:29:34 +02:00
Anna Henningsen
bb6fd7c2d1
src: ensure v8::Eternal is empty before setting it
...
V8 does not check this for us, but this is a requirement of the API.
PR-URL: https://github.com/nodejs/node/pull/59825
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2025-10-07 17:29:34 +02:00
Chengzhong Wu
12e553529c
lib: add source map support for assert messages
...
Map source lines in assert messages with cached source maps.
PR-URL: https://github.com/nodejs/node/pull/59751
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2025-10-07 17:29:34 +02:00
Chengzhong Wu
d2a70571f8
lib,src: refactor assert to load error source from memory
...
The source code is available from V8 API and assert can avoid reading
the source file from the filesystem and parse the file again.
PR-URL: https://github.com/nodejs/node/pull/59751
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2025-10-07 17:29:33 +02:00
Michaël Zasso
b632a1d98d
tools: skip test-internet workflow for draft PRs
...
PR-URL: https://github.com/nodejs/node/pull/59817
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2025-10-07 17:29:33 +02:00
Antoine du Hamel
ec5290fe01
build: do not include custom ESLint rules testing in tarball
...
PR-URL: https://github.com/nodejs/node/pull/59809
Reviewed-By: Richard Lau <richard.lau@ibm.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-10-07 17:29:33 +02:00
Antoine du Hamel
6021c3ac76
tools: copyedit build-tarball.yml
...
PR-URL: https://github.com/nodejs/node/pull/59808
Refs: https://www.shellcheck.net/wiki/SC2006
Refs: https://www.shellcheck.net/wiki/SC2086
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <richard.lau@ibm.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-10-07 17:29:33 +02:00
0hm☘️
7a91282bf9
src: use simdjson::pad
...
PR-URL: https://github.com/nodejs/node/pull/59391
Refs: https://github.com/nodejs/node/issues/59389
Reviewed-By: Daniel Lemire <daniel@lemire.me >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-10-07 17:29:32 +02:00
Chengzhong Wu
2237142369
module: link module with a module request record
...
When a module is being statically linked with module requests, if two
module requests with a same specifier but different attributes are
resolved to two modules, the module requests should be linked to these
two modules.
PR-URL: https://github.com/nodejs/node/pull/58886
Backport-PR-URL: https://github.com/nodejs/node/pull/60000
Refs: https://tc39.es/ecma262/#sec-HostLoadImportedModule
Refs: https://github.com/tc39/proposal-import-attributes?tab=readme-ov-file#how-would-this-proposal-work-with-caching
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2025-10-07 16:08:51 +02:00
Xuguang Mei
99ea08dc43
repl: add isValidParentheses check before wrap input
...
PR-URL: https://github.com/nodejs/node/pull/59607
Backport-PR-URL: https://github.com/nodejs/node/pull/60066
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2025-10-07 16:07:13 +02:00
npm CLI robot
7e0e86cb92
deps: upgrade npm to 10.9.4
...
PR-URL: https://github.com/nodejs/node/pull/60074
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2025-10-07 15:54:45 +02:00
Matteo Collina
91dda5facf
deps: update undici to 6.22.0
...
Signed-off-by: Matteo Collina <hello@matteocollina.com >
PR-URL: https://github.com/nodejs/node/pull/60112
Reviewed-By: Richard Lau <richard.lau@ibm.com >
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com >
2025-10-07 15:53:53 +02:00
Richard Lau
27cf259143
Working on v22.20.1
...
PR-URL: https://github.com/nodejs/node/pull/59973
2025-09-24 12:45:26 +00:00