Antoine du Hamel
96b4950dca
dns: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36314
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-12-07 19:40:52 +00:00
Antoine du Hamel
0869b829fa
net: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36303
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-12-07 10:08:03 -08:00
Antoine du Hamel
5f1bf80b5e
tools: upgrade to @babel/eslint-parser 7.12.1
...
PR-URL: https://github.com/nodejs/node/pull/36321
Fixes: https://github.com/ensure
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-12-07 10:05:29 -08:00
Antoine du Hamel
23f4b6ead7
worker: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36393
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-12-07 10:03:55 -08:00
Antoine du Hamel
b5bb09448a
http2: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36357
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-12-07 10:01:29 -08:00
Antoine du Hamel
4027e36dfd
string_decoder: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36358
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-12-07 09:59:42 -08:00
Antoine du Hamel
ff048bd797
buffer: refactor to use primordials instead of Array#reduce
...
PR-URL: https://github.com/nodejs/node/pull/36392
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
2020-12-07 06:08:44 +01:00
Antoine du Hamel
897307554a
tools: remove bashisms from macOS release scripts
...
PR-URL: https://github.com/nodejs/node/pull/36121
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-12-04 22:56:13 +00:00
Antoine du Hamel
1729ba7578
tools: remove bashisms from release script
...
PR-URL: https://github.com/nodejs/node/pull/36123
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2020-12-04 23:55:19 +01:00
Antoine du Hamel
ed6e71a1ca
readline: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36296
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-12-04 18:34:32 +00:00
Antoine du Hamel
e074bee7da
dgram: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36286
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-12-04 18:34:22 +00:00
Antoine du Hamel
e4d570fe9a
zlib: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36347
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-12-04 06:22:18 -08:00
Antoine du Hamel
3604fadacf
module: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36348
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-12-04 06:19:12 -08:00
Antoine du Hamel
a897a25d1d
querystring: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36315
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-12-03 09:23:59 -08:00
Antoine du Hamel
99f61677a9
benchmark,child_process: remove failing benchmark parameter
...
A 16 MiB strings seems to be too large to be send to the parent process,
making the whole benchmark throws.
PR-URL: https://github.com/nodejs/node/pull/36295
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-12-02 20:33:34 +00:00
Antoine du Hamel
187a862d22
path: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36302
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-12-02 20:22:34 +00:00
Antoine du Hamel
325a1fcd64
worker: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36267
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-12-02 20:22:24 +00:00
Antoine du Hamel
f066ae4dd8
tls: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36266
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-12-02 20:22:14 +00:00
Antoine du Hamel
825029ec59
repl: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36264
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-12-02 20:22:03 +00:00
Antoine du Hamel
7d45dd9aa3
buffer: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36166
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-12-01 17:44:27 +01:00
Antoine du Hamel
1d82d1e566
perf_hooks: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36297
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2020-12-01 14:28:03 +00:00
Antoine du Hamel
dbfb10dd36
v8: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36285
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-12-01 14:27:53 +00:00
Antoine du Hamel
e6e708400b
os: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36284
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-12-01 14:27:43 +00:00
Antoine du Hamel
299984561e
tools: fix undeclared identifier FALSE
...
PR-URL: https://github.com/nodejs/node/pull/36276
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-28 05:48:30 -08:00
Antoine du Hamel
8d6c2f2ada
fs: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36196
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-11-27 18:40:51 +01:00
Antoine du Hamel
b4c2ff5a3b
policy: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36210
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
2020-11-27 17:19:30 +00:00
Antoine du Hamel
709b339878
assert: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36234
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-11-27 06:17:41 -08:00
Antoine du Hamel
866b1e67cc
quic: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36211
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-25 05:24:28 -08:00
Antoine du Hamel and ExE Boss
05847a71e9
lib: refactor primordials.uncurryThis
...
This is done to avoid creating an array and gain performance.
Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com >
PR-URL: https://github.com/nodejs/node/pull/36221
Refs: https://v8.dev/blog/v8-release-80#optimizing-higher-order-builtins
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2020-11-25 13:20:00 +00:00
Antoine du Hamel
d4501b17e2
process: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36212
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-24 05:27:19 -08:00
Antoine du Hamel
893d8a60cb
errors: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36167
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-11-20 22:22:42 +01:00
Antoine du Hamel
f47d65538a
async_hooks: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36168
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-11-20 20:10:19 +00:00
Antoine du Hamel
514f464a60
http2: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36142
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Ricky Zhou <0x19951125@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-20 21:01:00 +01:00
Antoine du Hamel
3e0194e88e
lib: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36140
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-11-19 19:18:14 +01:00
Antoine du Hamel
ad0a01caed
http2: add support for TypedArray to getUnpackedSettings
...
PR-URL: https://github.com/nodejs/node/pull/36141
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-19 17:48:02 +00:00
Antoine du Hamel
a46b21f556
lib: remove primordials.SafePromise
...
PR-URL: https://github.com/nodejs/node/pull/36149
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-11-19 04:33:43 -08:00
Antoine du Hamel
ed26808bdf
tools: remove bashisms from license builder script
...
PR-URL: https://github.com/nodejs/node/pull/36122
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2020-11-18 18:58:35 +00:00
Antoine du Hamel
bd120207fb
timers: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36132
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-11-18 04:21:24 -08:00
Antoine du Hamel
08be03b7cb
tools: hide commit queue action link
...
PR-URL: https://github.com/nodejs/node/pull/36124
Reviewed-By: Denys Otrishko <shishugi@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-11-17 00:01:43 +00:00
Antoine du Hamel
1d02a35869
vm: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36023
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-14 14:46:19 +00:00
Antoine du Hamel
829786088a
esm: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36019
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-14 14:46:06 +00:00
Antoine du Hamel
5c3944fa20
lib,tools: enforce access to prototype from primordials
...
PR-URL: https://github.com/nodejs/node/pull/36025
Reviewed-By: Shingo Inoue <leko.noor@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-14 05:56:39 -08:00
Antoine du Hamel
c7d2a4544b
cluster: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36011
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-13 23:35:43 +00:00
Antoine du Hamel
28f31bdb6a
crypto: fix passing TypedArray to webcrypto AES methods
...
Refs: https://www.w3.org/TR/WebCryptoAPI/#subtlecrypto-interface
Fixes: https://github.com/nodejs/node/issues/36083
PR-URL: https://github.com/nodejs/node/pull/36087
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2020-11-13 22:00:15 +00:00
Antoine du Hamel
e174afeff2
child_process: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36003
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-13 22:00:05 +00:00
Antoine du Hamel
d8f66c1e57
assert: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/35998
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-13 21:59:55 +00:00
Antoine du Hamel
ba73f93f02
tools: enforce use of single quotes in editorconfig
...
PR-URL: https://github.com/nodejs/node/pull/36020
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-11-12 06:19:49 +00:00
Antoine du Hamel
da53a3caa3
crypto: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36012
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-09 20:23:07 -08:00
Antoine du Hamel
831f4c755d
tools,lib: recommend using safe primordials
...
Make the linter recommend replacing `globalThis.Map` by
`primordials.SafeMap`, and similar for `Set`, `WeakSet`, and `WeakMap`.
PR-URL: https://github.com/nodejs/node/pull/36026
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Shingo Inoue <leko.noor@gmail.com >
2020-11-09 19:05:41 +00:00
Antoine du Hamel
2c77fe192e
module: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/36024
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2020-11-09 19:05:31 +00:00
Antoine du Hamel
36fbbe0b86
test: use global.EventTarget instead of internals
...
`EventTarget` is exposed on the global scope, there is no need to use
`--expose-internals` flag in the tests.
Refs: https://github.com/nodejs/node/pull/35496
PR-URL: https://github.com/nodejs/node/pull/36002
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2020-11-09 19:25:15 +01:00
Antoine du Hamel
b589128f6f
bootstrap: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/35999
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
2020-11-09 19:23:46 +01:00
Antoine du Hamel
8f954388ed
tools,lib: tighten prefer-primordials rules for Error statics
...
PR-URL: https://github.com/nodejs/node/pull/36017
Reviewed-By: Shingo Inoue <leko.noor@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-09 06:07:46 -08:00
Antoine du Hamel
ad98cf04f3
stream: remove isPromise utility function
...
The function was not checking if the parameter was actually a Promise
instance, but if it has a `then` method. Removing the utility function
in favor of a clearer `typeof` check, handling the case when the
thenable throws if then method is accessed more than once.
PR-URL: https://github.com/nodejs/node/pull/35925
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2020-11-09 06:17:29 +00:00
Antoine du Hamel
133fdd4662
doc: fix crypto doc linter errors
...
PR-URL: https://github.com/nodejs/node/pull/36035
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-08 05:14:56 -08:00
Antoine du Hamel
3c9f072522
tools,doc: enable ecmaVersion 2021 in acorn parser
...
PR-URL: https://github.com/nodejs/node/pull/35994
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-11-07 01:30:21 +00:00
Antoine du Hamel
0ad4f70db5
domain: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/35885
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-06 22:22:20 +00:00
Antoine du Hamel
e6e6070364
errors: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/35944
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Ben Coe <bencoe@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-05 22:55:34 +00:00
Antoine du Hamel
c723e4cb0b
lib: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/35875
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-05 23:15:41 +01:00
Antoine du Hamel
1f6ca18c3b
console: use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/35734
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-05 23:11:56 +01:00
Antoine du Hamel
bf6883d1d4
build: fix lint-js-fix target
...
Refs: https://github.com/nodejs/node/pull/35708
PR-URL: https://github.com/nodejs/node/pull/35927
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2020-11-02 22:48:22 +00:00
Antoine du Hamel
876d81624d
build,tools: gitHub Actions: use Node.js Fermium
...
PR-URL: https://github.com/nodejs/node/pull/35840
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-10-30 12:11:13 +01:00
Antoine du Hamel
1da672994a
lib: use primordials when calling methods of Error
...
This is to unsure that code using those methods won't crash if the
methods are deleted in userland.
PR-URL: https://github.com/nodejs/node/pull/35837
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Shingo Inoue <leko.noor@gmail.com >
2020-10-30 11:08:20 +00:00
Antoine du Hamel
30e9fab866
doc: recommend test-doc instead of lint-md
...
The documentation style guide used to recommend checking changes in the
docs by running `make lint-md`. This leaves out some important checks
which are contained in the `test-doc` build target. This commit also
replaces `lint` by `lint-md` in the list of `test-doc`'s prerequisites.
PR-URL: https://github.com/nodejs/node/pull/35708
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2020-10-30 12:01:58 +01:00
Antoine du Hamel
b90e1353be
build: add vcbuilt test-doc target
...
PR-URL: https://github.com/nodejs/node/pull/35708
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2020-10-30 12:01:52 +01:00
Antoine du Hamel
0c6143656c
build,tools: add lint-js-doc target
...
Add a build target to lint JS code in Markdown files only.
PR-URL: https://github.com/nodejs/node/pull/35708
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2020-10-30 12:01:46 +01:00
Antoine du Hamel
4ab6628158
doc: add missing link in Node.js 14 Changelog
...
Refs: https://github.com/nodejs/node/pull/35525
PR-URL: https://github.com/nodejs/node/pull/35782
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2020-10-24 05:33:55 -07:00
Antoine du Hamel
3f4ec9c30b
doc,esm: document experimental warning removal
...
PR-URL: https://github.com/nodejs/node/pull/35750
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Guy Bedford <guybedford@gmail.com >
2020-10-22 17:23:17 +02:00
Antoine du Hamel
a987a3256c
build: use make functions instead of echo
...
PR-URL: https://github.com/nodejs/node/pull/35707
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-10-21 05:29:58 -07:00
Antoine du Hamel
aaf225a2a0
module: add setter for module.parent
...
PR-URL: https://github.com/nodejs/node/pull/35522
Reviewed-By: Jan Krems <jan.krems@gmail.com >
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-10-17 00:49:56 +02:00
Antoine du Hamel
ac5df63952
build: fix Commit Queue failure comment
...
Refs: https://github.com/nodejs/node/pull/35206
PR-URL: https://github.com/nodejs/node/pull/35599
Reviewed-By: Denys Otrishko <shishugi@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-10-14 06:11:13 -07:00
Antoine du Hamel
0aa2c5bec6
doc: harmonize YAML comments
...
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139
PR-URL: https://github.com/nodejs/node/pull/35575
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Ben Coe <bencoe@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-10-13 15:13:45 +02:00
Antoine du Hamel
900f28aa6d
doc: fixup perf_hooks
...
PR-URL: https://github.com/nodejs/node/pull/35527
Reviewed-By: Shelley Vohr <codebytere@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-10-11 10:00:52 +00:00
Antoine du Hamel
bd45124f00
doc: harmonize changes list ordering
...
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139
PR-URL: https://github.com/nodejs/node/pull/35454
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2020-10-09 18:46:47 +00:00
Antoine du Hamel
9fedb044e7
doc: changes description must end with a period
...
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139
PR-URL: https://github.com/nodejs/node/pull/35454
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2020-10-09 18:46:46 +00:00
Antoine du Hamel
125523bffe
doc: harmonize version list style in YAML comments
...
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139
PR-URL: https://github.com/nodejs/node/pull/35454
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2020-10-09 18:46:45 +00:00
Antoine du Hamel
6eace7749d
doc: fix missing PR-URLs in YAML comments
...
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139
PR-URL: https://github.com/nodejs/node/pull/35454
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2020-10-09 18:46:45 +00:00
Antoine du Hamel
b3c3e0115f
doc: remove outstanding YAML comment
...
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139
PR-URL: https://github.com/nodejs/node/pull/35454
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2020-10-09 18:46:44 +00:00
Antoine du Hamel
4cc06922dc
doc: harmonize YAML comments style in deprecations.md
...
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139
PR-URL: https://github.com/nodejs/node/pull/35454
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2020-10-09 18:46:43 +00:00
Antoine du Hamel
78f2b11ecd
doc: add history entry for exports patterns
...
PR-URL: https://github.com/nodejs/node/pull/35410
Refs: https://github.com/nodejs/node/pull/34718
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-10-09 01:01:52 +02:00
Antoine du Hamel
ef1af47b26
doc: fix deprecation history
...
PR-URL: https://github.com/nodejs/node/pull/35455
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-10-08 22:53:19 +00:00
Antoine du Hamel
96c37b3312
doc: fix util.inspect change history
...
PR-URL: https://github.com/nodejs/node/pull/35528
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Shelley Vohr <codebytere@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-10-08 22:44:04 +00:00
Antoine du Hamel
c208a20f9c
doc: add aduh95 to collaborators
...
PR-URL: https://github.com/nodejs/node/pull/35542
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2020-10-07 16:45:09 +02:00
Antoine du Hamel
bc0c094b74
src: unset NODE_VERSION_IS_RELEASE from master
...
PR-URL: https://github.com/nodejs/node/pull/35531
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Gus Caplan <me@gus.host >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2020-10-07 00:11:38 -04:00
Antoine du Hamel
ad012c9bbc
doc: fix YAML syntax errors
...
PR-URL: https://github.com/nodejs/node/pull/35529
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
2020-10-06 15:52:10 -07:00
Antoine du Hamel
a556484543
doc,esm: add history support info
...
Documents which versions of Node.js support which ESM-feature.
PR-URL: https://github.com/nodejs/node/pull/35395
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com >
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-10-05 06:05:28 -07:00
Antoine du Hamel
6467d1d4e9
tools: fix typo in error message
...
PR-URL: https://github.com/nodejs/node/pull/35417
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-10-04 11:46:39 +02:00
Antoine du Hamel
5c5d044de0
doc: fix conditional exports flag removal version
...
PR-URL: https://github.com/nodejs/node/pull/35428
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-10-04 08:18:57 +02:00
Antoine du Hamel
91837e9fbb
tools: check links in api docs
...
Fixes: https://github.com/nodejs/node/issues/35189
PR-URL: https://github.com/nodejs/node/pull/35191
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-10-01 06:19:42 -07:00
Antoine du Hamel
57f1e3224e
doc: sort md references in ASCII order
...
Refs: https://github.com/nodejs/node/pull/35244
PR-URL: https://github.com/nodejs/node/pull/35191
Fixes: https://github.com/nodejs/node/issues/35189
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-10-01 06:19:25 -07:00
Antoine du Hamel
ecf5060a42
doc: use .md extension for internal links
...
This helps catch broken links as part of the test suite. This also
improves the user experience when browsing the markdown files.
PR-URL: https://github.com/nodejs/node/pull/35191
Fixes: https://github.com/nodejs/node/issues/35189
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-10-01 06:19:12 -07:00
Antoine du Hamel
7794d36a37
tools,doc: enforce alphabetical order for md refs
...
PR-URL: https://github.com/nodejs/node/pull/35244
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Shelley Vohr <codebytere@gmail.com >
2020-09-22 10:25:43 -07:00
Antoine du Hamel
0b8fdb70ac
tools,doc: upgrade dependencies
...
PR-URL: https://github.com/nodejs/node/pull/35244
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Shelley Vohr <codebytere@gmail.com >
2020-09-22 10:25:36 -07:00
Antoine du HAMEL
dfa2dada07
doc: fix deprecation documentation inconsistencies
...
PR-URL: https://github.com/nodejs/node/pull/35082
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-09-16 07:10:21 -07:00
Antoine du HAMEL
d24eecd7d7
module: use isURLInstance instead of instanceof
...
PR-URL: https://github.com/nodejs/node/pull/34951
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is >
2020-09-15 22:17:47 +00:00
Antoine du HAMEL
541d296d56
doc: document support for package.json fields
...
Fixes: https://github.com/nodejs/node/issues/33143
PR-URL: https://github.com/nodejs/node/pull/34970
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-09-11 20:56:30 -07:00
Antoine du HAMEL
b0cc6572b0
doc: add ESM examples in module API doc page
...
PR-URL: https://github.com/nodejs/node/pull/34875
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Guy Bedford <guybedford@gmail.com >
2020-09-06 16:39:11 -04:00
Antoine du HAMEL
181ba95819
doc: add deprecated badge to legacy URL methods
...
PR-URL: https://github.com/nodejs/node/pull/34931
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Guy Bedford <guybedford@gmail.com >
2020-09-06 16:33:56 -04:00
Antoine du HAMEL
441c03de50
tools: fix docopen target
...
Adds to prerequisites the output file to open. Previously, this would
open an out-of-date version of the file, or fail if it hasn't been built
before.
PR-URL: https://github.com/nodejs/node/pull/35062
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is >
2020-09-06 16:28:53 -04:00
Antoine du HAMEL
8ae2f47954
tools: fix doc build targets
...
Adds doc output directory as order-only prerequisite for build target.
PR-URL: https://github.com/nodejs/node/pull/35060
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
2020-09-06 16:22:22 -04:00