Commit Graph
44533 Commits
Author SHA1 Message Date
Michael Dawson 560d00ffb7 doc: remove myself from security steward rotation
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/58927
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2025-07-04 14:04:13 +00:00
René f64b0b3478 src: simplify adding fast APIs to ExternalReferenceRegistry
PR-URL: https://github.com/nodejs/node/pull/58896
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2025-07-04 13:32:13 +00:00
Levi Zim 1539f3b727 deps: V8: cherry-pick 0ce2edb7adfd
Original commit message:

    Fix invalid template specialization

    Bug: chromium:40565911
    Change-Id: If206c140e99e24a6df4ee7351e8022748eabac22
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6491420
    Auto-Submit: Bruno Pitrus <brunopitrus@hotmail.com>
    Commit-Queue: Jakob Linke <jgruber@chromium.org>
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Jakob Linke <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#99987}

Refs: https://github.com/v8/v8/commit/0ce2edb7adfd65d4a2272098080980e88933786c
Fixes: https://github.com/nodejs/node/issues/58485
PR-URL: https://github.com/nodejs/node/pull/58773
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
2025-07-04 12:56:56 +00:00
dependabot[bot] 247672d078 meta: bump step-security/harden-runner from 2.12.0 to 2.12.2
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.12.0 to 2.12.2.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](https://github.com/step-security/harden-runner/compare/0634a2670c59f64b4a01f0f96f84700a4088b9f0...6c439dc8bdf85cadbbce9ed30d1c7b959517bc49)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-version: 2.12.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/58923
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-07-04 12:33:36 +00:00
dependabot[bot] e13d15d614 meta: bump github/codeql-action from 3.28.18 to 3.29.2
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.18 to 3.29.2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/ff0a06e83cb2de871e5a09832bc6a81e7276941f...181d5eefc20863364f96762470ba6f862bdef56b)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/58922
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-07-04 12:33:28 +00:00
dependabot[bot] 34f24960fb tools: bump the eslint group in /tools/eslint with 6 updates
Bumps the eslint group in /tools/eslint with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) | `7.27.4` | `7.27.7` |
| [@babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser) | `7.27.1` | `7.27.5` |
| [@stylistic/eslint-plugin](https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin) | `4.4.1` | `5.1.0` |
| [eslint](https://github.com/eslint/eslint) | `9.28.0` | `9.30.0` |
| [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) | `50.7.1` | `51.3.1` |
| [globals](https://github.com/sindresorhus/globals) | `16.2.0` | `16.3.0` |

Updates `@babel/core` from 7.27.4 to 7.27.7
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.27.7/packages/babel-core)

Updates `@babel/eslint-parser` from 7.27.1 to 7.27.5
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.27.5/eslint/babel-eslint-parser)

Updates `@stylistic/eslint-plugin` from 4.4.1 to 5.1.0
- [Release notes](https://github.com/eslint-stylistic/eslint-stylistic/releases)
- [Changelog](https://github.com/eslint-stylistic/eslint-stylistic/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint-stylistic/eslint-stylistic/commits/v5.1.0/packages/eslint-plugin)

Updates `eslint` from 9.28.0 to 9.30.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v9.28.0...v9.30.0)

Updates `eslint-plugin-jsdoc` from 50.7.1 to 51.3.1
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc)
- [Commits](https://github.com/gajus/eslint-plugin-jsdoc/compare/v50.7.1...v51.3.1)

Updates `globals` from 16.2.0 to 16.3.0
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](https://github.com/sindresorhus/globals/compare/v16.2.0...v16.3.0)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-version: 7.27.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: eslint
- dependency-name: "@babel/eslint-parser"
  dependency-version: 7.27.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: eslint
- dependency-name: "@stylistic/eslint-plugin"
  dependency-version: 5.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: eslint
- dependency-name: eslint
  dependency-version: 9.30.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
- dependency-name: eslint-plugin-jsdoc
  dependency-version: 51.3.1
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: eslint
- dependency-name: globals
  dependency-version: 16.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/58921
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-07-03 18:27:55 +00:00
RafaelGSS aad9030f5e src: cleanup uv_fs_req before uv_fs_stat on existSync
Refs: https://hackerone.com/reports/3184178

Calling uv_fs_stat() without first calling
uv_fs_req_cleanup() overwrites the pointer to the
previously allocated buffer leading to a memory
leak on windows

PR-URL: https://github.com/nodejs/node/pull/58915
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
2025-07-03 13:38:59 -03:00
Michaël Zasso 8db664f72c deps: V8: cherry-pick 1d7159580156
Original commit message:

    [explicit-resource-management] Clear isolate internal exception

    This CL clears the isolate internal exception before rejecting
    the promise.

    Bug: 418103036
    Change-Id: If3748f7fc4b79b7b5be5009b9fff0d0267541a6f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6594252
    Reviewed-by: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#100532}

Refs: https://github.com/v8/v8/commit/1d71595801567c60eae0e8ae7157c1afd0aedce5
PR-URL: https://github.com/nodejs/node/pull/58749
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-07-03 17:37:17 +02:00
Claudio W. 6a3b545b4d doc: add ovflowd back to core collaborators
PR-URL: https://github.com/nodejs/node/pull/58911
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
2025-07-03 06:48:59 +00:00
Richard Lau ecc4ab19fd doc: update email address for Richard Lau
PR-URL: https://github.com/nodejs/node/pull/58910
Refs: https://github.com/nodejs/TSC/issues/1699
Refs: https://www.redhat.com/en/blog/evolving-our-middleware-strategy
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-07-03 01:50:01 +00:00
Shelley Vohr ec4168668b tools: update inspector_protocol to 69d69dd
PR-URL: https://github.com/nodejs/node/pull/58900
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-07-02 19:57:10 +00:00
Rafael Gonzaga 46508d9dd8 src,permission: enhance permission model debug
This commit enhance the permission model debug logs
when NODE_DEBUG_NATIVE=PERMISSION_MODEL is used

Example

Inserting /Users/rafaelgss/repos/os/node/t.js
└─ /
   ├─ Users/rafaelgss/repos/os/node/t.js
   └─ tm
      ├─ 3
      ├─ 2
      └─ p/*

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/58898
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-07-02 17:37:13 +00:00
Rafael Gonzaga 8173d9d72b permission: propagate permission model flags on spawn
Previously, only child_process.fork propagated the exec
arguments (execvArgs) to the child process.
This commit adds support for spawn and spawnSync to
propagate permission model flags — except when they are
already provided explicitly via arguments or through
NODE_OPTIONS.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/58853
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2025-07-02 02:32:20 +00:00
Dario Piotrowicz 8d11399a98 test: add known issue tests for recursive readdir calls with Buffer path
PR-URL: https://github.com/nodejs/node/pull/58893
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-07-01 21:48:33 +00:00
Ilyas Shabi 35d1511aaa meta: add IlyasShabi to collaborators
Fixes: https://github.com/nodejs/node/issues/58766
PR-URL: https://github.com/nodejs/node/pull/58916
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-07-01 17:15:49 +00:00
Chengzhong Wu 983cfb8658 doc: update vm doc links
Synthetic Module Record is defined in the ECMA262. Link indirect eval
calls to MDN with rich examples.

PR-URL: https://github.com/nodejs/node/pull/58885
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
2025-07-01 14:23:55 +00:00
Shelley Vohr a7a37c3ac6 crypto: fix inclusion of OPENSSL_IS_BORINGSSL define
PR-URL: https://github.com/nodejs/node/pull/58845
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Richard Lau <rlau@redhat.com>
2025-07-01 12:57:57 +00:00
James M Snell 2022f832a9 test: add known issue tests for fs.cp
PR-URL: https://github.com/nodejs/node/pull/58883
Refs: https://github.com/nodejs/node/issues/58634
Refs: https://github.com/nodejs/node/issues/58869
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-07-01 04:35:06 +00:00
Node.js GitHub Bot f69f90d97a deps: update sqlite to 3.50.2
PR-URL: https://github.com/nodejs/node/pull/58882
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2025-07-01 00:44:38 +00:00
Dario Piotrowicz 4b4aaf921f test: add tests to ensure that node.1 is kept in sync with cli.md
add tests to make sure that the content of the doc/node.1 file
is kept in snyc with the content of the doc/api/cli.md file
(to make sure that when a flag or environment variable is added
or removed to one, the same change is also applied to the other)

PR-URL: https://github.com/nodejs/node/pull/58878
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-30 21:03:28 +00:00
Vas Sudanagunta 16035b4bbe doc: fix links in test.md
Links explaining the various target file-related `run([options])`
pointed to the wrong section.

PR-URL: https://github.com/nodejs/node/pull/58876
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
2025-06-30 19:50:14 +00:00
Ruben Bridgewater c08a1d152b v8: fix missing callback in heap utils destroy
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: https://github.com/nodejs/node/pull/58846
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
2025-06-30 11:51:40 +00:00
Shelley Vohr ab9ef37aa7 build: disable v8_enable_pointer_compression_shared_cage on non-64bit
PR-URL: https://github.com/nodejs/node/pull/58867
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-06-30 08:39:43 +00:00
Alex Yang 8b199eef3d fs: special input -1 on chown, lchown and fchown
PR-URL: https://github.com/nodejs/node/pull/58836
Fixes: https://github.com/nodejs/node/issues/58826
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-29 21:47:02 +00:00
Yoshiya Hinosawa 7db30d7ca8 assert: remove dead code
PR-URL: https://github.com/nodejs/node/pull/58760
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
2025-06-29 21:39:04 +00:00
Pietro Marchini 61a0b12c80 test_runner: correctly filter --experimental-config-file
PR-URL: https://github.com/nodejs/node/pull/58833
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2025-06-29 20:48:29 +00:00
Livia Medeiros f6a4305d16 test: replace .filter()[0] with .find()
PR-URL: https://github.com/nodejs/node/pull/58872
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-06-29 18:58:29 +00:00
Node.js GitHub BotandJoyee Cheung 0b88e0927f deps: update undici to 7.11.0
PR-URL: https://github.com/nodejs/node/pull/58859
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-06-29 18:42:18 +02:00
Richard Lau 4c65776a35 test: remove reliance on in-tree deps/undici
Remove the dependency on the in-tree copy of Undici in `deps/undici`
from `parallel/test-inspector-network-fetch`. For downstream rebuilders
of Node.js using an externalized Undici it is not uncommon to remove
`deps/undici` to ensure that the build is not using the in-tree copy.

PR-URL: https://github.com/nodejs/node/pull/58866
Refs: https://github.com/nodejs/node/issues/58865
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-06-29 16:33:14 +00:00
ronijames008 bab36c34c6 doc: add missing comma in child_process.md
Adds a comma after "blocks" in a sentence explaining how subprocesses
may pause when the pipe buffer is full. This improves readability and
clarifies the meaning of the sentence, preventing misinterpretation of
"blocks waiting" as a compound phrase.

No functional code is affected.

PR-URL: https://github.com/nodejs/node/pull/58862
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-29 15:27:45 +00:00
James M Snell ebe7dade03 doc: add guidelines for introduction of ERM support
PR-URL: https://github.com/nodejs/node/pull/58526
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
2025-06-29 13:54:00 +00:00
James M Snell a3dfca90d1 process: move multipleResolves event to EOL
The `multipleResolves` event has been deprecated for several
years now. It's time.

PR-URL: https://github.com/nodejs/node/pull/58707
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2025-06-29 04:23:09 -07:00
Dario Piotrowicz 4d5ee2491b doc: add all watch-mode related flags to node.1
PR-URL: https://github.com/nodejs/node/pull/58719
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-06-28 22:52:00 +00:00
Dario Piotrowicz 529967aa95 watch: add --watch-kill-signal flag
add the new `--watch-kill-signal` to allow users to customize
what signal is sent to the process on restarts during watch mode

PR-URL: https://github.com/nodejs/node/pull/58719
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-06-28 22:51:59 +00:00
Livia Medeiros f0a947865f test: close dirs in fs-opendir test
PR-URL: https://github.com/nodejs/node/pull/58855
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-06-28 21:31:56 +00:00
Shelley Vohr 1c2fa7ee70 src: -Wmismatched-new-delete in debug_utils.cc
PR-URL: https://github.com/nodejs/node/pull/58844
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2025-06-28 18:52:02 +00:00
Chengzhong Wu 0f7e75f7f6 vm: expose import phase on SourceTextModule.moduleRequests
PR-URL: https://github.com/nodejs/node/pull/58829
Refs: https://github.com/nodejs/node/issues/37648
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-06-28 18:51:48 +00:00
Dario Piotrowicz 9fe3316280 repl: fix eval errors thrown after close throwing ERR_USE_AFTER_CLOSE
prevent incorrect throws of `ERR_USE_AFTER_CLOSE` errors when the eval
function of a repl server returns an error after the repl server
has been closed

PR-URL: https://github.com/nodejs/node/pull/58791
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2025-06-28 18:51:41 +00:00
Livia Medeiros d824914e61 fs: throw ERR_INVALID_THIS on illegal invocations
PR-URL: https://github.com/nodejs/node/pull/58848
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-06-28 16:58:54 +00:00
Antoine du Hamel afbf2f385a tty: treat empty NO_COLOR same as absent NO_COLOR
PR-URL: https://github.com/nodejs/node/pull/58074
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-28 15:26:22 +02:00
Shelley Vohr 98da424ac4 build: option to use custom inspector_protocol path
PR-URL: https://github.com/nodejs/node/pull/58839
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2025-06-28 09:23:18 +00:00
jesh eaebfab299 doc: fix jsdoc definition of assert.ifError() fn in lib/assert.js
PR-URL: https://github.com/nodejs/node/pull/58573
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-06-27 13:30:51 +00:00
Node.js GitHub Bot cdadb20ae1 deps: update googletest to 35b75a2
PR-URL: https://github.com/nodejs/node/pull/58710
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-06-27 13:14:47 +00:00
Michael Henrique db8ca623d4 doc: add array type in http request headers
Document that the headers option in http.request() can be either an
object or an array of strings, similar to message.rawHeaders.

PR-URL: https://github.com/nodejs/node/pull/58049
Fixes: https://github.com/nodejs/node/issues/57986
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
2025-06-27 13:14:37 +00:00
jakecastelli 94f7568e5c test_runner: fix timeout not propagated to the child process in run
PR-URL: https://github.com/nodejs/node/pull/58831
Fixes: https://github.com/nodejs/node/issues/58802
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
2025-06-27 11:50:17 +00:00
Aviv Keller 488febf856 doc: add missing colon to headers in globals.md
PR-URL: https://github.com/nodejs/node/pull/58825
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
2025-06-27 00:40:35 +00:00
Node.js GitHub Bot 8aa07b7843 deps: update minimatch to 10.0.3
PR-URL: https://github.com/nodejs/node/pull/58712
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-06-26 22:08:49 +00:00
Jacob Smith 5b0c7dba0e test_runner: correct "already mocked" error punctuation placement
PR-URL: https://github.com/nodejs/node/pull/58840
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-06-26 20:01:15 +00:00
Antoine du Hamel dbd24b1651 doc: fix stream.md section order
For some reason, `stream.isErrored` and `stream.isReadable` sections
were in between `stream.Readable` static methods sections.

PR-URL: https://github.com/nodejs/node/pull/58811
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-26 14:10:39 +02:00
沈鸿飞 b4c5fb4ffb lib: fix getTypeScriptParsingMode jsdoc
PR-URL: https://github.com/nodejs/node/pull/58681
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-06-26 07:04:40 +00:00