BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
35,276 Commits 266 Branches 972 Tags
59558807ceeb84eef6f2f736a440caec5d4a8eee
Commit Graph
150 Commits
Author SHA1 Message Date
Michael Dawson c85e67b600 test: mark test-repl-sigint-nested-eval as flaky 
Refs: https://github.com/nodejs/node/issues/41123

- This is one of the remaining high occurance flaky
  tests from the reliability reports and recent
  failures in the CI. Mark as flaky until issue
  is resolved under referenced issue.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41302
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-01-04 15:59:25 -05:00
Michael Dawson eee1a6f42a test: mark test-crypto-keygen slow on windows 
Refs: https://github.com/nodejs/node/issues/41206

This test seems to be failing regularly on
windows with a timeout. Mark it slow to reduce
CI noise until it gets investigated.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41207
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-12-21 09:32:59 -05:00
James M Snell 09b57f7909 test: mark test-domain-error-types flaky 
Refs: https://github.com/nodejs/node/issues/39368
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39369
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-07-13 07:27:44 -07:00
Xu Meng db9cf52dcf test: check the different error code on IBM i 
Fixes: https://github.com/nodejs/node/issues/36925

PR-URL: https://github.com/nodejs/node/pull/38159
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-04-11 21:28:22 -05:00
Rich Trott 20009d7dee test: remove FLAKY status for test-async-hooks-http-parser-destroy 
This CI test failure hasn't been reported for some time.

Closes: https://github.com/nodejs/node/issues/26610

PR-URL: https://github.com/nodejs/node/pull/37636
Fixes: https://github.com/nodejs/node/issues/26610
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-03-08 09:38:47 -08:00
Rich Trott 5cea29b294 test: remove FLAKY status for fixed test 
test-worker-message-port-transfer-terminate was fixed in
25447d82d3 but the status file was not updated to reflect this.

PR-URL: https://github.com/nodejs/node/pull/37633
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-03-08 09:36:47 -08:00
Rich Trott f108778153 test: clear flaky designation for test-stream-pipeline-http2 
It hasn't failed for a long time.

Closes: https://github.com/nodejs/node/issues/20750

PR-URL: https://github.com/nodejs/node/pull/37631
Fixes: https://github.com/nodejs/node/issues/20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
 2021-03-08 06:24:25 -08:00
Rich Trott cd4b09589a test: clear FLAKY designation for test-http2-pipe 
It hasn't failed in a long time.

Refs: https://github.com/nodejs/node/issues/20750

PR-URL: https://github.com/nodejs/node/pull/37631
Fixes: https://github.com/nodejs/node/issues/20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
 2021-03-08 06:24:23 -08:00
Rich Trott 2748b0ad5a test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls 
The test does not seem to have failed since the issue was first reported
in 2019.

Closes: https://github.com/nodejs/node/issues/30845

PR-URL: https://github.com/nodejs/node/pull/37533
Fixes: https://github.com/nodejs/node/issues/30845
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-03-01 12:19:43 -08:00
Rich Trott 80098e605c test: remove FLAKY for test-http2-compat-client-upload-reject 
As far as I know, this test hasn't failed since around the time it was
first reported in 2019.

Closes: https://github.com/nodejs/node/issues/30847

PR-URL: https://github.com/nodejs/node/pull/37462
Fixes: https://github.com/nodejs/node/issues/30847
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-02-23 15:08:27 -08:00
Rich Trott 1d2ba1eb74 test: remove FLAKY designation for test-http2-client-upload-reject 
The test hasn't failed in a long time as far as I can tell. The issue
may have been fixed by various event updates/changes to http2 and
related systems.

PR-URL: https://github.com/nodejs/node/pull/37461
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-02-22 17:14:46 -08:00
Rich Trott 32482a828b test: remove FLAKY for test-domain-error-types 
PR-URL: https://github.com/nodejs/node/pull/37458
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-02-22 17:13:08 -08:00
Darshan Sen 4411a99dcd test: fix flaky test-webcrypto-encrypt-decrypt-aes 
* Use a copy of plaintext to prevent tampering of the original
* Since subtle.decrypt returns a Promise containing an ArrayBuffer and
  ArrayBuffers cannot be modified directly, create a Buffer from it
  right away so that the modification in the next line works as intended

Fixes: https://github.com/nodejs/node/issues/35586

PR-URL: https://github.com/nodejs/node/pull/37380
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2021-02-18 11:56:23 -05:00
Michaël Zasso fa3997d75a test: mark test-return-on-exit as flaky 
It fails sporadically in debug builds because the
"--stress-compaction --gc-interval=100" flags make Node.js crash.

Refs: https://github.com/nodejs/node/pull/36139

PR-URL: https://github.com/nodejs/node/pull/36139
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
 2021-02-11 19:11:49 +01:00
Rich Trott e331046a29 test: skip tests consistently in parallel.status 
Some tests are marked SKIP,FLAKY (resulting in yellow/unstable CI when
they fail) and others are marked SKIP (which means the results don't
affect CI at all). There doesn't seem to be any reason for the
difference. Mark them all as SKIP as IBM i for consistency and to have
the luxury of a green daily CI. We'll want these to be at least
SKIP,FLAKY (and preferably not skipped at all) before IBM i is
supported.

PR-URL: https://github.com/nodejs/node/pull/37035
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2021-01-27 20:49:06 +02:00
Richard Lau 863ec7dbaa test: mark flaky tests on IBM i 
PR-URL: https://github.com/nodejs/node/pull/36986
Refs: https://github.com/nodejs/node/issues/34410
Refs: https://github.com/nodejs/node/issues/36925
Refs: https://github.com/nodejs/node/issues/36929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-01-19 06:41:39 -08:00
Rod Vagg 5716130d1e Revert "test: mark test-cluster-bind-privileged-port flaky on arm" 
This reverts commit a45a404197.

Solved by marking ports <1024 as privileged on Docker containers.

Ref: https://github.com/nodejs/node/pull/36850
Ref: https://github.com/nodejs/node/issues/36847
Ref: https://github.com/nodejs/build/pull/2521

PR-URL: https://github.com/nodejs/node/pull/36884
Refs: https://github.com/nodejs/node/pull/36850
Refs: https://github.com/nodejs/node/issues/36847
Refs: https://github.com/nodejs/build/pull/2521
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-01-18 11:46:03 +01:00
James M Snell a45a404197 test: mark test-cluster-bind-privileged-port flaky on arm 
Per rvagg:
```
Persistent failure, even after restarts of the whole cluster. #36478 was
merged into this test yesterday but the parent commit still has the
failures.

What has changed is the Docker version. They all got an upgrade to
5:20.10.2~3-0~raspbian-buster and this is all running inside containers.
It's going to be the newest version of Docker running in our CI and I
wonder whether we're going to see similar failures when we upgrade other
hosts or if this is going to be restricted to ARM.

Other than that, I'm not sure what this could be. It seems like a
straightforward test that shouldn't fail, maybe Docker has introduced
something new for unprivileged port binding inside containers?
```

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/36850
Refs: https://github.com/nodejs/node/issues/36847
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
 2021-01-08 15:26:32 -08:00
Rich Trott 7c808170f5 test: remove test-http2-client-upload as flaky 
The test has not failed in quite some time (as far as I can tell) on CI.
Optimistically removing it.

Refs: https://github.com/nodejs/node/pull/29889

PR-URL: https://github.com/nodejs/node/pull/36496
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-12-15 03:40:55 -08:00
Rich Trott f178c5a134 test: fix flaky test-http2-respond-file-error-pipe-offset 
Fixes: https://github.com/nodejs/node/issues/35881

PR-URL: https://github.com/nodejs/node/pull/36305
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-12-07 07:29:30 -08:00
Rich Trott 55b1718b6a test: remove flaky designation for fixed test 
Remove flaky designation for test-worker-eventlooputil fixed in 9dbde1d.

PR-URL: https://github.com/nodejs/node/pull/35961
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-11-12 05:34:36 -08:00
Rich Trott 72ce5dcd52 test: add missing ref comments to parallel.status 
PR-URL: https://github.com/nodejs/node/pull/35896
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-11-04 04:56:52 -08:00
Myles Borins 915a94cf63 test: mark test-worker-eventlooputil flaky 
This is consistently failing in CI right now. Lets mark it flaky
while we figure out what is going on.

Refs: https://github.com/nodejs/node/issues/35844

PR-URL: https://github.com/nodejs/node/pull/35886
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
 2020-10-31 11:33:26 +00:00
Myles Borins 5da2512a72 test: mark test-http2-respond-file-error-pipe-offset flaky 
This is now failing inconsistently across many platforms. This
appears to be the result of the addition of mustSucceed being
added to the test during testing refactoring.

We should mark flaky until we have figured out what the issue
is.

Refs: https://github.com/nodejs/node/issues/35881

PR-URL: https://github.com/nodejs/node/pull/35883
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2020-10-30 12:31:10 -04:00
James M Snell efe60a5fe2 test: mark test-webcrypto-encrypt-decrypt-aes flaky 
Appears to be flaky only on rhe17-390x. Will be investigating

refs: https://github.com/nodejs/node/issues/35586

PR-URL: https://github.com/nodejs/node/pull/35587
Refs: https://github.com/nodejs/node/issues/35586
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2020-10-13 17:03:06 +00:00
Rich Trott ea5eb8fc9c test: remove test-child-process-fork-args flaky designation 
test-child-process-fork-args does not appear in results from `ncu-ci
walk commit` and no one has reported it failing for several months.
A stress test also passed.

Closes: https://github.com/nodejs/node/issues/32863

PR-URL: https://github.com/nodejs/node/pull/34684
Fixes: https://github.com/nodejs/node/issues/32863
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
 2020-08-10 17:28:41 -07:00
Rich Trott 4195c31ecb test: fix flaky test-http2-reset-flood 
Set `allowHalfOpen: true` in the client.

Fixes: https://github.com/nodejs/node/issues/29802
Refs: https://github.com/nodejs/node/pull/31806

PR-URL: https://github.com/nodejs/node/pull/34318
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2020-07-14 15:15:00 +02:00
Xu Meng 7a84e2e071 test: skip an ipv6 test on IBM i 
Due to some unknown system configuration, the code
`socket_ipv6.bind(0, 111::1)` does not throw the
expected error EADDRNOTAVAIL on some IBM i systems.
This issue is still being investigated. To get the
IBM i CI passing, skip it for now.

PR-URL: https://github.com/nodejs/node/pull/34209
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-07 23:43:55 +02:00
Rich Trott 772fdb0cd3 test: fix flaky test-fs-stream-construct 
The test is marked flaky on ARM because it times out on Raspberry Pi
devices in CI. Split the single test file into four separate test files
to ease debugging. Add fs.close() to avoid timing out.

Fixes: https://github.com/nodejs/node/issues/33796

PR-URL: https://github.com/nodejs/node/pull/34203
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2020-07-06 17:32:24 -07:00
Xu Meng 07bbadb2c7 test: skip some IBM i unsupported test cases 
Issuing a shutdown() on IBM i PASE with parameter SHUT_WR
also sends a normal close sequence to the partner program.
This leads to timing issues and ECONNRESET failures in some
test cases.
Refs: https://github.com/libuv/libuv/pull/2782

PR-URL: https://github.com/nodejs/node/pull/34118
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-07-03 12:02:24 -07:00
Michael Dawson 502f53ff49 test: temporarily exclude test on arm 
Refs: https://github.com/nodejs/node/issues/33796

Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: https://github.com/nodejs/node/pull/33814
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-06-09 15:42:49 -04:00
Sam Roberts 8e956f450a test: mark test flaky on freebsd 
Test name test-worker-message-port-message-before-close is too long for
a commit message description.

Refs: https://github.com/nodejs/node/issues/31280

PR-URL: https://github.com/nodejs/node/pull/32849
Refs: https://github.com/nodejs/node/issues/28803
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-04-28 19:18:13 +02:00
Sam Roberts 22192fc0a9 test: flaky test-stdout-close-catch on freebsd 
Refs: https://github.com/nodejs/node/issues/28803

PR-URL: https://github.com/nodejs/node/pull/32849
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-04-28 19:18:04 +02:00
Andrey Pechkurov 7893c70970 test: mark test-child-process-fork-args as flaky on Windows 
PR-URL: https://github.com/nodejs/node/pull/32950
Refs: https://github.com/nodejs/node/issues/32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2020-04-21 12:56:03 +03:00
Sam Roberts a12aedf41b test: mark test-http2-reset-flood flaky on all 
Refs: https://github.com/nodejs/node/issues/29802
Refs: https://github.com/nodejs/node/pull/32595

PR-URL: https://github.com/nodejs/node/pull/32825
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-04-14 10:57:47 -07:00
Luigi Pinca f675e3a365 Revert "test: mark empty udp tests flaky on OS X" 
This reverts commit 24a4f76709.

PR-URL: https://github.com/nodejs/node/pull/32489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
 2020-04-06 18:29:16 +02:00
Myles Borins 9d82c5501c test: mark test-http2-reset-flood flaky on bsd 
This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.

Refs: https://github.com/nodejs/node/issues/29802

PR-URL: https://github.com/nodejs/node/pull/32595
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2020-04-01 12:54:17 -04:00
Sam Roberts 24a4f76709 test: mark empty udp tests flaky on OS X 
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.

Refs: https://github.com/nodejs/node/issues/30030
Refs: https://github.com/nodejs/build/pull/2189#issuecomment-589767606

PR-URL: https://github.com/nodejs/node/pull/31936
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
 2020-02-26 06:11:05 -08:00
Rich Trott cdac18519f test: remove flaky designation for test-net-connect-options-port 
Closes: https://github.com/nodejs/node/issues/23207

PR-URL: https://github.com/nodejs/node/pull/31841
Fixes: https://github.com/nodejs/node/issues/23207
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
 2020-02-20 08:00:23 -08:00
Rich Trott 9a1c19bb28 test: mark test-fs-stat-bigint flaky on FreeBSD 
Refs: https://github.com/nodejs/node/issues/31727

PR-URL: https://github.com/nodejs/node/pull/31728
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-02-13 22:21:02 -08:00
Rich Trott fb437c49cf test: remove flaky designation for test-fs-stat-bigint 
PR-URL: https://github.com/nodejs/node/pull/30437
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-02-10 19:03:49 -10:00
Anna Henningsen 06a43d4dca test: fix flaky test-http2-stream-destroy-event-order 
Alternative to https://github.com/nodejs/node/pull/31590.

It appears that the issue here is that the test falsely assumed that
closing the client (which also currently destroys the socket rather
than gracefully shutting down the connection) would still leave
enough time for the server side to receive the stream error.

Address that by explicitly waiting for the server side to receive the
stream error before closing the client and the connection with it.

Refs: https://github.com/nodejs/node/pull/31590
Refs: https://github.com/nodejs/node/issues/20750

PR-URL: https://github.com/nodejs/node/pull/31610
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-02-06 04:06:56 -10:00
Anna Henningsen 9528f95336 test: mark additional tests as flaky on Windows 
Basically, any of the tests that failed in the runs for
https://github.com/nodejs/node/pull/31602 which was not already
marked as flaky.

PR-URL: https://github.com/nodejs/node/pull/31606
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2020-02-01 22:58:56 +01:00
Tobias Nießen 3203febbb2 test: skip keygen tests on arm systems 
test-crypto-keygen and test-crypto-dh-stateless are currently flaky
on ARM CI systems due to their slow CPUs.

PR-URL: https://github.com/nodejs/node/pull/31178
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
 2020-01-21 10:49:22 -04:00
Xu Meng 262c66a851 test: skip the unsupported test cases for IBM i 
This is a following PR of #30714.

PR-URL: https://github.com/nodejs/node/pull/30819
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2019-12-25 23:11:02 +01:00
Ben Noordhuis edf654d43e test: work around ENOTEMPTY when cleaning tmp dir 
Replace the homegrown rimrafsync implementation in test/common with
a call to `fs.rmdirSync(path, { recursive: true })`.

Fixes: https://github.com/nodejs/node/issues/30620
Fixes: https://github.com/nodejs/node/issues/30844

PR-URL: https://github.com/nodejs/node/pull/30849
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2019-12-12 14:37:05 -05:00
João Reis a2cfb7dd86 test: mark tests as flaky 
PR-URL: https://github.com/nodejs/node/pull/30848
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2019-12-07 19:15:43 -08:00
Anna Henningsen 58850f6bb4 test: revert 6d022c13 
Revert "test: skip test-domain-error-types in debug mode temporariliy"
This reverts commit 6d022c13c5.

PR-URL: https://github.com/nodejs/node/pull/30708
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2019-11-29 14:19:51 +05:30
Rich Trott 6d022c13c5 test: skip test-domain-error-types in debug mode temporariliy 
Until https://github.com/nodejs/node/issues/30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: https://github.com/nodejs/node/pull/30629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-11-26 10:18:42 -08:00
Luigi Pinca a4a089a568 test: deflake test-http-dump-req-when-res-ends.js 
On some platforms the `'end'` event might not be emitted because the
socket could be destroyed by the other peer while the client is still
sending the data triggering an error. Use the `'close'` event instead.

PR-URL: https://github.com/nodejs/node/pull/30360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2019-11-15 16:25:37 +01:00