Filip Skokan
5d0eb10c80
crypto: do not add undefined hash in webcrypto normalizeAlgorithm
...
PR-URL: https://github.com/nodejs/node/pull/42559
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-04-03 11:11:21 +01:00
Filip Skokan
e12cfd85ae
doc: aes webcrypto unwrap is not a node-specific extensions
...
PR-URL: https://github.com/nodejs/node/pull/42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-04-03 11:11:11 +01:00
Filip Skokan
4fa6c89cd5
crypto: cleanup webcrypto jwk code
...
PR-URL: https://github.com/nodejs/node/pull/42562
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-04-03 11:11:02 +01:00
MURAKAMI Masahiko
95f94cf0f3
test: improve lib/internal/readline/promises.js coverage
...
PR-URL: https://github.com/nodejs/node/pull/42420
Refs: https://coverage.nodejs.org/coverage-419f02ba1f00cac3/lib/internal/readline/promises.js.html
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-04-03 10:40:30 +01:00
Antoine du Hamel
48dbec8b60
test: remove hack for atob and btoa WPT tests
...
PR-URL: https://github.com/nodejs/node/pull/42540
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-04-03 10:40:21 +01:00
Rich Trott
b07dc4d19f
doc: simplify recommendations in process.md
...
Remove recommendation that has no explanation. Make the other
recommendation less wordy.
PR-URL: https://github.com/nodejs/node/pull/42556
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-04-02 23:12:54 -07:00
Node.js GitHub Bot
561885152e
meta: update AUTHORS
...
PR-URL: https://github.com/nodejs/node/pull/42585
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-04-03 06:52:36 +01:00
Rich Trott
b71779517d
doc: clarify recommendations in stream.md
...
PR-URL: https://github.com/nodejs/node/pull/42555
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-04-02 22:46:39 -07:00
Rich Trott
c9bb345b05
doc: simplify recommendation in webcrypto.md
...
PR-URL: https://github.com/nodejs/node/pull/42554
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-04-02 22:36:56 -07:00
Rich Trott
70dae240f0
doc: update DEP0102 text
...
PR-URL: https://github.com/nodejs/node/pull/42553
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-04-02 22:35:38 -07:00
Rich Trott
059b890009
doc: remove util.promisify() content in readline.md
...
PR-URL: https://github.com/nodejs/node/pull/42552
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-04-03 06:03:04 +01:00
mawaregetsuka
302fd02f71
lib: improve the coverage of the validator
...
PR-URL: https://github.com/nodejs/node/pull/42443
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-04-02 23:57:44 +01:00
Joyee Cheung
7c8d98ea84
test: pass data into napi_create_external
...
Since v8 10.1 v8::External::New DCHECKs that the data passed
into it cannot be a nullptr because that's not serializable
as external references. This updates the test to pass a
dummy data pointer to the call - which does not matter for the
test since we only care about whether the finalizer is
called.
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/3513234
PR-URL: https://github.com/nodejs/node/pull/42532
Refs: https://github.com/nodejs/node/pull/42115
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-04-02 23:57:33 +01:00
Antoine du Hamel
46f54bda48
test: improve FileHandle.prototype.write coverage
...
Refs: https://github.com/nodejs/node/pull/42518
PR-URL: https://github.com/nodejs/node/pull/42541
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-04-02 23:57:24 +01:00
Kohei Ueno
eda2498dfd
test: add test for exception handlings in debugger
...
PR-URL: https://github.com/nodejs/node/pull/42327
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2022-04-02 23:50:37 +01:00
Antoine du Hamel
bba82cd9b9
buffer: fix atob input validation
...
Fixes: https://github.com/nodejs/node/issues/42530
PR-URL: https://github.com/nodejs/node/pull/42539
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-04-02 23:50:27 +01:00
Antoine du Hamel
2dea9ccd8a
doc: add introduction sentence for CJS
...
PR-URL: https://github.com/nodejs/node/pull/42491
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-04-02 19:29:22 +01:00
Filip Skokan
18bd02f245
crypto: fix webcrypto derive key lengths
...
PR-URL: https://github.com/nodejs/node/pull/42542
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-04-02 15:54:35 +01:00
meixg
53da438ab8
doc: add @meixg to collaborators
...
PR-URL: https://github.com/nodejs/node/pull/42576
Fixes: https://github.com/nodejs/node/issues/42419
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Qingyu Deng <i@ayase-lab.com >
2022-04-02 20:38:01 +08:00
Ikko Ashimine
127da0f36b
test: fix typo in common/wpt.js
...
thw -> the
PR-URL: https://github.com/nodejs/node/pull/42567
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-04-02 06:42:30 +01:00
Rich Trott
bcc68c36b6
doc: consolidate CI sections
...
PR-URL: https://github.com/nodejs/node/pull/42534
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
2022-04-02 00:46:12 +01:00
Kohei Ueno
4cbb5d1a8b
src: fix typo in InspectorIoDelegate constructor
...
PR-URL: https://github.com/nodejs/node/pull/42520
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
2022-04-01 17:18:16 +01:00
Paolo Insogna
b9e97979f7
doc: document breaking change in http.IncomingMessage 'close' event
...
PR-URL: https://github.com/nodejs/node/pull/42521
Fixes: https://github.com/nodejs/node/issues/38924
Refs: https://github.com/nodejs/node/pull/33035
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-04-01 15:58:14 +02:00
Rich Trott
fd18b0e1d7
doc: remove extraneous comma
...
PR-URL: https://github.com/nodejs/node/pull/42548
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-04-01 14:54:14 +01:00
Tobias Nießen
d484cba6a0
doc: guide towards x509.fingerprint256
...
Recommend using x509.fingerprint256 instead of x509.fingerprint and
x509.fingerprint512 and suggest using it instead of x509.serialNumber
in order to uniquely identify certificates.
PR-URL: https://github.com/nodejs/node/pull/42516
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
2022-04-01 11:35:27 +01:00
Daeyeon Jeong
8dbdca8ed3
doc: fix internal link in collaborator-guide.md
...
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/42551
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-04-01 06:10:47 +01:00
Michael Dawson
1e5bafb9c8
doc: add suggestion for OpenSSL only sec releases
...
Fixes: https://github.com/nodejs/TSC/issues/1187
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42456
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-03-31 17:32:25 -04:00
mawaregetsuka
605a01bcfb
tools: fixed bug causing JSON format to be broken
...
PR-URL: https://github.com/nodejs/node/pull/41565
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-03-31 13:44:50 +01:00
Joyee Cheung
7319419787
bootstrap: reset process._exit and process.exitCode in pre-execution
...
PR-URL: https://github.com/nodejs/node/pull/42466
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2022-03-31 19:29:23 +08:00
Joyee Cheung
01f6b9543f
bootstrap: run inspector and event loop in snapshot builder
...
This makes --inspect and stdin/out functional in the embedded snapshot,
currently it's not guaranteed that these work perfectly, the
plan is to investigate any out-of-sync states that might appear
in user land snapshots with this while the it is a configure-time
feature.
PR-URL: https://github.com/nodejs/node/pull/42466
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2022-03-31 19:29:16 +08:00
Joyee Cheung
c131fbb652
bootstrap: make I/O streams work with user-land snapshot
...
Use the mksnapshot cleanup hooks to release the references
to the native streams so that they can be destroyed right
before the snapshot is taken, and move the initialization
of the global console to pre-execution so that they can be
re-initialized during snapshot dehydration. This makes
it possible for user-land snapshots to use the I/O during
snapshot building.
PR-URL: https://github.com/nodejs/node/pull/42466
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2022-03-31 19:29:14 +08:00
Joyee Cheung
37aee80643
build: add --node-snapshot-main configure option
...
This adds a --build-snapshot runtime option which is currently only
supported by the node_mksnapshot binary, and a --node-snapshot-main
configure option that makes use it to run a custom script when
building the embedded snapshot. The idea is to have this experimental
feature in core as a configure-time feature for now, and investigate
the renaming V8 bugs before we make it available to more users via
making it a runtime option.
PR-URL: https://github.com/nodejs/node/pull/42466
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2022-03-31 19:29:12 +08:00
Joyee Cheung
8a297ba3a0
bootstrap: refresh options in pre-execution
...
Refresh the options map during pre-execution to pave the way for
user land snapshots which may need to access run-time options at
snapshot-building time. The default embedded bootstrap snapshot
is still prevented from accessing them at snapshot building time
since it serves a wider audience and is ignorant of application
states, while the user-land snapshots are meant to be
application-specific and so it makes sense for them to access
runtime states as long as the snapshotted-code
works with re-initialized runtime states.
PR-URL: https://github.com/nodejs/node/pull/42466
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2022-03-31 19:29:08 +08:00
Daeyeon Jeong
1600869eb7
test: fix comments in test files
...
This commit fixes typos found in test files.
PR-URL: https://github.com/nodejs/node/pull/42536
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-03-31 08:48:03 +02:00
Darshan Sen
f2a22ef179
src,crypto: handle empty maybe correctly in crypto_dh.cc
...
Buffer::Length() dereferences the passed Local, so calling it when the
underlying pointer is a nullptr would lead to a crash. This fixes that
by returning early instead.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/42492
Refs: https://github.com/nodejs/node/pull/39941
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2022-03-31 04:29:55 +00:00
Darshan Sen
11c0da67f9
src: remove unnecessary static qualifier in crypto_dh.cc
...
ZeroPadDiffieHellmanSecret() is in an anonymous namespace, so it has
static linkage already.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/42492
Refs: https://github.com/nodejs/node/pull/39941
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2022-03-31 04:29:54 +00:00
Darshan Sen
87a76d9de8
src,crypto: remove uses of AllocatedBuffer from crypto_dh.cc
...
Refs: https://github.com/nodejs/node/pull/39941
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/42492
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2022-03-31 04:29:53 +00:00
Rich Trott
85f679fff1
doc: fix comment text in async_hooks example
...
PR-URL: https://github.com/nodejs/node/pull/42499
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-03-30 16:58:03 +01:00
Daniel Roe
eb3ca87a87
doc: add stability class to legacy status description
...
PR-URL: https://github.com/nodejs/node/pull/42525
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-30 17:49:29 +02:00
Rich Trott
f8ca5dfea4
child_process: add env contents types in JSDoc
...
Use JSDoc to indicate that the `env` object keys and values must be
strings.
Refs: https://github.com/nodejs/node/pull/42489#discussion_r835867932
PR-URL: https://github.com/nodejs/node/pull/42494
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-03-30 15:03:48 +01:00
Antoine du Hamel
d320d459d2
tools: update GHA actions version
...
PR-URL: https://github.com/nodejs/node/pull/42498
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-03-30 14:07:02 +01:00
Michael Dawson
33cbdb33e4
src: address 3 useless call coverity warnings
...
Fix the last 3 useless call reports from coverity
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42426
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-03-29 16:49:02 -04:00
Tobias Nießen
1000eb168a
doc: suggest checkHost in checkServerIdentity docs
...
Refs: https://github.com/nodejs/node/pull/42470
PR-URL: https://github.com/nodejs/node/pull/42495
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-03-29 18:55:41 +01:00
Rongjian Zhang
cff14bcaef
buffer: refactor byteLength to remove outdated optimizations
...
The third argument `mustMatch` is now outdated, so remove it.
Fixes: https://github.com/nodejs/node/issues/38536
PR-URL: https://github.com/nodejs/node/pull/38545
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-29 18:48:37 +01:00
theanarkh
e5200392a2
net,dns: trace tcp connection and dns by perf_hooks
...
use the perf_hooks to trace the time spent by net.connect, dns.lookup,
dns.lookupService, dns.resolvexxx.
PR-URL: https://github.com/nodejs/node/pull/42390
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2022-03-29 16:43:28 +01:00
Jacob Smith
5a927ef0c2
esm: emit experimental warnings in common place
...
PR-URL: https://github.com/nodejs/node/pull/42314
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
2022-03-28 22:43:15 +01:00
Daeyeon Jeong
c6051a08fa
test: fix typos in test/parallel
...
This pr fixes typos in some parallel tests.
PR-URL: https://github.com/nodejs/node/pull/42502
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Qingyu Deng <i@ayase-lab.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-03-28 21:37:31 +01:00
Tony Gorez
00cb0912ef
test: add trace-gc flag test
...
PR-URL: https://github.com/nodejs/node/pull/42471
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2022-03-28 21:15:08 +01:00
Joe Sepi
dfdfd2471f
doc: update security release onboarding
...
This change is helpful when publishing release announcements.
PR-URL: https://github.com/nodejs/node/pull/42333
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-03-28 16:42:00 +01:00
Xuguang Mei
8a96ff7e54
doc: fix question promise API example
...
PR-URL: https://github.com/nodejs/node/pull/42465
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-03-28 11:44:21 +01:00