Antoine du Hamel
d320d459d2
tools: update GHA actions version
...
PR-URL: https://github.com/nodejs/node/pull/42498
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-03-30 14:07:02 +01:00
Eliaz Bobadilla
2e6d5e111c
build: bump actions/checkout
...
https://github.com/actions/checkout\#checkout-v3
PR-URL: https://github.com/nodejs/node/pull/42460
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-03-27 21:34:40 -07:00
Michaël Zasso
e8ac3b4d68
build: rename tools workflow and add undici to it
...
The workflow already updates Corepack, which is a `deps`, not a `tool`.
Add subsystem and label variables to the matrix to better control the
automated pull requests and add undici to the updated deps.
PR-URL: https://github.com/nodejs/node/pull/42246
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
2022-03-09 20:37:39 +01:00
Richard Lau
2d6aea7ff5
build: drop shortened URL from lint-commit-message
...
The shortened link to the commit message guidelines no longer works
after they were moved from `docs/guides` to `docs/contributing`. Now
that `core-validate-commit` outputs an error message pointing to the
full URL of the commit message guidelines on failure we no longer need
to include the URL (shortened or otherwise) in the workflow title.
PR-URL: https://github.com/nodejs/node/pull/42168
Refs: https://github.com/nodejs/core-validate-commit/pull/95
Refs: https://github.com/nodejs/node/issues/41697
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-03 16:15:47 +00:00
Michael Dawson
b3723fac05
build: fix usage of input in feature action
...
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42150
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-02-28 17:28:36 +00:00
Michael Dawson
a62972ab28
build: increase max ops for stale feature action
...
Set the limit to match the number used in the
close stalled action. Required as not all eligeable
stale features are being processed.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42130
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-28 11:16:15 -05:00
Maël Nison
e84b635db4
build: add corepack to the auto-updated dependencies
...
PR-URL: https://github.com/nodejs/node/pull/42090
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-25 22:36:05 +00:00
Michael Dawson
5a65853063
build: last test of the stale feature action
...
- set the days so that we process ~ 40 issues
so that we can see what kind of feedback we get
on saying we are going to close stale feature requests
- set the label to stale instead of stalled so that
there is no race with the action that closes stalled
issues
- fix the links to the feature management doc
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42085
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2022-02-25 10:53:28 -05:00
Michael Dawson
19bf6c59ab
build: update feature close action for testing
...
This should process the 4 oldest feature requests.
Once we've confirmed these are ok we can adjust the
days before an issue is marked as stale.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42082
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-22 17:37:32 -05:00
Michaël Zasso
5348552b93
build: cancel running CI jobs when a PR is updated
...
Refs: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-a-fallback-value
PR-URL: https://github.com/nodejs/node/pull/42017
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Mary Marchini <oss@mmarchini.me >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-02-18 15:46:12 +00:00
Michael Dawson
6db686710e
build: increase operations and test tag
...
- increase the operations as 1 was too small to do
anything
- add an additional tag that must be present before
the action will run. I will manually add that tag
to some feature requests to be able to test
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42038
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-02-17 16:39:55 -05:00
Michael Dawson
b9a460e6eb
build: allow manual run of feature request action
...
add "workflow_dispatch:" so that action can be run
manuallyl for debugging.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42037
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2022-02-17 20:19:39 +00:00
Michael Dawson
3fbc10d7f7
build: add action to close stale feature requests
...
Implement the prodecure outlined in
https://github.com/nodejs/node/blob/master/doc/contributing/feature-request-management.md
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/41981
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-17 14:29:54 -05:00
Michaël Zasso
34cf563add
build: prevent concurrent CI and CQ workflow runs
...
Use concurrency groups to prevent new runs from being started while a
previous job is already running. This can happen when a lot of unrelated
jobs are pending because of runner exhaustion.
PR-URL: https://github.com/nodejs/node/pull/42016
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-16 16:37:29 +00:00
Rich Trott
d17be0fbe5
build: move tool updates workflow runtime a day later
...
Refs: https://github.com/nodejs/node/pull/41973#issuecomment-1039780665
PR-URL: https://github.com/nodejs/node/pull/41982
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-15 10:50:33 +00:00
Mestery
8e653d9898
build,tools: change the quotes in YAML
...
Remove useless quotes and use single quotes when needed.
PR-URL: https://github.com/nodejs/node/pull/41756
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
2022-02-14 19:09:17 +01:00
Filip Skokan
d1a9c439ff
build: revert fast-track changes
...
PR-URL: https://github.com/nodejs/node/pull/41892
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-08 17:05:00 +01:00
Mestery
f7ff2ff304
build: improve consistency between workflows
...
PR-URL: https://github.com/nodejs/node/pull/41791
Reviewed-By: Mary Marchini <oss@mmarchini.me >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-07 17:54:31 +00:00
Michael Dawson
a199387f04
doc: make contributing info more discoverable
...
There are been several discussions in recent PRs about
the docs related to contributing not being very discoverable.
Move these docs from doc/guides/ to doc/contributing.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/41408
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is >
Reviewed-By: Mary Marchini <oss@mmarchini.me >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-01-18 14:24:30 -05:00
Rich Trott
4b1ee04153
build: fix workflow access to git history
...
Refs: https://github.com/nodejs/node/pull/41466
PR-URL: https://github.com/nodejs/node/pull/41472
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
2022-01-13 15:08:44 +00:00
Mestery
665b404e65
build: improve readability of texts in workflows
...
PR-URL: https://github.com/nodejs/node/pull/40988
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-12-19 16:12:57 +00:00
Antoine du Hamel
10df3af981
tools: fix CQ and auto-start-ci jobs
...
PR-URL: https://github.com/nodejs/node/pull/41230
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-12-18 06:07:22 -08:00
Antoine du Hamel
587b167cc4
tools: fix GitHub Actions status when CQ is empty
...
Refs: https://github.com/nodejs/node/pull/40985#issuecomment-995252065
PR-URL: https://github.com/nodejs/node/pull/41193
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-12-18 01:52:54 +00:00
Rich Trott
41e1de6f40
build,tools: automate enforcement of emeritus criteria
...
PR-URL: https://github.com/nodejs/node/pull/41155
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Stewart X Addison <sxa@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Gus Caplan <me@gus.host >
2021-12-15 21:38:35 +00:00
Mestery
6267e55685
build: fix comment-labeled workflow
...
Refs: https://github.com/nodejs/node/pull/40985#issuecomment-994056146
PR-URL: https://github.com/nodejs/node/pull/41176
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-12-14 23:09:12 +00:00
Mestery
f404cd5ce2
build: use gh cli in workflows file
...
PR-URL: https://github.com/nodejs/node/pull/40985
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-12-14 19:06:36 +00:00
Rich Trott
73fe15bf24
build: fix commit-queue-rebase functionality
...
For commit-queue-rebase only, commit-queue.sh uses `git push` which
requires the credentials from the git checkout. Remove
`persist-credentials: false` from this workflow.
PR-URL: https://github.com/nodejs/node/pull/41140
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-12-11 11:00:00 +00:00
Rich Trott
781408f377
build: fail early in test-macos.yml
...
PR-URL: https://github.com/nodejs/node/pull/41035
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-12-03 21:29:24 -08:00
Rich Trott
71c04b12a6
build: add tools/doc to tools.yml updates
...
PR-URL: https://github.com/nodejs/node/pull/41036
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yash Ladha <yash@yashladha.in >
2021-12-02 13:14:22 -08:00
Antoine du Hamel
d81f328aa5
tools: ignore unrelated workflow changes in slow Actions tests
...
Changes in the workflow files never affect the node binary, running
build tasks seems unnecessary.
Refs: https://github.com/nodejs/node/pull/40928
PR-URL: https://github.com/nodejs/node/pull/40990
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-11-30 19:11:16 +00:00
Mestery
6b202cc383
build: update Actions versions
...
PR-URL: https://github.com/nodejs/node/pull/40987
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-11-30 19:11:07 +00:00
Rich Trott
6fd0a60d60
tools: update ESLint update script to consolidate dependencies
...
PR-URL: https://github.com/nodejs/node/pull/40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-11-29 14:52:36 -08:00
Rich Trott
1217087110
build: set persist-credentials: false on workflows
...
Out of extra caution, instruct `actions/checkout` to not save GitHub
authentication credentials in the git config for use by future steps.
PR-URL: https://github.com/nodejs/node/pull/40972
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-11-27 22:12:26 +00:00
Rich Trott
e64c66c1a9
build: ignore unrelated workflow changes in slow Actions tests
...
test-asan and test-macos are very slow and tend to get backed up. While
I'm literally waiting hours right now for test-macos to finish so I can
land a PR, I'm opening this pull request to have it be skipped when
things other than its own workflow file are the only changes in the PR.
PR-URL: https://github.com/nodejs/node/pull/40928
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2021-11-27 01:18:37 +00:00
Antoine du Hamel
27b10881d3
tools: fix commit-lint GH Actions CI
...
PR-URL: https://github.com/nodejs/node/pull/40845
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-11-25 12:14:40 -08:00
Rich Trott
f7ac6ba60c
tools: ping TSC members identified as inactive
...
When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.
PR-URL: https://github.com/nodejs/node/pull/40915
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
2021-11-24 18:33:04 +00:00
Rich Trott
516e29d8cf
build: fix branch name for lint-md-dependencies update
...
Refs: https://github.com/nodejs/node/runs/4288412090?check_suite_focus=true
PR-URL: https://github.com/nodejs/node/pull/40924
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2021-11-22 23:26:45 +00:00
Rich Trott
bad6526a00
build: fix make invocation in tools.yml
...
Be in the correct directory for `make lint-md-rollup`.
PR-URL: https://github.com/nodejs/node/pull/40890
Refs: https://github.com/nodejs/node/runs/4270533399?check_suite_focus=true
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-11-22 05:01:56 +00:00
Rich Trott
129c12e252
tools: add find-inactive-tsc
...
Automate the implementation of rules in the TSC Charter around automatic
removal of members who do not participate in TSC votes and attend fewer
than 25% of the meetings in a 3-month period.
PR-URL: https://github.com/nodejs/node/pull/40884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-11-21 15:10:04 +00:00
Rich Trott
e0233fc7dc
build: fix tools.yml errors
...
PR-URL: https://github.com/nodejs/node/pull/40870
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-11-19 09:18:06 +00:00
Antoine du Hamel
9cd30894f6
tools: only validate first commit message of a PR
...
PR-URL: https://github.com/nodejs/node/pull/40740
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-11-12 23:35:22 +01:00
Rich Trott
e8d16eee26
build: add GitHub Action to update tools modules
...
Update ESLint, Babel, remark, and so on. Run once a week.
PR-URL: https://github.com/nodejs/node/pull/40644
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-11-08 11:47:51 -08:00
Michaël Zasso
873119385f
tools: simplify and fix commit queue
...
Use `gh` CLI for CI and commit queue jobs, and use the correct token
to merge PRs.
PR-URL: https://github.com/nodejs/node/pull/40742
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com >
2021-11-07 15:26:45 +01:00
Antoine du Hamel
14825d63c0
tools: fix commit-lint workflow
...
PR-URL: https://github.com/nodejs/node/pull/40673
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-11-01 19:57:30 +01:00
Antoine du Hamel
b5aa08d2f9
tools: avoid fetch extra commits when validating commit messages
...
PR-URL: https://github.com/nodejs/node/pull/39128
Reviewed-By: Mary Marchini <oss@mmarchini.me >
2021-10-30 17:45:25 +02:00
Rich Trott
8eebc33c02
build: skip long-running Actions for README-only modifications
...
If the only file modified is README.md do not run test-linux or
build-windows tasks. This will help streamline onboarding sessions but
may help some other cases too.
PR-URL: https://github.com/nodejs/node/pull/40571
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-10-24 19:01:18 +00:00
Mestery
ed76b49834
build: fix actions pull request's branch
...
PR-URL: https://github.com/nodejs/node/pull/40494
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Qingyu Deng <i@ayase-lab.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2021-10-18 15:32:55 +02:00
Jiawen Geng
6baea14506
build: avoid run find inactive authors on forked repo
...
PR-URL: https://github.com/nodejs/node/pull/40465
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-10-15 18:30:17 +00:00
FrankQiu
983b757f3f
build: update codeowners-validator to 0.6
...
PR-URL: https://github.com/nodejs/node/pull/40307
Reviewed-By: Mary Marchini <oss@mmarchini.me >
2021-10-13 11:31:04 +00:00
Rich Trott
73c3885e10
build: remove duplicate check for authors.yml
...
update-authors.js will print if there are duplicates in the new entries
so we can remove the (not working) duplication check in the authors.yml
file. It would still be nice to get the information about duplicates
into the body of the GitHub PR so no one has to manually check for
duplicates (by either examining the file or looking at the Actions
output), but that can be a future improvement.
PR-URL: https://github.com/nodejs/node/pull/40393
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
2021-10-12 01:48:33 +00:00