BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-14 10:26:26 -04:00
Code Issues Packages Projects Releases Wiki Activity
39,487 Commits 236 Branches 964 Tags
6bb400f8ec0d276b09441abaedb6cd859f593ccf
Commit Graph
83 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Deokjin Kim 4b486e5e28 doc: fix Type notation in webstreams 
Replace `type` with `Type: {Promise}`. Plus, fix incorrect
verb(`creates` -> `returns`) in description.

PR-URL: https://github.com/nodejs/node/pull/49121
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-08-14 22:40:02 +00:00
Deokjin Kim 761f5681c8 doc: fix second parameter name of events.addAbortListener 
Second parameter name is described as `listener`(not resource)
in below line.

PR-URL: https://github.com/nodejs/node/pull/48922
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-07-27 15:10:48 +00:00
Deokjin Kim 77ea1732a1 doc: declare path on example of async_hooks.executionAsyncId() 
Example is not runnable because `path` is used, but it's not
declared.

PR-URL: https://github.com/nodejs/node/pull/48556
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-07-18 20:00:50 +00:00
Deokjin Kim ca096563e0 benchmark: use cluster.isPrimary instead of cluster.isMaster 
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary`
for benchmark.

Refs: https://github.com/nodejs/node/pull/47981
PR-URL: https://github.com/nodejs/node/pull/48002
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-17 05:51:53 +00:00
Deokjin Kim d2c4518ce6 doc: fix typo in binding functions 
According to usage(node::util::RegisterExternalReferences) of
below line, namespace has to be `util`(not `utils`).

PR-URL: https://github.com/nodejs/node/pull/48003
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-16 14:26:17 +00:00
Deokjin Kim 8cbc307c44 permission: remove unused function declaration 
RestrictAccess() is declared, but it's not used.

PR-URL: https://github.com/nodejs/node/pull/47957
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
 2023-05-15 14:18:07 +00:00
Deokjin Kim 2545019451 buffer: combine checking range of sourceStart in buf.copy 
Merging 2 checking range of sourceStart into 1. Plus,
add test case to increase coverage if sourceStart is greater
than length of source.

PR-URL: https://github.com/nodejs/node/pull/47758
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-07 23:58:41 +00:00
Deokjin Kim b0ca77032a test: refactor to use getEventListeners in timers 
Use `getEventListeners` instead of `listenerCount` because #35991
was landed.

Refs: https://github.com/nodejs/node/pull/35991
Refs: https://github.com/nodejs/node/pull/36006
PR-URL: https://github.com/nodejs/node/pull/47759
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
 2023-05-03 02:28:57 +00:00
Deokjin Kim eb176457a1 doc: update error code of buffer 
According to use of `validateNumber`, error code is changed
from ERR_INVALID_ARG_VALUE to ERR_OUT_OF_RANGE.

Refs: https://github.com/nodejs/node/pull/45796
PR-URL: https://github.com/nodejs/node/pull/47617
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-04-21 10:05:08 +00:00
Deokjin Kim de5787c87c doc: change offset of example in Buffer.copyBytesFrom 
Actual output is different from expected output if offset is 0.
Plus, removed unused importing `Buffer`.

PR-URL: https://github.com/nodejs/node/pull/47606
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
 2023-04-20 09:47:38 +00:00
Deokjin Kim edaa9f4102 benchmark: fix invalid requirementsURL 
Location of `writing-and-running-benchmarks.md` is `doc/contributing`
(not benchmark).

PR-URL: https://github.com/nodejs/node/pull/47378
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-04-03 23:52:21 +00:00
Deokjin Kim accfe8e79a doc: add importing util to example of `process.report.getReport' 
util.inspect() is used, but `util` is not imported. So added
importing util to example of `process.report.getReport`.
Plus, fix wrong importing in example of `process.memoryUsage.rss()`.

PR-URL: https://github.com/nodejs/node/pull/47298
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
 2023-03-31 15:37:56 +00:00
Deokjin Kim 2adb8b1054 doc: revise example of assert.CallTracker 
In example of tracker.getCalls(), actual and expected
are mismatched. So update expected value.
In example of tracker.report(), user can check report
easily through console.log().
In example of tracker.reset(), defining of tracker is
missed in CJS. Plus, use assert.strictEqual() to check
result.

PR-URL: https://github.com/nodejs/node/pull/47252
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-03-29 18:17:18 +00:00
Deokjin Kim 6ed64e784a doc: update output of example in AbortController 
Actual output of example in AbortController is mismatched.
Plus, make `reason` parameter as optional in JSDoc.

Refs: https://github.com/nodejs/node/blob/main/doc/api/globals.md#abortcontrollerabortreason
Refs: https://github.com/nodejs/node/blob/main/doc/api/globals.md#static-method-abortsignalabortreason
PR-URL: https://github.com/nodejs/node/pull/47227
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-25 22:46:05 +09:00
Deokjin Kim b0d31bb854 net: fix setting of value in 'setDefaultAutoSelectFamilyAttemptTimeout' 
Document describes that the value have to be 10 if passed value to
`setDefaultAutoSelectFamilyAttemptTimeout` is less than 10.
So need to use 10 for 'if' statement and fix typo in document.

Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#netsetdefaultautoselectfamilyattempttimeoutvalue
PR-URL: https://github.com/nodejs/node/pull/47012
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2023-03-10 15:07:55 +00:00
Deokjin Kim 57909654a9 doc: fix port of destination server is not defined in http2 
`port` variable is used, but it's not defined in client code.
So need to specify destination server(not proxy)'s port(8000)
in client code.

Refs: https://github.com/nodejs/node/blob/main/doc/api/http2.md#supporting-the-connect-method
PR-URL: https://github.com/nodejs/node/pull/46940
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2023-03-06 00:29:27 +00:00
Deokjin Kim c425a6f58e doc: use number which is bigger than 1024 as port in http2 
With 80 port, user should run example with root permission.
To avoid such situation, use 8000 or 8443 as port number
in example of http2.

PR-URL: https://github.com/nodejs/node/pull/46938
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-03-06 00:29:17 +00:00
Deokjin Kim ac7ef31076 doc: add emit to NodeEventTarget 
NodeEventTarget.emit() is not described in document. Plus, make
type parameter of removeAllListeners as optional.

Refs: https://github.com/nodejs/node/pull/35851
PR-URL: https://github.com/nodejs/node/pull/46356
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-02-21 03:22:51 +09:00
Deokjin Kim ecd385e891 doc: remove unused functions from example of streamConsumers.text 
json, blob, and buffer are imported, but these functions are not
used for example of `streamConsumers.text`.

PR-URL: https://github.com/nodejs/node/pull/46581
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-02-13 03:46:03 +00:00
Deokjin Kim d43b532789 lib: refactor to use validateBuffer 
Use validateBuffer to remove duplicate implementation.

PR-URL: https://github.com/nodejs/node/pull/46489
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2023-02-06 15:44:04 +00:00
Deokjin Kim 88d71dc301 lib: refactor to use min/max of validateNumber 
Fix NumberIsNaN is called two times and change error code
to ERR_OUT_OF_RANGE when RangeError is occurred in test.

PR-URL: https://github.com/nodejs/node/pull/45772
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-02-03 21:12:05 +00:00
Deokjin Kim 82ee78295a doc: fix wrong location of requestTimeout's default value 
Refs: https://nodejs.org/dist/latest-v19.x/docs/api/http.html#serverrequesttimeout
PR-URL: https://github.com/nodejs/node/pull/46423
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-02-03 14:51:55 +00:00
Deokjin Kim 13cab1cd4b doc: add deokjinkim to collaborators 
Fixes: https://github.com/nodejs/node/issues/46329
PR-URL: https://github.com/nodejs/node/pull/46444
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-02-03 23:25:15 +09:00
Deokjin Kim a5fd53f8ef doc: pass string to textEncoder.encode as input 
Input of `textEncoder.encode` should be string, not array.

Refs: https://nodejs.org/dist/latest-v19.x/docs/api/util.html#textencoderencodeinput
PR-URL: https://github.com/nodejs/node/pull/46421
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2023-01-30 17:32:35 +00:00
Deokjin Kim 391dc74a10 http: throw error if options of http.Server is array 
If options of http.Server is array, throw ERR_INVALID_ARG_TYPE.

Refs: https://github.com/nodejs/node/pull/24176
PR-URL: https://github.com/nodejs/node/pull/46283
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-01-25 08:52:33 +00:00
Deokjin Kim cc18fd9608 events: refactor to use validateNumber 
Need to use validateNumber for checking `TypeError`

PR-URL: https://github.com/nodejs/node/pull/45770
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2023-01-22 06:50:37 +00:00
Deokjin Kim 05296d9246 doc: mark some parameters as optional in webstreams 
Some parameters are described as optional in spec, so update
mismatched parameter.

Refs: https://streams.spec.whatwg.org/

PR-URL: https://github.com/nodejs/node/pull/46269
Refs: https://streams.spec.whatwg.org/
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-01-21 12:03:10 +01:00
Deokjin Kim c9ea952582 doc: update output of example in events.getEventListeners 
Update mismatched output of `events.getEventListeners` example.
Plus, show output using console.log.

PR-URL: https://github.com/nodejs/node/pull/46268
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-21 10:39:54 +00:00
Deokjin Kim 49be0ac4ac test: enable more case of bad buffer in fs.write 
Passing to the `string` parameter an object with an own
`toString` function is no longer supported.(DEP0162)
So use such case as bad buffer in test.

Refs: https://github.com/nodejs/node/blob/main/doc/api/deprecations.md#dep0162-fswrite-fswritefilesync-coercion-to-string
PR-URL: https://github.com/nodejs/node/pull/46236
Refs: https://github.com/nodejs/node/pull/42796
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-01-19 15:39:45 +00:00
Deokjin Kim b8043998db doc: fix mismatched arguments of NodeEventTarget 
Arguments of some APIs are mismatched and 2 APIs are not as
described.

PR-URL: https://github.com/nodejs/node/pull/45678
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-19 10:41:09 +01:00
Deokjin Kim 8a74477ddf trace_events: refactor to use validateStringArray 
`options.categories` is string[]. So used `validateStringArray`

Refs: https://nodejs.org/dist/latest-v19.x/docs/api/tracing.html#trace_eventscreatetracingoptions
PR-URL: https://github.com/nodejs/node/pull/46012
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-01-19 09:08:38 +00:00
Deokjin Kim 2ff8c5090e events: add initEvent to Event 
Refs: https://dom.spec.whatwg.org/#dom-event-initevent
PR-URL: https://github.com/nodejs/node/pull/46069
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-01-19 08:59:00 +00:00
Deokjin Kim 65f8a2716e events: change status of event.returnvalue to legacy 
`event.returnvalue` is described as legacy in spec.
Plus, add missed '#'(private member) of defaultPrevented
in implementation.

Refs: https://dom.spec.whatwg.org/#interface-event
Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue
PR-URL: https://github.com/nodejs/node/pull/46175
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-01-19 07:10:25 +00:00
Deokjin Kim 4b737c3557 doc: update events API example to have runnable code 
Fixes: https://github.com/nodejs/node/issues/45755
PR-URL: https://github.com/nodejs/node/pull/45760
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-18 19:25:11 +00:00
Deokjin Kim dc06df31b6 readline: refactor to use validateNumber 
`validateNumber` throws more proper error code and
error name.

PR-URL: https://github.com/nodejs/node/pull/45801
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-01-18 15:32:57 +01:00
Deokjin Kim 671ffd7825 buffer: use min/max of validateNumber 
Instead of additional `if` statement, use min/max
of `validateNumber`.

PR-URL: https://github.com/nodejs/node/pull/45796
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-01-18 10:36:27 +00:00
Deokjin Kim f461a4c5fc http: refactor to use validateHeaderName 
Remove duplicate implementation by using validateHeaderName.

PR-URL: https://github.com/nodejs/node/pull/46143
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-01-17 13:40:39 +00:00
Deokjin Kim 44595b48f0 lib: use kEmptyObject and update JSDoc in webstreams 
Use kEmptyObject as default value of strategy.
Plus, make reason and chunk as optional.
And refactor to use validateBuffer.

Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#transformstreamdefaultcontrollerenqueuechunk
Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#transformstreamdefaultcontrollererrorreason
Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#writablestreamdefaultwriterabortreason
Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#writablestreamdefaultwriterwritechunk
PR-URL: https://github.com/nodejs/node/pull/46183
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2023-01-15 22:10:42 +00:00
Deokjin Kim be93b7a582 lib: refactor to use validate function 
Throwing error after checking type is repeated. So replace
it with validate function.

PR-URL: https://github.com/nodejs/node/pull/46101
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2023-01-14 09:52:26 +00:00
Deokjin Kim 36d54dc6e0 vm: refactor to use validate function 
Throwing error after checking type is repeated.
So replace it with validate function.

PR-URL: https://github.com/nodejs/node/pull/46176
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-14 00:21:54 +00:00
Deokjin Kim a691002f1e http: refactor to use min of validateNumber for maxTotalSockets 
Remove duplicate implementation by using min of validateNumber.

PR-URL: https://github.com/nodejs/node/pull/46115
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-13 14:39:54 +00:00
Deokjin Kim 96605796ef doc: make options of readableStream.pipeTo as optional 
Refs: https://github.com/nodejs/node/blob/main/lib/internal/webstreams/readablestream.js#L380
PR-URL: https://github.com/nodejs/node/pull/46180
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-13 07:53:05 +00:00
Deokjin Kim a9bc3cf39b benchmark,tools: use os.availableParallelism() 
Refs: https://github.com/nodejs/node/pull/45895
PR-URL: https://github.com/nodejs/node/pull/46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-01-11 20:07:57 +00:00
Deokjin Kim d8014f6aa9 test: use os.availableParallelism() 
Refs: https://github.com/nodejs/node/pull/45895
PR-URL: https://github.com/nodejs/node/pull/46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-01-11 20:07:56 +00:00
Deokjin Kim c226783aa9 events: change status of event.cancelBubble to legacy 
`event.cancelBubble` is described as legacy in spec.

Refs: https://dom.spec.whatwg.org/#interface-event
PR-URL: https://github.com/nodejs/node/pull/46146
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2023-01-11 16:29:53 +00:00
Deokjin Kim 8282e65b0f perf_hooks: fix checking range of options.figures in createHistogram 
For `options.figures`, number between 1 and 5 is allowed. So need
to use `validateInteger` to limit max as 5.

Refs: https://github.com/nodejs/node/blob/main/doc/api/perf_hooks.md#perf_hookscreatehistogramoptions
PR-URL: https://github.com/nodejs/node/pull/45999
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-01-10 20:11:06 +00:00
Deokjin Kim 2363634076 test: update Web Events WPT 
This updates the tests and the status file via running
`git node wpt dom/events`.

PR-URL: https://github.com/nodejs/node/pull/46051
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-01-10 20:01:49 +00:00
Deokjin Kim 513c15147c events: change status of event.srcElement to legacy 
`event.srcElement` is described as legacy in spec.

Refs: https://dom.spec.whatwg.org/#interface-event
PR-URL: https://github.com/nodejs/node/pull/46085
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-01-07 10:54:00 +00:00
Deokjin Kim 57add38bd3 doc: fix event.cancelBubble documentation 
Setter of `event.cancelBubble` is a no-op if the value passed to it is
not `true`.

Refs: https://dom.spec.whatwg.org/#interface-event
PR-URL: https://github.com/nodejs/node/pull/45986
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2023-01-07 08:56:34 +01:00
Deokjin Kim 6763932946 doc: update output of example in inspector 
Actual output of promise example in inspector is mismatched.

PR-URL: https://github.com/nodejs/node/pull/46073
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2023-01-06 23:49:36 +00:00
Deokjin Kim cd4f4b4dfa doc: describe argument of Symbol.for 
Symbol is described with argument, but argument of Symbol.for
is ommited. So describe argument of Symbol.for for consistency.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolstring
PR-URL: https://github.com/nodejs/node/pull/46019
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-01-04 20:37:33 +00:00
Deokjin Kim 5d4cb8464d events: check signal before listener 
In WPT Events, TypeError is expected if both listener and
signal are null. But checking listener doesn't throw TypeError.
So check signal before listener because checking signal throws
TypeError if signal is null.

PR-URL: https://github.com/nodejs/node/pull/46054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2023-01-04 04:28:54 +00:00
Deokjin Kim c87a1977ff lib: update JSDoc of getOwnPropertyValueOrDefault 
PR-URL: https://github.com/nodejs/node/pull/46010
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-01-01 16:58:04 +01:00
Deokjin Kim 4b9f94bd90 test: use process.hrtime.bigint instead of process.hrtime 
`process.hrtime` is legacy. So replace `process.hrtime` with
`process.hrtime.bigint` in test.

Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime

Signed-off-by: Deokjin Kim <deokjin81.kim@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/45877
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-01-01 11:07:47 +00:00
Deokjin Kim 91b9a470b8 events: fix violation of symbol naming convention 
Capital letter is followed after 'k' prefix.

PR-URL: https://github.com/nodejs/node/pull/45978
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2023-01-01 10:57:48 +00:00
Deokjin Kim 5e43f3d776 vm: refactor to use validateStringArray 
PR-URL: https://github.com/nodejs/node/pull/46020
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2023-01-01 10:50:49 +00:00
Deokjin Kim 2582a0d2dd async_hooks: refactor to use validateObject 
PR-URL: https://github.com/nodejs/node/pull/46004
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-01-01 10:50:33 +00:00
Deokjin Kim 50744bb5f4 doc: use console.error for error case in timers and tls 
console.error is more suitable than console.log for error case.

PR-URL: https://github.com/nodejs/node/pull/46002
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-01-01 06:41:28 +00:00
Deokjin Kim 87f541e77d fs: refactor to use validateInteger 
PR-URL: https://github.com/nodejs/node/pull/46008
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-01-01 06:33:50 +00:00
Deokjin Kim 979ec87665 stream: refactor to use validateFunction 
PR-URL: https://github.com/nodejs/node/pull/46007
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-01-01 06:33:41 +00:00
Deokjin Kim d160518fbf lib: use kEmptyObject as default value for options 
`kEmptyObject` is more suitable than {} if options don't
need mutation.

PR-URL: https://github.com/nodejs/node/pull/46011
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-12-31 07:33:39 +00:00
Deokjin Kim e27012b248 doc: fix wrong output of example in url.protocol 
Tailing slash of url.href is ommited.

PR-URL: https://github.com/nodejs/node/pull/45954
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-12-28 21:19:34 +00:00
Deokjin Kim 0f23daae95 stream: fix typo in JSDoc 
`vois` -> `void`

PR-URL: https://github.com/nodejs/node/pull/45991
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-12-28 18:41:13 +01:00
Deokjin Kim 6d8c5a4580 doc: use os.availableParallelism() in async_context and cluster 
Refs: https://github.com/nodejs/node/pull/45895
PR-URL: https://github.com/nodejs/node/pull/45979
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-12-28 11:45:10 +00:00
Deokjin Kim 5754e04c9f http: replace var with const on code of comment 
`const` or `let` is more preferred than `var` except iteration.

PR-URL: https://github.com/nodejs/node/pull/45951
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2022-12-28 12:39:57 +01:00
Deokjin Kim 0bd8b4323c doc: make EventEmitterAsyncResource's options as optional 
Refs: https://github.com/nodejs/node/blob/main/lib/events.js#L140
PR-URL: https://github.com/nodejs/node/pull/45985
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2022-12-27 13:00:30 +00:00
Deokjin Kim 9e58e4b426 doc: update error message of example in repl 
Error message in document is different from actual result.

PR-URL: https://github.com/nodejs/node/pull/45920
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-12-24 20:09:54 +00:00
Deokjin Kim 2ad3b028e4 doc: remove port from example in url.hostname 
If port is used for `url.hostname`, `url.hostname`
is not working. So remove port from example in
`url.hostname`.

PR-URL: https://github.com/nodejs/node/pull/45927
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-12-24 06:14:22 +00:00
Deokjin Kim 4f3bc9d682 doc: show output of example in http 
User can check output of example easily.

PR-URL: https://github.com/nodejs/node/pull/45915
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-12-24 00:21:31 +00:00
Deokjin Kim f3dd3fed6d doc: fix wrong output of example in url.password 
Tailing slash of url.href is ommited.

PR-URL: https://github.com/nodejs/node/pull/45928
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2022-12-21 14:32:07 +00:00
Deokjin Kim ef8aa88866 doc: fix wrong output of example in util 
In `mime.type` of util, `application/javascript` is actual output,
but described as `application/javascript/javascript`.

PR-URL: https://github.com/nodejs/node/pull/45825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2022-12-12 18:11:44 +00:00
Deokjin Kim c776324f0a lib: check number of arguments in EventTarget's function 
For now, addEventListener() only checks number of arguments.
removeEventListener() and dispatchEvent() also need checking
number of arguments.

PR-URL: https://github.com/nodejs/node/pull/45668
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
 2022-12-09 06:07:20 +00:00
Deokjin Kim 3f98be90ea net: check autoSelectFamilyAttemptTimeout is positive 
In document, `autoSelectFamilyAttemptTimeout` is described as
positive integer because it's time unit. But there is no checking
whether it's positive integer.

PR-URL: https://github.com/nodejs/node/pull/45740
Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#socketconnectoptions-connectlistener
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-12-08 09:45:54 +01:00
Deokjin Kim ab064d12b7 doc: fix actual result of example is different in events 
Change of events internal may be not reflected yet.

PR-URL: https://github.com/nodejs/node/pull/45656
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
 2022-12-06 05:05:58 +00:00
Deokjin Kim f9227ffc4b doc: use console.error for error case in child_process and dgram 
console.error is more suitable than console.log for error case.

PR-URL: https://github.com/nodejs/node/pull/45690
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2022-12-02 15:23:15 +00:00
Deokjin Kim 59678813e7 lib: add missing type of removeEventListener in question 
removeEventListener of signal is not working because
event type is missed.

PR-URL: https://github.com/nodejs/node/pull/45676
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-12-01 14:39:39 +00:00
Deokjin Kim 1b550ba1af doc: add missing line in debugger 
Output of "node inspect" missed "connecting to..."
line from time to time. So added it.

PR-URL: https://github.com/nodejs/node/pull/45632
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-11-30 02:36:20 +00:00
Deokjin Kim 1750a94ec1 src: use enum class instead of enum in node_i18n 
"enum class" has more advantages than "enum" because
it's strongly typed and scoped.

Refs: https://isocpp.org/wiki/faq/cpp11-language-types#enum-class
PR-URL: https://github.com/nodejs/node/pull/45646
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2022-11-30 01:23:37 +00:00
Deokjin Kim 838c97c43f doc: fix actual result of example is different in stream 
Error message of JSON.parse may be changed with current node version.
For reference, actual result is same with previous node
version(v16.18.1).

PR-URL: https://github.com/nodejs/node/pull/45619
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
 2022-11-29 10:25:41 +00:00
Deokjin Kim 016abb6c55 doc: add options parameter to eventTarget.removeEventListener 
options parameter is available for eventTarget.removeEventListener,
but it's not described.

PR-URL: https://github.com/nodejs/node/pull/45667
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-11-29 09:56:43 +00:00
Deokjin Kim 58b60c1393 test: fix typos in test/parallel 
Fix typos in parallel tests.

PR-URL: https://github.com/nodejs/node/pull/45583
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
 2022-11-28 02:37:17 +00:00
Deokjin Kim 5f340058c8 doc: use console.error for error case in fs, https, net and process 
console.error is more suitable than console.log for error case.

PR-URL: https://github.com/nodejs/node/pull/45606
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
 2022-11-26 14:48:32 +00:00
Deokjin Kim f36768abd8 doc: use console.error for error case in http2 
console.error is more suitable than console.log for error case.

PR-URL: https://github.com/nodejs/node/pull/45577
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
 2022-11-23 06:34:37 +00:00