BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-14 10:26:26 -04:00
Code Issues Packages Projects Releases Wiki Activity
39,487 Commits 236 Branches 964 Tags
6bb400f8ec0d276b09441abaedb6cd859f593ccf
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Antoine du Hamel 1aeb48c975 test: refactor test-esm-loader-hooks for easier debugging 
- Always check stderr before stdout as the former would contain error
  information.
- Always match the full stdout to avoid surprises.
- Use `deepStrictEqual` when appropriate to get more informative test
  failures.
- Remove leading slashes from relative paths/URLs to not confuse them
  with absolute paths.
- Remove unnecessary `--no-warnings` flag.

PR-URL: https://github.com/nodejs/node/pull/49131
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2023-08-15 09:32:38 +00:00
Antoine du Hamel 52b3007f89 doc: fix name of the flag in initialize() docs 
PR-URL: https://github.com/nodejs/node/pull/49158
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-08-14 11:42:30 +00:00
Antoine du Hamel b5da2f4dad esm: fix globalPreload warning 
PR-URL: https://github.com/nodejs/node/pull/49069
Fixes: https://github.com/nodejs/node/issues/49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-08-13 14:37:32 +00:00
Antoine du Hamel 3d20582c0f module: make CJS load from ESM loader 
PR-URL: https://github.com/nodejs/node/pull/47999
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-08-13 04:23:05 +00:00
Antoine du Hamel e68e359aae test: reduce flakiness of test-esm-loader-hooks 
PR-URL: https://github.com/nodejs/node/pull/49105
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-08-12 10:20:12 +00:00
Antoine du Hamel 6aafb6fbbb esm: protect ERR_UNSUPPORTED_DIR_IMPORT against prototype pollution 
PR-URL: https://github.com/nodejs/node/pull/49060
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-08-11 06:29:14 +00:00
Antoine du Hamel cc80513551 tools: limit the number of auto start CIs 
PR-URL: https://github.com/nodejs/node/pull/49067
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2023-08-08 13:26:07 +00:00
Antoine du Hamel a973446b91 test: use spawn and spawnPromisified instead of exec 
PR-URL: https://github.com/nodejs/node/pull/48991
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-08-05 07:29:53 +00:00
Antoine du Hamel 3af7cfe7d4 test: refactor test-node-output-errors 
The main reason is to not have the test fail if the CWD contains some
special URL chars.

PR-URL: https://github.com/nodejs/node/pull/48992
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-08-03 21:52:30 +00:00
Antoine du Hamel a061781da3 test: use fixtures.fileURL when appropriate 
PR-URL: https://github.com/nodejs/node/pull/48990
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-03 21:36:13 +00:00
Antoine du Hamel 5c65565108 esm: fix typo parentUrl -> parentURL 
PR-URL: https://github.com/nodejs/node/pull/48999
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-08-02 20:27:39 +00:00
Antoine du Hamel af4cdcde15 src: do not pass user input to format string 
PR-URL: https://github.com/nodejs/node/pull/48973
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-01 20:05:51 +00:00
Antoine du Hamel ce958d2d78 test: validate error code rather than message 
PR-URL: https://github.com/nodejs/node/pull/48972
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-01 19:40:06 +00:00
Antoine du Hamel 217abd475f test: fix snapshot tests when cwd contains spaces or backslashes 
Both are valid characters for file names on non-Windows systems.

PR-URL: https://github.com/nodejs/node/pull/48959
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-07-31 21:54:28 +00:00
Antoine du Hamel 97ca9a8961 test: order common.mjs in ASCII order 
PR-URL: https://github.com/nodejs/node/pull/48960
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-07-31 13:09:15 +00:00
Antoine du Hamel 384f5d44a8 test: fix some assumptions in tests 
Some tests are assuming they will be run from a directory that do not
contain any quote or special character in its path. That assumption is
not necessary, using `JSON.stringify` or `pathToFileURL` ensures the
test can be run whatever the path looks like.

PR-URL: https://github.com/nodejs/node/pull/48958
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-07-31 13:09:07 +00:00
Antoine du Hamel 42b5711d0b test: fix es-module/test-esm-initialization 
PR-URL: https://github.com/nodejs/node/pull/48880
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-07-29 09:51:10 +00:00
Antoine du Hamel 053511f7ec module: ensure successful import returns the same result 
PR-URL: https://github.com/nodejs/node/pull/46662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2023-07-26 20:34:20 +00:00
Antoine du Hamel ad0603edc6 url: ensure getter access do not mutate observable symbols 
PR-URL: https://github.com/nodejs/node/pull/48897
Refs: https://github.com/nodejs/node/pull/48891
Refs: https://github.com/nodejs/node/issues/48886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-07-24 07:47:47 +00:00
Antoine du Hamel 16b8c71a32 esm: add back globalPreload tests and fix failing ones 
PR-URL: https://github.com/nodejs/node/pull/48779
Fixes: https://github.com/nodejs/node/issues/48778
Fixes: https://github.com/nodejs/node/issues/48516
Refs: https://github.com/nodejs/node/pull/46402
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-07-17 17:26:15 +02:00
Antoine du Hamel ffb1929b6a esm: fix emit deprecation on legacy main resolve 
PR-URL: https://github.com/nodejs/node/pull/48664
Refs: https://github.com/nodejs/node/pull/48325
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-07-11 16:49:06 +00:00
Antoine du Hamel 3ce51ae9c0 module: harmonize error code between ESM and CJS 
PR-URL: https://github.com/nodejs/node/pull/48606
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-07-04 09:52:56 +00:00
Antoine du Hamel d9f394e607 test: remove unnecessary noop function args to mustNotCall() 
PR-URL: https://github.com/nodejs/node/pull/48513
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2023-06-24 16:16:07 +02:00
Antoine du Hamel 64255b11bd doc: revise error.md introduction 
PR-URL: https://github.com/nodejs/node/pull/48423
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
 2023-06-15 23:24:53 +00:00
Antoine du Hamel d2d4a310f1 typings: fix JSDoc in ESM loader modules 
PR-URL: https://github.com/nodejs/node/pull/48424
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2023-06-11 21:09:21 +02:00
Antoine du Hamel 2c6698b4db lib: add support for inherited custom inspection methods 
PR-URL: https://github.com/nodejs/node/pull/48306
Fixes: https://github.com/nodejs/node/issues/48207
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-06-11 08:10:47 +00:00
Antoine du Hamel 9f3466bcb6 esm: remove support for arrays in import internal method 
This avoids initializing arrays that we never use, and simplifies the
implementation overall.

PR-URL: https://github.com/nodejs/node/pull/48296
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-06-05 08:32:33 +00:00
Antoine du Hamel de4fb11e4f lib: do not disable linter for entire files 
Disabling linter for single lines is less error prone.

PR-URL: https://github.com/nodejs/node/pull/48299
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
 2023-06-02 17:42:40 +02:00
Antoine du Hamel fa1c73213f esm: handle globalPreload hook returning a nullish value 
PR-URL: https://github.com/nodejs/node/pull/48249
Fixes: https://github.com/nodejs/node/issues/48240
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-06-01 12:10:45 +02:00
Antoine du Hamel d28f1f1193 esm: handle more error types thrown from the loader thread 
PR-URL: https://github.com/nodejs/node/pull/48247
Refs: https://github.com/nodejs/node/issues/48240
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-06-01 09:21:01 +00:00
Antoine du Hamel 2fac041508 tools: harmonize dep_updaters scripts 
PR-URL: https://github.com/nodejs/node/pull/48201
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-05-29 10:59:52 +00:00
Antoine du Hamel 00fcff575e doc: add version info on the SEA docs 
PR-URL: https://github.com/nodejs/node/pull/48173
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-05-25 15:54:46 +00:00
Antoine du Hamel 30870d126b doc: fix Windows code snippet tags 
Those were wrongly marked as `bash`, when the text around it was
referencing PowerShell or Command Prompt.

PR-URL: https://github.com/nodejs/node/pull/48100
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
 2023-05-21 11:27:16 +00:00
Antoine du Hamel 260092eca3 doc: harmonize fenced code snippet flags 
We had a few code snippets that were using a non-descriptive tag (e.g.
`console` or `text`), whereas the actual language it's using describes
it better, and improves the syntax highlighting. This commit also
removes non-necessary leading chars (e.g. `$`, `>`, or `%`) to make it
easier for readers to copy and paste to try the command themselves.

PR-URL: https://github.com/nodejs/node/pull/48082
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-21 09:36:57 +02:00
Antoine du Hamel cdd20cfd71 esm: do not use 'beforeExit' on the main thread 
PR-URL: https://github.com/nodejs/node/pull/47964
Fixes: https://github.com/nodejs/node/issues/47929
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-05-14 05:32:08 +00:00
Antoine du Hamel d6c0b81fd2 esm: rename URLCanParse to be consistent 
PR-URL: https://github.com/nodejs/node/pull/47668
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-04-24 17:27:42 +02:00
Antoine du Hamel 7dd3732480 esm: remove support for deprecated hooks 
Those have been deprecated for a while, it's time.

PR-URL: https://github.com/nodejs/node/pull/47580
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-04-19 23:52:05 +00:00
Antoine du Hamel ee08c701f7 esm: initialize import.meta on eval 
PR-URL: https://github.com/nodejs/node/pull/47551
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-04-19 18:55:36 +00:00
Antoine du Hamel 2e0152ccf1 esm: propagate process.exit from the loader thread to the main thread 
PR-URL: https://github.com/nodejs/node/pull/47548
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-04-19 04:30:28 +00:00
Antoine du Hamel bc445fa3a2 doc: fix history ordering of WASI constructor 
PR-URL: https://github.com/nodejs/node/pull/47611
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2023-04-18 11:35:05 -07:00
Antoine du Hamel 4afb25ccfd benchmark: add a benchmark for defaultResolve 
PR-URL: https://github.com/nodejs/node/pull/47543
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-04-13 19:49:54 +00:00
Antoine du Hamel 57caf13562 tools: fix notify-on-push Slack messages 
PR-URL: https://github.com/nodejs/node/pull/47453
Refs: https://api.slack.com/reference/surfaces/formatting#special-mentions
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-04-08 15:17:50 +00:00
Antoine du Hamel aa5eb58d3b esm: skip file: URL conversion to path when possible 
PR-URL: https://github.com/nodejs/node/pull/46305
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-04-01 07:43:38 +00:00
Antoine du Hamel 863ac8fa37 util: fix inspecting error with a throwing getter for cause 
PR-URL: https://github.com/nodejs/node/pull/47163
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-03-31 16:27:52 +00:00
Antoine du Hamel 841f6b3abf esm: increase test coverage of edge cases 
PR-URL: https://github.com/nodejs/node/pull/47033
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-03-31 16:27:43 +00:00
Antoine du Hamel 553b052648 tools: remove targets for individual test suites in Makefile 
PR-URL: https://github.com/nodejs/node/pull/46892
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2023-03-31 13:48:59 +00:00
Antoine du Hamel 946f0ca29b tools: fix Slack notification action 
PR-URL: https://github.com/nodejs/node/pull/47237
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-03-23 21:17:55 +00:00
Antoine du Hamel 820030491f tools: notify on Slack when invalid commit lands 
PR-URL: https://github.com/nodejs/node/pull/47178
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-03-23 09:38:17 +00:00
Antoine du Hamel ad2c3c04e6 url: allow extension of user provided URL objects 
PR-URL: https://github.com/nodejs/node/pull/46989
Fixes: https://github.com/nodejs/node/issues/46981
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-03-19 03:25:35 +00:00
Antoine du Hamel f7e9a12017 doc: clarify that fs.create{Read,Write}Stream support AbortSignal 
Refs: https://github.com/nodejs/node/pull/36431
PR-URL: https://github.com/nodejs/node/pull/47122
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-18 17:21:51 +00:00
Antoine du Hamel 03fd5ae04d test: move test-tls-autoselectfamily-servername to test/internet 
And switch from `google.com` to `nodejs.org`.

PR-URL: https://github.com/nodejs/node/pull/47029
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-03-11 13:52:43 +00:00
Antoine du Hamel b8ef1b476e test: add coverage for custom loader hooks with permission model 
PR-URL: https://github.com/nodejs/node/pull/46977
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2023-03-08 17:14:07 +00:00
Antoine du Hamel 0c460518e8 typings: improve primordials typings 
PR-URL: https://github.com/nodejs/node/pull/46970
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-03-08 10:47:26 +00:00
Antoine du Hamel 0c4f8f255a esm: fix import assertion warning 
Refs: https://github.com/nodejs/node/pull/46901#discussion_r1122242913
PR-URL: https://github.com/nodejs/node/pull/46971
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-07 10:32:47 +00:00
Antoine du Hamel ab8942848b lib: enforce use of trailing commas 
PR-URL: https://github.com/nodejs/node/pull/46881
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-03-06 10:44:14 +01:00
Antoine du Hamel 5a7491b5ac esm: add a runtime warning when using import assertions 
PR-URL: https://github.com/nodejs/node/pull/46901
Refs: https://github.com/nodejs/node/issues/46830
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-03-03 18:31:12 +00:00
Antoine du Hamel 928a2b04dd url: remove unnecessary call to FunctionPrototypeBind 
PR-URL: https://github.com/nodejs/node/pull/46870
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-01 20:47:24 +00:00
Antoine du Hamel 6258c067f2 doc: add history info for node:test 
PR-URL: https://github.com/nodejs/node/pull/46851
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
 2023-02-28 16:37:27 +00:00
Antoine du Hamel 9dbb1623ff lib: add trailing commas to all public core modules 
PR-URL: https://github.com/nodejs/node/pull/46848
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2023-02-28 12:10:24 +01:00
Antoine du Hamel 55dd283758 tools: fix linter message when using global DOMException 
Refs: https://github.com/nodejs/node/blob/757c10414776b6f035ced453599527a841f47d6e/lib/internal/util.js#L601-L610
PR-URL: https://github.com/nodejs/node/pull/46822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2023-02-26 18:44:14 +01:00
Antoine du Hamel 5f76836277 lib: add trailing commas to more internal files 
PR-URL: https://github.com/nodejs/node/pull/46811
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2023-02-26 11:34:02 +01:00
Antoine du Hamel 54f452d764 events: add trailing commas in source files 
PR-URL: https://github.com/nodejs/node/pull/46759
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-02-24 09:45:04 +01:00
Antoine du Hamel 351d7fd20d child_process: add trailing commas in source files 
PR-URL: https://github.com/nodejs/node/pull/46758
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-02-24 09:44:18 +01:00
Antoine du Hamel e4e8421c25 repl: add trailing commas in source files 
PR-URL: https://github.com/nodejs/node/pull/46757
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2023-02-24 09:43:27 +01:00
Antoine du Hamel 655b070d31 debugger: add trailing commas in source files 
PR-URL: https://github.com/nodejs/node/pull/46714
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-02-22 01:26:44 +01:00
Antoine du Hamel f33ae81d84 tls: add trailing commas in source files 
PR-URL: https://github.com/nodejs/node/pull/46715
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-02-22 01:22:23 +01:00
Antoine du Hamel 629a8fa2df punycode: add pending deprecation 
PR-URL: https://github.com/nodejs/node/pull/46719
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
 2023-02-21 15:33:29 +00:00
Antoine du Hamel f43d4fafeb lib: add trailing commas in internal/perf 
PR-URL: https://github.com/nodejs/node/pull/46697
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-02-20 01:59:21 +01:00
Antoine du Hamel 9f192530f2 fs: add trailing commas in source files 
PR-URL: https://github.com/nodejs/node/pull/46696
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-02-20 01:58:32 +01:00
Antoine du Hamel d9a0a4a095 cluster: add trailing commas in source files 
PR-URL: https://github.com/nodejs/node/pull/46695
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-02-20 01:57:41 +01:00
Antoine du Hamel cafc0b2b33 lib: add trailing commas in internal/process 
PR-URL: https://github.com/nodejs/node/pull/46687
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-02-18 18:56:43 +01:00
Antoine du Hamel d42628d05a stream: add trailing commas in webstream source files 
PR-URL: https://github.com/nodejs/node/pull/46685
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-02-18 18:55:52 +01:00
Antoine du Hamel 3a648af0f0 stream: add trailing commas in stream source files 
PR-URL: https://github.com/nodejs/node/pull/46686
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-02-18 17:53:57 +00:00
Antoine du Hamel 0084fc7994 tools: fix bug in prefer-primordials lint rule 
PR-URL: https://github.com/nodejs/node/pull/46659
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2023-02-17 18:29:42 +00:00
Antoine du Hamel cbcefdf253 lib: enforce use of trailing commas in more files 
Some part of the codebase already use trailing commas, this commit is
adding a lint rule to ensure it stays this way.
This commit also adds the rule for a few files that were missing only
one or two trailing commas.

PR-URL: https://github.com/nodejs/node/pull/46655
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-02-16 18:47:24 +01:00
Antoine du Hamel fe514bf960 lib: enforce use of trailing commas for functions 
PR-URL: https://github.com/nodejs/node/pull/46629
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2023-02-14 18:45:16 +01:00
Antoine du Hamel 3acdeb1f7a benchmark: add trailing commas in benchmark/path 
PR-URL: https://github.com/nodejs/node/pull/46628
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-02-14 17:09:42 +00:00
Antoine du Hamel 873e5ce54a test: add trailing commas in test/pummel 
PR-URL: https://github.com/nodejs/node/pull/46610
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2023-02-12 17:36:39 +01:00
Antoine du Hamel 5c74108891 benchmark: add trailing commas in benchmark/http 
PR-URL: https://github.com/nodejs/node/pull/46609
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-02-12 16:32:00 +00:00
Antoine du Hamel 214b00d215 benchmark: add trailing commas in benchmark/crypto 
PR-URL: https://github.com/nodejs/node/pull/46553
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-02-10 00:54:53 +00:00
Antoine du Hamel 3aef395ed5 benchmark: add trailing commas in benchmark/url 
PR-URL: https://github.com/nodejs/node/pull/46551
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-02-10 00:54:40 +00:00
Antoine du Hamel 71646e2eca benchmark: add trailing commas in benchmark/http2 
PR-URL: https://github.com/nodejs/node/pull/46552
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-02-09 23:15:52 +00:00
Antoine du Hamel 8844cc42e7 lib: tighten AbortSignal.prototype.throwIfAborted implementation 
PR-URL: https://github.com/nodejs/node/pull/46521
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2023-02-08 13:29:09 +00:00
Antoine du Hamel da89ab8545 stream: refactor to use validateAbortSignal 
PR-URL: https://github.com/nodejs/node/pull/46520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-02-08 13:28:59 +00:00
Antoine du Hamel f466fe5ecc benchmark: add trailing commas in benchmark/process 
PR-URL: https://github.com/nodejs/node/pull/46481
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-02-05 11:00:09 +00:00
Antoine du Hamel 806a516851 benchmark: add trailing commas in benchmark/misc 
PR-URL: https://github.com/nodejs/node/pull/46474
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-02-04 18:19:36 +00:00
Antoine du Hamel 95434fbf28 benchmark: add trailing commas in benchmark/buffers 
PR-URL: https://github.com/nodejs/node/pull/46473
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-02-04 18:19:25 +00:00
Antoine du Hamel 7079158d29 test: add trailing commas in test/js-native-api 
PR-URL: https://github.com/nodejs/node/pull/46385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-02-03 17:12:18 +01:00
Antoine du Hamel 279839dc43 benchmark: add trailing commas in benchmark/module 
PR-URL: https://github.com/nodejs/node/pull/46461
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-02-03 11:45:13 +01:00
Antoine du Hamel fd4869b3f3 benchmark: add trailing commas in benchmark/net 
PR-URL: https://github.com/nodejs/node/pull/46439
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-02-03 11:43:15 +01:00
Antoine du Hamel 83cc1e2c8b benchmark: add trailing commas in benchmark/util 
PR-URL: https://github.com/nodejs/node/pull/46438
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-02-03 11:42:25 +01:00
Antoine du Hamel 75dca44c60 tools: update ESLint custom rules to not use the deprecated format 
Refs: https://eslint.org/docs/latest/extend/custom-rules-deprecated
PR-URL: https://github.com/nodejs/node/pull/46460
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-02-03 09:55:29 +00:00
Antoine du Hamel 997c47fba7 benchmark: add trailing commas in benchmark/async_hooks 
PR-URL: https://github.com/nodejs/node/pull/46424
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-02-01 21:46:09 +00:00
Antoine du Hamel 9e5d1af3ea benchmark: add trailing commas in benchmark/fs 
PR-URL: https://github.com/nodejs/node/pull/46426
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2023-02-01 19:16:18 +00:00
Antoine du Hamel 6d92cc736d test: add trailing commas in test/known_issues 
PR-URL: https://github.com/nodejs/node/pull/46408
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2023-02-01 10:46:55 +01:00
Antoine du Hamel f57e9c36ab test: add trailing commas in test/internet 
PR-URL: https://github.com/nodejs/node/pull/46407
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2023-02-01 10:46:06 +01:00
Antoine du Hamel d640feee85 test: add trailing commas in test/node-api 
PR-URL: https://github.com/nodejs/node/pull/46384
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-29 20:01:09 +01:00
Antoine du Hamel ac66a99cf1 test: add trailing commas in test/message 
PR-URL: https://github.com/nodejs/node/pull/46372
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-29 19:15:22 +01:00
Antoine du Hamel aa8a2441cb test: add trailing commas in test/pseudo-tty 
PR-URL: https://github.com/nodejs/node/pull/46371
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-29 19:14:30 +01:00
Antoine du Hamel ca5f322d32 benchmark: add trailing commas 
PR-URL: https://github.com/nodejs/node/pull/46370
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-29 19:13:35 +01:00