Commit Graph
43637 Commits
Author SHA1 Message Date
Filip Skokan 6fdd4e6dcf src: refactor SubtleCrypto algorithm and length validations
PR-URL: https://github.com/nodejs/node/pull/57273
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Mattias Buelens <mattias@buelens.com>
2025-03-04 17:45:51 +00:00
James M Snell 52ac44888d src: make more error handling improvements
PR-URL: https://github.com/nodejs/node/pull/57262
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-03-04 09:11:10 -08:00
Rafael Gonzaga 2cff256065 Revert "test: temporary remove resource check from fs read-write"
This reverts commit 55cc372b96.

PR-URL: https://github.com/nodejs/node/pull/56906
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
2025-03-04 16:34:07 +00:00
James M Snell da906646c0 lib: remove obsolete Cipher export
Cipher was removed from the public API a while ago but we were still
defining it and exporting `require('crypto').Cipher` as `undefined`.
Silly us.

PR-URL: https://github.com/nodejs/node/pull/57266
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-03-04 08:33:21 -08:00
Antoine du Hamel 559d481924 src: fix typo in comment
PR-URL: https://github.com/nodejs/node/pull/57291
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2025-03-05 00:58:31 +10:30
Chengzhong Wu f37d2a5809 tools: add more details about rolling inspector_protocol
PR-URL: https://github.com/nodejs/node/pull/57167
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2025-03-04 12:13:28 +00:00
Aditi d3064e8ddb v8: add v8.getCppHeapStatistics() method
Expose `CppHeap` data via
`cppgc::CppHeap::CollectStatistics()` in the v8 module.

PR-URL: https://github.com/nodejs/node/pull/57146
Fixes: https://github.com/nodejs/node/issues/56533
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-03-04 11:14:34 +00:00
Rob Palmer a914f173d2 doc: recommend erasableSyntaxOnly in ts docs
TypeScript 5.8 is now released which adds a new tsconfig flag that
aligns with Node's default behavior.

https://www.typescriptlang.org/tsconfig/#erasableSyntaxOnly

Two weeks ago this options was added to the recommended TSConfig for
Node which resides in the tsconfig/bases project.

https://github.com/tsconfig/bases/blob/main/bases/node-ts.json
PR-URL: https://github.com/nodejs/node/pull/57271
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
2025-03-04 10:09:32 +00:00
Joyee Cheung 0aa3dddfeb module: handle cached linked async jobs in require(esm)
This handles two cases caused by using Promise.all() with
multiple dynamic import() that can make an asynchronously
linked module job that has finished/failed linking but
has not yet started actual evaluation appear in the load
cache when another require request is in turn to handle
it.

- When the cached async job has finished linking but has not
  started its evaluation because the async run() task would be
  later in line, start the evaluation from require() with
  runSync().
- When the cached async job have already encountered a linking
  error that gets wrapped into a rejection, but is still later
  in line to throw on it, just unwrap and throw the linking error
  from require().

PR-URL: https://github.com/nodejs/node/pull/57187
Fixes: https://github.com/nodejs/node/issues/57172
Refs: https://github.com/shufo/prettier-plugin-blade/issues/311
Refs: https://github.com/fisker/prettier-plugin-blade-311
Refs: https://github.com/mochajs/mocha/issues/5290
Refs: https://github.com/JoshuaKGoldberg/repros/tree/mocha-missing-module-cyclic
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2025-03-04 07:34:34 +00:00
Node.js GitHub Bot 635aed90c0 deps: update corepack to 0.32.0
PR-URL: https://github.com/nodejs/node/pull/57265
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-03-04 00:40:44 +00:00
Node.js GitHub Bot 5ac95510c7 deps: update undici to 7.4.0
PR-URL: https://github.com/nodejs/node/pull/57236
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2025-03-03 23:08:27 +00:00
dependabot[bot] 187ddb1d5d tools: bump the eslint group in /tools/eslint with 5 updates
Bumps the eslint group in /tools/eslint with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) | `7.26.7` | `7.26.9` |
| [@babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser) | `7.26.5` | `7.26.8` |
| [@stylistic/eslint-plugin-js](https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin-js) | `3.0.1` | `4.1.0` |
| [eslint](https://github.com/eslint/eslint) | `9.19.0` | `9.21.0` |
| [globals](https://github.com/sindresorhus/globals) | `15.14.0` | `16.0.0` |

Updates `@babel/core` from 7.26.7 to 7.26.9
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.9/packages/babel-core)

Updates `@babel/eslint-parser` from 7.26.5 to 7.26.8
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.8/eslint/babel-eslint-parser)

Updates `@stylistic/eslint-plugin-js` from 3.0.1 to 4.1.0
- [Release notes](https://github.com/eslint-stylistic/eslint-stylistic/releases)
- [Changelog](https://github.com/eslint-stylistic/eslint-stylistic/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint-stylistic/eslint-stylistic/commits/v4.1.0/packages/eslint-plugin-js)

Updates `eslint` from 9.19.0 to 9.21.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v9.19.0...v9.21.0)

Updates `globals` from 15.14.0 to 16.0.0
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](https://github.com/sindresorhus/globals/compare/v15.14.0...v16.0.0)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: eslint
- dependency-name: "@babel/eslint-parser"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: eslint
- dependency-name: "@stylistic/eslint-plugin-js"
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: eslint
- dependency-name: eslint
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
- dependency-name: globals
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: eslint
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/57261
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-03-03 18:52:10 +00:00
Marco Ippolito 1347d424e2 test: module syntax should throw
PR-URL: https://github.com/nodejs/node/pull/57121
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
2025-03-03 18:30:40 +00:00
marco-ippolito 5b7ebbc7b3 deps: update amaro to 0.4.1
PR-URL: https://github.com/nodejs/node/pull/57121
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
2025-03-03 18:30:40 +00:00
dependabot[bot] 3463aa2c10 meta: bump actions/download-artifact from 4.1.8 to 4.1.9
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.8 to 4.1.9.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/fa0a91b85d4f404e444e00e005971372dc801d16...cc203385981b70ca67e1cc392babf9cc229d5806)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/57260
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-03-03 18:15:55 +00:00
dependabot[bot] 948557ed67 meta: bump peter-evans/create-pull-request from 7.0.6 to 7.0.7
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.6 to 7.0.7.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](https://github.com/peter-evans/create-pull-request/compare/67ccf781d68cd99b580ae25a5c18a1cc84ffff1f...dd2324fc52d5d43c699a5636bcf19fceaa70c284)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/57259
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-03-03 18:15:38 +00:00
dependabot[bot] ee8c38a75a meta: bump step-security/harden-runner from 2.10.4 to 2.11.0
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.10.4 to 2.11.0.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](https://github.com/step-security/harden-runner/compare/cb605e52c26070c328afc4562f0b4ada7618a84e...4d991eb9b905ef189e4c376166672c3f2f230481)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/57258
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-03-03 18:15:26 +00:00
dependabot[bot] fb8b72837b meta: bump actions/cache from 4.2.0 to 4.2.2
Bumps [actions/cache](https://github.com/actions/cache) from 4.2.0 to 4.2.2.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/1bd1e32a3bdc45362d1e726936510720a7c30a57...d4323d4df104b026a6aa633fdb11d772146be0bf)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/57256
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-03-03 18:15:17 +00:00
dependabot[bot] f9916e943d meta: bump actions/upload-artifact from 4.6.0 to 4.6.1
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08...4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/57255
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-03-03 18:15:09 +00:00
Cheng 47a59bde2a src: fix node_config_file.h compilation error in GN build
PR-URL: https://github.com/nodejs/node/pull/57210
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-03-03 08:27:31 +00:00
Mert Can Altin 7c910d09e2 module: add dynamic file-specific ESM warnings
PR-URL: https://github.com/nodejs/node/pull/56628
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-03-03 07:35:35 +00:00
Meghan Denny 208f07adda test: more common.mustNotCall in net, tls
PR-URL: https://github.com/nodejs/node/pull/57246
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
2025-03-03 05:54:27 +00:00
Eric Fortis 97cbefabd9 doc: clarify path.isAbsolute is not path traversal mitigation
PR-URL: https://github.com/nodejs/node/pull/57073
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-03-02 18:48:59 +01:00
Chengzhong Wu 464485397a tools: remove deps/zlib/GN-scraper.py
Gyp appends search path for `pymod_do_main`, so `GN-scraper.py` in
`v8_gypfiles` always takes precedence over `deps/zlib/GN-scraper.py`,
and `deps/zlib/GN-scraper.py` is never loaded.

PR-URL: https://github.com/nodejs/node/pull/57238
Refs: https://github.com/nodejs/gyp-next/blob/46fc91f1fa0aeb72a2581ea6996f5e37f7a2e9ce/pylib/gyp/input.py#L935
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-03-02 12:36:30 +00:00
Marco Ippolito a3657da5c6 meta: set nodejs/config as codeowner
PR-URL: https://github.com/nodejs/node/pull/57237
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-03-02 12:18:40 +00:00
Gürgün Dayıoğlu 6b0af1748c timers: check for immediate instance in clearImmediate
PR-URL: https://github.com/nodejs/node/pull/57069
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
2025-03-01 23:54:52 +00:00
David Sanders d1ec948866 doc: fix rendering of DEP0174 description
PR-URL: https://github.com/nodejs/node/pull/56835
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-03-01 23:46:31 +00:00
1ilsang a6181b4a71 doc: add 1ilsang to triage team
PR-URL: https://github.com/nodejs/node/pull/57183
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
2025-03-01 23:29:20 +00:00
Node.js GitHub Bot e8df4f22f8 tools: update doc to new version
PR-URL: https://github.com/nodejs/node/pull/57085
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-03-01 23:29:11 +00:00
Yagiz Nizipli f4dd4bb2b3 src: reduce string allocations on sqlite
PR-URL: https://github.com/nodejs/node/pull/57227
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
2025-03-01 21:00:17 +00:00
Edy Silva 71196c431f net: emit an error when custom lookup resolves to a non-string address
PR-URL: https://github.com/nodejs/node/pull/57192
Fixes: https://github.com/nodejs/node/issues/57112
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2025-03-01 20:43:41 +00:00
Richard Lau 60dff4208f test: skip test-config-json-schema with quic
`parallel/test-config-json-schema` compares to a generated fixture that
assumes that Node.js was built with default configuration settings.

Skip the test if non-default quic is enabled (`configure --with-quic`).

Refs: https://github.com/nodejs/node/pull/57016
Refs: https://github.com/nodejs/node/pull/57142
PR-URL: https://github.com/nodejs/node/pull/57225
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-03-01 19:10:59 +00:00
Richard Lau 5ae1224cef deps: update gyp file for ngtcp2 1.11.0
Add source file introduced in ngtcp2 1.11.0 to `ngtcp2.gyp`.

Refs: https://github.com/nodejs/node/pull/57179
PR-URL: https://github.com/nodejs/node/pull/57225
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-03-01 19:10:59 +00:00
Node.js GitHub Bot ed22a68254 deps: update ada to 3.1.3
PR-URL: https://github.com/nodejs/node/pull/57222
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2025-03-01 01:50:39 +00:00
Guy Bedford db4dcc05ac esm: support source phase imports for WebAssembly
PR-URL: https://github.com/nodejs/node/pull/56919
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
2025-02-28 09:52:47 -08:00
Edy Silva ac5afbc83a doc: add @geeksilva97 to collaborators
Fixes: https://github.com/nodejs/node/issues/57032
PR-URL: https://github.com/nodejs/node/pull/57241
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-02-28 14:26:52 -03:00
James M Snell 40deed2ebd src: improve error handling in node_messaging.cc
PR-URL: https://github.com/nodejs/node/pull/57211
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-02-28 17:26:08 +01:00
James M Snell 72cfa4b11c src: improve error handling in tty_wrap.cc
PR-URL: https://github.com/nodejs/node/pull/57211
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-02-28 17:26:08 +01:00
James M Snell b4c7ea0dc4 src: improve error handling in tcp_wrap.cc
PR-URL: https://github.com/nodejs/node/pull/57211
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-02-28 17:26:06 +01:00
Gürgün Dayıoğlu 52ecb96cf6 lib: optimize priority queue
PR-URL: https://github.com/nodejs/node/pull/57100
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2025-02-28 16:25:49 +00:00
Colin Ihrig aafc14bae5 doc: add missing assert return types
This commit documents the return types for assert.rejects() and
assert.doesNotReject().

PR-URL: https://github.com/nodejs/node/pull/57219
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-02-28 14:33:00 +00:00
Antoine du Hamel 48f381d309 fs: only show deprecation warning when error code matches
PR-URL: https://github.com/nodejs/node/pull/56549
Refs: https://github.com/nodejs/node/pull/55753
Reviewed-By: Jacob Smith <jacob@frende.me>
2025-02-28 10:46:11 +00:00
Luigi Pinca 0d92ce497b test: swap assert.strictEqual() parameters
The `actual` and the `expected` parameters are respectively the first
and the second.

PR-URL: https://github.com/nodejs/node/pull/57217
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-02-28 10:37:18 +00:00
Meghan Denny 4ec9d42d48 test: assert write return values in buffer-bigint64
PR-URL: https://github.com/nodejs/node/pull/57212
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-02-28 05:06:08 +00:00
Marco Ippolito 1a6bef29b2 src: set default config as node.config.json
PR-URL: https://github.com/nodejs/node/pull/57171
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-02-27 21:02:10 +00:00
Stefan Stojanovic 4edc6dbe71 build,win: disable node pch with ccache
PR-URL: https://github.com/nodejs/node/pull/57224
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2025-02-27 19:45:15 +00:00
Edy Silva c7cf6778c7 sqlite,test,doc: allow Buffer and URL as database location
PR-URL: https://github.com/nodejs/node/pull/56991
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-02-27 17:43:13 +00:00
Node.js GitHub Bot 269c851240 2025-02-26, Version 23.9.0 (Current)
Notable changes:

dns:
  * (SEMVER-MINOR) add TLSA record query and parsing (Rithvik Vibhu) https://github.com/nodejs/node/pull/52983
process:
  * (SEMVER-MINOR) add threadCpuUsage (Paolo Insogna) https://github.com/nodejs/node/pull/56467

PR-URL: https://github.com/nodejs/node/pull/57207
2025-02-26 17:34:53 +01:00
Sujal Raj 304743655d doc: add streamResetBurst and streamResetRate
Added missing documentation for the streamResetBurst and streamResetRate
options in the http2.createSecureServer section. This ensures developers
are aware of these configurable options.

Fixes: https://github.com/nodejs/node/issues/57169
Refs: https://nodejs.org/docs/latest/api/http2.html#http2createserveroptions-onrequesthandler
PR-URL: https://github.com/nodejs/node/pull/57195
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
2025-02-26 15:47:23 +00:00
Daniel M Brasil fd453837ea src: fix ThrowInvalidURL call in PathToFileURL
Replace `nullptr` with `std::nullopt` when calling `ThrowInvalidURL` in
`PathToFileURL`. This ensures the function receives the correct argument
type and aligns with the expected behavior.

PR-URL: https://github.com/nodejs/node/pull/57141
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
2025-02-26 14:34:50 +00:00