Antoine du Hamel
737db4e81b
src: coerce spawnSync args to string once
...
PR-URL: https://github.com/nodejs/node/pull/62633
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2026-07-19 17:31:03 -05:00
Daniel Lando
3bc2bac693
build: remove redundant -fuse-linker-plugin from GCC LTO flags
...
The `-fuse-linker-plugin` flag has been automatically enabled by GCC
since version 5 when LTO is active, making the explicit flag
redundant. Since Node.js requires GCC >= 13.2, this flag serves no
purpose.
Removing it also improves portability with alternative linkers (mold,
lld) that may not support GCC's linker plugin interface, avoiding
build failures when these linkers are used with GCC LTO builds.
Refs: https://github.com/yao-pkg/pkg/issues/231
Signed-off-by: Daniel Lando <daniel.sorridi@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/62667
Reviewed-By: Richard Lau <richard.lau@ibm.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2026-07-19 17:31:03 -05:00
Rohan Santhosh Kumar
2e5ea5da46
doc: fix typo in devcontainer guide
...
PR-URL: https://github.com/nodejs/node/pull/62687
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Aviv Keller <me@aviv.sh >
2026-07-19 17:31:03 -05:00
Mike McCready
dcbb795532
doc: clarify Backport-PR-URL metadata added automatically
...
Signed-off-by: M McCready <66998419+MikeMcC399@users.noreply.github.com >
PR-URL: https://github.com/nodejs/node/pull/62668
Fixes: https://github.com/nodejs/node/issues/61955
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2026-07-19 17:31:02 -05:00
Filip Skokan
558d28fee4
doc: update WPT test runner README.md
...
Signed-off-by: Filip Skokan <panva.ip@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/62680
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Aviv Keller <me@aviv.sh >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-19 17:31:02 -05:00
Antoine du Hamel
f370889d1a
stream: simplify createPromiseCallback
...
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/62650
Reviewed-By: Aviv Keller <me@aviv.sh >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2026-07-19 17:31:02 -05:00
sangwook
04e1e7efb7
stream: fix writev unhandled rejection in fromWeb
...
When using Duplex.fromWeb() or Writable.fromWeb() with cork()/uncork(),
writes are batched into _writev(). If destroy() is called in the same
microtask, the underlying WritableStream writer gets aborted, causing
SafePromiseAll() to reject with a non-array value (e.g. an AbortError).
The done() callback in _writev() of both fromWeb adapter functions
unconditionally called error.filter(), assuming the value was always an
array. This caused a TypeError that became an unhandled rejection,
crashing the process.
Fix by separating the resolve and reject handlers of SafePromiseAll:
use () => done() on the resolve path (all writes succeeded, no error)
and done on the reject path (error passed directly to callback).
Fixes: https://github.com/nodejs/node/issues/62199
Signed-off-by: sangwook <rewq5991@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/62297
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
2026-07-19 17:31:02 -05:00
Antoine du Hamel
2238aa6b84
tools: improve backport review script
...
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/62573
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2026-07-19 17:31:02 -05:00
Rohan Santhosh Kumar
12a372dcc0
doc: fix spelling in release announcement guidance
...
PR-URL: https://github.com/nodejs/node/pull/62663
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-19 17:31:02 -05:00
Filip Skokan
bfb7fd2be8
test: ensure WPT report is in out/wpt
...
Signed-off-by: Filip Skokan <panva.ip@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/62637
Reviewed-By: Jason Zhang <xzha4350@gmail.com >
Reviewed-By: Mattias Buelens <mattias@buelens.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Aviv Keller <me@aviv.sh >
2026-07-19 17:31:01 -05:00
Filip Skokan
357842d0bb
test: improve WPT runner summary
...
Signed-off-by: Filip Skokan <panva.ip@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/62636
Reviewed-By: Mattias Buelens <mattias@buelens.com >
Reviewed-By: Jason Zhang <xzha4350@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2026-07-19 17:31:01 -05:00
Ruben Bridgewater
90f90ae20e
assert,util: fix stale nested cycle memo entries
...
Temporary nested cycle-tracking entries could remain in the memory set
after a successful comparison. If a later sibling comparison reused one
of those objects, deepStrictEqual could incorrectly fail for equivalent
structures.
This cleans up the temporary nested entries after the nested
comparison returns.
Fixes: https://github.com/nodejs/node/issues/62422
PR-URL: https://github.com/nodejs/node/pull/62509
Fixes: https://github.com/nodejs/node/issues/62422
Reviewed-By: Jordan Harband <ljharb@gmail.com >
2026-07-19 17:31:01 -05:00
Antoine du Hamel
dae9644789
stream: refactor duplexify to be less suceptible to prototype pollution
...
PR-URL: https://github.com/nodejs/node/pull/62559
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jordan Harband <ljharb@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2026-07-19 17:31:01 -05:00
Michael Dawson
c1432639ee
meta: move Michael to emeritus
...
Unfortunately I have a lot going on at home and work these days so
I won't have time to contribute for a while and I think it makes
sense to move Emeritus until that changes.
Signed-off-by: Michael Dawson <midawson@redhat.com >
PR-URL: https://github.com/nodejs/node/pull/62536
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <richard.lau@ibm.com >
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Stewart X Addison <sxa@redhat.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2026-07-19 17:31:01 -05:00
Antoine du Hamel
8198b32080
tools: improve output for unexpected passes in WTP tests
...
PR-URL: https://github.com/nodejs/node/pull/62587
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-19 17:31:01 -05:00
Yuya Inoue
f2a148137b
test: capture negative utimes mtime at call time
...
PR-URL: https://github.com/nodejs/node/pull/62490
Refs: https://github.com/nodejs/node/issues/37692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-19 17:31:00 -05:00
Richard Lau
207d61e5e7
tools: revert OpenSSL update workflow to ubuntu-latest
...
Workflow requires Docker, which is not available in `ubuntu-slim`.
Signed-off-by: Richard Lau <richard.lau@ibm.com >
PR-URL: https://github.com/nodejs/node/pull/62627
Refs: https://github.com/nodejs/node/pull/62625
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2026-07-19 17:31:00 -05:00
René
fff4379cfc
meta: populate apt list for slim runner in update-openssl workflow
...
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk >
PR-URL: https://github.com/nodejs/node/pull/62628
Refs: https://github.com/actions/runner-images/issues/13426
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Richard Lau <richard.lau@ibm.com >
2026-07-19 17:31:00 -05:00
Filip Skokan
5ff8428f4b
test: allow skipping individual WPT subtests
...
Signed-off-by: Filip Skokan <panva.ip@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/62517
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2026-07-19 17:31:00 -05:00
Node.js GitHub Bot
5e40c7d24b
deps: update minimatch to 10.2.5
...
PR-URL: https://github.com/nodejs/node/pull/62594
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-19 17:31:00 -05:00
Node.js GitHub Bot
94e87e658d
deps: update googletest to d72f9c8aea6817cdf1ca0ac10887f328de7f3da2
...
PR-URL: https://github.com/nodejs/node/pull/62593
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-19 17:30:59 -05:00
Node.js GitHub Bot
b9945f6e7e
deps: update simdjson to 4.6.1
...
PR-URL: https://github.com/nodejs/node/pull/62592
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-19 17:30:59 -05:00
Joyee Cheung
33b0ba3155
test: use on-disk fixture for test-npm-install
...
Instead of writing the fixtures on the fly in the test,
put them in the fixtures directory that can be copied into
a temporary directory to reproduce in a debugger.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/62584
Refs: https://github.com/nodejs/node/pull/61898
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2026-07-19 17:30:59 -05:00
Rafael Gonzaga
29d5ad9172
doc: update bug bounty program
...
https://nodejs.org/en/blog/announcements/discontinuing-security-bug-bounties
PR-URL: https://github.com/nodejs/node/pull/62590
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day >
2026-07-19 17:30:59 -05:00
Santiago Gimeno
fb0e8e5c5d
deps: libuv: cherry-pick aabb7651de
...
Original commit message:
win: properly initialize OSVERSIONINFOW (#5107 )
Otherwise calling `RtlGetVersion()` might produce UB. Problem was
causing random crashes in the node.js test suite with stack traces
like this one:
```
node.exe!__report_gsfailure(unsigned __int64 stack_cookie) Line 220
at D:\a\_work\1\s\src\vctools\crt\vcstartup\src\gs\gs_report.c(220)
...
```
Fixes: https://github.com/libuv/libuv/issues/5106
Refs: https://github.com/libuv/libuv/commit/aabb7651de73ec2f1a74361ca3430eed1a62e402
PR-URL: https://github.com/nodejs/node/pull/62561
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2026-07-19 17:30:59 -05:00
Tom Pereira
ab9555eb4b
doc: document TransformStream transformer.cancel option
...
Add documentation for the `cancel` option of the `TransformStream`
transformer, which allows users to specify a callback that will be
called when the stream is canceled.
See: https://streams.spec.whatwg.org/#transformer-api
Fixes: https://github.com/nodejs/node/issues/62540
PR-URL: https://github.com/nodejs/node/pull/62566
Fixes: https://github.com/nodejs/node/issues/62540
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-19 17:30:59 -05:00
Robert Nagy
b27b85fb3d
http: cleanup pipeline queue
...
When a socket with pipelined requests is destroyed then some requests
will leak.
PR-URL: https://github.com/nodejs/node/pull/62534
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-19 17:30:58 -05:00
dependabot[bot]
7f78de5733
meta: bump step-security/harden-runner from 2.15.0 to 2.16.1
...
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner ) from 2.15.0 to 2.16.1.
- [Release notes](https://github.com/step-security/harden-runner/releases )
- [Commits](https://github.com/step-security/harden-runner/compare/a90bcbc6539c36a85cdfeb73f7e2f433735f215b...fe104658747b27e96e4f7e80cd0a94068e53901d )
---
updated-dependencies:
- dependency-name: step-security/harden-runner
dependency-version: 2.16.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
PR-URL: https://github.com/nodejs/node/pull/62550
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2026-07-19 17:30:58 -05:00
dependabot[bot]
d30f9f1902
meta: bump actions/setup-node from 6.2.0 to 6.3.0
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 6.2.0 to 6.3.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](https://github.com/actions/setup-node/compare/6044e13b5dc448c55e2357c09f80417699197238...53b83947a5a98c8d113130e565377fae1a50d02f )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-version: 6.3.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
PR-URL: https://github.com/nodejs/node/pull/62548
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-19 17:30:58 -05:00
dependabot[bot]
a309795dba
meta: bump github/codeql-action from 4.32.4 to 4.35.1
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.32.4 to 4.35.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/codeql-action/compare/89a39a4e59826350b863aa6b6252a07ad50cf83e...c10b8064de6f491fea524254123dbe5e09572f13 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.35.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
PR-URL: https://github.com/nodejs/node/pull/62547
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2026-07-19 17:30:58 -05:00
dependabot[bot]
19a1e7b386
meta: bump codecov/codecov-action from 5.5.2 to 6.0.0
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 5.5.2 to 6.0.0.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/codecov/codecov-action/compare/671740ac38dd9b0130fbe1cec585b89eea48d3de...57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 )
---
updated-dependencies:
- dependency-name: codecov/codecov-action
dependency-version: 6.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
PR-URL: https://github.com/nodejs/node/pull/62545
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2026-07-19 17:30:58 -05:00
dependabot[bot]
885f22fd73
meta: bump actions/cache from 5.0.3 to 5.0.4
...
Bumps [actions/cache](https://github.com/actions/cache ) from 5.0.3 to 5.0.4.
- [Release notes](https://github.com/actions/cache/releases )
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md )
- [Commits](https://github.com/actions/cache/compare/cdf6c1fa76f9f475f3d7449005a359c84ca0f306...668228422ae6a00e4ad889ee87cd7109ec5666a7 )
---
updated-dependencies:
- dependency-name: actions/cache
dependency-version: 5.0.4
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
PR-URL: https://github.com/nodejs/node/pull/62543
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-19 17:30:57 -05:00
James M Snell
9cc46a1e7d
meta: require DCO signoff in commit message guidelines
...
Apply suggestion from @jasnell
PR-URL: https://github.com/nodejs/node/pull/62510
Refs: https://github.com/nodejs/core-validate-commit/pull/141
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Ruy Adorno <ruy@vlt.sh >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2026-07-19 17:30:57 -05:00
Stefan Stojanovic
0a704f160e
module,win: fix long subpath import
...
Fixes: https://github.com/nodejs/node/issues/62043
PR-URL: https://github.com/nodejs/node/pull/62101
Fixes: https://github.com/nodejs/node/issues/62043
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
2026-07-19 17:30:57 -05:00
Antoine du Hamel
483220ec0d
tools: allow triagers to queue a PR for CI until it's reviewed
...
PR-URL: https://github.com/nodejs/node/pull/62524
Fixes: https://github.com/nodejs/node/issues/62496
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2026-07-19 17:30:57 -05:00
Antoine du Hamel
9016178031
tools: do not run commit-lint on release proposals
...
PR-URL: https://github.com/nodejs/node/pull/62523
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2026-07-19 17:30:57 -05:00
Joyee Cheung
5e84a2f470
meta: expand memory leak DoS criteria to all DoS
...
We have dedicated requirements about memory leaks when triaging
DoS. These applies in generall to all types of DoS, and many recent
reports about DoS attack vectors fail to meet them, resulting in
a lot of extra back-and-forth in triaging. Clarify in the threat
model by expanding these requirements to all DoS.
Drive-by: clarify criteria of documented JavaScript behavior is
that they are included in ECMA262. Also use "Node.js application
developer" instead of "user" the refer to the party being
vulnerable to avoid confusion.
PR-URL: https://github.com/nodejs/node/pull/62505
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2026-07-19 17:30:57 -05:00
Node.js GitHub Bot
f0982fccd5
deps: update icu to 78.3
...
PR-URL: https://github.com/nodejs/node/pull/62324
Reviewed-By: Richard Lau <richard.lau@ibm.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-19 17:30:56 -05:00
Node.js GitHub Bot
7fc381f834
deps: update libuv to 1.52.1
...
PR-URL: https://github.com/nodejs/node/pull/61829
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2026-07-19 17:30:56 -05:00
Jurj Andrei George
9b1900617c
sqlite: enable Percentile extension
...
PR-URL: https://github.com/nodejs/node/pull/61295
Refs: https://github.com/nodejs/node/issues/60618
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2026-07-19 17:30:56 -05:00
Gürgün Dayıoğlu
df6e226943
process: optimize asyncHandledRejections by using FixedQueue
...
PR-URL: https://github.com/nodejs/node/pull/60854
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
2026-07-19 17:30:56 -05:00
Kit Dallege
fb078ad8c1
doc: remove spawn with shell example from bat/cmd section
...
Remove the suggestion to use child_process.spawn() with the shell
option set for running .bat and .cmd files on Windows. Passing
arguments through spawn with shell: true is deprecated (DEP0190)
due to shell injection risks. Keep the exec() and direct cmd.exe
spawn alternatives.
Fixes: https://github.com/nodejs/node/issues/58735
PR-URL: https://github.com/nodejs/node/pull/62243
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com >
2026-07-19 17:30:56 -05:00
Gürgün Dayıoğlu
5dca770350
events: avoid cloning listeners array on every emit
...
PR-URL: https://github.com/nodejs/node/pull/62261
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2026-07-19 17:30:55 -05:00
Anna Henningsen
7ea1b92256
src: convert context_frame field in AsyncWrap to internal field
...
Using an internal field instead of a `v8::Global<>` removes
an unnecessary memory leak footgun.
This includes a test that demonstrates the issue, albeit
using internal APIs.
It's worth noting that if this PR is not accepted, we'd still
be missing memory tracking for the `context_frame_` field,
and we'd need to add it through our memory tracking API.
PR-URL: https://github.com/nodejs/node/pull/62103
Backport-PR-URL: https://github.com/nodejs/node/pull/62357
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2026-07-19 17:30:55 -05:00
Anna Henningsen
fbfbc83809
src: make AsyncWrap subclass internal field counts explicit
...
This helps ensure that we already set the correct number of
internal fields when creating objects, even if the number of
internal fields of e.g. AsyncWrap changes over time.
PR-URL: https://github.com/nodejs/node/pull/62103
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2026-07-19 17:30:55 -05:00
Dmytro Semchuk
9e6dfe6435
doc: fix typo in --disable-wasm-trap-handler description
...
PR-URL: https://github.com/nodejs/node/pull/61820
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-19 17:30:55 -05:00
Nikita Skovoroda
f5e11a2d5f
test: fix test-buffer-zero-fill-cli to be effective
...
PR-URL: https://github.com/nodejs/node/pull/60623
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2026-07-19 17:30:55 -05:00
Antoine du Hamel
6eeefbd3bf
doc: clarify that features cannot be both experimental and deprecated
...
PR-URL: https://github.com/nodejs/node/pull/62456
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2026-07-19 17:30:55 -05:00
Antoine du Hamel
6018b37d7f
tools: adopt the --check-for-duplicates NCU flag
...
PR-URL: https://github.com/nodejs/node/pull/62478
Refs: https://github.com/nodejs/node-core-utils/pull/1035
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
2026-07-19 17:30:54 -05:00
Antoine du Hamel
3e8ad4c05f
build: support empty libname flags in configure.py
...
PR-URL: https://github.com/nodejs/node/pull/62477
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: James M Snell <jasnell@gmail.com >
2026-07-19 17:30:54 -05:00