BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-14 10:26:26 -04:00
Code Issues Packages Projects Releases Wiki Activity
35,007 Commits 236 Branches 964 Tags
7ad052d2bd2b3f38f75103815d37df2a028902f6
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Rich Trott bad6526a00 build: fix make invocation in tools.yml 
Be in the correct directory for `make lint-md-rollup`.

PR-URL: https://github.com/nodejs/node/pull/40890
Refs: https://github.com/nodejs/node/runs/4270533399?check_suite_focus=true
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-11-22 05:01:56 +00:00
Rich Trott 129c12e252 tools: add find-inactive-tsc 
Automate the implementation of rules in the TSC Charter around automatic
removal of members who do not participate in TSC votes and attend fewer
than 25% of the meetings in a 3-month period.

PR-URL: https://github.com/nodejs/node/pull/40884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-11-21 15:10:04 +00:00
Rich Trott 3c86674e9e doc: improve README.md lede section 
Use clear and concise language.

PR-URL: https://github.com/nodejs/node/pull/40837
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
 2021-11-19 13:45:39 +00:00
Rich Trott e0233fc7dc build: fix tools.yml errors 
PR-URL: https://github.com/nodejs/node/pull/40870
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-11-19 09:18:06 +00:00
Rich Trott f85b6b512b meta: edit GOVERNANCE.md for minor updates 
PR-URL: https://github.com/nodejs/node/pull/40798
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-11-14 22:30:49 -08:00
Rich Trott fc4a792728 test: fix flaky test-policy-integrity 
Split the test into seven tests so that it doesn't time out.

Fixes: https://github.com/nodejs/node/issues/40694
Fixes: https://github.com/nodejs/node/issues/38088

PR-URL: https://github.com/nodejs/node/pull/40763
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
 2021-11-10 13:33:08 -08:00
Rich Trott 9ef0ae21fc tools: update babel-eslint-parser to 7.16.0 
PR-URL: https://github.com/nodejs/node/pull/40720
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-11-08 13:16:24 -08:00
Rich Trott 492d767b6d test: add semicolons for linter update 
Add missing semicolons that will be flagged when we update
@babel/eslint-parser to 7.16.0.

PR-URL: https://github.com/nodejs/node/pull/40720
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-11-08 13:16:21 -08:00
Rich Trott 04451d869c tools: improve update scripts 
The --production flag has no effect in this situation. Remove it.

Add --ignore-scripts as a precaution.

PR-URL: https://github.com/nodejs/node/pull/40644
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-11-08 11:47:53 -08:00
Rich Trott e8d16eee26 build: add GitHub Action to update tools modules 
Update ESLint, Babel, remark, and so on. Run once a week.

PR-URL: https://github.com/nodejs/node/pull/40644
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-11-08 11:47:51 -08:00
Rich Trott d4aca08999 doc: fix lint re-enabling comment in README.md 
If there is not a blank line before it, the comment does not re-enable
the rule.

PR-URL: https://github.com/nodejs/node/pull/40647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-11-01 19:04:38 -07:00
Rich Trott 8e9549181a tools: notify user if format-md needs to be run 
This will help enforce formatting of markdown files.

PR-URL: https://github.com/nodejs/node/pull/40647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-11-01 19:04:36 -07:00
Rich Trott 75d5d72f48 doc: format v8.md in preparation for stricter linting 
PR-URL: https://github.com/nodejs/node/pull/40647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-11-01 19:04:34 -07:00
Rich Trott f867b61597 test,doc: correct documentation for runBenchmark() 
The function only takes two arguments.

PR-URL: https://github.com/nodejs/node/pull/40683
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-11-01 15:54:31 -07:00
Rich Trott b2aff85485 test: mark test-policy-integrity flaky on Windows 
Ref: https://github.com/nodejs/node/issues/40694

PR-URL: https://github.com/nodejs/node/pull/40684
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
 2021-11-01 09:28:42 -07:00
Rich Trott 2883992a06 test,tools: increase pummel/benchmark test timeout from 4x to 6x 
The win10-COMPILED_BY-vs2019 hosts in CI are very slow and timing out on
certain tests in pummel and (previously) benchmark. Increase timeout
from 4x to 6x.

PR-URL: https://github.com/nodejs/node/pull/40684
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
 2021-11-01 09:28:37 -07:00
Rich Trott cbcf86f23d test,tools: increase timeout for benchmark tests 
test-benchmark-buffer is consistently timing out on a single Windows
host in CI. Rather than try to figure out if we need to scale the
timeout up for a certain memory limit or chip speed or something else,
let's increase the timeout for benchmark tests in general.

PR-URL: https://github.com/nodejs/node/pull/40684
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
 2021-11-01 09:28:35 -07:00
Rich Trott 86099a375a tools: avoid unnecessary escaping in markdown formatter 
Update mdast-util-to-markdown to 1.2.4 which reduces unnecessary
escaping of `_` and some other characters. Re-run markdown formatter.

PR-URL: https://github.com/nodejs/node/pull/40645
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-10-31 09:36:05 -07:00
Rich Trott 571e0b1b3f doc: final round of markdown format changes 
Once the README and find-inactive-collaborators.mjs changes land here,
we can introduce markdown formatting as a step in the toolchain
somewhere.

Before this lands, https://github.com/nodejs/node-core-utils/pull/578
will need to land and be included in a node-core-utils release.

PR-URL: https://github.com/nodejs/node/pull/40645
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-10-31 09:36:02 -07:00
Rich Trott 1a6d92728f tools,meta: remove exclusions from AUTHORS 
The update-authors tool omits Chromium team members. This was a decision
made years ago. The idea was that these folks contributed to V8 not to
Node.js, as they typically ended up in our code-base via cherry-picked
commits from V8.
Ref: https://github.com/nodejs/node/pull/232#discussion-diff-22412788

Now that there are over 3000 contributors identified in AUTHORS, some of
whom are bots that we run, I think it's time to undo this exception. If
we used someone else's code in a cherry-pick, congratulations to them,
they're authors. In particular, this will fix the omission of Yang
Guo who contributed extensively to Node.js outside of V8 contributions.

PR-URL: https://github.com/nodejs/node/pull/40648
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-10-31 15:23:21 +00:00
Rich Trott babd73ce25 meta: consolidate AUTHORS entries for brettkiefer 
PR-URL: https://github.com/nodejs/node/pull/40599
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2021-10-30 00:19:38 +00:00
Rich Trott 1306d5ca28 meta: consolidate AUTHORS entries for alexzherdev 
PR-URL: https://github.com/nodejs/node/pull/40620
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-10-28 14:28:44 +00:00
Rich Trott 3a74481225 meta: consolidate AUTHORS entries for Azard 
PR-URL: https://github.com/nodejs/node/pull/40619
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-10-28 14:28:35 +00:00
Rich Trott 9c405f2591 doc: simplify CHANGELOG.md 
Remove unnecessary `<sup>` usage and lint-disabling comment.

PR-URL: https://github.com/nodejs/node/pull/40475
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2021-10-26 23:35:51 +00:00
Rich Trott d4842e64bb tools: fix formatting of warning message in update-authors.js 
The email already has `<` and `>` surrounding it so adding it results in
a misformatted message.

PR-URL: https://github.com/nodejs/node/pull/40600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-26 10:07:14 +00:00
Rich Trott a2d65c0351 meta: consolidate AUTHORS entries for clakech 
PR-URL: https://github.com/nodejs/node/pull/40589
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
 2021-10-25 18:20:21 +00:00
Rich Trott 070b54a4ac policy: fix message for invalid manifest specifier 
Add test for invalid manifest specifier and fix the error message
which is missing a space ("singletrailing" instead of
"single trailing").

PR-URL: https://github.com/nodejs/node/pull/40574
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
 2021-10-24 22:41:28 -07:00
Rich Trott 8eebc33c02 build: skip long-running Actions for README-only modifications 
If the only file modified is README.md do not run test-linux or
build-windows tasks. This will help streamline onboarding sessions but
may help some other cases too.

PR-URL: https://github.com/nodejs/node/pull/40571
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-10-24 19:01:18 +00:00
Rich Trott 566365dd9d doc: update onboarding task 
Make starting Jenkins CI optional.

PR-URL: https://github.com/nodejs/node/pull/40570
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-10-24 19:01:07 +00:00
Rich Trott ce0e21e50a meta: consolidate AUTHORS entries for darai0512 
PR-URL: https://github.com/nodejs/node/pull/40569
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-10-24 19:00:56 +00:00
Rich Trott 31d7d6c994 doc: simplify ccache instructions 
`ccache` has reasonable defaults for `max_size` and `cache_dir` so
remove instructions to set those things explicitly.

Change fenced code from `console` to `bash` for easier copy/paste.

PR-URL: https://github.com/nodejs/node/pull/40550
Fixes: https://github.com/nodejs/node/issues/40542
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-24 06:59:22 -07:00
Rich Trott edd716beb1 doc: fix macOS environment variables for ccache 
macOS requires `cc` and `c++` rather than `gcc` and `g++`.

Closes: https://github.com/nodejs/node/issues/40542

PR-URL: https://github.com/nodejs/node/pull/40550
Fixes: https://github.com/nodejs/node/issues/40542
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-24 06:59:20 -07:00
Rich Trott a749c1f20c doc: use GFM footnotes in webcrypto.md 
PR-URL: https://github.com/nodejs/node/pull/40477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-10-23 06:13:21 -07:00
Rich Trott 179248a7b9 tools: udpate doc tools to accommodate GFM footnotes 
PR-URL: https://github.com/nodejs/node/pull/40477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-10-23 06:13:18 -07:00
Rich Trott 5f0031e53f doc: run license-builder 
PR-URL: https://github.com/nodejs/node/pull/40540
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-10-23 06:21:36 +00:00
Rich Trott c946e3c875 tools: update license-builder.sh for OpenSSL 
PR-URL: https://github.com/nodejs/node/pull/40540
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-10-23 06:21:35 +00:00
Rich Trott 80e94dbb68 doc: use GFM footnotes in maintaining-V8.md (#40476) 
PR-URL: https://github.com/nodejs/node/pull/40476
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-22 21:23:17 -07:00
Rich Trott 3577f6dc48 doc: use GFM footnotes in BUILDING.md 
PR-URL: https://github.com/nodejs/node/pull/40474
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-22 20:19:54 -07:00
Rich Trott 3d3aa5d837 doc: fix entry for Slack channel in onboarding.md 
PR-URL: https://github.com/nodejs/node/pull/40563
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
 2021-10-22 11:06:31 -07:00
Rich Trott 36663c9e54 meta: consolidate AUTHORS entries for dfabulich 
PR-URL: https://github.com/nodejs/node/pull/40527
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-10-22 17:05:20 +00:00
Rich Trott 89c05770d5 doc: document considerations for inclusion in core 
Document the things that are considered when making the determination as
to whether something should or shouldn't be in core. This does not (yet,
at least) attempt to address *how* to include modules in core. (Should
it be in the Node.js code base or vendored in from a separate
repository?) It is limited to *whether* something should be in core or
not.

Closes: https://github.com/nodejs/TSC/issues/1041

PR-URL: https://github.com/nodejs/node/pull/40338
Fixes: https://github.com/nodejs/TSC/issues/1041
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-10-22 15:21:50 +00:00
Rich Trott 0d59d0d1c3 doc: update link in onboarding doc 
PR-URL: https://github.com/nodejs/node/pull/40539
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-21 22:09:50 -07:00
Rich Trott d0b58c0287 doc: format doc/api/*.md with markdown formatter 
PR-URL: https://github.com/nodejs/node/pull/40403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-10-20 11:59:11 +02:00
Rich Trott a7c17e08de test: adjust CLI flags test to ignore blank lines in doc 
PR-URL: https://github.com/nodejs/node/pull/40403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-10-20 11:59:05 +02:00
Rich Trott d274347e38 meta: add Richard Lau to TSC list in README.md 
Refs: https://github.com/nodejs/TSC/issues/1096

PR-URL: https://github.com/nodejs/node/pull/40523
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-19 21:53:49 +00:00
Rich Trott 53d91063db meta: consolidate AUTHORS entries for dguo 
PR-URL: https://github.com/nodejs/node/pull/40517
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-19 18:29:54 +00:00
Rich Trott 2bed0317fc meta: consolidate AUTHORS entries for cxreg 
PR-URL: https://github.com/nodejs/node/pull/40490
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-10-19 06:10:07 -07:00
Rich Trott cbc7b5d424 meta: consolidate AUTHORS entries for emanuelbuholzer 
PR-URL: https://github.com/nodejs/node/pull/40469
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-10-17 13:44:13 +00:00
Rich Trott 7624917069 tools: update tools/lint-md dependencies to support GFM footnotes 
PR-URL: https://github.com/nodejs/node/pull/40445
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-16 02:44:51 +00:00
Rich Trott 881174e016 meta: consolidate AUTHORS entries for ebickle 
PR-URL: https://github.com/nodejs/node/pull/40447
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-15 13:17:22 +00:00
Rich Trott 95cf944736 meta: consolidate AUTHORS entries for evantorrie 
Add a .mailmap entry for evantorrie to consolidate their two AUTHORS
entries into one.

PR-URL: https://github.com/nodejs/node/pull/40430
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2021-10-13 18:25:09 +00:00
Rich Trott 350a95b89f tools: update lint-md dependencies 
Update lint-md dependencies and re-create lint-md.mjs.

PR-URL: https://github.com/nodejs/node/pull/40404
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-10-13 13:28:55 +00:00
Rich Trott c350c217f4 meta: consolidate AUTHORS entries for gabrielschulhof 
PR-URL: https://github.com/nodejs/node/pull/40420
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-10-12 18:15:31 +00:00
Rich Trott a9411891cf meta: consolidate AUTHORS information for geirha 
Use a .mailmap entry to consolidate the two entries for gierha in
AUTHORS into a single entry.

PR-URL: https://github.com/nodejs/node/pull/40406
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-10-12 04:56:59 +00:00
Rich Trott 73c3885e10 build: remove duplicate check for authors.yml 
update-authors.js will print if there are duplicates in the new entries
so we can remove the (not working) duplication check in the authors.yml
file. It would still be nice to get the information about duplicates
into the body of the GitHub PR so no one has to manually check for
duplicates (by either examining the file or looking at the Actions
output), but that can be a future improvement.

PR-URL: https://github.com/nodejs/node/pull/40393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-10-12 01:48:33 +00:00
Rich Trott 012152d7d6 tools: udpate @babel/eslint-parser 
Remove unused plugins and update @babel/eslint-parser

PR-URL: https://github.com/nodejs/node/pull/40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-11 18:37:51 -07:00
Rich Trott 43c780e741 tools: remove @babel/plugin-syntax-import-assertions 
As of ESLint 8.0.0 at least, this plugin is unnecessary.

PR-URL: https://github.com/nodejs/node/pull/40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-11 18:37:45 -07:00
Rich Trott b39db95737 tools: remove @bable/plugin-syntax-class-properties 
ESLint 8.0.0 makes the plugin unnecessary.

PR-URL: https://github.com/nodejs/node/pull/40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-11 18:37:42 -07:00
Rich Trott a6fd39f44f tools: remove @babel/plugin-syntax-top-level-await 
ESLint 8.0.0 introduced support for top level await, so
@babel/plugin-syntax-top-level-await is no longer necessary.

PR-URL: https://github.com/nodejs/node/pull/40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-11 18:37:38 -07:00
Rich Trott 8ca76eba73 tools: update ESLint to 8.0.0 
PR-URL: https://github.com/nodejs/node/pull/40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-11 18:37:33 -07:00
Rich Trott dd8e219d71 tools: prepare ESLint rules for 8.0.0 requirements 
PR-URL: https://github.com/nodejs/node/pull/40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-11 18:37:28 -07:00
Rich Trott 0a1b399781 tools: fix ESLint update scripts 
Changes to the npm dependency in the core repo require changes to
update-eslint.sh and update-bable-eslint.sh.

PR-URL: https://github.com/nodejs/node/pull/40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-11 18:37:24 -07:00
Rich Trott 40db88b7b5 doc: format changelogs 
Use the format-md task to format changelogs.

PR-URL: https://github.com/nodejs/node/pull/40388
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-10-11 17:45:09 +00:00
Rich Trott 0cc37209fa meta: consolidate duplicate AUTHORS entries for hassaanp 
Create a .mailmap entry to consolidate the two AUTHORS entries for
hassaanp into a single entry.

PR-URL: https://github.com/nodejs/node/pull/40391
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-10-11 05:53:58 +00:00
Rich Trott a3c0713d9e meta: consolidate AUTHORS entry for thw0rted 
Use a .mailmap entry to consolidate the two entries for thw0rted in
AUTHORS into one entry.

PR-URL: https://github.com/nodejs/node/pull/40387
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-09 19:33:12 +00:00
Rich Trott eb65871ab4 doc: format doc/guides using format-md task 
PR-URL: https://github.com/nodejs/node/pull/40358
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-09 08:53:46 -07:00
Rich Trott 6a205d7a56 meta: use .mailmap to consolidate AUTHORS entries for ide 
James Ide has two AUTHORS entries. Use .mailmap to consolidate them into
a single entry.

PR-URL: https://github.com/nodejs/node/pull/40367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-10-09 08:08:14 -07:00
Rich Trott d6d6b050ff tools: warn about duplicates when generating AUTHORS file 
PR-URL: https://github.com/nodejs/node/pull/40304
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-10-09 08:05:11 -07:00
Rich Trott 09e8e14af5 meta: consolidate AUTHORS entries for jemjam 
PR-URL: https://github.com/nodejs/node/pull/40328
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-10-07 07:02:47 -07:00
Rich Trott 46e3163ad6 meta: update mailmap entry for othiym23 
PR-URL: https://github.com/nodejs/node/pull/40326
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-07 06:49:33 -07:00
Rich Trott 88e82b890b doc: format general markdown files 
Use `make format-md` to format general markdown files.

PR-URL: https://github.com/nodejs/node/pull/40322
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-06 21:20:55 -07:00
Rich Trott 20289e9464 meta: add mailmap entry for ratracegrad 
There are two AUTHORS entries for ratracegrad. Use a mailmap entry to
consolidate them into a single entry.

PR-URL: https://github.com/nodejs/node/pull/40291
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-10-05 06:22:10 +00:00
Rich Trott cbd61c944c doc: format markdown files in test directory 
Use `make format-md` to format markdown files in `test` directory.

PR-URL: https://github.com/nodejs/node/pull/40290
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-10-04 20:19:11 -07:00
Rich Trott 2a3a9b8b71 build: check for duplicates in new AUTHORS entries 
When the GitHub Action adds new entries to the AUTHORS file, have it
also flag new entries that might be duplicates.

PR-URL: https://github.com/nodejs/node/pull/40264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-10-03 20:44:01 +00:00
Rich Trott b5cfb264a1 meta: add .mailmap entry for Jimbly 
Consolidate two email addresses for Jimbly into one AUTHORS record using
.mailmap.

PR-URL: https://github.com/nodejs/node/pull/40267
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-10-03 01:49:04 +00:00
Rich Trott 8a58fcebf8 tools: update remark-preset-lint-node to 3.2.0 
PR-URL: https://github.com/nodejs/node/pull/40278
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-10-02 07:38:26 +00:00
Rich Trott afb4ad6135 meta: add .mailmap entry for daguej 
Consolidate duplicate AUTHORS entries with a .mailmap entry.

PR-URL: https://github.com/nodejs/node/pull/40223
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
 2021-09-30 14:11:41 +00:00
Rich Trott fbeeddd0aa meta: update gdams contact information 
Refs: https://github.com/nodejs/node/pull/37182

PR-URL: https://github.com/nodejs/node/pull/40233
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-09-27 22:42:59 +00:00
Rich Trott a2ed30b636 meta: add .mailmap entry for kunalspathak 
Use mailmap entry to consolidate duplicate entries in AUTHORS.

PR-URL: https://github.com/nodejs/node/pull/40202
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-09-26 06:56:40 +00:00
Rich Trott 85811d1ade tools: fix lint-md autolinking 
Update a transitive dependency in lint-md to fix an autolink bug in the
formatter that causes a lot of our files (particularly changelogs) to be
misformatted when run through the automatic formatter.

Refs: https://github.com/syntax-tree/mdast-util-gfm-autolink-literal/commit/7555d45f9ad4ecdd578ffedf3cbc4b01d3ae0135

PR-URL: https://github.com/nodejs/node/pull/40181
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
 2021-09-25 10:23:30 -07:00
Rich Trott 6077473111 tools: implement markdown formatting 
Markdown formatter is now available via `mark format-md` (or
`vcbuild format-md` on Windows).

PR-URL: https://github.com/nodejs/node/pull/40181
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
 2021-09-25 10:23:20 -07:00
Rich Trott 8d83c47029 tools: re-implement lint-md without unified-args 
`unified-args` ignores settings in the preset, expecting them to be in
remarkrc files or passed on the command line instead. Realizing that
we always send the same configuration options via the command-line
anyway, this removes `unified-args`. This means the preset settings are
now respected and it removes nearly 30000 lines of code in the resulting
rollup file.

I wasn't sure I was going to want to keep rollup so I started
re-implementing this without it, but ended up putting a minimal rollup
back as it still saves about 90000 lines of code vs. checking in
`node_modules`.

PR-URL: https://github.com/nodejs/node/pull/40180
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-25 03:51:52 +00:00
Rich Trott 8e84d566ea meta: add mailmap entry for ralphtheninja 
PR-URL: https://github.com/nodejs/node/pull/40153
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-09-23 20:27:17 -07:00
Rich Trott fd86dad5a0 meta: update mailmap for LakshmiSwethaG 
LakshmiSwethaG's name appears twice in AUTHORS. Use .mailmap to map the
various email addresses to a single one.

PR-URL: https://github.com/nodejs/node/pull/40172
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-09-23 14:09:43 +00:00
Rich Trott 18e527c32f build: add --no-user for pip commands in Makefile 
I ran into "Cannot combine --user and --target" in an environment and
adding --no-user seemed to fix it.

Refs: https://stackoverflow.com/a/67259534/436641

PR-URL: https://github.com/nodejs/node/pull/40169
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Christian Clauss <cclauss@me.com>
 2021-09-23 14:09:35 +00:00
Rich Trott 51d2623034 tools: update remark-preset-lint-node to 3.1.0 
Update remark-preset-lint-node from 3.0.1 to 3.1.0. This is a necessary
step before we can use the lint preset to format markdown files.

PR-URL: https://github.com/nodejs/node/pull/40166
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-09-22 22:28:46 +00:00
Rich Trott 24cc239cad tools: fix find-inactive-collaborators for recent README change 
I missed this change in 420cdc7cf9.

PR-URL: https://github.com/nodejs/node/pull/40163
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-09-22 21:24:28 +00:00
Rich Trott 0991dfcece doc: add blank line between comments 
Upcoming remark-based formatting/linting will add a blank line between
comments in markdown. This is in preparation for that change.

PR-URL: https://github.com/nodejs/node/pull/40160
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-09-21 18:40:04 -07:00
Rich Trott 5ca5499c87 doc: update markdown files in src for upcoming linting/formatting 
PR-URL: https://github.com/nodejs/node/pull/40159
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-09-21 17:04:06 -07:00
Rich Trott a6a5d4bda0 doc: update benchmarks README.md for upcoming linting/formatting 
PR-URL: https://github.com/nodejs/node/pull/40158
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-09-21 17:02:07 -07:00
Rich Trott f4a350da85 doc: prepare markdown file for upcoming formatting/linting 
PR-URL: https://github.com/nodejs/node/pull/40156
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-21 17:00:23 -07:00
Rich Trott 0c95dead55 doc: update tools .md files for upcoming lint/formatting 
Looks like only one .md file in `tools` needs to be changed.

PR-URL: https://github.com/nodejs/node/pull/40155
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-21 16:58:58 -07:00
Rich Trott 549f96889a doc: update markdown formatting for *.md files 
Fix formatting that will change when run through upcoming remark preset.

PR-URL: https://github.com/nodejs/node/pull/40154
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-09-21 15:37:19 +00:00
Rich Trott 420cdc7cf9 doc: prepare README.md for stricter linting 
PR-URL: https://github.com/nodejs/node/pull/40137
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-09-20 12:01:25 +00:00
Rich Trott b0d5eecdd9 tools,doc: fix misrendering of consecutive JS blocks 
Our markdown-to-html tool was assuming that any consecutive JS blocks
were ESM vs CJS alternatives, but that is not always the case, resulting
in both a confusing interface and invalid HTML.

PR-URL: https://github.com/nodejs/node/pull/40146
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-09-19 07:58:17 +00:00
Rich Trott 0bafe6dd21 doc: fix comma splice 
PR-URL: https://github.com/nodejs/node/pull/40133
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-09-19 07:23:47 +00:00
Rich Trott 088c01bfdf meta: update GeoffreyBooth email addresses in AUTHORS and .mailmap 
PR-URL: https://github.com/nodejs/node/pull/40132
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2021-09-19 06:57:11 +00:00
Rich Trott 6ef1d7c347 meta: add mailmap entry for LPardue 
PR-URL: https://github.com/nodejs/node/pull/40129
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-09-18 16:16:51 +02:00
Rich Trott 3decfa75d2 build: run modified internet tests on GitHub Actions 
If internet tests are modified in a pull request, run the internet tests
in GitHub Actions.

PR-URL: https://github.com/nodejs/node/pull/40100
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-09-16 22:42:53 +00:00
Rich Trott 0f1765e134 build: add .mailmap/AUTHORS to paths-ignore for test-macos 
PR-URL: https://github.com/nodejs/node/pull/40109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-16 16:40:50 +00:00