BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
39,546 Commits 266 Branches 972 Tags
7e7aad84df414f062adecaa330bb5255fcbb648b
Commit Graph
39546 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Node.js GitHub Bot 7e7aad84df tools: update lint-md-dependencies 
PR-URL: https://github.com/nodejs/node/pull/49342
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-08-29 00:33:27 +00:00
Rafael Gonzaga 9eb84febf0 doc: clarify policy expectations 
PR-URL: https://github.com/nodejs/node/pull/48947
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2023-08-28 21:41:57 +00:00
Cheng Zhao 0409cdd91c tools: remove v8_dump_build_config action 
The script has been removed in #44741.

PR-URL: https://github.com/nodejs/node/pull/49301
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-27 22:06:33 +00:00
Jungku Lee b9153af4cc doc: add print results for examples in StringDecoder 
PR-URL: https://github.com/nodejs/node/pull/49326
Refs: https://github.com/nodejs/node/pull/49143
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-27 15:32:47 +00:00
Tobias Nießen 5a0777776d crypto: do not overwrite _writableState.defaultEncoding 
This only affects the writable side of LazyTransform and should not
change the behavior of any LazyTransform streams (Cipher, Decipher,
Cipheriv, Decipheriv, Hash, Hmac).

If the user does not set defaultEncoding when creating a transform
stream, WritableState uses 'utf8' by default. Only LazyTransform
overwrites this with 'buffer' for strict backward compatibility. This
was necessary when crypto.DEFAULT_ENCODING still existed. Now that
DEFAULT_ENCODING has been removed, defaultEncoding is always 'buffer'.
The writable side of LazyTransform appears to treat 'utf8' and 'buffer'
in exactly the same way. Therefore, there seems to be no need to
overwrite _writableState.defaultEncoding at this point.

Nevertheless, because Node.js has failed to hide implementation details
such as _writableState from the ecosystem, we may want to consider this
a breaking change.

Refs: https://github.com/nodejs/node/pull/47182
Refs: https://github.com/nodejs/node/pull/8611
PR-URL: https://github.com/nodejs/node/pull/49140
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-08-27 14:12:29 +00:00
Tobias Nießen 56c3263049 doc: update outdated reference to NIST SP 800-131A 
NIST SP 800-131A Rev. 1 has been withdrawn. Replace the reference with a
link to NIST SP 800-131A Rev. 2.

PR-URL: https://github.com/nodejs/node/pull/49316
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2023-08-26 21:11:21 +00:00
Deokjin Kim fee0601674 doc: use cjs as block code's type in MockTimers 
Use `cjs` instead of `js` to show toggle button between
CJS and ESM because corresponding example using `mjs`
exists.

PR-URL: https://github.com/nodejs/node/pull/49309
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-26 14:57:18 +00:00
Yeseul Lee 76e659a103 fs: add the options param description in openAsBlob() 
PR-URL: https://github.com/nodejs/node/pull/49308
Refs: https://github.com/nodejs/node/blob/main/doc/api/fs.md#fsopenasblobpath-options
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-26 14:48:59 +00:00
Khafra 4ba7370650 stream: use Buffer.from when constructor is a Buffer 
When using BYOB streams, it's possible for the constructor in
readableByteStreamControllerConvertPullIntoDescriptor to be a node
Buffer. If it is, use `Buffer.from` over `new ctor`.

Fixes https://github.com/nodejs/node/issues/49245

PR-URL: https://github.com/nodejs/node/pull/49250
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-08-26 11:43:58 +00:00
Node.js GitHub Bot 1ca23adc35 tools: update lint-md-dependencies 
- @rollup/plugin-node-resolve@15.2.0
- unified@11.0.1
- vfile-reporter@8.1.0

PR-URL: https://github.com/nodejs/node/pull/49253
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2023-08-26 12:56:58 +02:00
Shubham Pandey 4178683a26 doc: update options.filter description for fs.cp 
PR-URL: https://github.com/nodejs/node/pull/49289
Fixes: https://github.com/nodejs/node/issues/49092
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2023-08-26 07:53:46 +02:00
Stewart X Addison 3d0a317763 doc: add riscv64 to list of architectures 
PR-URL: https://github.com/nodejs/node/pull/49284

Signed-off-by: Stewart X Addison <sxa@redhat.com>
Fixes: https://github.com/nodejs/node/issues/49278
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-26 07:48:16 +02:00
Antoine du Hamel 69f7583ee5 policy: fix path to URL conversion 
PR-URL: https://github.com/nodejs/node/pull/49133
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-08-26 05:45:13 +00:00
Tobias Nießen 460c19f226 doc: avoid "not currently recommended" 
Compromised algorithms will never again be recommended, so remove the
qualifier "currently".

PR-URL: https://github.com/nodejs/node/pull/49300
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2023-08-25 20:08:17 +00:00
Deokjin Kim c5cad08476 fs: remove redundant code in readableWebStream() 
Remove redundant code by moving it to outside of `if/else`. Plus,
make `options` optional in doc.

PR-URL: https://github.com/nodejs/node/pull/49298
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-25 15:23:15 +00:00
Geoffrey Booth 33710e7e7d doc: update module hooks docs 
PR-URL: https://github.com/nodejs/node/pull/49265
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-08-24 19:27:23 +00:00
Tobias Nießen 6117cc3bd1 test: fix compiler warning in NodeCryptoEnv 
This fixes a warning in line 26: "warning: value computed is not used"
when calling BIO_seek().

Refs: https://github.com/nodejs/node/pull/47160
PR-URL: https://github.com/nodejs/node/pull/49206
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-08-24 16:25:09 +00:00
Jungku Lee a494ef68f3 doc: modify param description for end(),write() in StringDecoder 
PR-URL: https://github.com/nodejs/node/pull/49285
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
 2023-08-24 16:00:28 +00:00
Juan José 5ff1ead6b2 build: add symlink to compile_commands.json file if needed 
Usually lsp servers needs the `compile_commands.json` file in the root
directory.

Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/49260
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-08-24 14:02:04 +00:00
Raz LuvatonandRobert Nagy b0f423390f stream: add highWaterMark for the map operator 
this is done so we don't wait for the first items to
finish before starting new ones

Fixes: https://github.com/nodejs/node/issues/46132

Co-authored-by: Robert Nagy <ronagy@icloud.com>
PR-URL: https://github.com/nodejs/node/pull/49249
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2023-08-24 12:11:21 +00:00
Node.js GitHub Bot da197d1890 deps: update zlib to 1.2.13.1-motley-f5fd0ad 
PR-URL: https://github.com/nodejs/node/pull/49252
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-08-24 11:17:43 +00:00
Robert NagyandChemi Atlow feb5b0fef8 fs: make sure to write entire buffer 
fs.write(v) is not guaranteed to write everything in a single
call. Make sure we don't assume so.

PR-URL: https://github.com/nodejs/node/pull/49211
Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2023-08-24 08:15:08 +03:00
Cheng Zhao 996f3904bc doc: use NODE_API_SUPPORTED_VERSION_MAX in release doc 
The code was changed in #48501 but the doc was missed.

PR-URL: https://github.com/nodejs/node/pull/49268
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-08-23 14:11:54 -04:00
Abdirahim Musse ee1f609a9e test: handle EUNATCH 
When IPv6 is disabled IBM i returns EUNATCH (errno 42)
instead of EADDRNOTAVAIL.

libuv 1.46.0 adds EUNATCH errno

We can now use error.code to refer to EUNATCH
in node versions that use libuv 1.46.0.

PR-URL: https://github.com/nodejs/node/pull/48050
Refs: https://github.com/nodejs/node/issues/48049
Refs: https://github.com/nodejs/node/pull/46546
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-08-23 14:00:25 -04:00
Antoine du Hamel e74d1b8db9 doc: fix typo in stream.finished documentation 
PR-URL: https://github.com/nodejs/node/pull/49271
Refs: https://nodejs.org/api/stream.html#streamfinishedstream-options
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
 2023-08-23 09:17:31 +00:00
Antoine du Hamel bca14f8518 worker: protect against user mutating well-known prototypes 
PR-URL: https://github.com/nodejs/node/pull/49270
Fixes: https://github.com/nodejs/node/issues/49259
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-08-23 09:06:51 +00:00
Node.js GitHub Bot 0d080a269e meta: move one or more collaborators to emeritus 
PR-URL: https://github.com/nodejs/node/pull/49264
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-23 04:21:02 +00:00
Jungku Lee 56a2a2e399 doc: update description for percent_encode sets in WHATWG API 
PR-URL: https://github.com/nodejs/node/pull/49258
Refs: https://url.spec.whatwg.org/#percent-encoded-bytes
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-23 01:13:46 +00:00
Geoffrey Booth 164c57d4c5 doc: move and rename loaders section 
PR-URL: https://github.com/nodejs/node/pull/49261
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-08-22 21:53:40 +00:00
Joyee Cheung 5c9daf4583 sea: generate code cache with deserialized isolate 
V8 now requires code cache to be compiled from an isolate with the
same RO space layout as the one that's going to deserialize the
cache, so for a binary built with snapshot, we need to compile
the code cache using a deserialized isolate.

Drive-by: ignore "useCodeCache" when "useSnapshot" is true because
the compilation would've been done during build time anyway in
that case, and print a warning for it.

PR-URL: https://github.com/nodejs/node/pull/49226
Refs: https://github.com/nodejs/node-v8/issues/252
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-08-22 16:56:04 +00:00
Joyee Cheung f6f1131096 src: support snapshot deserialization in RAIIIsolate 
PR-URL: https://github.com/nodejs/node/pull/49226
Refs: https://github.com/nodejs/node-v8/issues/252
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-08-22 16:56:03 +00:00
Fedor Indutny 62b2cf30f2 doc: clarify use of Uint8Array for n-api 
`napi_get_buffer_info` always supported receiving `Uint8Array` as a
`value` argument because `node::Buffer` is a subclass of `Uint8Array`
and the underlying V8 APIs don't distinguish between two. With this
change we mark both types as supported by the API so that the user code
doesn't have to unknowingly use oficially unsupported type of the
`value` argument.

PR-URL: https://github.com/nodejs/node/pull/48742
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-08-21 18:12:09 +00:00
Jungku Lee a16b610e86 src: remove unused function GetName() in node_perf 
PR-URL: https://github.com/nodejs/node/pull/49244
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
 2023-08-21 16:42:12 +00:00
Livia Medeiros eeddbfae6c test,benchmark: use tmpdir.fileURL() 
PR-URL: https://github.com/nodejs/node/pull/49138
Refs: https://github.com/nodejs/node/pull/49040
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-21 16:42:03 +00:00
Livia Medeiros 052434a0c1 test: use tmpdir.resolve() 
PR-URL: https://github.com/nodejs/node/pull/49136
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-21 16:41:53 +00:00
Geoffrey Booth 484ad83358 doc: add signature for module.register 
PR-URL: https://github.com/nodejs/node/pull/49251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-08-20 20:52:41 +00:00
Jungku Lee 982e7a65cc src: use ARES_SUCCESS instead of 0 
PR-URL: https://github.com/nodejs/node/pull/49048
Refs: https://github.com/nodejs/node/pull/48834
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
 2023-08-20 10:04:34 +00:00
Jungku Lee 45e5ec89a6 src: add a condition if the argument of DomainToUnicode is empty 
PR-URL: https://github.com/nodejs/node/pull/49097
Refs: https://github.com/nodejs/node/pull/46410
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
 2023-08-20 09:55:44 +00:00
Antoine du Hamel 2557932db2 esm: align sync and async load implementations 
Refs: https://github.com/nodejs/node/pull/48272
PR-URL: https://github.com/nodejs/node/pull/49152
Refs: https://github.com/nodejs/node/pull/47999
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-08-20 05:08:22 +00:00
Antoine du Hamel 0daea967ea test: reduce flakiness of test-esm-loader-hooks 
PR-URL: https://github.com/nodejs/node/pull/49248
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-08-20 04:50:06 +00:00
Michael Dawson 502629376c build: expand when we run internet tests 
Refs: https://github.com/nodejs/node/issues/49203

Changes slipped into v18.x regressed
test/internet/test-dns-ipv6 as I assume the action did
not run because no test under test/internet was changed.
Add some of the common paths that include code that might
introduce failures in the internet tests.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: https://github.com/nodejs/node/pull/49218
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-19 21:44:21 +00:00
Jacob Smith 41a3a1daa2 doc: caveat unavailability of import.meta.resolve in custom loaders 
PR-URL: https://github.com/nodejs/node/pull/49242
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2023-08-19 16:45:02 +00:00
Hyunjin Kim cb4a6fafe6 doc: use same name in the doc as in the code 
Refs: https://streams.spec.whatwg.org/#bytelengthqueuingstrategy
PR-URL: https://github.com/nodejs/node/pull/49216
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-19 16:15:22 +00:00
Tobias Nießen 78842cf213 crypto: remove getDefaultEncoding() 
Refs: https://github.com/nodejs/node/pull/47182
Refs: https://github.com/nodejs/node/pull/47869
Refs: https://github.com/nodejs/node/pull/47943
Refs: https://github.com/nodejs/node/pull/47998
Refs: https://github.com/nodejs/node/pull/49140
Refs: https://github.com/nodejs/node/pull/49145
Refs: https://github.com/nodejs/node/pull/49167
Refs: https://github.com/nodejs/node/pull/49169
PR-URL: https://github.com/nodejs/node/pull/49170
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-19 12:55:30 +05:30
Joyee Cheung 64a5c01b99 test: add spawnSyncAndExit() and spawnSyncAndExitWithoutError() 
Replaces expectSyncExit() and expectSyncExitWithoutError(). Since
we usually just check the child process right after its spawned,
these shorthands also takes care of the spawning. This makes the
tests more concise.

PR-URL: https://github.com/nodejs/node/pull/49200
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-08-18 16:54:19 +00:00
Joyee Cheung ecde9d9640 test: make test-perf-hooks more robust and work with workers 
Previously the test makes several assumptions about the absolute
values of the nodeTiming fields, which can make the test flaky
on slow machines. This patch rewrites the test to check the
relative values instead. It also updates the test to make it
work with workers instead of directly skipping in workers.

PR-URL: https://github.com/nodejs/node/pull/49197
Refs: https://github.com/nodejs/reliability/issues/638
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-08-18 11:49:56 +00:00
Joyee Cheung 1f2ad05600 test: use gcUntil() in test-v8-serialize-leak 
Previously this can be flaky because the there could be a delay
of the deallocation after gc() is invoked. Use gcUntil() to run
the GC multiple times to make the test more robust.

PR-URL: https://github.com/nodejs/node/pull/49168
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-18 11:17:24 +00:00
Joyee Cheung 7b7a68b1fe bootstrap: build code cache from deserialized isolate 
V8 now requires the code cache to be compiled with a finalized
read-only space, so we need to serialize the snapshot to get
a finalized read-only space first, then deserialize it to compile
the code cache.

PR-URL: https://github.com/nodejs/node/pull/49099
Refs: https://github.com/nodejs/node/issues/47636
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13789
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-08-18 11:17:13 +00:00
Rafael Gonzaga c021b27221 meta: mention nodejs/tsc when changing GH templates 
PR-URL: https://github.com/nodejs/node/pull/49189
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-08-17 21:19:23 +00:00
Rafael Gonzaga 7d5d640396 doc: add notable-change label mention to PR template 
PR-URL: https://github.com/nodejs/node/pull/49188
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-08-17 21:09:36 +00:00