cjihrig
8e76397fab
fs: validate encoding to binding.writeString()
...
The binding layer performs some validation of the encoding and
data passed to WriteString(). This commit adds similar validation
to the JS layer for better error handling.
PR-URL: https://github.com/nodejs/node/pull/38183
Fixes: https://github.com/nodejs/node/issues/38168
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
2021-04-11 23:57:29 -04:00
cjihrig
28bca33f28
tools: update ESLint to 7.24.0
...
Update ESLint to 7.24.0
PR-URL: https://github.com/nodejs/node/pull/38179
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-11 23:55:09 -04:00
Xu Meng
db9cf52dcf
test: check the different error code on IBM i
...
Fixes: https://github.com/nodejs/node/issues/36925
PR-URL: https://github.com/nodejs/node/pull/38159
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2021-04-11 21:28:22 -05:00
Antoine du Hamel
548cbf0625
perf_hooks: fix loop delay resolution validation
...
Fixes: https://github.com/nodejs/node/issues/38160
PR-URL: https://github.com/nodejs/node/pull/38166
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-04-11 23:15:47 +02:00
Serkan Özel
993a1da47c
doc: mention cryptographic prng in description of randomUUID
...
PR-URL: https://github.com/nodejs/node/pull/38074
Refs: https://github.com/nodejs/node/pull/36729
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-11 13:39:56 -07:00
Rich Trott
95ca351fd8
test: skip fs.watch() test on IBMi
...
We've added pummel tests to CI, so we need to add a skip for IBMi for
the fs.watch() test there as we have for all the fs.watch() tests
elsewhere.
PR-URL: https://github.com/nodejs/node/pull/38192
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-04-11 06:42:38 -07:00
ycjcl868
f5eea1744d
build: don't run test workflow on doc dir on macOS
...
Leaving it in the Linux workflow because addons tests are affected by
changes to addons.md example code. So we need to keep that running
somewhere for docs changes, but one platform seems sufficient.
PR-URL: https://github.com/nodejs/node/pull/37999
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-10 16:51:10 -07:00
Rich Trott
2853b76e20
build: add pummel tests to ci runs
...
PR-URL: https://github.com/nodejs/node/pull/34289
Reviewed-By: Richard Lau <rlau@redhat.com >
2021-04-10 15:18:10 -07:00
Rich Trott
24426cd8c4
build: prepare Windows coverage GitHub Action for pummel tests
...
The pummel tests result in the Windows coverage runs in CI to exhaust
memory, so we need to bump up the heap size.
PR-URL: https://github.com/nodejs/node/pull/34289
Reviewed-By: Richard Lau <rlau@redhat.com >
2021-04-10 15:18:04 -07:00
Rich Trott
8cee28465c
test: fix test-dh-regr for OpenSSL 3
...
PR-URL: https://github.com/nodejs/node/pull/34289
Reviewed-By: Richard Lau <rlau@redhat.com >
2021-04-10 15:17:56 -07:00
Rich Trott
213ae4f4c6
test: skip test-vm-memleak in ASAN
...
ASAN increases memory usage, which in turn messes up the memory leak
test. Skip the test on ASAN.
PR-URL: https://github.com/nodejs/node/pull/34289
Reviewed-By: Richard Lau <rlau@redhat.com >
2021-04-10 15:17:51 -07:00
Rich Trott
50208915a0
test: skip test-hash-seed on armv6 and armv7
...
The test is too slow to run on the Raspberry Pi bots. (It takes over 900
seconds to run on Pi 3 bots and even more than that on Pi 2 bots.) Skip
it on armv6 and armv7.
Refs: https://github.com/nodejs/node/pull/34289
PR-URL: https://github.com/nodejs/node/pull/34289
Reviewed-By: Richard Lau <rlau@redhat.com >
2021-04-10 15:17:43 -07:00
Fedor Indutny
6a1986d50a
deps: update llhttp to 5.1.0
...
PR-URL: https://github.com/nodejs/node/pull/38146
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com >
2021-04-10 14:31:34 -07:00
Arkerone
5ba5cc8619
doc: fix typos in doc/api/cli.md
...
PR-URL: https://github.com/nodejs/node/pull/38163
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-10 07:41:03 -07:00
Voltrex
6a2314acd7
doc: add link to V8
...
Added the link redirecting to the V8 engine github repository just like
libuv.
PR-URL: https://github.com/nodejs/node/pull/38144
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-04-10 19:22:20 +05:30
James M Snell
40ace47396
http: fixup perf regression
...
Only call into hrtime if there's an observer
Also, fix up some previously missed changes from the original refactor
Signed-off-by: James M Snell <jasnell@gmail.com >
Refs: https://github.com/nodejs/node/issues/37937
Refs: https://github.com/nodejs/node/pull/37136
PR-URL: https://github.com/nodejs/node/pull/38110
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2021-04-09 16:58:58 -07:00
James M Snell
d2f116c6bb
crypto: fixup randomFill size and offset handling
...
Signed-off-by: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/38138
Fixes: https://github.com/nodejs/node/issues/38137
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-04-09 15:35:39 -07:00
Daniel Bevenius
7216eb67df
test: update OpenSSL 3.x expected error message
...
This commit updates an expected error message which has changed in
OpenSSl 3.x. OpenSSL 3.0 is still under development but once there is a
relase we should not be seeing test failure like this.
PR-URL: https://github.com/nodejs/node/pull/38164
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-09 23:54:14 +02:00
Ruy Adorno
c748668704
deps: upgrade npm to 7.9.0
...
PR-URL: https://github.com/nodejs/node/pull/38156
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-09 07:09:06 -07:00
Rich Trott
7e516aaac0
test: remove unneeded m flag on regular expressions
...
The m flag has no effect on regular expressions that don't match the
start or the end of a line.
PR-URL: https://github.com/nodejs/node/pull/38124
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-04-09 06:35:51 -07:00
Daniel Bevenius
269f5132cc
test: skip different params test for OpenSSL 3.x
...
This skips the tests with different dh params as they are currently
failing after the latest updated to OpenSSL 3.0.0-alpha14.
I'll continue working and investigating the cause of this but it would
be nice to get this merged so it does not fail the CI build.
PR-URL: https://github.com/nodejs/node/pull/38165
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2021-04-09 15:24:56 +02:00
Ouyang Yadong
f96dffb7ae
test: fix flaky test-zlib-unused-weak.js
...
PR-URL: https://github.com/nodejs/node/pull/38149
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2021-04-09 19:54:59 +08:00
Ash Cripps
1d8c022544
build: update Makefile to support fat binary
...
build a binary that is both x86_64 and arm64 on macos
PR-URL: https://github.com/nodejs/node/pull/37861
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Rod Vagg <rod@vagg.org >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2021-04-09 12:13:47 +01:00
Daniel Bevenius
7df0fc5c5c
build: move OPENSSL_API_COMPAT to else clause
...
Currently there are a number of deprecation warnings generated when
linking with OpenSSL 3.0, for example:
In file included from ../src/crypto/crypto_scrypt.h:6,
from ../src/crypto/crypto_scrypt.cc:1:
../src/crypto/crypto_util.h:64:37: warning:
‘void RSA_free(RSA*)’ is deprecated: Since OpenSSL 3.0
[-Wdeprecated-declarations]
64 | using RSAPointer = DeleteFnPtr<RSA, RSA_free>;
The reason for this is that I had placed the macro OPENSSL_API_COMPAT
inside of the node_shared_openssl="false" clause, but that was a
mistake and this macro should have gone into the else clause instead.
PR-URL: https://github.com/nodejs/node/pull/38126
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-09 05:42:27 +02:00
cjihrig
e96773b94b
test: add regression test for serdes readDouble()
...
Refs: https://github.com/nodejs/node/issues/37978
PR-URL: https://github.com/nodejs/node/pull/38121
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-04-08 22:27:04 -04:00
cjihrig
ca13f7aaf3
deps: V8: cherry-pick 501482cbc704
...
Original commit message:
Fix ValueDeserializer::ReadDouble() bounds check
If end_ is smaller than sizeof(double), the result would wrap
around, and lead to an invalid memory access.
Refs: https://github.com/nodejs/node/issues/37978
Change-Id: Ibc8ddcb0c090358789a6a02f550538f91d431c1d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2801353
Reviewed-by: Marja Hölttä <marja@chromium.org >
Commit-Queue: Marja Hölttä <marja@chromium.org >
Cr-Commit-Position: refs/heads/master@{#73800}
PR-URL: https://github.com/nodejs/node/pull/38121
Fixes: https://github.com/nodejs/node/issues/37978
Refs: https://github.com/v8/v8/commit/501482cbc704
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-04-08 22:27:03 -04:00
Tobias Nießen
dfe3f952a3
crypto: fix crash in CCM mode without data
...
Fixes: https://github.com/nodejs/node/issues/38035
PR-URL: https://github.com/nodejs/node/pull/38102
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-08 22:18:52 +02:00
James M Snell
8930eba199
assert: change status of legacy asserts
...
Previously marked deprecated, but these are unlikely to ever see
breaking changes or complete removal. Mark as legacy instead.
Signed-off-by: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/38113
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2021-04-08 11:25:02 -07:00
James M Snell
15b8e6b1c4
timers: graduate awaitable timers and improve docs
...
Signed-off-by: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/38112
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Bryan English <bryan@bryanenglish.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2021-04-08 11:23:54 -07:00
James M Snell
944a956087
assert: graduate assert.match and assert.doesNotMatch
...
Signed-off-by: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/38111
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-04-08 11:21:29 -07:00
Darcy Clarke
bc531d1860
deps: upgrade npm to 7.8.0
...
PR-URL: https://github.com/nodejs/node/pull/38030
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Ruy Adorno <ruyadorno@github.com >
2021-04-08 14:18:11 -04:00
Luigi Pinca
cc4ee6cba8
test: deflake test-http-many-ended-pipelines
...
The socket might be destroyed by the other peer while data is still
being written. Add the missing error handler.
PR-URL: https://github.com/nodejs/node/pull/38018
Fixes: https://github.com/nodejs/node/issues/37291
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-04-08 19:29:56 +02:00
Yash Ladha
8d63aa828e
src: fix typo for initialization
...
PR-URL: https://github.com/nodejs/node/pull/37974
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-08 20:55:55 +05:30
Arkerone
093b527b25
doc: fix typo in assert.md
...
change "asssert" to "assert"
PR-URL: https://github.com/nodejs/node/pull/38152
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-08 07:22:24 -07:00
Bradley Farias
656fb4657a
lib: add tsconfig for code completions
...
PR-URL: https://github.com/nodejs/node/pull/38042
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-04-08 08:35:09 -05:00
Rich Trott
0da7a11e54
test,http: check that http server is robust from handler abuse
...
The only way I could find to complete coverage for _http_common.js is to
use semi-private (exposed but probably shouldn't be) handlers to get the
state into something weird. With the if-condition being checked (see
Refs) commented out, I get this result from this test:
```
node:_http_common:140
if (len > 0 && !stream._dumped) {
^
TypeError: Cannot read property '_dumped' of null
at HTTPParser.parserOnBody (node:_http_common:140:26)
```
With the check in place, the test passes without an error. Seems like
quite the edge case, but I'm going to assume it's there for a reason.
Refs: https://coverage.nodejs.org/coverage-b560645d6b0a4bed/lib/_http_common.js.html#L137
PR-URL: https://github.com/nodejs/node/pull/37958
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-08 05:20:01 -07:00
Arkerone
b16e79e05b
tls: fix typo
...
`byteLenth` -> `byteLength`.
PR-URL: https://github.com/nodejs/node/pull/38129
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-04-08 10:35:38 +02:00
Luigi Pinca
7869761c2e
net: fix typo
...
`construtor` -> `constructor`.
Fixes: https://github.com/nodejs/node/issues/38125
PR-URL: https://github.com/nodejs/node/pull/38127
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
2021-04-08 10:33:09 +02:00
Tobias Nießen
0fa579ac2a
doc: add missing comma in crypto doc
...
PR-URL: https://github.com/nodejs/node/pull/38142
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2021-04-08 10:11:57 +02:00
Filip Skokan
e8cb6446ef
crypto: reconcile oneshot sign/verify sync and async implementations
...
PR-URL: https://github.com/nodejs/node/pull/37816
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2021-04-08 10:08:26 +02:00
legendecas
d86132488d
lib: properly process JavaScript exceptions on async_hooks fatal error
...
JavaScript exceptions could be arbitrary values.
PR-URL: https://github.com/nodejs/node/pull/38106
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-08 08:58:09 +02:00
Joyee Cheung
6cb314bbe5
bootstrap: print information for snapshot at environment exit in debug
...
Print information relevant to snapshot building at the environment
exit when NODE_DEBUG_NATIVE is set to include mksnapshot. This helps
us understand what need to be fixed to build a snapshot when a script
is run to completion.
PR-URL: https://github.com/nodejs/node/pull/37967
Refs: https://github.com/nodejs/node/issues/37476
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-08 12:02:01 +08:00
Richard Lau
9cfb418e1f
build: package release changelog for releases
...
Package the changelog for the release line as `CHANGELOG.md` when
building a release binary tarball.
PR-URL: https://github.com/nodejs/node/pull/38033
Fixes: https://github.com/nodejs/node/issues/38025
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-07 12:26:34 -07:00
Rich Trott
098a4d6551
test: skip test-crypto-dh-keys on armv6 and armv7
...
The test is too slow to run on the Raspberry Pi bots. (It takes over 500
seconds to run on Pi 3 bots and over 900 seconds on Pi 2 bots.) Skip
it on armv6 and armv7.
Refs: https://github.com/nodejs/node/pull/34289
PR-URL: https://github.com/nodejs/node/pull/38076
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-07 12:11:47 -07:00
Richard Lau
f9b63b8530
test: update parallel/test-crypto-keygen for OpenSSL 3
...
OpenSSL 3 returns a different error code.
PR-URL: https://github.com/nodejs/node/pull/38136
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2021-04-07 11:36:44 -07:00
Arkerone
4bc8f7542f
doc: fix typo in crypto
...
-change "keyLenth" to "keyLength"
-change "ivLenth" to "ivLength"
PR-URL: https://github.com/nodejs/node/pull/38130
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Harshitha K P <harshitha014@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-07 11:29:29 -07:00
Tobias Nießen
6a6cdfad03
test: fix skip message for test-macos-app-sandbox
...
PR-URL: https://github.com/nodejs/node/pull/38114
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-04-07 11:25:50 -07:00
Rich Trott
038608d401
tools: relax max-len lint rule for template strings
...
Splitting template strings across multiple lines can make them harder to
read.
PR-URL: https://github.com/nodejs/node/pull/38097
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-07 04:16:35 -07:00
Nitzan Uziely
6986fa07eb
worker: fix exit code for error thrown in handler
...
Change worker exit code when the unhandled exception
handler throws from 0 to 7
fixes: https://github.com/nodejs/node/issues/37996
PR-URL: https://github.com/nodejs/node/pull/38012
Fixes: https://github.com/nodejs/node/issues/37996
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 15:01:46 -07:00
Rich Trott
1e4a2bcbee
crypto: remove check for condition that is always true
...
The value of `key` will always be `!= null` because earlier in the
function, `ERR_CRYPTO_SIGN_KEY_REQUIRED` is thrown if `key` is falsy.
Remove condition that subsequently checks that `key != null`.
PR-URL: https://github.com/nodejs/node/pull/38072
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 14:58:46 -07:00