Ruben Bridgewater
97c52ca5dc
assert: add more information to AssertionErrors
...
This adds information about the actual thrown error to the
AssertionError's message property.
It also improves the logged error instances error name by using the
constructors name, if available.
PR-URL: https://github.com/nodejs/node/pull/28263
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-10-01 22:56:01 +02:00
Ruben Bridgewater
5700cd17dd
assert: do not repeat .throws() code
...
This refactors some code for less duplication.
PR-URL: https://github.com/nodejs/node/pull/28263
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-10-01 22:55:40 +02:00
Ruben Bridgewater
d47b6786c9
assert: wrap validation function errors
...
This makes sure that validation function used by `assert.throws` and
`assert.rejects` always throw validatin errors instead of rethrowing
the received error.
That should improve the debugging experience for developers since
they have a better context where the error is coming from and they
also get to know what triggered it.
PR-URL: https://github.com/nodejs/node/pull/28263
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-10-01 22:55:11 +02:00
Ruben Bridgewater
0b3242c3ce
assert: fix generatedMessage property
...
This makes sure the `generatedMessage` property is always set as
expected. This was not the case some `assert.throws` and
`assert.rejects` calls.
PR-URL: https://github.com/nodejs/node/pull/28263
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-10-01 22:55:11 +02:00
Ruben Bridgewater
ace3f16917
assert: improve class instance errors
...
This improves `assert.throws()` and `assert.rejects()` in case error
classes are used as validation for the expected error.
In case of a failure it will now throw an `AssertionError` instead
of the received error if the check fails. That error has the received
error as actual property and the expected property is set to the
expected error class.
The error message should help users to identify the problem faster
than before by providing extra context what went wrong.
PR-URL: https://github.com/nodejs/node/pull/28263
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-10-01 22:55:07 +02:00
Ruben Bridgewater
eb05d68815
crypto: refactor array buffer view validation
...
This is just a refactoring to reduce code and computational overhead.
PR-URL: https://github.com/nodejs/node/pull/29683
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-10-01 22:39:37 +02:00
Ruben Bridgewater
204248a0c3
console: update time formatting
...
This improves the readability of the `console.timeEnd()` output
while keeping a higher output's precision in multiple cases.
Instead of e.g. '1.005min' it will print '1:00.300 (m:ss.mmm)'.
PR-URL: https://github.com/nodejs/node/pull/29629
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2019-10-01 21:13:53 +02:00
Sam Roberts
3473e58fee
test: well-defined DH groups now verify clean
...
OpenSSL 1.1.1d no longer generates warnings for some DH groups that used
to be considered unsafe. See below for discussion. This is considered a
bug fix.
See:
- https://github.com/openssl/openssl/pull/9363
- https://github.com/openssl/openssl/pull/9363#discussion_r324802618
PR-URL: https://github.com/nodejs/node/pull/29550
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2019-10-01 11:11:18 -07:00
Sam Roberts
1ca1e0163e
deps: update archs files for OpenSSL-1.1.1
...
After an OpenSSL source update, all the config files need to be
regenerated and comitted by:
$ cd deps/openssl/config
$ make
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl/crypto/include/internal/bn_conf.h
$ git add deps/openssl/openssl/crypto/include/internal/dso_conf.h
$ git add deps/openssl/openssl/include/openssl/opensslconf.h
$ git commit
PR-URL: https://github.com/nodejs/node/pull/29550
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2019-10-01 11:11:13 -07:00
Sam Roberts
17d1d16441
deps: upgrade openssl sources to 1.1.1d
...
This updates all sources in deps/openssl/openssl by:
$ cd deps/openssl/
$ rm -rf openssl
$ tar zxf ~/tmp/openssl-1.1.0h.tar.gz
$ mv openssl-1.1.0h openssl
$ git add --all openssl
$ git commit openssl
PR-URL: https://github.com/nodejs/node/pull/29550
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2019-10-01 11:07:43 -07:00
Sam Roberts
7ce316e6a2
doc: security maintenance processes
...
The TSC has responsibility for Node.js security, so avoid fragmentation
of the Node.js maintenance process documentation by adding it to the
other guides.
PR-URL: https://github.com/nodejs/node/pull/29685
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2019-10-01 10:54:11 -07:00
Michaël Zasso
d9fd2cd0ff
2019-10-01, Version 12.11.1 (Current)
...
Notable changes:
* build:
* This release fixes a regression that prevented from building Node.js
using the official source tarball.
https://github.com/nodejs/node/pull/29712
* deps:
* Updated small-icu data to support "unit" style in the
`Intl.NumberFormat` API.
https://github.com/nodejs/node/pull/29735
PR-URL: https://github.com/nodejs/node/pull/29796
2019-10-01 18:44:05 +02:00
XhmikosR
a8956e4676
doc: remove redundant escape
...
PR-URL: https://github.com/nodejs/node/pull/29716
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2019-10-01 08:50:53 -07:00
TATSUNO Yasuhiro
16e47b976b
doc: fix type of atime/mtime
...
PR-URL: https://github.com/nodejs/node/pull/29666
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2019-09-30 22:01:37 -07:00
Alex Aubuchon
15fb02a515
src: rename --loader to --experimental-loader
...
Renames the `--loader` cli argument to `--experimental-loader`. This is
to clearly indicate the esm loader feature as experimental even after
esm is no longer experimental.
Also minorly alters the `--experimental-loader` docs to say that the
passed loader can be an esm module.
Refs: https://github.com/nodejs/modules/issues/351#issuecomment-535189524
PR-URL: https://github.com/nodejs/node/pull/29752
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2019-09-30 21:47:01 -07:00
Rich Trott
1c5a3f0d09
test: fix flaky test-cluster-net-listen-ipv6only-none
...
test-cluster-net-listen-ipv6only-none was using port `0` for an
IPv6-only operation and assuming that the operating system would supply
a port that was also available in IPv4. However, CI results seem to
indicate that a port can be supplied that is in use by IPv4 but
available to IPv6, resulting in the test failing. Use `common.PORT` to
avoid this issue.
Fixes: https://github.com/nodejs/node/issues/29679
PR-URL: https://github.com/nodejs/node/pull/29681
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
2019-09-30 18:56:17 -07:00
Simon A. Eugster
2487f39030
doc: clarify fs.symlink() usage
...
PR-URL: https://github.com/nodejs/node/pull/29700
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-09-30 11:44:19 -07:00
Robert Nagy
f663b31cc2
stream: always invoke callback before emitting error
...
Ensure the callback is always invoked before emitting
the error in both sync and async case.
PR-URL: https://github.com/nodejs/node/pull/29293
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-09-30 10:56:29 -07:00
Michaël Zasso
634a9a97f4
deps: enable unit data in small-icu
...
The data are needed for new Intl.NumberFormat options added by V8.
Fixes: https://github.com/nodejs/node/issues/29734
PR-URL: https://github.com/nodejs/node/pull/29735
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Minwoo Jung <minwoo@nodesource.com >
2019-09-30 06:48:33 -07:00
Guy Bedford
c42ab995c1
module: pass full URL to loader for top-level load
...
PR-URL: https://github.com/nodejs/node/pull/29736
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: David Carlier <devnexen@gmail.com >
2019-09-29 20:12:24 -07:00
Robert Nagy
1a3bf4f935
doc: clarify pipeline stream cleanup
...
PR-URL: https://github.com/nodejs/node/pull/29738
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2019-09-29 18:48:40 -07:00
cjihrig
663ef98e9a
test: simplify force-context-aware test
...
PR-URL: https://github.com/nodejs/node/pull/29705
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Shelley Vohr <codebytere@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2019-09-29 08:42:08 -04:00
cjihrig
82f89ec8c1
tls: simplify setSecureContext() option parsing
...
The following pattern is redundant, so remove it:
if (options.foo !== undefined)
this.foo = options.foo;
else
this.foo = undefined;
PR-URL: https://github.com/nodejs/node/pull/29704
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Minwoo Jung <minwoo@nodesource.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2019-09-29 08:23:37 -04:00
Robert Nagy
ce62e963a1
stream: remove ambiguous code
...
PR-URL: https://github.com/nodejs/node/pull/29664
Reviewed-By: Minwoo Jung <minwoo@nodesource.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2019-09-29 18:42:55 +09:00
Sam Roberts
dd74b163f9
doc: sync security policy with nodejs.org
...
The Node.js security disclosure policy has diverged between the website
and github:
- https://nodejs.org/en/security/
- https://github.com/nodejs/node/security/policy
The website is more recent and accurate, so sync the content from:
- https://github.com/nodejs/nodejs.org/blob/master/locale/en/security.md
PR-URL: https://github.com/nodejs/node/pull/29682
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2019-09-28 16:58:57 -07:00
Guy Bedford
2825e1183d
module: move cjs type check behind flag
...
PR-URL: https://github.com/nodejs/node/pull/29732
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Jan Krems <jan.krems@gmail.com >
Reviewed-By: Gus Caplan <me@gus.host >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
2019-09-28 11:56:39 -07:00
Richard Lau
f21818ec32
build: include deps/v8/test/torque in source tarball
...
Builds from the source tarball were broken by the recent V8 upate
to 7.7 as a file needed to build torque wasn't included in the source
tarball as it resides in deps/v8/test.
PR-URL: https://github.com/nodejs/node/pull/29712
Fixes: https://github.com/nodejs/node/issues/29709
Refs: https://github.com/nodejs/node/pull/28918
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Rod Vagg <rod@vagg.org >
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com >
2019-09-28 06:59:54 -07:00
Richard Lau
95792a7989
Revert "stream: invoke callback before emitting error always"
...
This reverts commit 3de5eae6db .
PR-URL: https://github.com/nodejs/node/pull/29741
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2019-09-28 06:53:52 -07:00
João Reis
35bfe0e414
build,win: goto lint only after defining node_exe
...
When running `vcbuild lint` on a new prompt where vcbuild was not run
before, `%node_exe%` was not defined and `eslint.js`, `lint-js.js`
and `lint-md.js` would be run directly using the program defined in
Windows (usually the Windows Scripting Host or Notepad).
This moves the goto statement to after `%node_exe%` is defined.
Fixes: https://github.com/nodejs/node/issues/29602
PR-URL: https://github.com/nodejs/node/pull/29616
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2019-09-27 16:45:12 -07:00
Ruben Bridgewater
aea9a0f77d
worker: fix process._fatalException return type
...
This makes sure `process._fatalException()` returns a boolean when
run inside of a worker.
PR-URL: https://github.com/nodejs/node/pull/29706
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Minwoo Jung <minwoo@nodesource.com >
2019-09-27 16:26:42 -07:00
Anton Gerasimov
c2ce8d0547
tls: add option for private keys for OpenSSL engines
...
Add `privateKeyIdentifier` and `privateKeyEngine` options
to get private key from an OpenSSL engine in tls.createSecureContext().
PR-URL: https://github.com/nodejs/node/pull/28973
Reviewed-By: Rod Vagg <rod@vagg.org >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
2019-09-27 15:50:56 -07:00
Robert Nagy
3de5eae6db
stream: invoke callback before emitting error always
...
Ensure the callback is always invoked before emitting
the error in both sync and async case.
PR-URL: https://github.com/nodejs/node/pull/29293
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-09-27 15:45:17 -07:00
Kirill Fomichev
c48467408d
doc: fix output in inspector HeapProfile example
...
PR-URL: https://github.com/nodejs/node/pull/29711
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2019-09-27 15:39:29 -07:00
exoego
5e1440c76b
doc: add KeyObject to type for crypto.createDecipheriv() argument
...
PR-URL: https://github.com/nodejs/node/pull/29689
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-09-27 15:37:14 -07:00
imhype
63c0f15a82
doc: clarify description of readable.push() method
...
PR-URL: https://github.com/nodejs/node/pull/29687
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2019-09-27 15:36:00 -07:00
Robert Nagy
7223ce2a9c
doc: clarify stream errors while reading and writing
...
Errors should be propagated through destroy(err). Anything else
is basically undefined behaviour.
PR-URL: https://github.com/nodejs/node/pull/29653
Refs: https://github.com/nodejs/node/issues/29584
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2019-09-27 15:34:17 -07:00
XhmikosR
ccb524fa16
doc: specify display=fallback for Google Fonts
...
PR-URL: https://github.com/nodejs/node/pull/29688
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2019-09-26 22:46:34 -07:00
Vse Mozhet Byt
008a1f6e8c
doc: fix some recent nits
...
PR-URL: https://github.com/nodejs/node/pull/29670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-09-26 22:41:45 -07:00
XhmikosR
f81bef5398
doc: fix 404 links
...
For `www.cve.mitre.org` they don't seem to redirect www to naked.
PR-URL: https://github.com/nodejs/node/pull/29661
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-09-26 22:32:46 -07:00
XhmikosR
73f4dc8464
doc: remove align from tables
...
This is obsolete. Also, in our case it doesn't seem to have
any effect since the table cells have their natural width,
i.e. as much as they need.
PR-URL: https://github.com/nodejs/node/pull/29668
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: David Carlier <devnexen@gmail.com >
2019-09-26 22:16:13 -07:00
David Carlier
4d2856ed5a
src: fix asan build for gcc/clang
...
Add missing header for LSAN.
PR-URL: https://github.com/nodejs/node/pull/29383
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-09-25 22:45:44 -07:00
rickyes
322e1e15d5
http2: optimize the altsvc Max bytes limit, define and use constants
...
PR-URL: https://github.com/nodejs/node/pull/29673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Minwoo Jung <minwoo@nodesource.com >
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-09-25 22:31:37 -07:00
Daniel Bevenius
899dd15f8f
src: fix compiler warning in inspector_profiler.cc
...
Currently, the following compiler warnings is generated:
../src/inspector_profiler.cc:231:5: warning:
ignoring return value of function declared with 'warn_unused_result'
attribute [-Wunused-result]
profile->Set(context, FIXED_ONE_BYTE_STRING(isolate, "source-map-cache")
^~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
This commit adds a .ToChecked() call to avoid the warning.
PR-URL: https://github.com/nodejs/node/pull/29660
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Minwoo Jung <minwoo@nodesource.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2019-09-26 06:09:55 +02:00
Ruben Bridgewater
d36b6f8da3
2019-09-24, Version 12.11.0 (Current)
...
Notable changes:
* crypto:
* Add `oaepLabel` option https://github.com/nodejs/node/pull/29489
* deps:
* Update V8 to 7.7.299.11 https://github.com/nodejs/node/pull/28918
* More efficient memory handling
* Stack trace serialization got faster
* The `Intl.NumberFormat` API gained new functionality
* For more information: https://v8.dev/blog/v8-release-77
* events:
* Add support for `EventTarget` in `once`
https://github.com/nodejs/node/pull/29498
* fs:
* Expose memory file mapping flag `UV_FS_O_FILEMAP`
https://github.com/nodejs/node/pull/29260
* inspector:
* New API - `Session.connectToMainThread`
https://github.com/nodejs/node/pull/28870
* process:
* Initial SourceMap support via `env.NODE_V8_COVERAGE`
https://github.com/nodejs/node/pull/28960
* stream:
* Make `_write()` optional when `_writev()` is implemented
https://github.com/nodejs/node/pull/29639
* tls:
* Add option to override signature algorithms
https://github.com/nodejs/node/pull/29598
* util:
* Add `encodeInto` to `TextEncoder`
https://github.com/nodejs/node/pull/29524
* worker:
* The `worker_thread` module is now stable
https://github.com/nodejs/node/pull/29512
PR-URL: https://github.com/nodejs/node/pull/29695
2019-09-26 01:14:24 +02:00
61743063cc
crypto: use byteLength in timingSafeEqual
...
PR-URL: https://github.com/nodejs/node/pull/29657
Co-authored-by: ZaneHannanAU <ZaneHannanAU@users.noreply.github.com >
Co-authored-by: Rich Trott <rtrott@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Minwoo Jung <minwoo@nodesource.com >
2019-09-25 15:58:15 -03:00
Trivikram Kamat
7333c7163a
doc,http: indicate callback is optional for message.setTimeout()
...
Documents that callback is optional for IncomingMessage setTimeout
PR-URL: https://github.com/nodejs/node/pull/29654
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2019-09-24 22:54:25 -07:00
Shelley Vohr
f120e6d817
test: --force-context-aware cli flag
...
PR-URL: https://github.com/nodejs/node/pull/29631
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2019-09-24 22:49:35 -07:00
Shelley Vohr
3c17f160e3
src: add buildflag to force context-aware addons
...
PR-URL: https://github.com/nodejs/node/pull/29631
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2019-09-24 22:49:33 -07:00
Ruben Bridgewater
5058c7f138
doc: document that iv may be null when using createCipheriv()
...
This adds `null` to the supported types of the `iv` option when
using `crypto.createCipheriv()`.
PR-URL: https://github.com/nodejs/node/pull/29684
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2019-09-24 22:06:56 -07:00
Anna Henningsen
81fee01310
doc: update AUTHORS list
...
PR-URL: https://github.com/nodejs/node/pull/29608
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com >
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2019-09-24 21:51:01 -07:00