Aviv Keller
9be0057859
test: fix soucre to source
...
PR-URL: https://github.com/nodejs/node/pull/55038
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-09-21 08:27:56 +00:00
Michael Dawson
29b9c72b05
test: add asserts to validate test assumptions
...
Refs: https://github.com/nodejs/node/pull/54968
Refs: https://github.com/nodejs/node/issues/53382
Add additional asserts as suggestd by Richard in:
https://github.com/nodejs/node/pull/54968
Signed-off-by: Michael Dawson <midawson@redhat.com >
PR-URL: https://github.com/nodejs/node/pull/54997
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-09-20 17:48:57 -04:00
Aviv Keller
81cc72996a
build: fix eslint makefile target
...
PR-URL: https://github.com/nodejs/node/pull/54999
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-09-20 21:46:54 +00:00
Chengzhong Wu
8b8fc53c9a
src: cleanup per env handles directly without a list
...
Environment handles can be cleaned up directly without saving the
references in a list and iterate the list.
PR-URL: https://github.com/nodejs/node/pull/54993
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2024-09-20 19:59:05 +00:00
Joyee Cheung
62383cd113
module: implement flushCompileCache()
...
This implements an API for users to intentionally flush the
accumulated compile cache instead of waiting until process
shutdown. It may be useful for application that loads dependencies
first and then either reload itself in other instances, or spawning
other instances that load an overlapping set of its dependencies -
in this case its useful to flush the cache early instead of waiting
until the shutdown of itself.
Currently flushing is triggered by either process
shutdown or user requests. In the future we should simply start the
writes right after module loading on a separate thread, and this method
only blocks until all the pending writes (if any) on the other thread
are finished. In that case, the off-thread writes should finish long
before any attempt of flushing is made so the method would then only
incur a negligible overhead from thread synchronization.
PR-URL: https://github.com/nodejs/node/pull/54971
Fixes: https://github.com/nodejs/node/issues/54770
Fixes: https://github.com/nodejs/node/issues/54465
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2024-09-20 19:05:07 +00:00
Joyee Cheung
4dfed556ba
module: throw when invalid argument is passed to enableCompileCache()
...
PR-URL: https://github.com/nodejs/node/pull/54971
Fixes: https://github.com/nodejs/node/issues/54770
Fixes: https://github.com/nodejs/node/issues/54465
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2024-09-20 19:05:06 +00:00
Joyee Cheung
9a73aa0d15
module: write compile cache to temporary file and then rename it
...
This works better in terms of avoiding race conditions.
PR-URL: https://github.com/nodejs/node/pull/54971
Fixes: https://github.com/nodejs/node/issues/54770
Fixes: https://github.com/nodejs/node/issues/54465
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2024-09-20 19:05:06 +00:00
Aviv Keller and Fabian Iwand
f666a1b754
tls: fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo
...
Co-Authored-By: Fabian Iwand <mootari@users.noreply.github.com >
PR-URL: https://github.com/nodejs/node/pull/52627
Fixes: https://github.com/nodejs/node/issues/52448
Refs: https://github.com/nodejs/node/pull/23188
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2024-09-20 17:59:22 +00:00
Jonas
fd8c762fab
src: add unistd.h import if node posix credentials is defined
...
usage comment
PR-URL: https://github.com/nodejs/node/pull/54528
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-09-20 14:58:02 +00:00
Pietro Marchini
e35299ae62
test: add runner watch mode isolation tests
...
PR-URL: https://github.com/nodejs/node/pull/54888
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2024-09-20 13:41:40 +00:00
Chemi Atlow
f79fd03f41
test_runner: add support for coverage via run()
...
PR-URL: https://github.com/nodejs/node/pull/53937
Fixes: https://github.com/nodejs/node/issues/53867
Refs: https://github.com/nodejs/node/issues/53924
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2024-09-20 13:20:45 +00:00
Batuhan Tomo
99433a2d7a
doc: add more details for localStorage and sessionStorage
...
PR-URL: https://github.com/nodejs/node/pull/53881
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-09-20 13:20:29 +00:00
Aviv Keller
2a1607cc2e
test: fix invalid wasm test
...
PR-URL: https://github.com/nodejs/node/pull/54935
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-09-20 10:42:59 +00:00
Luigi Pinca
a6ed2148a0
test: move test-http-max-sockets to parallel
...
PR-URL: https://github.com/nodejs/node/pull/54977
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
2024-09-20 09:57:21 +00:00
Luigi Pinca
636b3432d3
test: remove test-http-max-sockets flaky designation
...
There is no recent trace of failure for this test.
Fixes: https://github.com/nodejs/node/issues/47116
PR-URL: https://github.com/nodejs/node/pull/54976
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
2024-09-20 09:57:06 +00:00
Richard Lau
4f70132972
doc: reflect toolchains used for official binaries
...
Update the list of toolchains used to build the official Node.js
binaries for Node.js 23 onwards.
PR-URL: https://github.com/nodejs/node/pull/54967
Refs: https://github.com/nodejs/build/issues/3806
Refs: https://github.com/nodejs/node/pull/54081
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-09-20 01:51:34 +00:00
Stefan Stojanovic
653b96527a
build,win: float VS 17.11 compilation patch
...
Fixes: https://github.com/nodejs/node/issues/54898
PR-URL: https://github.com/nodejs/node/pull/54970
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-09-19 20:36:42 +00:00
Rafael Gonzaga
29357cb0ef
benchmark: include ascii to fs/readfile
...
PR-URL: https://github.com/nodejs/node/pull/54988
Reviewed-By: Daniel Lemire <daniel@lemire.me >
Reviewed-By: Raz Luvaton <rluvaton@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
2024-09-19 20:15:47 +00:00
Yagiz Nizipli
cde6dccb65
tools: refactor js2c.cc to use c++20
...
PR-URL: https://github.com/nodejs/node/pull/54849
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Daniel Lemire <daniel@lemire.me >
2024-09-19 19:21:21 +00:00
David Dong
291d90acbc
test: refactor test-whatwg-webstreams-encoding to be shorter
...
PR-URL: https://github.com/nodejs/node/pull/54569
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-09-19 15:26:02 +00:00
Abdirahim Musse
c8c108f9b0
tools: add additonal include dirs for V8 on AIX
...
On AIX, we now include src/wasm/float16.h from within src/utils/utils.h
and src/wasm/float16.h includes additional header files.
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-09-19 14:25:42 +00:00
Michaël Zasso
6e150f9527
deps: V8: cherry-pick 97199f686e2f
...
Original commit message:
aix: add work around for f16 type
AIX builds started to fail after this commit https://chromium.googlesource.com/v8/v8.git/+/d057564707d3a5df074b7f49a12a2f1e96638f94 .
Change-Id: I25a5c4ae3b4fe5c27a9fb9e35e2bcd2bbed40351
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5789180
Reviewed-by: Clemens Backes <clemensb@chromium.org >
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org >
Commit-Queue: Clemens Backes <clemensb@chromium.org >
Cr-Commit-Position: refs/heads/main@{#95952}
Refs: https://github.com/v8/v8/commit/97199f686e2f05ee126ded43b4d31ac001274d9d
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-09-19 14:25:42 +00:00
Michaël Zasso
1e16779fa1
deps: V8: cherry-pick 01a47f3ffff2
...
Original commit message:
[cfi] Add missing 'typename' in SegmentedTable
Makes the code more consistent and fixes compilation on older Clang
versions.
Change-Id: I82abebd500e6651ac5c5b180cd7b49b4f20e8299
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5805956
Reviewed-by: Samuel Groß <saelo@chromium.org >
Commit-Queue: Michaël Zasso <mic.besace@gmail.com >
Reviewed-by: Stephen Röttger <sroettger@google.com >
Cr-Commit-Position: refs/heads/main@{#95809}
Refs: https://github.com/v8/v8/commit/01a47f3ffff2621acdbc5dce0624a31679df4083
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-09-19 14:25:41 +00:00
Michaël Zasso
762a440e68
deps: patch V8 to support older Clang versions
...
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-09-19 14:25:40 +00:00
Michaël Zasso
95f2213eed
deps: always define V8_NODISCARD as no-op
...
It's causing compiler errors with some classes on Xcode 11
and the attribute should have no runtime effect.
PR-URL: https://github.com/nodejs/node/pull/54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2024-09-19 14:25:40 +00:00
Stefan Stojanovic
09d997f181
deps: fix FP16 bitcasts.h
...
PR-URL: https://github.com/nodejs/node/pull/53134
Refs: https://github.com/nodejs/node/issues/52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-09-19 14:25:39 +00:00
StefanStojanovic and Michaël Zasso
1866363854
deps: patch V8 to support compilation with MSVC
...
Co-Authored-By: Michaël Zasso <targos@protonmail.com >
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-09-19 14:25:39 +00:00
Michaël Zasso
6f4f22f84c
deps: patch V8 to avoid duplicated zlib symbol
...
PR-URL: https://github.com/nodejs/node/pull/54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2024-09-19 14:25:38 +00:00
Michaël Zasso
dfff61475e
deps: disable V8 concurrent sparkplug compilation
...
It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.
Refs: https://github.com/nodejs/node/issues/47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: https://github.com/nodejs/node/pull/47450
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-09-19 14:25:37 +00:00
Michaël Zasso
69ad89f8eb
deps: always define V8_EXPORT_PRIVATE as no-op
...
dllexport introduces issues when compiling with MSVC.
PR-URL: https://github.com/nodejs/node/pull/47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-09-19 14:25:37 +00:00
Michaël Zasso
17a17164d6
src: update NODE_MODULE_VERSION to 131
...
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 12.9.
Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-09-19 14:25:36 +00:00
Michaël Zasso
f68d7d2acc
build: reset embedder string to "-node.0"
...
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-09-19 14:25:36 +00:00
Michaël Zasso
5ab3140dfb
deps: update V8 to 12.9.202.18
...
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-09-19 14:25:34 +00:00
Aviv Keller
b446a587ba
doc: mark v21 as End-of-Life
...
PR-URL: https://github.com/nodejs/node/pull/54984
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-09-19 14:12:48 +00:00
Aviv Keller
8aa57918c2
meta: remove never-used workflow trigger
...
PR-URL: https://github.com/nodejs/node/pull/54983
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-09-19 14:01:57 +00:00
Marco Ippolito
bb405210c5
test_runner: support typescript module mocking
...
PR-URL: https://github.com/nodejs/node/pull/54878
Fixes: https://github.com/nodejs/node/issues/54428
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Erick Wendel <erick.workspace@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
2024-09-19 13:36:52 +00:00
Antoine du Hamel
be4babb3c2
module: report unfinished TLA in ambiguous modules
...
PR-URL: https://github.com/nodejs/node/pull/54980
Fixes: https://github.com/nodejs/node/issues/54931
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2024-09-19 10:34:13 +00:00
Antoine du Hamel
6031a4bc7c
worker: handle --input-type more consistently
...
PR-URL: https://github.com/nodejs/node/pull/54979
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-09-19 10:08:50 +00:00
Yagiz Nizipli
c42d8461b0
zlib: remove prototype primordials usage
...
# Conflicts:
# lib/zlib.js
PR-URL: https://github.com/nodejs/node/pull/54695
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ruy Adorno <ruy@vlt.sh >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com >
2024-09-19 03:16:20 +00:00
dependabot[bot]
59c7c55aad
tools: bump the eslint group in /tools/eslint with 7 updates
...
Bumps the eslint group in /tools/eslint with 7 updates:
| Package | From | To |
| --- | --- | --- |
| `@babel/core` | `7.24.9` | `7.25.2` |
| `@babel/eslint-parser` | `7.25.0` | `7.25.1` |
| `@babel/plugin-syntax-import-attributes` | `7.24.7` | `7.25.6` |
| `@stylistic/eslint-plugin-js` | `2.4.0` | `2.7.2` |
| `eslint` | `9.8.0` | `9.9.1` |
| `eslint-plugin-jsdoc` | `48.8.3` | `50.2.2` |
| `globals` | `15.8.0` | `15.9.0` |
Signed-off-by: dependabot[bot] <support@github.com >
PR-URL: https://github.com/nodejs/node/pull/54821
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2024-09-19 02:00:25 +02:00
Michael Dawson
6dfa3e46d3
test: adjust key sizes to support OpenSSL32
...
Refs: https://github.com/nodejs/node/issues/53382
This test fails on OpenSSL32 because it complains the key
being used is too short.
Adjust the key sizes so that they will pass on OpenSSL32 in
addition to other OpenSSL3 versions.
Since the keys are not public key related I don't think the
increase in key size will be too bad in terms of performance so
I've just increased versus guarding for OpenSSL32
Signed-off-by: Michael Dawson <midawson@redhat.com >
PR-URL: https://github.com/nodejs/node/pull/54972
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-09-18 19:26:45 +00:00
Robert Nagy
0d4387ebe2
buffer: use simdutf convert_latin1_to_utf8_safe
...
simdutf 5.5 includes convert_latin1_to_utf8_safe
PR-URL: https://github.com/nodejs/node/pull/54798
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Daniel Lemire <daniel@lemire.me >
2024-09-18 18:39:01 +00:00
Michael Dawson
f8b7a17146
test: update test to support OpenSSL32
...
Refs: https://github.com/nodejs/node/issues/53382
This test fails on OpenSSL32 because it complains the key being
used is too short.
It seems to have been missed when the test suite was udpated to have
a Makefile to generate key material as the keys are hard coded in the
test as opposed to being read in from the fixtures/key directory.
Update the test to use keys/certs from the fixtures directory and
to remove newlines at the end of the key and cert to retain the
inteded test.
Signed-off-by: Michael Dawson <midawson@redhat.com >
PR-URL: https://github.com/nodejs/node/pull/54968
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-09-18 16:36:08 +00:00
Pietro Marchini
50136a167d
test_runner: avoid coverage report partial file names
...
Co-author: Medhansh404 <21ucs126@lnmiit.ac.in >
PR-URL: https://github.com/nodejs/node/pull/54379
Fixes: https://github.com/nodejs/node/issues/51299
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2024-09-18 18:24:19 +02:00
Chengzhong Wu
7e00be7650
Revert "build: upgrade clang-format to v18"
...
This reverts commit c3e1c31baa .
PR-URL: https://github.com/nodejs/node/pull/54994
Refs: https://github.com/nodejs/node/pull/53957
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-09-18 15:58:34 +00:00
Khafra
b470e2fcb2
test: update DOM events web platform tests
...
PR-URL: https://github.com/nodejs/node/pull/54642
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Mattias Buelens <mattias@buelens.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-09-18 17:39:56 +02:00
Khafra
0de1cf004c
events: return currentTarget when dispatching
...
PR-URL: https://github.com/nodejs/node/pull/54642
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Mattias Buelens <mattias@buelens.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-09-18 17:30:23 +02:00
Aviv Keller
c6ae161237
meta: remove unneeded ignore rules from ruff
...
PR-URL: https://github.com/nodejs/node/pull/54360
Reviewed-By: Christian Clauss <cclauss@me.com >
2024-09-18 17:07:37 +02:00
Yagiz Nizipli
0c5fa57bc7
cli: ensure --run has proper pwd
...
PR-URL: https://github.com/nodejs/node/pull/54949
Refs: https://github.com/nodejs/node/pull/53600
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com >
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br >
2024-09-18 12:18:40 +00:00
Wiyeong Seo
e42ca5c1a9
path: remove repetitive conditional operator in posix.resolve
...
PR-URL: https://github.com/nodejs/node/pull/54835
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-09-18 12:18:24 +00:00