cjihrig
9dca43e709
domain: show falsy names as anonymous for DEP0097
...
Many anonymous functions use the empty string as their name.
Since the DEP0097 logic was using nullish coalescing, these
functions were not being displayed as anonymous. This commit
updates the logic to use || instead of ??.
PR-URL: https://github.com/nodejs/node/pull/37550
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-03-03 12:51:15 -05:00
cjihrig
934d3f05a3
tools: update eslint-plugin-markdown configuration
...
This commit updates the linting setup to work with
eslint-plugin-markdown@2.0.0. This also allows the update-eslint
script to continue to function properly without changes.
PR-URL: https://github.com/nodejs/node/pull/37549
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-03-03 12:42:26 -05:00
Michaël Zasso
f6b1df2226
2021-03-03, Version 15.11.0 (Current)
...
Notable changes:
crypto:
* (SEMVER-MINOR) make FIPS related options always awailable (Vít Ondruch) https://github.com/nodejs/node/pull/36341
errors:
* (SEMVER-MINOR) remove experimental from --enable-source-maps (Benjamin Coe) https://github.com/nodejs/node/pull/37362
PR-URL: https://github.com/nodejs/node/pull/37569
2021-03-03 07:06:17 +01:00
Luigi Pinca
20def25f25
tools: update ESLint to 7.21.0
...
PR-URL: https://github.com/nodejs/node/pull/37546
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-03-02 20:39:26 +01:00
Ruy Adorno
993963e2ee
deps: upgrade npm to 7.6.0
...
PR-URL: https://github.com/nodejs/node/pull/37559
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-03-02 09:31:29 +01:00
cjihrig
b3f35e2c70
doc,lib: add missing deprecation code
...
PR-URL: https://github.com/nodejs/node/pull/37541
Refs: https://github.com/nodejs/node/pull/37136
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-03-01 17:41:45 -05:00
cjihrig
f91509ba85
doc: remove experimental from --enable-source-maps
...
PR-URL: https://github.com/nodejs/node/pull/37540
Refs: https://github.com/nodejs/node/pull/37362
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Gus Caplan <me@gus.host >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-03-01 17:39:26 -05:00
marsonya
d5c3ed0b09
doc: fix typo in doc/api/packages.md
...
PR-URL: https://github.com/nodejs/node/pull/37536
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2021-03-01 17:00:32 -05:00
Rich Trott
2748b0ad5a
test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls
...
The test does not seem to have failed since the issue was first reported
in 2019.
Closes: https://github.com/nodejs/node/issues/30845
PR-URL: https://github.com/nodejs/node/pull/37533
Fixes: https://github.com/nodejs/node/issues/30845
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-03-01 12:19:43 -08:00
Rich Trott
978594c706
test: make status file names consistent
...
For some reason, the test/addons directory has a status file of
addon.status rather than addons.status. Make it consistent with other
directories.
PR-URL: https://github.com/nodejs/node/pull/37532
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-03-01 12:18:18 -08:00
Rich Trott
20bfa17cc8
test: account for pending deprecations in esm test
...
test-esm-local-deprecations fails if NODE_PENDING_DEPRECATION is set
because the test expects exactly the warnings it expects and no other
warnings. Modify the test to still expect its errors in the order it
expects them, but to ignore errors it does not expect.
PR-URL: https://github.com/nodejs/node/pull/37542
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-03-01 12:16:30 -08:00
James M Snell
360e8c842a
workers: fix spawning from preload scripts
...
Fix spawning nested worker threads from preload scripts and
warn about doing so.
Signed-off-by: James M Snell <jasnell@gmail.com >
Fixes: https://github.com/nodejs/node/issues/36531
PR-URL: https://github.com/nodejs/node/pull/37481
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2021-03-01 11:43:27 -08:00
James M Snell
da217d0773
fs: fix flag and mode validation
...
The `flag` and `mode` options were not being validated correctly.
Signed-off-by: James M Snell <jasnell@gmail.com >
Fixes: https://github.com/nodejs/node/issues/37430
PR-URL: https://github.com/nodejs/node/pull/37480
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-03-01 09:47:56 -08:00
Joyee Cheung
7c63bc6540
doc: document how to register external bindings for snapshot
...
PR-URL: https://github.com/nodejs/node/pull/37463
Refs: https://github.com/nodejs/node/issues/35711
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-03-02 00:11:55 +08:00
humanwebpl
1ca4a9cdbf
doc: fix typo "director" instead of "directory"
...
Change fs.readdirSync() description from "Reads the contents of
the director." to "Reads the contents of the directory."
PR-URL: https://github.com/nodejs/node/pull/37523
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Harshitha K P <harshitha014@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-03-01 07:22:50 -08:00
Rich Trott
e6cbec59c4
doc: revise LTS text in collaborator guide
...
PR -> pull request
can -> might (to be clear it's about possibility)
were -> do for active/passive parallel structure
PR-URL: https://github.com/nodejs/node/pull/37527
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2021-02-28 22:45:38 -08:00
Rich Trott
67bc0ec7ac
doc: revise CI text in collaborator guide
...
Minor clarifications to text. For example, this moves the "(green or
yellow)" parenthetical closer to the text to which it applies. (It
applies only to Jenkins CI.)
PR-URL: https://github.com/nodejs/node/pull/37526
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2021-02-28 22:43:44 -08:00
Rich Trott
be1cc51005
doc: revise objections section of collaborator guide
...
The bold text is overused in this section. This change removes it. It
also changes some wording: PR -> pull request, can -> may in a rare
instance where "may" is the right choice in our docs, etc. (The
recommendation to avoid "may" is because "may" implies permission rather
than just ability. Yes, I'm probably the one that changed it from "may"
in the first place.)
PR-URL: https://github.com/nodejs/node/pull/37525
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2021-02-28 22:42:17 -08:00
Rich Trott
2fd1db82ea
doc: revise premature disclosure text in collaborator guide
...
Avoid abbreviations and jargon. PR -> pull request, repo -> repository,
etc.
PR-URL: https://github.com/nodejs/node/pull/37524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2021-02-28 22:39:30 -08:00
Rich Trott
1e34df139c
stream: move duplicated code to an internal module
...
Create a utils module for isIterable(), isReadable(), and isStream().
PR-URL: https://github.com/nodejs/node/pull/37508
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2021-02-28 05:07:26 -08:00
Michael Dawson
7a4c2c8d86
doc: change links to use HEAD in top level docs
...
Change the top level docs to use HEAD in links
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/37494
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-02-27 12:03:22 -08:00
marsonya
0486cb86cd
doc: apply sentence case to headers in doc/guides
...
PR-URL: https://github.com/nodejs/node/pull/37506
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com >
Reviewed-By: Harshitha K P <harshitha014@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-02-27 12:00:15 -08:00
marsonya
f683cf901c
doc: fix typo in webcrypto.md
...
PR-URL: https://github.com/nodejs/node/pull/37507
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-02-27 11:52:27 -08:00
Anna Henningsen
5968c54235
worker: fix interaction of terminate() with messaging port
...
When a Worker is terminated, its own handle and the public
`MessagePort` are `.ref()`’ed, so that all relevant events,
including the `'exit'` events, end up being received.
However, this is problematic if messages end up being queued
from the Worker between the beginning of the `.terminate()` call
and its completion, and there are no `'message'` event handlers
present at that time. In that situation, currently the messages
would not end up being processed, and since the MessagePort
is still `.ref()`’ed, it would keep the event loop alive
indefinitely.
To fix this:
- Make sure that all messages end up being received by
`drainMessagePort()`, including cases in which the port had
been stopped (i.e. there are no `'message'` listeners) and
cases in which we exceed the limit for messages being processed
in one batch.
- Unref the Worker’s internal ports manually after the Worker
has exited.
Either of these solutions should be solving this on its own,
but I think it makes sense to make sure that both of them
happen during cleanup.
PR-URL: https://github.com/nodejs/node/pull/37319
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-02-27 17:26:20 +01:00
Nitzan Uziely
9f56bc8b4c
child_process: fix spawn and fork abort behavior
...
Fix AbortSignal in Spawn which doesn't actually abort
the process, and fork can emit an AbortError even if
the process was already exited. Add documentation
For killSignal.
Fixes: https://github.com/nodejs/node/issues/37273
PR-URL: https://github.com/nodejs/node/pull/37325
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2021-02-27 14:38:50 +02:00
James M Snell
fc6d8f4b84
doc: document the NO_COLOR and FORCE_COLOR env vars
...
Signed-off-by: James M Snell <jasnell@gmail.com >
Fixes: https://github.com/nodejs/node/issues/37404
PR-URL: https://github.com/nodejs/node/pull/37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-02-26 11:35:35 -08:00
Antoine du Hamel
5d240c5efc
doc: add url.resolve replacement example
...
Fixes: https://github.com/nodejs/node/issues/37492
PR-URL: https://github.com/nodejs/node/pull/37501
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-02-26 16:35:32 +01:00
Antoine du Hamel
75259c7492
crypto: refactor hasAnyNotIn to avoid unsafe array iteration
...
PR-URL: https://github.com/nodejs/node/pull/37433
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2021-02-26 16:34:04 +01:00
Nitzan Uziely
503d6ccdef
fs: fix writeFile signal does not close file
...
Fix an issue where the writeFile does not close the file
when the signal is aborted.
PR-URL: https://github.com/nodejs/node/pull/37402
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-02-26 16:31:36 +01:00
Nitzan Uziely
c4180b74c5
fs: fix pre-aborted writeFile AbortSignal file leak
...
Fix an issue in writeFile where a file is opened, and not closed
if the abort signal is aborted after the file was opened
but before writing began.
PR-URL: https://github.com/nodejs/node/pull/37393
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-02-26 16:27:54 +01:00
marsonya
5c3bc21146
doc: apply sentence case to guides headers
...
PR-URL: https://github.com/nodejs/node/pull/37497
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com >
2021-02-26 11:26:48 +01:00
Nitzan Uziely
7837d3fde9
stream: add AbortSignal support to finished
...
PR-URL: https://github.com/nodejs/node/pull/37354
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-02-26 11:21:24 +01:00
Antoine du Hamel
fbda84ef84
doc: update CI requirements for landing pull requests
...
PR-URL: https://github.com/nodejs/node/pull/37308
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Shelley Vohr <codebytere@gmail.com >
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mary Marchini <oss@mmarchini.me >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2021-02-26 11:18:44 +01:00
Filip Skokan
8ddee73efc
crypto: check ed/x webcrypto key import algorithm names
...
PR-URL: https://github.com/nodejs/node/pull/37305
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-02-26 11:16:52 +01:00
Antoine du Hamel
83cce8717f
lib: use <array>.push and <array>.unshift instead of <array>.concat
...
Using `push` and `unshift` methods is more performant than reassigning a
new array created with `concat`.
PR-URL: https://github.com/nodejs/node/pull/37239
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-02-26 11:11:22 +01:00
Vít Ondruch
f392ac0bbe
crypto: make FIPS related options always awailable
...
There is no reason to hide FIPS functionality behind build flags.
OpenSSL always provide the information about FIPS availability via
`FIPS_mode()` function.
This makes the user experience more consistent, because the OpenSSL
library is always queried and the `crypto.getFips()` always returns
OpenSSL settings.
Fixes #34903
PR-URL: https://github.com/nodejs/node/pull/36341
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com >
2021-02-25 18:12:58 -05:00
James M Snell
148bc33347
fs: fixup negative length in fs.truncate
...
`fs.ftruncate`, `fsPromises.truncate`, and `fsPromises.ftruncate`
all adjust negative lengths to 0 before invoking the system call.
`fs.truncate()` was the one outlier.
This "fixes" https://github.com/nodejs/node/issues/35632 but in the
opposite direction than discussed in the issue -- specifically by
removing an EINVAL error from one function rather than adding it to
another.
Signed-off-by: James M Snell <jasnell@gmail.com >
Fixes: https://github.com/nodejs/node/issues/35632
PR-URL: https://github.com/nodejs/node/pull/37483
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-02-25 14:45:08 -08:00
James M Snell
ee6c467c8a
doc: recommend queueMicrotask over process.nextTick
...
We likely cannot ever deprecate process.nextTick, but we can start
steering people towards queueMicrotask for most cases.
Signed-off-by: James M Snell <jasnell@gmail.com >
Fixes: https://github.com/nodejs/node/issues/36870
PR-URL: https://github.com/nodejs/node/pull/37484
Reviewed-By: Gus Caplan <me@gus.host >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
2021-02-25 14:33:59 -08:00
Ruy Adorno
43e29418c4
deps: upgrade npm to 7.5.6
...
PR-URL: https://github.com/nodejs/node/pull/37496
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
2021-02-25 09:52:12 -05:00
Richard Lau
448de26d7b
deps: V8: cherry-pick 373f4ae739ee
...
Original commit message:
[torque] Don't replace unmodified empty files
To improve incremental builds.
Bug: v8:7793
Change-Id: I6990a97e058d22d34acd1f609167cd30ca7518ad
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596789
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org >
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com >
Cr-Commit-Position: refs/heads/master@{#72053}
Refs: https://github.com/v8/v8/commit/373f4ae739eeae0e4d2224b15002be35f1470312
PR-URL: https://github.com/nodejs/node/pull/37505
Fixes: https://github.com/nodejs/node/issues/37368
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2021-02-25 09:48:00 +01:00
ttzztztz
63794b4198
test: fix incorrect timers-promisified case
...
PR-URL: https://github.com/nodejs/node/pull/37425
Fixes: https://github.com/nodejs/node/issues/37395
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2021-02-25 07:27:23 +01:00
Michaël Zasso
001dc16cf1
src: use non-deprecated V8 module and script APIs
...
PR-URL: https://github.com/nodejs/node/pull/37330
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-02-25 00:16:41 +01:00
Michaël Zasso
43cc8e4b2e
deps: bump minimum ICU version to 68
...
Refs: https://github.com/v8/v8/commit/1e69cdd95bad505ec5de1ddca9e58eee8cd9383f
PR-URL: https://github.com/nodejs/node/pull/37330
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-02-25 00:16:30 +01:00
Michaël Zasso
017661768a
tools: update V8 gypfiles for 8.9
...
PR-URL: https://github.com/nodejs/node/pull/37330
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-02-25 00:16:26 +01:00
Michaël Zasso
8eeecc19ae
deps: V8: cherry-pick 8957d4677aa7
...
Original commit message:
[aarm64] Fix GetSharedLibraryAddresses
This patch fixes a segmentation fault which occurs when using `--prof` flag on a Darwin ARM64 architecture.
See https://github.com/nodejs/node/issues/36656
Change-Id: Idc3ce6c8fd8a24f76f1b356f629e37340045b51e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2609413
Reviewed-by: Ulan Degenbaev <ulan@chromium.org >
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Commit-Queue: Ulan Degenbaev <ulan@chromium.org >
Cr-Commit-Position: refs/heads/master@{#72886}
Refs: https://github.com/v8/v8/commit/8957d4677aa794c230577f234071af0dadb88f7b
PR-URL: https://github.com/nodejs/node/pull/37330
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-02-25 00:16:20 +01:00
Michaël Zasso
b186142a0b
deps: V8: backport a11395433dbd
...
Original commit message:
[cppgc]: Fix build on msvc
Fixes compilation with msvc 2019 toolchain.
See: https://github.com/nodejs/node/pull/37330#issuecomment-783000812
Change-Id: I3b658d9ef49889c0a0467a1146e8d16b50fca65d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2711152
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Commit-Queue: Michael Lippautz <mlippautz@chromium.org >
Cr-Commit-Position: refs/heads/master@{#72917}
Refs: https://github.com/v8/v8/commit/a11395433dbd1880a1bb5b84078a36ab0804a623
PR-URL: https://github.com/nodejs/node/pull/37330
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-02-25 00:16:13 +01:00
Matin Zadehdolatabad
d6b50611f4
deps: V8: cherry-pick 0c8b6e415c30
...
Original commit message:
[mac][wasm] Work around MacOS 11.2 code page decommit failures
MacOS 11.2 refuses to set "no access" permissions on memory that
we previously used for JIT-compiled code. It is still unclear
whether this is WAI on the part of the kernel. In the meantime,
as a workaround, we use madvise(..., MADV_FREE_REUSABLE) instead
of mprotect(..., NONE) when discarding code pages. This is inspired
by what Chromium's gin platform does.
Fixed: v8:11389
Change-Id: I866586932573b4253002436ae5eee4e0411c45fc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2679688
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org >
Commit-Queue: Michael Lippautz <mlippautz@chromium.org >
Auto-Submit: Jakob Kummerow <jkummerow@chromium.org >
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Cr-Commit-Position: refs/heads/master@{#72559}
Refs: https://github.com/v8/v8/commit/0c8b6e415c3020a987d2287f1543d629cd993535
Fixes: https://github.com/nodejs/node/issues/37061
PR-URL: https://github.com/nodejs/node/pull/37276
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Ash Cripps <acripps@redhat.com >
2021-02-25 00:16:10 +01:00
Benjamin Coe
bb2a98ff41
deps: V8: cherry-pick fe191e8d05cc
...
Original commit message:
[coverage] optional chaining coverage
Implement coverage tracking for optional chains.
Bug: v8:10060
Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Reviewed-by: Toon Verwaest <verwaest@chromium.org >
Reviewed-by: Gus Caplan <snek@chromium.org >
Reviewed-by: Sigurd Schneider <sigurds@chromium.org >
Commit-Queue: Benjamin Coe <bencoe@google.com >
Cr-Commit-Position: refs/heads/master@{#72075}
Refs: https://github.com/v8/v8/commit/fe191e8d05ccfa740432f56d34b1ff2d32265a8d
PR-URL: https://github.com/nodejs/node/pull/36956
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-02-25 00:16:07 +01:00
Michaël Zasso
290f2d8d3e
deps: V8: cherry-pick deb0813166f3
...
Original commit message:
[heap] Add proper rebind support to StrongRootBlockAllocator
MSVC's STL in debug mode rebinds the allocator passed to vectors to
allocate helper structures, so we need StrongRootBlockAllocator to have
proper rebind support rather than assuming it always rebinds to Address.
Bug: v8:11241
Change-Id: I15688e43fe2c71ec4ff0c287a03e36ca57427417
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622915
Auto-Submit: Leszek Swirski <leszeks@chromium.org >
Reviewed-by: Ulan Degenbaev <ulan@chromium.org >
Commit-Queue: Leszek Swirski <leszeks@chromium.org >
Cr-Commit-Position: refs/heads/master@{#72060}
Refs: https://github.com/v8/v8/commit/deb0813166f3fcb72c742f76e3c7228f23568bf1
PR-URL: https://github.com/nodejs/node/pull/36139
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Shelley Vohr <codebytere@gmail.com >
2021-02-25 00:16:06 +01:00
Michaël Zasso
63ed0b8bfe
deps: V8: cherry-pick 9a6a22874c81
...
Original commit message:
[heap] Fix DCHECK in TransitionArrayNeedsCompaction
The dead target check in TransitionArrayNeedsCompaction, confirming that
Smi (uninitialized) targets imply that no other target is dead, has to
additionally support Smi entries.
Bug: v8:11305
Change-Id: I6f3fa9e7420b1bd0a64a25dae670f439e3f41162
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622914
Commit-Queue: Leszek Swirski <leszeks@chromium.org >
Commit-Queue: Ulan Degenbaev <ulan@chromium.org >
Auto-Submit: Leszek Swirski <leszeks@chromium.org >
Reviewed-by: Ulan Degenbaev <ulan@chromium.org >
Cr-Commit-Position: refs/heads/master@{#72040}
Refs: https://github.com/v8/v8/commit/9a6a22874c814be0a3ad12065b386722df110df5
PR-URL: https://github.com/nodejs/node/pull/36139
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Shelley Vohr <codebytere@gmail.com >
2021-02-25 00:16:02 +01:00