Adam Brunner
aa1333ff3b
doc: "util" is not needed to extend ES6 classes
...
PR-URL: https://github.com/nodejs/node/pull/9737
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Italo A. Casas <me@italoacasas.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2016-11-23 19:29:54 +01:00
Rich Trott
2486273c0e
test: fix flaky test-inspector
...
Using `socket.destroy()` instead of `socket.end()` fixes
more-than-intermittent ECONNRESET issues on Windows.
PR-URL: https://github.com/nodejs/node/pull/9727
Fixes: https://github.com/nodejs/node/issues/8804
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com >
2016-11-23 10:21:48 -08:00
Sam Roberts
fd644f51f8
crypto: allow adding extra certs to well-known CAs
...
In closed environments, self-signed or privately signed certificates are
commonly used, and rejected by Node.js since their root CAs are not
well-known. Allow extending the set of well-known compiled-in CAs via
environment, so they can be set as a matter of policy.
PR-URL: https://github.com/nodejs/node/pull/9139
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com >
2016-11-23 08:35:22 -08:00
Sam Roberts
213134f66d
src: add wrapper for process.emitWarning()
...
PR-URL: https://github.com/nodejs/node/pull/9139
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com >
2016-11-23 07:16:38 -08:00
Rich Trott
d71dd9b2f3
test:refactor test-tls-hello-parser-failure
...
* setTimeout() with no duration -> setImmediate()
* add common.mustCall() where appropriate
* var -> const
* .on() -> .once()
PR-URL: https://github.com/nodejs/node/pull/9715
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2016-11-22 21:22:58 -08:00
Jeremiah Senkpiel
db3f12f7e0
2016-11-22, Version 7.2.0 (Current)
...
This is a security release impacting Windows 10 users.
Notable changes:
* crypto: The `Decipher` methods `setAuthTag()` and `setAAD` now return
`this`. (Kirill Fomichev) https://github.com/nodejs/node/pull/9398
* dns: Implemented `{ttl: true}` for `resolve4()` and `resolve6()`.
(Ben Noordhuis) https://github.com/nodejs/node/pull/9296 &
https://github.com/nodejs/node/pull/9296
* libuv: Upgrade to v1.10.1 (cjihrig)
https://github.com/nodejs/node/pull/9647
- Fixed a potential buffer overflow when writing data to console on
Windows 10. (CVE-2016-9551)
* process: Added a new `external` property to the data returned by
`memoryUsage()`. (Fedor Indutny)
https://github.com/nodejs/node/pull/9587
* tls: Fixed a memory leak when writes were queued on TLS connection
that was destroyed during handshake. (Fedor Indutny)
https://github.com/nodejs/node/pull/9626
* V8 (dep): Upgrade to v5.4.500.43 (Michaël Zasso)
https://github.com/nodejs/node/pull/9697
* v8: The data returned by `getHeapStatistics()` now includes three new
fields: `malloced_memory`, `peak_malloced_memory`, and
`does_zap_garbage`. (Gareth Ellis)
https://github.com/nodejs/node/pull/8610
PR-URL: https://github.com/nodejs/node/pull/9745
2016-11-22 18:46:07 -05:00
Stewart Addison
1bd871655a
build: add shared library support to AIX build
...
Updates to build the shared library version of node on AIX. Adds the
same functionality to AIX that was added on Linux under this:
Ref: https://github.com/nodejs/node/pull/6994/
PR-URL: https://github.com/nodejs/node/pull/9675
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2016-11-22 14:22:22 -05:00
Stewart Addison
625a2716c6
deps: backport GYP fix to fix AIX shared suffix
...
Required to support the shared library builds on AIX - this sets the
shared library suffix within GYP to .a instead of .so on AIX
My patch: https://codereview.chromium.org/2492233002/ was landed as
as part of this one which fixed some other (not required, but
included for completeness of the backport) changes:
Ref: https://codereview.chromium.org/2511733005/
2016-11-22 14:20:07 -05:00
Roman Reiss
245a92894b
doc: fix <code> inside stability boxes
...
Fixes: https://github.com/nodejs/node/issues/9714
PR-URL: https://github.com/nodejs/node/pull/9723
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2016-11-22 19:40:02 +01:00
Jeremiah Senkpiel
3f1e38c847
timers: use consistent checks for canceled timers
...
Previously not all codepaths set `timer._idleTimeout = -1` for canceled
or closed timers, and not all codepaths checked it either.
Unenroll uses this to say that a timer is indeed closed and it is the
closest thing there is to an authoritative source for this.
Refs: https://github.com/nodejs/node/pull/9606
Fixes: https://github.com/nodejs/node/issues/9561
PR-URL: https://github.com/nodejs/node/pull/9685
Reviewed-By: Rich Trott <rtrott@gmail.com >
2016-11-22 12:28:41 -05:00
Vse Mozhet Byt
929fd4a892
doc: fix typo in assert code example
...
PR-URL: https://github.com/nodejs/node/pull/9704
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2016-11-22 17:27:05 +01:00
Michaël Zasso
52fd49b7ff
deps: update V8 to 5.4.500.43
...
PR-URL: https://github.com/nodejs/node/pull/9697
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-11-22 04:42:31 +01:00
Sam Roberts
3cbb553df8
tools: disallow trailing whitespace for markdown
...
markdown had a dispensation because 2 or more trailing spaces triggers a
new paragraph. There are no examples of that usage in Node, all trailing
whitespace found were mistakes, and the dispensation is now removed.
See: https://github.com/nodejs/node/pull/9620
PR-URL: https://github.com/nodejs/node/pull/9676
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
2016-11-21 09:04:29 -08:00
Ben Noordhuis
13c4f44e97
test: add new.target add-on regression test
...
Add a test that checks that new.target inheritance works when inheriting
from a constructor defined in C++.
PR-URL: https://github.com/nodejs/node/pull/9689
Refs: https://github.com/nodejs/node/issues/9288
Refs: https://github.com/nodejs/node/pull/9293
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-11-21 14:34:25 +01:00
Gibson Fahnestock
515b1f3972
build: default to ppc64 on AIX
...
The ./configure python script searches `gcc -dM -E -` for the ARCH
flags. On AIX, gcc builds in 32 bit mode by default prior to gcc v6, so
you don't get the __PPC64__ flag unless you run `gcc -maix64 -dM -E -`.
We don't support ppc 32 bit for any OS, so always use ppc64 as the
host_arch.
PR-URL: https://github.com/nodejs/node/pull/9645
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-11-21 10:52:51 +00:00
Rich Trott
d6dc2e8d44
test: refactor test-async-wrap-*
...
* `assert.equal()` -> `assert.strictEqual()`
* add duration to `setTimeout()`
PR-URL: https://github.com/nodejs/node/pull/9663
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com >
2016-11-20 20:47:42 -08:00
Gareth Ellis
440057eae0
src: extend HeapStatistics with new fields
...
src: Add does_zap_garbage, malloced_memory and
peak_malloced_memory to v8 HeapStatistics
Following https://github.com/nodejs/code-and-learn/issues/56 I
have exposed does_zap_garbage to HeapStatistics.
The other fields, malloced_memory and peak_malloced_memory don't
seem to be in the current version of v8 in master.
PR-URL: https://github.com/nodejs/node/pull/8610
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-11-20 02:23:00 +01:00
Josh Gavant
31dac410a4
src: fix method name, output format
...
* add additional newline to HTTP GET JSON responses
* SendTargentsListResponse -> SendListResponse
PR-URL: https://github.com/nodejs/node/pull/9627
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-11-20 01:53:15 +01:00
Anna Henningsen
3295a7feba
src: allow getting Symbols on process.env
...
1aa595e5bd introduced a `throw` for accessing `Symbol` properties of
`process.env`. However, this breaks `util.inspect(process)` and
things like `Object.prototype.toString.call(process.env)`, so this
patch changes the behaviour for the getter to just always return
`undefined`.
Ref: https://github.com/nodejs/node/pull/9446
Fixes: https://github.com/nodejs/node/issues/9641
PR-URL: https://github.com/nodejs/node/pull/9631
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-11-20 01:40:33 +01:00
Kirill Fomichev
6b86ecc007
crypto: return this in setAuthTag/setAAD
...
Allow method chaining as with setAutoPadding and other methods.
PR-URL: https://github.com/nodejs/node/pull/9398
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Sam Roberts <sam@strongloop.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-11-20 01:16:26 +01:00
monkick
55cb280265
doc: fix typo in BUILDING.md
...
e.g., to e.g. at BUILDING.md line 116
PR-URL: https://github.com/nodejs/node/pull/9569
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-11-20 01:11:28 +01:00
Anna Henningsen
8a6b37bc51
doc: remove backtick escaping for manpage refs
...
Removing backticks will make the doctool emit links to the man pages.
PR-URL: https://github.com/nodejs/node/pull/9632
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2016-11-20 00:56:25 +01:00
Anna Henningsen
79c382787f
tools: use better regexp for manpage references
...
In practice, manpage names may contain dots (e.g. `resolv.conf(5)`).
PR-URL: https://github.com/nodejs/node/pull/9632
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2016-11-20 00:56:05 +01:00
Rod Vagg
dbf4bf2bec
test: simplify test-http-client-unescaped-path
...
PR-URL: https://github.com/nodejs/node/pull/9649
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-11-20 00:45:18 +01:00
Rahat Ahmed
8f05611a5c
doc: improve description of urlObject.query
...
The description of urlObject.query is ambiguous about when it's an
object vs when it's a string. Added a sentence pointing to the option
that determines this in url.parse().
Also fixed the missing parentheses in the first sentence by rewording it to
avoid nested parentheses.
PR-URL: https://github.com/nodejs/node/pull/9625
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2016-11-19 18:16:48 +01:00
Vse Mozhet Byt
45279947f1
doc: small improvements in readline code examples
...
1. Consistent template literals in `console.log()`.
2. === instead of ==.
3. const instead of var.
PR-URL: https://github.com/nodejs/node/pull/9628
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jackson Tian <shyvo1987@gmail.com >
2016-11-19 18:05:53 +01:00
Aaron Petcoff
f133c16f5d
test: Use strictEqual in test-tls-writewrap-leak
...
PR-URL: https://github.com/nodejs/node/pull/9666
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2016-11-19 17:27:23 +01:00
Kenneth Skovhus
6df167c457
doc: child_process .stdio accepts a String type
...
Document that `execFileSync`, `execSync` and `spawnSync` also support
`stdio` as an Array.
PR-URL: https://github.com/nodejs/node/pull/9637
Fixes: https://github.com/nodejs/node/issues/9636
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Sam Roberts <sam@strongloop.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
2016-11-18 23:42:17 +01:00
JungMinu
be0ce60af6
doc: remove invalid padding from privateEncrypt
...
PR-URL: https://github.com/nodejs/node/pull/9611
Fixes: https://github.com/nodejs/node/issues/9609
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com >
Reviewed-By: Sam Roberts <sam@strongloop.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
2016-11-18 23:37:54 +01:00
imatvieiev
f9c98563da
doc: add return types and props types to OS module
...
PR-URL: https://github.com/nodejs/node/pull/9648
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2016-11-18 23:24:32 +01:00
Ben Noordhuis
6b1a8d03c7
dns: implement {ttl: true} for dns.resolve6()
...
Add an option to retrieve the Time-To-Live of the AAAA record.
PR-URL: https://github.com/nodejs/node/pull/9296
Refs: https://github.com/nodejs/node/issues/5893
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
2016-11-18 22:01:44 +01:00
Ben Noordhuis
c31b507b94
dns: implement {ttl: true} for dns.resolve4()
...
Add an option to retrieve the Time-To-Live of the A record.
PR-URL: https://github.com/nodejs/node/pull/9296
Refs: https://github.com/nodejs/node/issues/5893
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
2016-11-18 22:01:11 +01:00
Ben Noordhuis
b80f05efaa
test: fix memory leaks in malloc cctests
...
Make cctest valgrind-clean again by freeing heap-allocated memory.
Overlooked in commit ea94086 ("src: provide allocation + nullptr check
shortcuts.")
PR-URL: https://github.com/nodejs/node/pull/9667
Refs: https://github.com/nodejs/node/pull/8482
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
2016-11-18 21:57:10 +01:00
Ben Noordhuis
9f779d351f
src: fix memory leak introduced in 34febfbf4
...
Fix leaking the BIO in the error path. Introduced in commit 34febfbf4
("crypto: fix handling of root_cert_store").
PR-URL: https://github.com/nodejs/node/pull/9604
Refs: https://github.com/nodejs/node/pull/9409
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Fedor Indutny <fedor@indutny.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Rod Vagg <rod@vagg.org >
2016-11-18 21:46:13 +01:00
Italo A. Casas
38813c11c6
doc: add italoacasas to collaborators
...
PR-URL: https://github.com/nodejs/node/pull/9677
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2016-11-18 13:24:10 -05:00
Bethany Griggs
06198964e2
test: run tests even if os.cpus() fails
...
Currently if the os.cpus() call fails every test will fail. As there is
already a test for os.cpus(), the other tests should run even if the
os.cpus() call fails.
PR-URL: https://github.com/nodejs/node/pull/9616
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-11-18 17:37:26 +00:00
Sam Roberts
a03074afe4
doc: strip trailing whitespace
...
PR-URL: https://github.com/nodejs/node/pull/9620
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-11-18 09:26:38 -08:00
Sam Roberts
10e5e7abac
doc: fix "either as either" typo
...
PR-URL: https://github.com/nodejs/node/pull/9665
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-11-18 08:54:08 -08:00
Sam Roberts
79f6546df4
doc: fix tls "the the" typo
...
PR-URL: https://github.com/nodejs/node/pull/9665
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-11-18 08:54:04 -08:00
Sam Roberts
cfd6d08227
doc: describe when a tls server emits 'close'
...
PR-URL: https://github.com/nodejs/node/pull/9665
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-11-18 08:53:58 -08:00
Sam Roberts
9dcc7c578e
doc: fix an SNI mistyped as SNS
...
PR-URL: https://github.com/nodejs/node/pull/9665
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-11-18 08:53:46 -08:00
solebox
35d48d3e10
src: squelch unused function warnings in util.h
...
Fixes: https://github.com/nodejs/node/issues/9083
PR-URL: https://github.com/nodejs/node/pull/9115
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-11-18 08:29:56 -08:00
James M Snell
976fe250f5
doc: move TSC and CTC meeting minutes out of core repo
...
The TSC and CTC meeting minutes are more properly placed in
the nodejs/tsc and nodejs/ctc repositories, respectively.
PR-URL: https://github.com/nodejs/node/pull/9503
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
2016-11-18 07:29:31 -08:00
masashi.g
99277952b4
test: use setImmediate() in test of stream2
...
use setImmediate() insted of setTimeout()
in test of stream2 push.
The test is in test/parallel/test-stream2-push.js
Fixes: https://github.com/nodejs/code-and-learn/issues/58
PR-URL: https://github.com/nodejs/node/pull/9583
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org >
2016-11-18 18:21:16 +09:00
Mitsuo Utano
30bf123e41
doc: fix typo in doc/repl.md line: 6
...
fix doc/api/repl.md line 6 "includable" => "includible"
Fixes: https://github.com/nodejs/code-and-learn/issues/58
PR-URL: https://github.com/nodejs/node/pull/9582
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org >
2016-11-18 18:04:14 +09:00
Yoshiya Hinosawa
63e889a256
test: add test case of PassThrough
...
This commit adds the test case of PassThrough.
This test case checks that PassThrough can
construct without new operator.
This is a part of Code And Learn at NodeFest 2016
Fixes: https://github.com/nodejs/code-and-learn/issues/58
PR-URL: https://github.com/nodejs/node/pull/9581
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org >
2016-11-18 17:57:24 +09:00
cjihrig
1fca11e114
deps: upgrade libuv to 1.10.1
...
Fixes: https://github.com/nodejs/node/issues/9542
Fixes: https://github.com/nodejs/node/issues/9546
PR-URL: https://github.com/nodejs/node/pull/9647
Reviewed-By: Imran Iqbal <imran@imraniqbal.org >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Johan Bergström <bugs@bergstroem.nu >
2016-11-17 09:54:16 -05:00
Evan Lucas
21826ef21a
src: use ABORT() macro instead of abort()
...
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.
PR-URL: https://github.com/nodejs/node/pull/9613
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-11-17 07:46:45 -06:00
Sakthipriyan Vairamani (thefourtheye)
c5678d3c32
tools: improve docopen target in Makefile
...
1. As it is, it just tries to build only the `all.html` file. If none of
the other files are built already, generated page will not be good.
To fix this, we process the assets and generate HTML files first.
2. After the HTML is generated, `google-chrome` is used to open the
generated file in browser. This is not very portable as it might not
be installed or installations might have used a different name. So,
we use Python's webbrowser module to open the file.
PR-URL: https://github.com/nodejs/node/pull/9436
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
2016-11-17 17:24:47 +05:30
Anna Henningsen
5dea1e2a5d
fs: export realpathCacheKey from internal/fs
...
Move the internally defined symbol `fs.realpathCacheKey` to
the internal fs module, where it’s more appropriate.
The symbol was recently added in c084287a60 , but since
`internal/fs` is only available in the v7.x branch, this
needs to be a separate follow-up change.
PR-URL: https://github.com/nodejs/node/pull/8862
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-11-16 20:22:18 +01:00