Rich Trott
c42849fde4
debugger: avoid non-ASCII char in code file
...
Avoid non-ASCII char in lib code as a single non-ASCII char forces all
the chars to be stored inefficiently, bloating the binary size. This
also brings the file closer to compatibility with our lint rules.
PR-URL: https://github.com/nodejs/node/pull/38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-05-06 10:33:16 -07:00
Rich Trott
d5f0c83d80
debugger: wrap lines longer than 80 chars
...
Wrap lines more than 80 chararcters long in inspect_repl.js so we can
disable specific rules.
PR-URL: https://github.com/nodejs/node/pull/38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-05-06 10:33:14 -07:00
Juan José Arboleda
75073aba9d
src: make workers messaging more resilient
...
PR-URL: https://github.com/nodejs/node/pull/38510
Fixes: https://github.com/nodejs/node/issues/38499
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-05-06 10:31:56 -07:00
Juan José Arboleda
b373a2c4ba
Revert "worker: remove ERR_CLOSED_MESSAGE_PORT"
...
This reverts commit 73370b4584 .
The unit test is preserved to make sure it does not break
https://github.com/nodejs/node/issues/26463 again.
PR-URL: https://github.com/nodejs/node/pull/38510
Fixes: https://github.com/nodejs/node/issues/38499
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-05-06 10:31:54 -07:00
Rich Trott
bed947b854
debugger: rename inspector-cli test module to debugger
...
PR-URL: https://github.com/nodejs/node/pull/38530
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-05-06 10:19:50 -07:00
Antoine du Hamel
c6dc9319f3
lib: make IterableWeakMap safe to iterate
...
PR-URL: https://github.com/nodejs/node/pull/38523
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-05-06 10:18:50 -07:00
Daniel Bevenius
2ff93c8975
test: skip tests for openssl-3.0.0-alpha15
...
This commit skips some test when OpenSSL 3.0.0-alpha15 is used as there
is an issue that causes them to fail.
This is only a temp solution until there is new OpenSSL release.
Fixes: https://github.com/nodejs/node/issues/38373
PR-URL: https://github.com/nodejs/node/pull/38451
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-05-06 10:19:11 -04:00
Daniel Bevenius
67ea715209
test: update OpenSSL 3.0.0-alpha15 error messages
...
PR-URL: https://github.com/nodejs/node/pull/38451
Fixes: https://github.com/nodejs/node/issues/38373
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-05-06 10:19:00 -04:00
Jordan Baczuk
aed17e963a
doc: fix code example in ecdh.setPublicKey()
...
Fixes: https://github.com/nodejs/node/issues/38540
PR-URL: https://github.com/nodejs/node/pull/38542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-05-05 21:19:27 -07:00
Antoine du Hamel
26e318a321
doc: use HEAD instead of master for links
...
PR-URL: https://github.com/nodejs/node/pull/38518
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-05-05 10:45:30 +02:00
Rongjian Zhang
efd70f4361
test: complete coverage of querystring
...
PR-URL: https://github.com/nodejs/node/pull/38520
Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/querystring.js.html#L179
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-05-04 20:07:54 -07:00
ZiJian Liu
7d74487820
test: increase coverage for AbortController
...
Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/internal/abort_controller.js.html#L126
PR-URL: https://github.com/nodejs/node/pull/38514
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-05-04 20:06:47 -07:00
ZiJian Liu
d5c734587c
test: increase coverage for Blob
...
Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/internal/blob.js.html#L132
PR-URL: https://github.com/nodejs/node/pull/38515
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-05-04 20:04:58 -07:00
Fedor Indutny
7abc7e45b2
node-api: faster threadsafe_function
...
Invoke threadsafe_function during the same tick and avoid marshalling
costs between threads and/or churning event loop if either:
1. There's a queued call already
2. `Push()` is called while the main thread was running
threadsafe_function
PR-URL: https://github.com/nodejs/node/pull/38506
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-05-04 18:39:28 -07:00
Nitzan Uziely
9643128270
doc: clarify DiffieHellmanGroup class docs
...
Make it clearer in the docs that DiffieHellmanGroup does
not support changing the keys after creation.
PR-URL: https://github.com/nodejs/node/pull/38363
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Adrian Estrada <edsadr@gmail.com >
2021-05-04 14:56:32 -07:00
Voltrex
46d83b37ab
typings: add JSDoc typings for readline
...
Added JSDoc typings for the `readline` lib module.
PR-URL: https://github.com/nodejs/node/pull/38253
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-05-04 14:54:52 -07:00
Rich Trott
e8eb6ac31c
doc: fix broken AHAFS link in fs doc
...
The content we're linking to for AHAFS was published in 2011 but has now
been archived. This updates the link to the archived version (as the
current version results in a "Yikes!" page with an HTTP 400 response
code).
Unfortunately, the archived version does say "This content is no
longer being updated or maintained. The content is provided “as is.”
Given the rapid evolution of technology, some content, steps, or
illustrations may have changed." So we'll want to update at some point I
imagine. But for the moment, archived content with a notice like that is
better than a broken link.
PR-URL: https://github.com/nodejs/node/pull/38534
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Ash Cripps <acripps@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-05-04 13:27:53 -07:00
Rich Trott
431d375054
doc: use AIX instead of Aix in fs.md
...
Both for consistency within the doc and to conform with IBM's usage
regarding their on product, refer to the operating system as AIX rather
than Aix.
PR-URL: https://github.com/nodejs/node/pull/38535
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
2021-05-04 13:27:01 -07:00
Richard Lau
3a6116dabb
test: run message and pseudo-tty tests in parallel
...
PR-URL: https://github.com/nodejs/node/pull/38502
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-05-04 13:25:24 -07:00
Antoine du Hamel
b0341512b8
tools: make GH Actions workflows work if default branch is not master
...
PR-URL: https://github.com/nodejs/node/pull/38516
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Mary Marchini <oss@mmarchini.me >
2021-05-04 13:21:20 -07:00
Darshan Sen
f9d6de41a7
build: compile with -std=gnu++14
...
The name ‘gnu++1y’ is deprecated.
Refs: https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html
PR-URL: https://github.com/nodejs/node/pull/38504
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-05-04 13:20:21 -07:00
Rodolfo Carvalho
3219309d50
doc: remove extraneous dash from flag prefix
...
When rendered by `man node`, all flags have a dash prepended to them.
Prior to this change, the man page would incorrectly read
`---unhandled-rejections=mode`
The three dashes is invalid syntax and rejected by the `node` command.
PR-URL: https://github.com/nodejs/node/pull/38532
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-05-04 13:18:18 -07:00
MrJithil
9df904b222
doc: corrected workload name as per the latest VS Installer
...
PR-URL: https://github.com/nodejs/node/pull/38500
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Adrian Estrada <edsadr@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-05-04 13:14:08 -07:00
Michaël Zasso
671c289957
2021-05-04, Version 16.1.0 (Current)
...
Notable changes:
fs:
* (SEMVER-MINOR) allow no-params fsPromises fileHandle read (Nitzan Uziely) https://github.com/nodejs/node/pull/38287
PR-URL: https://github.com/nodejs/node/pull/38522
2021-05-04 17:09:39 +02:00
Rich Trott
f71166bfa2
doc: use sentence case in headers in src/crypto/README.md
...
Use sentence case consistently in headers in src/crypto/README.md.
PR-URL: https://github.com/nodejs/node/pull/38524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2021-05-04 06:33:08 -07:00
Rich Trott
df3465a9e7
test: move test-net-connect-econnrefused from pummel to sequential
...
test-net-connect-econnrefused esems to run quickly on all platforms and
does not appear to need to be in the pummel directory. Move to
sequential.
PR-URL: https://github.com/nodejs/node/pull/38462
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-05-04 05:57:28 -07:00
Rich Trott
18e4f405b1
test: fix flaky inspector-cli tests when breakpionts are restored
...
PR-URL: https://github.com/nodejs/node/pull/38431
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-05-03 08:59:01 -07:00
Luigi Pinca
63c9b5ba9b
tools: use mktemp to create the workspace directory
...
On some platforms, the TMPDIR environment variable is not set.
PR-URL: https://github.com/nodejs/node/pull/38432
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-05-03 14:49:52 +02:00
Antoine du Hamel
2c0fd32db3
debugger: enable linter on internal/inspector/inspect_client
...
PR-URL: https://github.com/nodejs/node/pull/38417
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-05-03 13:57:15 +02:00
Antoine du Hamel
f331a1894f
debugger: refactor internal/inspector/_inspect to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/38406
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-05-03 13:55:51 +02:00
Michaël Zasso
e2708ee491
Revert "doc: os.uptime() temporary bug notice"
...
This reverts commit b9ffb82f9b .
The bug was fixed in libuv 1.41.0.
Refs: https://github.com/libuv/libuv/pull/3072
PR-URL: https://github.com/nodejs/node/pull/38494
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-05-03 13:36:01 +02:00
helloyou2012
d826f6bade
stream: the position of _read() is wrong
...
Fixes: https://github.com/nodejs/node/issues/33940
PR-URL: https://github.com/nodejs/node/pull/38292
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2021-05-03 11:55:52 +02:00
Antoine du Hamel
68e6673224
test,readline: improve tab completion coverage
...
PR-URL: https://github.com/nodejs/node/pull/38465
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-05-02 15:04:57 +02:00
Antoine du Hamel
5cee7cbe02
test: fix common.mustCall length and name properties
...
Reassign `name` and `length` properties to the returned function to not
break code that relies on it.
PR-URL: https://github.com/nodejs/node/pull/38464
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-05-02 11:56:33 +02:00
James M Snell
99099f9147
doc: document 'secureConnect' event limitation
...
Fixes: https://github.com/nodejs/node/issues/10555
Signed-off-by: James M Snell <jasnell@gmail.com >
Refs: https://github.com/nodejs/node/pull/10846
PR-URL: https://github.com/nodejs/node/pull/38447
Reviewed-By: Alba Mendez <me@alba.sh >
Reviewed-By: Adrian Estrada <edsadr@gmail.com >
2021-05-02 09:24:55 +02:00
Luigi Pinca
1226f056d1
tools: use a shallow clone of the npm/cli repository
...
Use a shallow clone instead of cloning the whole repository.
PR-URL: https://github.com/nodejs/node/pull/38463
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2021-05-02 09:22:58 +02:00
Antoine du Hamel
54dfdbcccf
readline: move utilities to internal modules
...
PR-URL: https://github.com/nodejs/node/pull/38466
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-05-02 09:20:18 +02:00
Michaël Zasso
69c57e99f0
deps: V8: cherry-pick fd75c97d3f56
...
Original commit message:
[interpreter] Apply Reflect.apply transform in BytecodeGenerator
Calls with a spread expression in a non-final position get transformed
to calls to Reflect.apply. This transformation is currently done in
the parser, which does not compose well with other features (e.g.
direct eval checking, optional chaining).
Do this transform in the BytecodeGenerator instead.
Bug: v8:11573, v8:11558, v8:5690
Change-Id: I56c90a2036fe5b43e0897c57766f666bf72bc3a8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2765783
Auto-Submit: Shu-yu Guo <syg@chromium.org >
Commit-Queue: Leszek Swirski <leszeks@chromium.org >
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org >
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Cr-Commit-Position: refs/heads/master@{#73534}
Refs: https://github.com/v8/v8/commit/fd75c97d3f56f0e4b8f2842c08b0f8d1c47bed00
PR-URL: https://github.com/nodejs/node/pull/38455
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-05-02 09:06:06 +02:00
XadillaX
9c7aa96703
zlib: fix brotli flush range
...
Fixes: https://github.com/nodejs/node/issues/38407
PR-URL: https://github.com/nodejs/node/pull/38408
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-05-01 16:41:37 -07:00
Ruy Adorno
c975dff3c0
deps: upgrade npm to 7.11.2
...
PR-URL: https://github.com/nodejs/node/pull/38475
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2021-04-30 17:39:15 -04:00
Rich Trott
ff4e782c08
test: address deprecation warning
...
fs.truncateSync() emits a deprecation warning when called with a file
descriptor. Move to fs.ftruncateSync().
PR-URL: https://github.com/nodejs/node/pull/38448
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2021-04-30 13:31:36 -07:00
Yash Ladha
0f5a76f858
inspector: remove redundant method for connection check
...
PR-URL: https://github.com/nodejs/node/pull/37986
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-30 13:29:47 -07:00
Yash Ladha
93f0b4d35b
perf_hooks: add toJSON to performance class
...
Added toJSON method to the InternalPerformance class as per the
convention followed in other performance classes and per the spec:
https://www.w3.org/TR/hr-time/#tojson-method
Fixes: https://github.com/nodejs/node/issues/37623
PR-URL: https://github.com/nodejs/node/pull/37771
Fixes: https://github.com/nodejs/node/issues/37623
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-30 13:28:27 -07:00
Ruben Bridgewater
5bfb6f0564
doc: fix outdated util inspect documentation and layout example
...
The documentation and layout example was not up to date with the
latest changes.
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de >
PR-URL: https://github.com/nodejs/node/pull/37079
Fixes: https://github.com/nodejs/node/issues/37054
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2021-04-30 12:46:50 -07:00
Ruben Bridgewater
942b76d9e5
util: fix infinite recursion during inspection
...
A specially crafted object with circular structures behind getters
could cause a infinite recursion. This is now fixed by detecting the
objects as already visited.
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de >
PR-URL: https://github.com/nodejs/node/pull/37079
Fixes: https://github.com/nodejs/node/issues/37054
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2021-04-30 12:46:48 -07:00
pezhmanparsaee
3c6ff9e149
test: crypto KeyObject.from() ERR_INVALID_ARG_TYPE
...
PR-URL: https://github.com/nodejs/node/pull/37890
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2021-04-30 12:44:49 -07:00
Rich Trott
c7ccab31e5
test: fix flaky test-crypto-timing-safe-dqual-benchmarks
...
Fixes: https://github.com/nodejs/node/issues/38226
PR-URL: https://github.com/nodejs/node/pull/38476
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Ruy Adorno <ruyadorno@github.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-30 11:19:37 -07:00
Antoine du Hamel
40ea8aa364
punycode: add pending deprecation
...
PR-URL: https://github.com/nodejs/node/pull/38444
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2021-04-30 10:59:28 -07:00
Richard Lau
6434cd66bb
doc: mark Node.js 10 as End-of-Life
...
PR-URL: https://github.com/nodejs/node/pull/38482
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2021-04-30 12:06:14 -04:00
James M Snell
d85929c32a
meta: post comment when pr labeled fast-track
...
Signed-off-by: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/38446
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
Reviewed-By: Mary Marchini <oss@mmarchini.me >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2021-04-30 06:43:01 -07:00