Bradley Farias
eb3fee1b87
doc: ensure collaborators validate commits
...
This should be done every time a collaborator pushes a commit.
PR-URL: https://github.com/nodejs/node/pull/16162
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
2017-10-13 13:30:06 -07:00
Bradley Farias
a36aa049c8
src: add internalBindings for binding isolation
...
This commit adds a method to internal/process that allows access to
bindings that are not intended to be used by user code. It has a
separate cache object and modlist in order to avoid collisions.
You can use NODE_MODULE_CONTEXT_AWARE_INTERNAL to register a C++
module as an internal.
PR-URL: https://github.com/nodejs/node/pull/15759
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Refael Ackermann <refack@gmail.com >
2017-10-12 09:13:29 -05:00
Bradley Farias
0fc402b992
module: coverity fixes for ESM C++
...
PR-URL: https://github.com/nodejs/node/pull/15275
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-09-15 15:29:05 -07:00
Bradley Farias
c8a389e19f
module: Allow runMain to be ESM
...
This follows the EPS an allows the node CLI to have ESM as an entry point.
`node ./example.mjs`. A newer V8 is needed for `import()` so that is not
included. `import.meta` is still in specification stage so that also is not
included.
PR-URL: https://github.com/nodejs/node/pull/14369
Author: Bradley Farias <bradley.meck@gmail.com >
Author: Guy Bedford <guybedford@gmail.com >
Author: Jan Krems <jan.krems@groupon.com >
Author: Timothy Gu <timothygu99@gmail.com >
Author: Michaël Zasso <targos@protonmail.com >
Author: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
2017-09-07 15:18:32 -05:00
Bradley Farias
d49e6693fe
url: do not use HandleScope in ToObject
...
It is not needed / invalidates the returned value unlike EscapableHandleScope
PR-URL: https://github.com/nodejs/node/pull/14096
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-17 09:29:30 -04:00
Bradley Farias
757ff8071e
doc: require uses fs root for '/' prefix
...
PR-URL: https://github.com/nodejs/node/pull/11897
Fixes: https://github.com/nodejs/node/issues/7151
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2017-03-21 23:06:52 -07:00
Bradley Farias
608ea94272
doc: package main can be directory with an index
...
This behavior dates back to 2011 but was not documented.
PR-URL: https://github.com/nodejs/node/pull/11581
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: James Snell <jasnell@gmail.com >
2017-03-13 10:28:07 -05:00
Bradley Meck
636935acc7
doc: add bmeck to collaborators
...
PR-URL: https://github.com/nodejs/node/pull/6962
Reviewed-By: Rich Trott <rtrott@gmail.com >
2016-05-25 00:05:44 -05:00
Bradley Meck
41a063f067
test: test preloaded modules using stdin or repl
...
This test fails on Solaris, see the PR for discussion.
PR-URL: https://github.com/nodejs/node/pull/2253
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
2016-05-11 14:33:01 -04:00
Bradley Meck
cd84f399e8
Introduce --link-module to ./configure
...
- Allows specifying a _third_party_main outside of the node repository
- Allows embedders to create custom builtin modules outside of node's
repository
PR-URL: https://github.com/nodejs/node/pull/2497
Reviewed-By: fishrock123 - Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com >
Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com >
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com >
2015-08-28 12:04:39 -04:00
Bradley Meck
2d251e661a
module: fix module preloading when cwd is ENOENT
...
Fixes a regression from 5759722cfahttps://github.com/nodejs/node/issues/1803
PR-URL: https://github.com/nodejs/node/pull/2353
Reviewed-By: Jeremiah Senkpiel <fishrock123@rockemail.com >
2015-08-24 10:46:14 -04:00
Bradley Meck
cf14a2427c
src: add --track-heap-objects
...
- This makes v8 add .trace_function_info to the serialized form of
snapshots from v8::HeapSnapshot::Serialize
- .trace_funciton_info combined with .trace_node in snapshots tells the
JS location that allocated a specific object
PR-URL: https://github.com/nodejs/io.js/pull/2135
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2015-07-10 15:27:07 -06:00
Bradley Meck
6bef15afe7
src: remove traceSyncIO property from process
...
PR-URL: https://github.com/nodejs/io.js/pull/2143
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2015-07-09 17:28:56 +02:00
Bradley Meck
70ad9bbcbd
child_process: make fork() execPath configurable
...
Allows for arbitrary path to executable spawned using `fork`. This
fixes some issues around running multiple versions of node with workers
and allows arbitrary IPC with compatible executables.
Fixes #3248 .
2013-01-06 22:55:30 +01:00
Bradley Meck
d5214b3627
Allow Strings for ports on net.Server.listen
2010-08-30 13:27:38 -07:00
Bradley Farias