 Ruslan Bekenev
|
237a42dd93
|
tools: add custom private key option
Add -i option for release.sh that allows users to specify
non-default private key for ssh and scp commands.
Change argument parsing to getopts.
PR-URL: https://github.com/nodejs/node/pull/14401
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
|
2017-08-27 11:03:50 -03:00 |
|
|
Ruslan Bekenev
|
2710616d53
|
build: remove duplicated code
Makefile contains copy-pasted code in some targets and this commit
aims to remove it.
PR-URL: https://github.com/nodejs/node/pull/13482
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
|
2017-08-16 17:04:23 +02:00 |
|
|
Ruslan Bekenev
|
c53db1e8e9
|
assert: show thrown message in doesNotThrow()
assert.doesNotThrow() should show actual error message instead
of "Got unwanted exception" which is not really helpful.
PR-URL: https://github.com/nodejs/node/pull/12167
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
|
2017-07-19 15:53:26 -04:00 |
|
|
Ruslan Bekenev
|
b23d414c7e
|
tls: do not wrap net.Socket with StreamWrap
Fixes: https://github.com/nodejs/node/issues/3655
PR-URL: https://github.com/nodejs/node/pull/12799
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
|
2017-05-15 19:56:33 +02:00 |
|
|
Ruslan Bekenev
|
896be833c8
|
node: add missing option to --help output
PR-URL: https://github.com/nodejs/node/pull/12763
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
2017-05-03 15:23:15 +02:00 |
|
|
Ruslan Bekenev
|
78e00631dd
|
build: use do_not_edit variable where possible
We should not use hardcoded string to warn users about
file was generated by configure script. Since we already
have do_not_edit variable we can use it
PR-URL: https://github.com/nodejs/node/pull/12610
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
|
2017-04-27 17:24:19 +02:00 |
|
|
Ruslan Bekenev
|
f6b1eb2ec4
|
test: use common.js to check platform
PR-URL: https://github.com/nodejs/node/pull/12629
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
|
2017-04-27 17:15:21 +02:00 |
|
|
Ruslan Bekenev
|
47c255ef68
|
build: run cpplint even if jslint failed
lint target now runs both linters
even if one of them failed.
PR-URL: https://github.com/nodejs/node/pull/12276
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
|
2017-04-14 21:50:09 +03:00 |
|
|
Ruslan Bekenev
|
bd7e0a3f13
|
doc: response.write ignores body in some cases
PR-URL: https://github.com/nodejs/node/pull/12314
Fixes: https://github.com/nodejs/node/issues/8057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
2017-04-14 21:43:19 +03:00 |
|
|
Ruslan Bekenev
|
2e74b0da8f
|
doc: add note that vm module is not a security mechanism
the text added in this commit should warn users about
wrong idea that vm module can be secure to run unsafe scripts
in sandboxes
PR-URL: https://github.com/nodejs/node/pull/11557
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
2017-03-17 11:19:13 -07:00 |
|