BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-14 10:26:26 -04:00
Code Issues Packages Projects Releases Wiki Activity
19,418 Commits 236 Branches 964 Tags
c4c63812822fc973cb3d4bb4040729213dcaa620
Commit Graph
57 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Yorkie Liu 6975c490d1 build: fix shared installing target 
PR-URL: https://github.com/nodejs/node/pull/15148
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-09-28 02:04:12 -03:00
yorkie 1b30df1003 stream: move legacy to lib/internal dir 
Improve readability of lib/stream.js by moving the legacy abstract
Stream into lib/internal/streams/legacy.js.

PR-URL: https://github.com/nodejs/node/pull/8197
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2017-02-01 09:58:51 +01:00
yorkie 7bc6aeac86 dns: remove internal variable from makeAsync 
PR-URL: https://github.com/nodejs/node/pull/8800
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2016-09-30 10:02:39 +08:00
yorkie f4d7abf3bc tls: improve createSecureContext in _tls_common 
- this shares the iterator variable `i` expictly.
- this converts some var to const.

PR-URL: https://github.com/nodejs/node/pull/8781
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-09-28 09:15:27 +08:00
yorkie 33aa953f91 doc: fix title level at tls.md 
PR-URL: https://github.com/nodejs/node/pull/8782
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
 2016-09-27 07:59:49 -07:00
yorkie 8698f691c1 doc,tool: add tls.TLSSocket to typeMap 
We use tls.TLSSocket type in tls.md, so that needs to be added to doctool's typeMap

PR-URL: https://github.com/nodejs/node/pull/8742
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2016-09-27 00:36:56 +08:00
yorkie 13c34a15bd doc: improve child_process doc types 
PR-URL: https://github.com/nodejs/node/pull/8741
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2016-09-27 00:21:35 +08:00
yorkie eaa08062f3 doc,tool: add ref to Integer 
We documented most types as Integer, but we don't have link for that.

PR-URL: https://github.com/nodejs/node/pull/8740
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-09-26 22:26:22 +08:00
yorkie 9a6e253d32 src: remove unneeded ABORT after CHECK 
CHECK includes node::Abort(), so that's unneeded to call ABORT after
CHECK.

PR-URL: https://github.com/nodejs/node/pull/8593
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-09-22 10:18:06 -07:00
yorkie 9b0246b179 timers: remove unreachable code 
PR-URL: https://github.com/nodejs/node/pull/8487
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
 2016-09-15 14:26:42 +08:00
yorkie 68bf02d437 doc: capitalize arguments' type names in url doc 
PR-URL: https://github.com/nodejs/node/pull/8489
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-09-15 14:19:00 +08:00
yorkie ebaa69baf6 doc: fix link on timers.md 
PR-URL: https://github.com/nodejs/node/pull/8488
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-09-11 21:35:31 -07:00
yorkie a3c5567eb4 src,win: use correct exit code in old versions 
If `IsWindows7OrGreater()` returns `false`, the Node.js program should
exit with a more specific code ERROR_EXE_MACHINE_TYPE_MISMATCH instead
the code 0x1(ERROR_INVALID_FUNCTION)

PR-URL: https://github.com/nodejs/node/pull/8204
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-08-31 04:22:43 +08:00
yorkie 10b3f131c2 async_wrap: add a missing case to test-async-wrap-throw-no-init 
PR-URL: https://github.com/nodejs/node/pull/8198
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
 2016-08-26 03:52:19 +08:00
yorkie accaa34377 doc: clarify collaborators & ctc members relationships 
inspired by this conversation
https://github.com/nodejs/node/pull/7183#discussion_r73786541

PR-URL: https://github.com/nodejs/node/pull/7996
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2016-08-08 23:24:48 +08:00
yorkie 99296eedbe http: specify _implicitHeader in OutgoingMessage 
PR-URL: https://github.com/nodejs/node/pull/7949
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2016-08-05 23:26:46 +08:00
yorkie a52b1c0580 doctool: improve the title of pages in doc 
PR-URL: https://github.com/nodejs/node/pull/7939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
 2016-08-04 12:17:58 -07:00
Yazhong Liu 841c7025a9 doc: add yorkie to collaborators 
PR-URL: https://github.com/nodejs/node/pull/7004
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2016-05-27 04:14:37 +08:00
yorkie 6e9a4abb03 doc,events: fix a link typo 
PR-URL: https://github.com/nodejs/node/pull/6640
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
 2016-05-10 06:40:12 -05:00
yorkie 8637c27b77 doc: fix the lint of an example in cluster.md 
PR-URL: https://github.com/nodejs/node/pull/6516
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-05-03 10:13:23 -07:00
yorkie 4e905fa8d5 cluster: remove use of bind() in destroy() 
This commit replaces process.exit.bind() with an arrow function
in Worker.prototype.destroy().

PR-URL: https://github.com/nodejs/node/pull/6502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-05-03 09:31:51 -04:00
Yazhong Liu d3c498b1b7 node: remove unused variables in AppendExceptionLine 
PR-URL: https://github.com/nodejs/node/pull/4264
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2015-12-14 12:38:52 -08:00
yorkie 8c35903ba3 fs,doc: use target instead of destination 
PR-URL: https://github.com/nodejs/node/pull/3912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Bert Belder <bertbelder@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2015-12-05 18:25:05 -08:00
yorkie cc2ceb6cb9 doc: improve child_process.markdown wording 
PR-URL: https://github.com/nodejs/node/pull/4138
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2015-12-04 10:26:29 -08:00
yorkie 2fb34b6132 doc: fix the exception description 
A value shouldn't be described as doing inherit from some class, more
strictly, the value is an instance of the class `Error`.

PR-URL: https://github.com/nodejs/node/pull/3658
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2015-11-30 18:29:52 -08:00
yorkie 8b97249893 fs: fix the error report on fs.link(Sync) 
As the Node.js documentation specified:

> fs.link(srcpath, dstpath, callback)

But when we run:

```js
> fs.link()
```

We will get the below:

```js
TypeError: dest path must be a string
    at TypeError (native)
    at Object.fs.link (fs.js:915:11)
    at repl:1:4
```

Just correct the message of relevant 2 errors in this PR :-)

PR-URL: https://github.com/nodejs/node/pull/3917
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2015-11-20 16:09:09 -08:00
yorkie 72e3dd9f43 process: throw on non-function to nextTick() 
This commit causes process.nextTick() to throw when its callback
argument is not a function.

PR-URL: https://github.com/nodejs/node/pull/3860
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
 2015-11-18 10:52:01 -05:00
Yazhong Liu 1f842c2c61 fs: consider NaN/Infinity in toUnixTimestamp 
PR-URL: https://github.com/nodejs/node/pull/2387
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
 2015-09-14 16:55:15 -06:00
Yazhong Liu 5f33521be5 repl: remove unnecessary check for globals 
There is no need to check for globals and also check if it is
an array.

PR-URL: https://github.com/nodejs/io.js/pull/1722
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2015-05-17 14:03:37 -04:00
Yazhong Liu 6edc900b95 repl: support non-array .scope, document it 
REPL evaluate `.scope` when it needs to get a list of the variable names
available in the current scope. Do not throw if the output of such
evaluation is not array, just ignore it.

PR-URL: https://github.com/nodejs/io.js/pull/1682
Reviewed-By: Fedor Indutny <fedor@indutny.com>
 2015-05-17 12:22:26 +02:00
Yazhong Liu 51d0808c90 stream: remove duplicated expression 
PR-URL: https://github.com/iojs/io.js/pull/1444
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
 2015-04-16 19:26:11 -04:00
Yazhong Liu f8c893dd39 doc: fix confusion markdown in util.markdown 
PR-URL: https://github.com/iojs/io.js/pull/1097
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
 2015-03-08 14:49:06 -07:00
Yazhong Liu ba687f6eb4 url: support path for url.format 
this adds support for a "path" field that overrides
"query", "search", and "pathname" if given.

Fixes: https://github.com/joyent/node/issues/8722
PR-URL: https://github.com/joyent/node/pull/8755
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
 2014-12-02 11:32:08 -08:00
Yazhong Liu d312b6d15c url: support path for url.format 
this adds support for a "path" field that overrides
"query", "search", and "pathname" if given.

Fixes: https://github.com/joyent/node/issues/8722
PR-URL: https://github.com/joyent/node/pull/8755
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
 2014-12-02 10:55:22 -08:00
Yazhong Liu 83d7d9e6d8 buffer: add generic functions for (u)int ops 
Add generic functions for (U)Int read/write operations on Buffers. These
support up to and including 48 bit reads and writes.

Include documentation and tests.

Additional work done by Trevor Norris to include 40 and 48 bit write
support. Because bitwise operations cannot be used on values greater
than 32 bits, the operations have been replaced with mathematical
calculations. Regardless, they are still faster than floating point
operations.

Reviewed-by: Trevor Norris <trev.norris@gmail.com>
 2014-10-03 01:31:20 -07:00
Yazhong Liu 7be96f5285 src: add missing Isolate arguments 
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
 2014-08-19 10:23:20 -07:00
Yazhong Liu 7166b55015 repl: fix overwrite for this._prompt 
Signed-off-by: Fedor Indutny <fedor@indutny.com>
 2014-07-29 12:53:05 +04:00
Yazhong Liu 613654e882 test: fix multiple_line problem in match 
Signed-off-by: Fedor Indutny <fedor@indutny.com>
 2014-07-01 19:04:35 +04:00
Yazhong Liu 6b09f9cd41 node: fix #7841 by overlooking the spare sourceline 
Signed-off-by: Fedor Indutny <fedor@indutny.com>
 2014-06-27 16:09:52 +04:00
Yazhong Liu fcbffa71d0 tls: using %StringSplit to split cert.subjectaltname 
Signed-off-by: Fedor Indutny <fedor@indutny.com>
 2014-06-24 09:55:26 +04:00
Yazhong Liu ab50fad63b http: add 308 status_code, see RFC7238 
Signed-off-by: Fedor Indutny <fedor@indutny.com>
 2014-06-08 10:02:25 -07:00
Yazhong Liu e86c9421ef doc: document url slashes property 
Slashes should be documented, because 3rd-party protocols -- those
postfixed with `://` -- would incorrectly `format` and `parse` if they
didn't set/get the `slashes` option.

Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>
 2014-05-22 09:27:03 -07:00
Yazhong Liu 89cb740fc3 crypto: check protocol version at handshake header 
Signed-off-by: Fedor Indutny <fedor@indutny.com>
 2014-05-16 12:25:03 +04:00
Yazhong Liu e1aa066fe1 readline: fix close event of readline.Interface() 
Not removing 'end' listeners for input and output on the 'close' event
resulted in an EventEmitter related memory leak.

This issue also might be reproduced at:
https://github.com/npm/npm/issues/5203

Signed-off-by: Trevor Norris <trev.norris@gmail.com>
 2014-05-12 14:13:14 -07:00
Yazhong Liu a4f2f9ea8a doc: add spec for util.deprecate() 
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
 2014-05-07 14:56:21 -07:00
Yazhong Liu 940974ed03 net: deduplicate Socket.prototype.address 
Signed-off-by: Fedor Indutny <fedor@indutny.com>
 2014-04-14 20:12:38 +04:00
Yazhong Liu 93c3674ff7 readline: consider newlines for cursor position 
Fixes #7266.
Closes #7279.
 2014-03-12 14:47:17 -03:00
Yazhong Liu cfe0bab85b readline: fix line event, if input emit 'end' 
If an input stream would emit `end` event, like
`fs.createReadStream`, then readline need to get the last line
correctly even though that line isnt ended with `\n`.
 2014-02-17 16:21:29 -08:00
Yazhong Liu c980280159 repl: remove a unnecessary concatenation 2014-02-17 16:04:36 -08:00
Yazhong Liu 3ae0b17c76 repl: REPLServer inherits from readline.Interface 
This exposes a setPrompt for and other readline features
 2014-02-17 16:04:36 -08:00
Yorkie c7f5c98ee9 crypto: remove duplicate ERR_load_crypto_strings() 
ERR_load_crypto_strings() registers the error strings for
all libcrypto functions, SSL_load_error_strings() does the
same, but also registers the libssl error strings.
 2014-01-22 22:55:52 +04:00
Yorkie 8d3bc88bbe querystring: remove name from stringify() 
QueryString.stringify() allowed a fourth argument that was used as a
conditional in the return value, but was undocumented, not used by core
and always was always false/undefiend. So the argument and conditional
have been removed.

Signed-off-by: Trevor Norris <trev.norris@gmail.com>
 2013-12-30 11:41:37 -08:00
Yorkie 59fb0185ec crypto: remove unnecessary OpenSSL_add_all_digests 
`OpenSSL_add_all_algorithms` implicitly adds both digests and
ciphers. No need in calling `OpenSSL_add_all_digests` after it.
 2013-12-19 15:43:21 +04:00
Yorkie 95ee84fabe util: more strict check for bool/number/string 2013-12-18 17:58:02 +04:00
Yazhong Liu 5cfee927cd doc: mention execArgv in setupMaster 2013-12-06 10:45:40 -08:00
Yazhong Liu bd7fa92de4 doc: list execArgv option for child_process.fork() 2013-12-02 13:41:30 -08:00
Yazhong Liu fcfaa392ae doc: net: fix typo in example code 2013-11-30 14:05:45 +01:00