Commit Graph
45185 Commits
Author SHA1 Message Date
Bryan English cac004b65d doc: correct diagnostics_channel built-in channel names
The names listed under the Modules and Process built-in channel sections
did not match the channel names actually published by the runtime, so
subscribing with the documented names produced no events.

Signed-off-by: Bryan English <bryan@bryanenglish.com>
PR-URL: https://github.com/nodejs/node/pull/62995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
2026-07-19 17:31:12 -05:00
Daijiro Wachi ffe8635061 doc: use mjs/cjs blocks for callbackify null reason example
PR-URL: https://github.com/nodejs/node/pull/62884
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2026-07-19 17:31:12 -05:00
Node.js GitHub Bot a1495a9d2f deps: update corepack to 0.34.7
PR-URL: https://github.com/nodejs/node/pull/62810
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2026-07-19 17:31:12 -05:00
Jamie Magee c337233a31 test: export isRiscv64 from common module
isRiscv64 is defined and used internally for the timeout multiplier
but was not exported. Export it alongside the other platform booleans
(isLinux, isFreeBSD, isPi, etc.) so tests can use common.isRiscv64
instead of inlining process.arch checks.

Refs: https://github.com/nodejs/build/issues/4099
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62609
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
2026-07-19 17:31:12 -05:00
semimikoh 78bf3fa476 src: fix crash in GetErrorSource() for invalid using syntax
Signed-off-by: semimikoh <ejffjeosms@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62770
Fixes: https://github.com/nodejs/node/issues/62767
Refs: https://github.com/tc39/test262
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2026-07-19 17:31:12 -05:00
Node.js GitHub Bot 4226fefe08 tools: update gyp-next to 0.22.1
PR-URL: https://github.com/nodejs/node/pull/62961
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2026-07-19 17:31:11 -05:00
7ea06c192b crypto: fix unsigned conversion of 4-byte RSA publicExponent
`bigIntArrayToUnsignedInt` used the signed `<<` operator, so when the
most significant byte of a 4-byte input had its top bit set (e.g.
`[0x80, 0x00, 0x00, 0x01]`) the result was a negative Int32 instead of
the intended unsigned 32-bit value. This caused any RSA `publicExponent`
exactly 4 bytes long with the top bit set to be parsed incorrectly.
Coerce the final value with `>>> 0` and add a unit test.

Assisted-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com>
Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com>
Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62839
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2026-07-19 17:31:11 -05:00
Antoine du Hamel 7066835db6 tools: fix commit linter for semver-major release proposals
PR-URL: https://github.com/nodejs/node/pull/62993
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
2026-07-19 17:31:11 -05:00
Daijiro Wachi eaa817f243 lib: avoid quadratic shift() in startup snapshot callback
PR-URL: https://github.com/nodejs/node/pull/62914
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2026-07-19 17:31:11 -05:00
Mike McCready 4625824cfb doc: correct typo in PR contribution instructions
Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/62738
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2026-07-19 17:31:11 -05:00
Chengzhong Wu ff7b0422e9 meta: add automation policy
PR-URL: https://github.com/nodejs/node/pull/62871
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
2026-07-19 17:31:11 -05:00
Anna Henningsen 9a26db0eb7 src: simplify TCPWrap::Connect signature
Just a little piece of cleanup -- this aligns `TCPWrap::Connect`
with its sibling `TCPWrap::Bind`, deduplicates code and removes
an unnecessary heap allocation.

Signed-off-by: Anna Henningsen <anna@addaleax.net>
PR-URL: https://github.com/nodejs/node/pull/62929
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2026-07-19 17:31:10 -05:00
Daijiro Wachi 1a2ed986f7 doc: fix duplicate word "of of" in postMessageToThread
PR-URL: https://github.com/nodejs/node/pull/62917
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
2026-07-19 17:31:10 -05:00
Daijiro Wachi 99ff83aeab doc: fix duplicate word "for for" in compile cache
PR-URL: https://github.com/nodejs/node/pull/62917
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
2026-07-19 17:31:10 -05:00
Daijiro Wachi da3ac70bcd tools: consolidate and simplify .editorconfig deps section
PR-URL: https://github.com/nodejs/node/pull/62887
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2026-07-19 17:31:10 -05:00
Gürgün Dayıoğlu a0b970af77 url: optimize URLSearchParams set/delete duplicate handling
PR-URL: https://github.com/nodejs/node/pull/62266
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
2026-07-19 17:31:10 -05:00
Gürgün Dayıoğlu 75b0b18e61 process: handle rejections only when needed
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
PR-URL: https://github.com/nodejs/node/pull/62919
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
2026-07-19 17:31:10 -05:00
skooch 5a9b8b3d2a deps: cherry-pick libuv/libuv@439a54b
Original commit message:

    unix: treat futimens() as best-effort in copyfile

    futimens() may fail with EPERM on CIFS/SMB shares that do not
    support setting timestamps. Since preserving timestamps during
    copyfile is best-effort, ignore the return value unconditionally.

    Refs: https://github.com/libuv/libuv/pull/4396

Fixes: https://github.com/nodejs/node/issues/56248
PR-URL: https://github.com/nodejs/node/pull/62881
Refs: https://github.com/libuv/libuv/pull/5053
Refs: https://github.com/libuv/libuv/pull/4396
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
2026-07-19 17:31:09 -05:00
Daijiro Wachi 96800c7c01 doc: fix typo in dns.lookup options description
PR-URL: https://github.com/nodejs/node/pull/62882
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2026-07-19 17:31:09 -05:00
Tim Perry 2ffb92bc35 http: fix leaked error listener on sync HTTP req create + destroy
Previously, this resulted in an error listener being added but not
cleaned up when the socket was freed back to the agent pool.

This also updates the docs to clarify when req.destroy() kills the
underlying socket - only if it's called during request processing (more
specifically: after onSocketNT, at which point we may have started
reading & writing).

Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62872
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2026-07-19 17:31:09 -05:00
Filip Skokan e1df7f5615 lib: harden kKeyOps lookup with null prototype
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62877
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2026-07-19 17:31:09 -05:00
Daijiro Wachi d7d6fdbbb8 http: fix no_proxy leading-dot suffix matching
PR-URL: https://github.com/nodejs/node/pull/62333
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2026-07-19 17:31:09 -05:00
Matteo Collina 94080c81a2 meta: move VoltrexKeyva to emeritus
PR-URL: https://github.com/nodejs/node/pull/62895
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2026-07-19 17:31:08 -05:00
Antoine du Hamel 8931c2a359 tools: set bot as author of tools-deps-update PRs
PR-URL: https://github.com/nodejs/node/pull/62856
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2026-07-19 17:31:08 -05:00
dependabot[bot] e7f59a2655 meta: bump peter-evans/create-pull-request from 8.1.0 to 8.1.1
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 8.1.0 to 8.1.1.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](https://github.com/peter-evans/create-pull-request/compare/c0f553fe549906ede9cf27b5156039d195d2ece0...5f6978faf089d4d20b00c7766989d076bb2fc7f1)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-version: 8.1.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/62845
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2026-07-19 17:31:08 -05:00
dependabot[bot] d3a7b2a817 meta: bump step-security/harden-runner from 2.16.1 to 2.19.0
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.16.1 to 2.19.0.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](https://github.com/step-security/harden-runner/compare/fe104658747b27e96e4f7e80cd0a94068e53901d...8d3c67de8e2fe68ef647c8db1e6a09f647780f40)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-version: 2.19.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/62844
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2026-07-19 17:31:08 -05:00
dependabot[bot] 782b75ba1e meta: bump actions/setup-node from 6.3.0 to 6.4.0
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 6.3.0 to 6.4.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/53b83947a5a98c8d113130e565377fae1a50d02f...48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-version: 6.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/62842
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
2026-07-19 17:31:08 -05:00
Antoine du Hamel e22786e470 module: remove duplicated checks from _resolveFilename
PR-URL: https://github.com/nodejs/node/pull/62729
Reviewed-By: Jacob Smith <jacob@frende.me>
2026-07-19 17:31:08 -05:00
dependabot[bot] 434fe0b23d tools: bump brace-expansion in /tools/clang-format
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion)
from 1.1.12 to 1.1.13.

- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](https://github.com/juliangruber/brace-expansion/compare/v1.1.12...v1.1.13)

---
updated-dependencies:
- dependency-name: brace-expansion
  dependency-version: 1.1.13
  dependency-type: indirect
...

PR-URL: https://github.com/nodejs/node/pull/62467
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2026-07-19 17:31:07 -05:00
Daijiro Wachi e32b026625 stream: ensuring cross-destruction in _duplexify to prevent leaks
PR-URL: https://github.com/nodejs/node/pull/62824
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
2026-07-19 17:31:07 -05:00
Kit DallegeandClaude Opus 4.6 67e6404cee doc: clarify diffieHellman.generateKeys recomputes same key
Clarify that calling generateKeys() after a private key has been
set recomputes the same public key deterministically, rather than
implying the public key changes. The public key is fully determined
by the private key, so the result is identical unless the private
key was changed via setPrivateKey().

Fixes: https://github.com/nodejs/node/issues/56990

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PR-URL: https://github.com/nodejs/node/pull/62205
Fixes: https://github.com/nodejs/node/issues/56990
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
2026-07-19 17:31:07 -05:00
Gerhard Stöbich b4fce608d1 src: use DCHECK in AsyncWrap::MakeCallback instead emiting a warning
Replace emitting of a process warning by a DCHECK because the use after
free in http parser is fixed now.

Refs: https://github.com/nodejs/node/pull/61995#issuecomment-3980534771
Refs: https://github.com/nodejs/node/pull/62095
PR-URL: https://github.com/nodejs/node/pull/62795
Refs: https://github.com/nodejs/node/pull/62095
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2026-07-19 17:31:07 -05:00
om-ghante 8ece7d4722 src: fix MaybeStackBuffer char_traits deprecation warning
On newer libc++ (shipped with macOS Xcode 16+), std::char_traits<T> for
T not equal to char, wchar_t, char8_t, char16_t, or char32_t is
deprecated and will be removed in a future release. When
MaybeStackBuffer is instantiated with unsigned char or uint8_t (e.g. in
test/cctest/test_util.cc), the ToString() and ToStringView() methods
trigger this deprecation warning because their return types reference
std::basic_string<unsigned char> and std::basic_string_view<unsigned
char>, even though these methods are never actually called for those
types.

Convert ToString() and ToStringView() into member function templates
with a constrained default template parameter, so the return type is
only instantiated when the function is actually called. Extract the
type list into a reusable standard_char_type concept.

PR-URL: https://github.com/nodejs/node/pull/62507
Refs: https://github.com/nodejs/node/issues/62506
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2026-07-19 17:31:07 -05:00
Antoine du Hamel 9e1a0bc2d0 doc: remove Ayase-252 and meixg from triagger team
PR-URL: https://github.com/nodejs/node/pull/62841
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
2026-07-19 17:31:07 -05:00
Chengzhong Wu fdac54f0e9 node-api: update libuv ABI stability note
PR-URL: https://github.com/nodejs/node/pull/62789
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2026-07-19 17:31:06 -05:00
eungiandClaude Sonnet 4.6 6963d141c8 doc: clarify dns.lookup() callback signature when all is true
Document the `addresses` argument returned by the callback when
`options.all` is true, and note that `address` and `family` are
not provided in that case. Fixes #57355

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PR-URL: https://github.com/nodejs/node/pull/62800
Fixes: https://github.com/nodejs/node/issues/57355
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
2026-07-19 17:31:06 -05:00
Levi Zim 56903ce09c tools: exclude @node-core/doc-kit from dependabot cooldown
`@node-core/doc-kit` is an internal package maintained within the nodejs
organization, which is unlikely to be a direct source of supply-chain
attack. The cooldown only slow down the propagation of new improvements
from doc-kit to Node.js repo and causes surprises.

The cooldown should be configured in the `doc-kit` repository instead.
Currently there is a 3-day cooldown. Maybe we need to increase that to
match the 5-day cooldown used in this repository.

This patch excludes `@node-core/doc-kit` from the cooldown.
Note that `@node-core/doc-kit` is the only dependency in `tools/doc`.
But to be future proof, I did't remove the cooldown directly.

PR-URL: https://github.com/nodejs/node/pull/62775
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2026-07-19 17:31:06 -05:00
Filip Skokan aafbd6974c test: mark test-snapshot-reproducible flaky
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62808
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2026-07-19 17:31:06 -05:00
Filip Skokan b9d778a2c1 tools: re-enable undici WPTs in daily wpt.fyi job
Refs: https://github.com/nodejs/node/pull/60444
Closes: https://github.com/nodejs/undici/issues/4644

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62677
Fixes: https://github.com/nodejs/undici/issues/4644
Refs: https://github.com/nodejs/node/pull/60444
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2026-07-19 17:31:06 -05:00
René 16db5927da lib: use js-only implementation of isDataView()
PR-URL: https://github.com/nodejs/node/pull/62780
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2026-07-19 17:31:06 -05:00
René 0454a3bb73 src: use context-free V8 message column getters
PR-URL: https://github.com/nodejs/node/pull/62778
Refs: https://issues.chromium.org/issues/42210793
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
2026-07-19 17:31:05 -05:00
Aviv Keller ddc8fe02c6 meta: broaden stale bot
PR-URL: https://github.com/nodejs/node/pull/62658
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2026-07-19 17:31:05 -05:00
Ms2ger de8e6dca08 lib: fix sequence argument handling in Blob constructor
This uses the existing WebIDL infrastructure to handle the iteration
over the argument correctly according to the specification.

Note that we can't avoid looping over the input twice: we only know the
value of the 'endings' option after converting the blob parts into an
array.

PR-URL: https://github.com/nodejs/node/pull/62179
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
2026-07-19 17:31:05 -05:00
Paolo Insogna 521f5aeed4 doc: add experimental modules lifetime policy
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
PR-URL: https://github.com/nodejs/node/pull/62753
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2026-07-19 17:31:05 -05:00
René 0a8aaa1dde test: check contextify contextual store behavior in strict mode
Previously, this behavior was tested indirectly by the REPL tests.
However, REPL now uses DONT_CONTEXTIFY for its VM context.

PR-URL: https://github.com/nodejs/node/pull/62571
Refs: https://github.com/nodejs/node/pull/62371
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2026-07-19 17:31:05 -05:00
Ben Noordhuis 0e83bae7cb node-api: add napi_create_external_sharedarraybuffer
Creates a SharedArrayBuffer from externally managed memory.

Fixes: https://github.com/nodejs/node/issues/62259
PR-URL: https://github.com/nodejs/node/pull/62623
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
2026-07-19 17:31:05 -05:00
Kevin Eady e9e73f56fa node-api: execute tsfn finalizer after queue drains when aborted
A threadsafe function may utilize its context in its `call_js` callback.
The context should be valid during draining of the queue when the
threadsafe function is aborted.

Fixes: https://github.com/nodejs/node/issues/60026
PR-URL: https://github.com/nodejs/node/pull/61956
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2026-07-19 17:31:04 -05:00
Matteo Collina b86fb9073b stream: fix nested compose error propagation
PR-URL: https://github.com/nodejs/node/pull/62556
Fixes: https://github.com/nodejs/node/issues/60083
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2026-07-19 17:31:04 -05:00
Fahad Khan 53fe5a0725 doc: clarify process._debugProcess() in Permission Model
PR-URL: https://github.com/nodejs/node/pull/62537
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2026-07-19 17:31:04 -05:00
Edy Silva 1878e7b675 fs: validate position argument before length === 0 early return
PR-URL: https://github.com/nodejs/node/pull/62674
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2026-07-19 17:31:04 -05:00