BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-14 10:26:26 -04:00
Code Issues Packages Projects Releases Wiki Activity
41,599 Commits 236 Branches 964 Tags
cba170d8833dbf05fa80df13fa95cceb72067a21
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Luigi Pinca a81d83325d test: remove timers from test-tls-socket-close 
Fixes: https://github.com/nodejs/node/issues/49902
PR-URL: https://github.com/nodejs/node/pull/53019
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-05-23 11:51:39 +00:00
Luigi Pinca eaa839ed8a test: add AbortController to knownGlobals 
PR-URL: https://github.com/nodejs/node/pull/53020
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2024-05-18 08:50:47 +00:00
Luigi Pinca a6f9a34c54 doc: replace U+00A0 with U+0020 
Replace NO-BREAK SPACE (U+00A0) with SPACE (U+0020) in `doc/api/net.md`.

PR-URL: https://github.com/nodejs/node/pull/52590
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2024-04-21 09:03:50 +00:00
Luigi Pinca ba9e1e0ffb doc: sort options alphabetically 
Sort options alphabetically in `doc/api/net.md`.

PR-URL: https://github.com/nodejs/node/pull/52589
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2024-04-21 08:55:04 +00:00
Luigi Pinca 580aae58f6 test: ensure that all worker servers are ready 
Wait for the `'listening'` message from all workers before creating the
first connection. This fixes an `EMFILE` error that is raised on Windows
when running the following command

```
python tools/test.py -J --repeat=1000 parallel/test-tls-ticket-cluster
```

PR-URL: https://github.com/nodejs/node/pull/52563
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2024-04-19 09:17:19 +00:00
Luigi Pinca c02de658a1 stream: make Duplex inherit destroy from Writable 
Make `Duplex` inherit the `destroy` method from `Writable` instead of
`Readable` so that pending write callbacks are correctly invoked when
the stream is destroyed.

PR-URL: https://github.com/nodejs/node/pull/52318
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2024-04-05 18:34:33 +00:00
Luigi Pinca 3a456c6db8 Revert "build: fix warning in cares under GN build" 
This reverts commit f22802ceb8.

PR-URL: https://github.com/nodejs/node/pull/51865
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2024-03-03 06:29:16 +00:00
Luigi Pinca 5c97f411d8 test: remove flaky designation 
Searching the automatically-generated test failure reports in the issues
at https://github.com/nodejs/reliability/issues, I don't see
`test-worker-message-port-message-before-close` failing any time
recently.

PR-URL: https://github.com/nodejs/node/pull/51736
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2024-03-02 11:46:24 +00:00
Luigi Pinca c1fa929f39 test: remove test-fs-stat-bigint flaky designation 
Refs: https://github.com/nodejs/node/issues/31727#issuecomment-985589968
PR-URL: https://github.com/nodejs/node/pull/51735
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2024-02-22 18:33:14 +00:00
Luigi Pinca 6db72fcae4 test: remove test-cli-node-options flaky designation 
The last trace of failure dates back to 2023-09-24.

Fixes: https://github.com/nodejs/node/issues/50295
PR-URL: https://github.com/nodejs/node/pull/51716
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2024-02-17 06:44:18 +00:00
Luigi Pinca 78273ed0d1 test: remove test-domain-error-types flaky designation 
There is no recent trace of failure for this test.

Fixes: https://github.com/nodejs/node/issues/38063
PR-URL: https://github.com/nodejs/node/pull/51717
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2024-02-16 19:27:04 +00:00
Luigi Pinca 0f80e29419 test: remove duplicate entry for flaky test 
Refs: https://github.com/nodejs/node/blob/5acd42ed9e65/test/parallel/parallel.status#L28-L30
PR-URL: https://github.com/nodejs/node/pull/51654
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
 2024-02-05 17:55:45 +00:00
Luigi Pinca 415aa77083 test: remove test-crypto-keygen flaky designation 
Refs: https://github.com/nodejs/node/issues/41206#issuecomment-1858836845
PR-URL: https://github.com/nodejs/node/pull/51567
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2024-02-03 09:42:22 +00:00
Luigi Pinca a7eb72d23d test: remove test-fs-rmdir-recursive flaky designation 
Refs: https://github.com/nodejs/node/issues/41201#issuecomment-1858836768
PR-URL: https://github.com/nodejs/node/pull/51566
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2024-02-01 07:13:03 +00:00
Luigi Pinca 6ab15a1aa8 test: remove test-file-write-stream4 flaky designation 
Recent failures seem to be only caused by insufficient space left on the
device.

PR-URL: https://github.com/nodejs/node/pull/51472
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2024-01-17 19:17:14 +00:00
Luigi Pinca a568aaaea6 deps: add nghttp3/**/.deps to .gitignore 
PR-URL: https://github.com/nodejs/node/pull/51400
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2024-01-08 08:23:08 +00:00
Luigi Pinca 8bb30274db watch: clarify that the fileName parameter can be null 
Add a comment to clarify that the `fileName` parameter can be `null` if
the file name cannot be determined.

PR-URL: https://github.com/nodejs/node/pull/51305
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-12-30 21:30:15 +00:00
Luigi Pinca 30f8ef1a97 http: remove misleading warning 
There are cases where the `'clientError'` event can be emitted multiple
times, even if the socket is correctly destroyed.

Fixes: https://github.com/nodejs/node/issues/51073
PR-URL: https://github.com/nodejs/node/pull/51204
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
 2023-12-21 20:09:01 +00:00
Luigi Pinca 40715481bf test: use tmpdir.refresh() in test-esm-loader-resolve-type.mjs 
Use `tmpdir.refresh()` in
`test/es-module/test-esm-loader-resolve-type.mjs` so that the temporary
directory is removed when the test exits.

PR-URL: https://github.com/nodejs/node/pull/51206
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2023-12-20 18:17:31 +00:00
Luigi Pinca 0390a1de66 test: use tmpdir.refresh() in test-esm-json.mjs 
Use `tmpdir.refresh()` in `test/es-module/test-esm-json.mjs` so that
the temporary directory is removed when the test exits.

PR-URL: https://github.com/nodejs/node/pull/51205
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-12-20 17:47:39 +00:00
Luigi Pinca 053f36855a dns: call handle.setServers() with a valid array 
`handle.setServers()` takes an array, not a string.

PR-URL: https://github.com/nodejs/node/pull/50811
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2023-11-21 20:56:02 +00:00
Luigi Pinca 95534ad82f build: fix build with Python 3.12 
Replace `distutils.version.StrictVersion` with
`packaging.version.Version`.

Refs: https://github.com/nodejs/node/pull/50209#issuecomment-1795852539
PR-URL: https://github.com/nodejs/node/pull/50582
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-11-08 20:20:53 +00:00
Luigi Pinca 3e3467e77a test: relax version check with shared OpenSSL 
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.

Fixes: https://github.com/nodejs/node/issues/43078
PR-URL: https://github.com/nodejs/node/pull/50505
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-11-08 20:20:43 +00:00
Luigi Pinca a037b88561 doc: recommend supported Python versions 
Refs: https://github.com/nodejs/node/pull/50209#issuecomment-1781016950
PR-URL: https://github.com/nodejs/node/pull/50407
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-11-01 13:41:03 +00:00
Luigi Pinca 0345ea5928 test: reduce the number of requests and parsers 
The maximum number of parsers in the free list is set to 1000. However
the test does not need to use this maximum. Reduce it to 50.

Refs: https://github.com/nodejs/node/pull/50228#issuecomment-1768293624
PR-URL: https://github.com/nodejs/node/pull/50240
Fixes: https://github.com/nodejs/node/issues/49564
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2023-10-20 12:56:44 +00:00
Luigi Pinca b1ada0ad55 tls: handle cases where the raw socket is destroyed 
Ensure that the `'close'` event is emitted on a `TLSSocket` when it is
created from an existing raw `net.Socket` and the raw socket is not
closed cleanly (destroyed).

Refs: https://github.com/nodejs/node/commit/048e0bec5147
Refs: https://github.com/nodejs/node/issues/49902#issuecomment-1741203813
Fixes: https://github.com/nodejs/node/issues/49902
PR-URL: https://github.com/nodejs/node/pull/49980
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2023-10-04 14:19:42 +00:00
Luigi Pinca f05d6d090c Revert "test: mark test-runner-output as flaky" 
This reverts commit 717e233cd9.

Refs: https://github.com/nodejs/node/commit/fef7927cc3a7
PR-URL: https://github.com/nodejs/node/pull/49905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-09-30 15:43:14 +00:00
Luigi Pinca 480ab8c3a4 Revert "test: mark test-http-regr-gh-2928 as flaky" 
This reverts commit 48fcb205e4.

Refs: https://github.com/nodejs/node/commit/18e00a577d74
PR-URL: https://github.com/nodejs/node/pull/49708
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
 2023-09-20 18:31:47 +00:00
Luigi Pinca 18e00a577d test: deflake test-http-regr-gh-2928 
Hard code the value of the host parameter to `common.localhostIPv4` in
`server.listen()` and `net.connect()`. This

1. ensures that the client `socket._handle` is not reinitialized during
   connection due to the family autodetection algorithm, preventing
   `parser.consume()` from being called with an invalid `socket._handle`
   parameter.
2. works around an issue in the FreeBSD 12 machine where the stress test
   is run where some sockets get stuck after connection.

PR-URL: https://github.com/nodejs/node/pull/49574
Closes: https://github.com/nodejs/node/pull/49565
Fixes: https://github.com/nodejs/node/issues/49564
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-09-18 20:16:24 +02:00
Luigi Pinca ccf46ba0f5 test: deflake test-tls-socket-close 
Move the check for the destroyed state of the remote socket to the inner
`setImmediate()`.

Refs: https://github.com/nodejs/node/pull/49327#issuecomment-1712525257
PR-URL: https://github.com/nodejs/node/pull/49575
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-09-13 06:04:39 +00:00
Luigi Pinca ae115d68e0 zlib: disable CRC32 SIMD optimization 
It seems that the optimization causes memory corruption. Disable it
until the issue is fixed upstream.

Fixes: https://github.com/nodejs/node/issues/45268
PR-URL: https://github.com/nodejs/node/pull/49511
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-09-10 05:44:49 +00:00
Luigi Pinca 26bfae531f test: deflake test-net-throttle 
Sometimes the test completes with only two data chunks received on the
client.

Fixes: https://github.com/nodejs/node/issues/40507
PR-URL: https://github.com/nodejs/node/pull/48599
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
 2023-07-12 12:17:19 +00:00
Luigi Pinca 01233410f7 test: move test-net-throttle to parallel 
The test is not very resource intensive. It just writes data to a TCP
socket until backpressure is reached. Move it parallel.

PR-URL: https://github.com/nodejs/node/pull/48599
Fixes: https://github.com/nodejs/node/issues/40507
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
 2023-07-12 12:17:18 +00:00
Luigi Pinca 08638b74ec Revert "test: remove test-crypto-keygen flaky designation" 
This reverts commit 893c000046.

Refs: https://github.com/nodejs/node/pull/48575#issuecomment-1620267554
PR-URL: https://github.com/nodejs/node/pull/48652
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
 2023-07-05 16:30:30 +00:00
Luigi Pinca 1aabfa8732 doc: fix options order 
Move the `joinDuplicateHeaders` option to the correct alphabetical
order.

PR-URL: https://github.com/nodejs/node/pull/48617
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-07-03 06:20:24 +00:00
Luigi Pinca 651c02cbbc http: null the joinDuplicateHeaders property on cleanup 
Null the `joinDuplicateHeaders` property when the parser is freed.

Refs: https://github.com/nodejs/node/pull/45982
PR-URL: https://github.com/nodejs/node/pull/48608
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
 2023-07-03 06:20:13 +00:00
Luigi Pinca 893c000046 test: remove test-crypto-keygen flaky designation 
PR-URL: https://github.com/nodejs/node/pull/48575
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2023-06-29 08:47:12 +00:00
Luigi Pinca 300634d33d test: remove test-timers-immediate-queue flaky designation 
PR-URL: https://github.com/nodejs/node/pull/48575
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2023-06-29 08:47:11 +00:00
Luigi Pinca d09ff0db70 fs: remove unneeded return statement 
The `writable._write()` implementation does not need to return anything,
only call the callback.

PR-URL: https://github.com/nodejs/node/pull/48526
Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
 2023-06-26 09:01:35 +00:00
Luigi Pinca c308054aaa test: mark test-child-process-stdio-reuse-readable-stdio flaky 
Refs: https://github.com/nodejs/node/issues/48300#issuecomment-1604531463
Refs: https://github.com/nodejs/reliability/issues/597#issue-1772339022
PR-URL: https://github.com/nodejs/node/pull/48537
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-06-25 11:08:07 +00:00
Luigi Pinca e7646a5dc0 tools: replace sed with perl 
For cross-platform compatibility use perl instead of sed.

Fixes: https://github.com/nodejs/node/issues/48496
PR-URL: https://github.com/nodejs/node/pull/48499
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-06-20 09:11:55 +00:00
Luigi Pinca d15652e959 test: ignore the copied entry_point.c 
Add `test_cannot_run_js/entry_point.c` to
`test/js-native-api/.gitignore`.

PR-URL: https://github.com/nodejs/node/pull/48297
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-06-06 16:22:18 +00:00
Luigi Pinca f351c8a6c1 test: refactor test-gc-http-client-timeout 
Due to server response delay, all possible requests are created anyway.
Instead of doing `36 * os.availableParallelism()` requests, use a fixed
number.

Refs: https://github.com/nodejs/node/pull/48078#issuecomment-1568183115
PR-URL: https://github.com/nodejs/node/pull/48292
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
 2023-06-06 15:42:42 +00:00
Luigi Pinca 0919b5e277 tools: disable jsdoc/no-defaults rule 
PR-URL: https://github.com/nodejs/node/pull/48328
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2023-06-06 02:04:57 +00:00
Luigi Pinca 6a6b3c5402 test: fix zlib version regex 
Add support for subrevision in the regular expression for the zlib
version.

Refs: https://github.com/madler/zlib/blob/48c3741002ac/zlib.h#L40
PR-URL: https://github.com/nodejs/node/pull/48227
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-05-30 06:11:06 +00:00
Luigi Pinca 20080f9a19 test: use lower security level in s_client 
With the default security level (SECLEVEL=2), the following error

```
40E72B52DB7F0000:error:0A00018A:SSL routines:tls_process_ske_dhe:dh key
too small:../deps/openssl/openssl/ssl/statem/statem_clnt.c:2100
```

is raised on on Ubuntu 22.04 on WSL2.

PR-URL: https://github.com/nodejs/node/pull/48192
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-05-29 19:23:40 +00:00
Luigi Pinca 4aa17bc8dd tools: use shasum instead of sha256sum 
By default, there is no sha256sum command in macOS.

PR-URL: https://github.com/nodejs/node/pull/48229
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-05-29 19:15:08 +00:00
Luigi Pinca 95d24292ed tools: fix zconf.h path 
Use the `DEPS_DIR` variable to build the path instead of hardcoding it.

PR-URL: https://github.com/nodejs/node/pull/48089
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2023-05-21 16:58:01 +00:00
Luigi Pinca 509b1eb3aa doc: do not create a backup file 
The `sed -i -- 's_^#include "chromeconf.h"_//#include "chromeconf.h"_' deps/zlib/zconf.h`
command creates a `zconf.h--` backup file on macOS. Replace it with an
equivalent perl one-liner so that it works on both Linux and macOS.

PR-URL: https://github.com/nodejs/node/pull/47151
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-04-06 16:42:34 +02:00
Luigi Pinca be2791b512 deps: update zlib to upstream 5edb52d4 
Updated as described in doc/contributing/maintaining-zlib.md.

Refs: https://github.com/nodejs/node/pull/45387#issuecomment-1462728879
PR-URL: https://github.com/nodejs/node/pull/47151
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-04-06 16:42:26 +02:00
Luigi Pinca 47cd966104 doc: add documentation for socket.destroySoon() 
PR-URL: https://github.com/nodejs/node/pull/46337
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-01-28 06:00:45 +00:00
Luigi Pinca 20359cc563 deps: add /deps/**/.github/ to .gitignore 
- Ignore `.github` directories in the `deps` directory.
- Remove `deps/base64/base64/.github/`.

PR-URL: https://github.com/nodejs/node/pull/46091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-01-11 19:29:33 +00:00
Luigi Pinca 6668c4dfb8 tools: move update-eslint.sh to dep_updaters/ 
Move the `update-eslint.sh` script to the `dep_updaters/` directory.

PR-URL: https://github.com/nodejs/node/pull/46088
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-01-06 09:14:30 +00:00
Luigi Pinca 7f2ef89fab tools: make update-eslint.sh work with npm@9 
Make the `update-eslint.sh` script work with `npm@9`.

PR-URL: https://github.com/nodejs/node/pull/46088
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-01-06 09:14:29 +00:00
Luigi Pinca 50f8de27a4 Revert "deps: fix zlib compilation for CPUs without SIMD features" 
This reverts commit 26991f795d.

PR-URL: https://github.com/nodejs/node/pull/45589
Fixes: https://github.com/nodejs/node/issues/32856
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2022-12-04 08:14:09 +00:00
Luigi Pinca c89f9d3fd4 doc: sort http.createServer() options alphabetically 
PR-URL: https://github.com/nodejs/node/pull/45680
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2022-12-01 17:37:50 +00:00
Luigi Pinca c74dbd2936 crypto: update root certificates 
Update the list of root certificates in src/node_root_certs.h with
tools/mk-ca-bundle.pl.

Certificates added:
- Autoridad de Certificacion Firmaprofesional CIF A62634068
- Certainly Root E1
- Certainly Root R1
- D-TRUST BR Root CA 1 2020
- D-TRUST EV Root CA 1 2020
- DigiCert TLS ECC P384 Root G5
- DigiCert TLS RSA4096 Root G5
- E-Tugra Global Root CA ECC v3
- E-Tugra Global Root CA RSA v3
- HiPKI Root CA - G1
- ISRG Root X2
- Security Communication ECC RootCA1
- Security Communication RootCA3
- Telia Root CA v2
- vTrus ECC Root CA
- vTrus Root CA

Certificates removed:
- Cybertrust Global Root
- DST Root CA X3
- GlobalSign Root CA - R2
- Hellenic Academic and Research Institutions RootCA 2011

PR-URL: https://github.com/nodejs/node/pull/45490
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2022-11-18 20:12:34 +00:00
Luigi Pinca 0b5acaabbb tools: update certdata.txt 
This is the certdata.txt[0] from NSS 3.85, released on 2022-11-10.

This is the version of NSS that will ship in Firefox 108 on
2022-12-13.

[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_85_RTM/lib/ckfw/builtins/certdata.txt

PR-URL: https://github.com/nodejs/node/pull/45490
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2022-11-18 20:12:33 +00:00
Luigi Pinca b6c108f092 deps: update zlib to upstream 8bbd6c31 
Updated as described in doc/contributing/maintaining-zlib.md.

PR-URL: https://github.com/nodejs/node/pull/45387
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2022-11-16 19:59:11 +00:00
Luigi Pinca 01e673c7f6 tools: allow scripts to run from anywhere 
Make the `update-cares.sh`, `update-llhttp.sh`, `update-nghttp2.sh`,
and `update-npm.sh` scripts work even if they are run outside of the
`tools` directory.

PR-URL: https://github.com/nodejs/node/pull/45361
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-11-09 14:17:44 +00:00
Luigi Pinca 28bf0317c2 deps: upgrade to libuv 1.44.2 
Notable changes:

- Build regression fixes for various platform updates
  (https://github.com/libuv/libuv/pull/3428,
  https://github.com/libuv/libuv/pull/3419,
  https://github.com/libuv/libuv/pull/3423,
  https://github.com/libuv/libuv/pull/3413,
  https://github.com/libuv/libuv/pull/3431)
- Support for GNU/Hurd (https://github.com/libuv/libuv/pull/3450)
- Release tool improvements
  (https://github.com/libuv/libuv-release-tool/pull/13)
- Better performing rw locks on Win32 (https://github.com/libuv/libuv/pull/3383)
- Support for posix_spawn API (https://github.com/libuv/libuv/pull/3257)
- Fix regression on OpenBSD (https://github.com/libuv/libuv/pull/3506)
- Add uv_available_parallelism() (https://github.com/libuv/libuv/pull/3499)
- Don't use thread-unsafe strtok() (https://github.com/libuv/libuv/pull/3524)
- Fix hang after NOTE_EXIT (https://github.com/libuv/libuv/pull/3521)
- Better align order-of-events behavior between platforms
  (https://github.com/libuv/libuv/pull/3598)
- Fix fs event not fired if the watched file is moved/removed/recreated
  (https://github.com/libuv/libuv/pull/3540)
- Fix pipe resource leak if closed during connect (and other bugs)
  (https://github.com/libuv/libuv/pull/3611)
- Don't error when killing a zombie process
  (https://github.com/libuv/libuv/pull/3625)
- Avoid posix_spawnp() cwd bug (https://github.com/libuv/libuv/pull/3597)
- Skip EVFILT_PROC events when invalidating events for an fd
  (https://github.com/libuv/libuv/pull/3629)

Fixes: https://github.com/nodejs/node/issues/42290
PR-URL: https://github.com/nodejs/node/pull/42340
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-11-05 19:53:50 +01:00
Luigi Pinca 65ec9f35e9 test: defer invocation checks 
Do not immediately check the `tcpserver` hook invocations when it
closes. Do it in the next iteration of the event loop.

PR-URL: https://github.com/nodejs/node/pull/42340
Refs: https://github.com/nodejs/node/pull/42340#issuecomment-1290964192
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-11-05 19:53:24 +01:00
Luigi Pinca 8dd635eb41 lib: use process.nextTick() instead of setImmediate() 
Do not delay the call to `stream.end()` too much.

PR-URL: https://github.com/nodejs/node/pull/42340
Refs: https://github.com/nodejs/node/pull/42340#issuecomment-1261163284
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-11-05 19:53:13 +01:00
Luigi Pinca 60de1476ea test: fix test-socket-write-after-fin-error 
The `'error'` event is not emitted because the socket is already
destroyed when `socket.write()` is called. Use the `socket.write()`
callback instead.

PR-URL: https://github.com/nodejs/node/pull/42340
Refs: https://github.com/nodejs/node/pull/42340#issuecomment-1182387070
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-11-05 19:53:03 +01:00
Luigi Pinca 58431c0e6b os: convert uid and gid to 32-bit signed integers 
Make `os.userInfo()` convert the `uid` and `gid` fields to 32-bit signed
integers on Windows.

PR-URL: https://github.com/nodejs/node/pull/42340
Refs: https://github.com/libuv/libuv/commit/f3e0bffcb14
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-11-05 19:52:50 +01:00
Luigi Pinca cfd4c43a1e tools: use Python 3.11 in GitHub Actions workflows 
PR-URL: https://github.com/nodejs/node/pull/45191
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2022-10-28 18:35:50 +00:00
Luigi Pinca cf748ad2b7 build: support Python 3.11 
PR-URL: https://github.com/nodejs/node/pull/45191
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2022-10-28 18:35:49 +00:00
Luigi Pinca ef1771183e tools: update gr2m/create-or-update-pull-request-action 
Update gr2m/create-or-update-pull-request-action to version 1.9.1.

PR-URL: https://github.com/nodejs/node/pull/45022
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-10-19 06:25:07 +00:00
Luigi Pinca 7ed44db558 tools: do not use the set-output command in workflows 
The `set-output` command is deprecated. Use the `GITHUB_OUTPUT`
environment file.

Refs: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
PR-URL: https://github.com/nodejs/node/pull/45024
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-19 06:24:58 +00:00
Luigi Pinca 7c06eab1dc Revert "http: do not leak error listeners" 
This reverts commit 736a7d8d60.

The patch attempted to fix an issue, signaled by a warning, caused by
an invalid API usage. However it introduced a behavior change that is
breaking userland modules.

It is a user error, so restore the original behavior and have the user
investigate and fix the issue in their code.

Refs: https://github.com/nodejs/node/pull/43587#issuecomment-1272092166
Refs: https://github.com/nodejs/node/pull/43587#issuecomment-1272094883
PR-URL: https://github.com/nodejs/node/pull/44921
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2022-10-12 12:16:56 +00:00
Luigi Pinca 5d92ddc8b1 tools: fix typo in update-nghttp2.sh 
PR-URL: https://github.com/nodejs/node/pull/44664
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-09-16 13:28:04 +00:00
Luigi Pinca aa3d3b7630 doc: fix errors in http.md 
Fixes: https://github.com/nodejs/node/issues/44567
PR-URL: https://github.com/nodejs/node/pull/44587
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Mestery <mestery@protonmail.com>
 2022-09-12 19:29:30 +00:00
Luigi Pinca f9bfe785ee test: use python3 instead of python 
On some platforms, such as macOS, the `python` command is no longer
available by default.

PR-URL: https://github.com/nodejs/node/pull/44545
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-09-10 13:43:46 +00:00
Luigi Pinca f9cf4b6490 test: remove duplicate test 
The test in `test/parallel/test-stream-writable-callback-twice.js` is
duplicated in `test/parallel/test-stream-writable-write-cb-twice.js`.

PR-URL: https://github.com/nodejs/node/pull/44313
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2022-08-24 20:23:20 +00:00
Luigi Pinca e0191ca9fb doc: add history for net.createServer() options 
Fixes: https://github.com/nodejs/node/issues/44298
PR-URL: https://github.com/nodejs/node/pull/44326
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-08-23 15:38:45 +00:00
Luigi Pinca 2b32985c62 stream: use null for the error argument 
When no error occurs, use `null` instead of `undefined` for the `error`
argument of the `writable.write()` and `writable.end()` callbacks.

Fixes: https://github.com/nodejs/node/issues/44290
PR-URL: https://github.com/nodejs/node/pull/44312
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2022-08-23 07:51:53 +00:00
Luigi Pinca 679cad96ca tools: update ESLint to 8.22.0 
PR-URL: https://github.com/nodejs/node/pull/44243
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-08-17 12:05:06 +00:00
Luigi Pinca b2f4a55770 test: remove test-http-client-response-timeout flaky designation 
The issue was fixed by https://github.com/nodejs/node/pull/43890.

Fixes: https://github.com/nodejs/node/issues/43680
PR-URL: https://github.com/nodejs/node/pull/44145
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
 2022-08-07 12:26:50 +00:00
Luigi Pinca 57ff476c33 test: remove duplicate test 
`test/parallel/test-http-agent-no-wait.js` is basically a duplicate of
`test/parallel/test-http-client-close-with-default-agent.js`, remove it.

PR-URL: https://github.com/nodejs/node/pull/44051
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-07-31 12:46:06 +01:00
Luigi Pinca ed7631dae9 doc: remove bullet point referring to Node.js 12 
Refs: https://github.com/nodejs/node/pull/43734#pullrequestreview-1033019134

PR-URL: https://github.com/nodejs/node/pull/43744
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2022-07-12 05:27:22 +01:00
Luigi Pinca 8c4cf96967 doc: update default branch name in test/** 
Refs: https://github.com/nodejs/node/issues/33864

PR-URL: https://github.com/nodejs/node/pull/43445
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-06-17 10:49:22 +02:00
Luigi Pinca 7bf50bc26a doc: update main branch name in doc/contributing/* 
Refs: https://github.com/nodejs/node/issues/33864

PR-URL: https://github.com/nodejs/node/pull/43438
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-06-16 14:10:56 +01:00
Luigi Pinca f7d55b9d6b meta: add mailmap entry for npm team 
PR-URL: https://github.com/nodejs/node/pull/43143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-05-19 18:06:50 +01:00
Luigi Pinca efcf07fb07 meta: add mailmap entry for Morgan Roderick 
PR-URL: https://github.com/nodejs/node/pull/43144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-19 13:43:39 +01:00
Luigi Pinca 02e0c174a4 test: simplify test-gc-{http-client,net}-* 
Instead of sending/creating a fixed number of requests/connections,
detect when GC has started and stop sending requests/creating
connections at that point.

Refs: https://github.com/nodejs/node/commit/47ecf2060343
Refs: https://github.com/nodejs/node/commit/7ce8403ef1a6

PR-URL: https://github.com/nodejs/node/pull/42782
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-04-29 21:17:47 +02:00
Luigi Pinca e2ff1c3b2c build: improve reliability of find_python.cmd script 
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: https://github.com/nodejs/node/issues/42801

PR-URL: https://github.com/nodejs/node/pull/42810
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-04-23 20:45:27 +01:00
Luigi Pinca bde889bd4e doc: add documentation for inherited methods 
These methods are inherited from `http.OutgoingMessage` and
they are already documented as methods of the `http.ServerResponse`
class. For consistency, document them also as methods of the
`http.ClientRequest` class.

PR-URL: https://github.com/nodejs/node/pull/42691
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Mestery <mestery@protonmail.com>
 2022-04-18 19:49:05 +01:00
Luigi Pinca 0699150267 doc: copyedit http.OutgoingMessage documentation 
Fix nits/typos and simplify some sentences.

PR-URL: https://github.com/nodejs/node/pull/42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-04-17 20:23:55 +01:00
Luigi Pinca 86b3191bcd doc: fix added: info for outgoingMessage.writable* 
- `outgoingMessage.writableCorked` was added to Node.js v13.2.0 via
  62e15a793a and backported to Node.js v12.16.0 via db8144be31.
- `outgoingMessage.writableEnded` was added to Node.js v12.9.0 via
  f9b61d2bc7.
- `outgoingMessage.writableFinished` was added to Node.js v12.7.0 via
  06d0abea0d.
- `outgoingMessage.writableHighWaterMark`,
  `outgoingMessage.writableLength`, and
  `outgoingMessage.writableObjectMode` were added to Node.js v12.9.0 via
  16e001112c.

PR-URL: https://github.com/nodejs/node/pull/42737
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
 2022-04-17 07:31:47 +01:00
Luigi Pinca 76e7170a40 doc: document the 'close' and 'finish' events 
These events are already documented as events of the
`http.ServerResponse` class. Document that they can also be emitted on
instances of the `http.ClientRequest` class.

PR-URL: https://github.com/nodejs/node/pull/42704
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
 2022-04-14 23:09:19 +01:00
Luigi Pinca c4a736ce12 doc: fix added: info for outgoingMessage.{,un}cork() 
`outgoingMessage.cork()` and `outgoingMessage.uncork()` were added to
Node.js v13.2.0 via 62e15a793a and backported to Node.js v12.16.0 via
db8144be31.

PR-URL: https://github.com/nodejs/node/pull/42711
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-04-14 23:09:04 +01:00
Luigi Pinca e61b62b9d4 doc: improve doc for http.ServerResponse inheritance 
Document that `http.ServerResponse` inherits from
`http.OutgoingMessage`.

PR-URL: https://github.com/nodejs/node/pull/42693
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-04-14 08:24:19 +01:00
Luigi Pinca 4508c8caa4 doc: fix added: info for some methods 
`outgoingMessage.getHeader()`, `outgoingMessage.getHeaderNames()`, and
`outgoingMessage.getHeaders()` were added to Node.js v7.7.0 via
3e8d43d165.

PR-URL: https://github.com/nodejs/node/pull/42661
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
 2022-04-11 06:21:48 +01:00
Luigi Pinca 13ad8d4e09 doc: fix outgoingMessage.removeHeader() signature 
Specify that `outgoingMessage.removeHeader()` takes a `name` argument
whose type is string.

PR-URL: https://github.com/nodejs/node/pull/42652
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
 2022-04-10 09:08:56 +01:00
Luigi Pinca d4d0b09122 test: renew certificates for specific test 
Renew the certificates used by
`test/parallel/test-https-selfsigned-no-keycertsign-no-crash.js` by
running the `https_renew_cert.sh` script under the same directory.

PR-URL: https://github.com/nodejs/node/pull/42342
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2022-03-15 14:47:56 +00:00
Luigi Pinca 626367c4e3 test: deflake test-common-expect-warning 
The subprocess might exit before the data is flushed. Run the assertion
after the `'end'` event is emitted.

PR-URL: https://github.com/nodejs/node/pull/42046
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-02-24 21:08:15 +01:00
Luigi Pinca 495825bc18 tools: update ESLint to 8.9.0 
PR-URL: https://github.com/nodejs/node/pull/41973
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-02-15 05:17:13 -08:00
Luigi Pinca 7ce8403ef1 test: simplify test-gc-http-client 
Instead of sending a fixed number of requests, detect when GC has
started and stop sending requests at that point.

PR-URL: https://github.com/nodejs/node/pull/41620
Refs: https://github.com/nodejs/node/commit/47ecf2060343
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2022-01-23 21:26:51 +01:00
Luigi Pinca d01c645b9b test: move test-gc-http-client-onerror to sequential 
Fixes: https://github.com/nodejs/node/issues/41399

PR-URL: https://github.com/nodejs/node/pull/41619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
 2022-01-22 19:32:40 +00:00
Luigi Pinca 42b51afb75 tools: update ESLint to 8.4.0 
PR-URL: https://github.com/nodejs/node/pull/41085
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
 2021-12-06 06:56:36 +00:00