larissayvette
234353a1b8
lib,src: refactor buffer out of range index
...
PR-URL: https://github.com/nodejs/node/pull/11296
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2017-05-27 21:11:26 -07:00
larissayvette
1c834e78ff
errors,test: migrating error to internal/errors
...
PR-URL: https://github.com/nodejs/node/pull/11505
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2017-05-06 15:54:26 -07:00
larissayvette
8a25e31fbe
test: consolidate buffer.read() in a file
...
PR-URL: https://github.com/nodejs/node/pull/11297
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2017-02-16 15:17:17 -08:00
larissayvette
084acc819d
test: check noAssert option in buf.write*()
...
Add test to cover previously untested `noAssert` functionality in
buf.write*() functions.
PR-URL: https://github.com/nodejs/node/pull/10790
Reviewed-By: Rich Trott <rtrott@gmail.com >
2017-01-26 14:11:44 -08:00
larissayvette
425563b59e
test: delete duplicate test of noAssert in readUInt*
...
PR-URL: https://github.com/nodejs/node/pull/10791
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
2017-01-16 10:32:37 -08:00
larissayvette
c8ed5f29ca
test: add test for noAssert option in buf.read*()
...
PR-URL: https://github.com/nodejs/node/pull/10713
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-01-11 14:57:13 -08:00
larissayvette
66c0767be4
test: basic functionality of readUIntLE()
...
PR-URL: https://github.com/nodejs/node/pull/10359
Reviewed-By: Julian Duque <julianduquej@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Italo A. Casas <me@italoacasas.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-12-24 15:44:40 -08:00
larissayvette
a5103ce4b5
test: basic functionality of readUIntBE()
...
PR-URL: https://github.com/nodejs/node/pull/10417
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Italo A. Casas <me@italoacasas.com >
Reviewed-By: Julian Duque <julianduquej@gmail.com >
2016-12-23 15:10:14 -05:00
larissayvette
832960592f
test: refactor test-http-after-connect.js
...
- Replace assert.equal() to assert.strictEqual()
- Replace var with const where applicable
- Removed firstBodyChunk which is never used
- Remove the process.on('exit', ...) and replace its functionality by
- Using common.mustCall() where applicable
PR-URL: https://github.com/nodejs/node/pull/10229
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Italo A. Casas <me@italoacasas.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2016-12-13 07:59:40 -05:00
larissayvette
4e1d6d0d68
test: checking if error constructor is assert.AssertionError
...
PR-URL: https://github.com/nodejs/node/pull/9119
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2016-10-18 15:45:03 -07:00
larissayvette
1bc9af88d1
test: fixes that do not affect performance
...
PR-URL: https://github.com/nodejs/node/pull/9011
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2016-10-12 09:13:03 -07:00
larissayvette