Luigi Pinca
cc4ee6cba8
test: deflake test-http-many-ended-pipelines
...
The socket might be destroyed by the other peer while data is still
being written. Add the missing error handler.
PR-URL: https://github.com/nodejs/node/pull/38018
Fixes: https://github.com/nodejs/node/issues/37291
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-04-08 19:29:56 +02:00
Yash Ladha
8d63aa828e
src: fix typo for initialization
...
PR-URL: https://github.com/nodejs/node/pull/37974
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-08 20:55:55 +05:30
Arkerone
093b527b25
doc: fix typo in assert.md
...
change "asssert" to "assert"
PR-URL: https://github.com/nodejs/node/pull/38152
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-08 07:22:24 -07:00
Bradley Farias
656fb4657a
lib: add tsconfig for code completions
...
PR-URL: https://github.com/nodejs/node/pull/38042
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-04-08 08:35:09 -05:00
Rich Trott
0da7a11e54
test,http: check that http server is robust from handler abuse
...
The only way I could find to complete coverage for _http_common.js is to
use semi-private (exposed but probably shouldn't be) handlers to get the
state into something weird. With the if-condition being checked (see
Refs) commented out, I get this result from this test:
```
node:_http_common:140
if (len > 0 && !stream._dumped) {
^
TypeError: Cannot read property '_dumped' of null
at HTTPParser.parserOnBody (node:_http_common:140:26)
```
With the check in place, the test passes without an error. Seems like
quite the edge case, but I'm going to assume it's there for a reason.
Refs: https://coverage.nodejs.org/coverage-b560645d6b0a4bed/lib/_http_common.js.html#L137
PR-URL: https://github.com/nodejs/node/pull/37958
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-08 05:20:01 -07:00
Arkerone
b16e79e05b
tls: fix typo
...
`byteLenth` -> `byteLength`.
PR-URL: https://github.com/nodejs/node/pull/38129
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-04-08 10:35:38 +02:00
Luigi Pinca
7869761c2e
net: fix typo
...
`construtor` -> `constructor`.
Fixes: https://github.com/nodejs/node/issues/38125
PR-URL: https://github.com/nodejs/node/pull/38127
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
2021-04-08 10:33:09 +02:00
Tobias Nießen
0fa579ac2a
doc: add missing comma in crypto doc
...
PR-URL: https://github.com/nodejs/node/pull/38142
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2021-04-08 10:11:57 +02:00
Filip Skokan
e8cb6446ef
crypto: reconcile oneshot sign/verify sync and async implementations
...
PR-URL: https://github.com/nodejs/node/pull/37816
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2021-04-08 10:08:26 +02:00
legendecas
d86132488d
lib: properly process JavaScript exceptions on async_hooks fatal error
...
JavaScript exceptions could be arbitrary values.
PR-URL: https://github.com/nodejs/node/pull/38106
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-08 08:58:09 +02:00
Joyee Cheung
6cb314bbe5
bootstrap: print information for snapshot at environment exit in debug
...
Print information relevant to snapshot building at the environment
exit when NODE_DEBUG_NATIVE is set to include mksnapshot. This helps
us understand what need to be fixed to build a snapshot when a script
is run to completion.
PR-URL: https://github.com/nodejs/node/pull/37967
Refs: https://github.com/nodejs/node/issues/37476
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-08 12:02:01 +08:00
Richard Lau
9cfb418e1f
build: package release changelog for releases
...
Package the changelog for the release line as `CHANGELOG.md` when
building a release binary tarball.
PR-URL: https://github.com/nodejs/node/pull/38033
Fixes: https://github.com/nodejs/node/issues/38025
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-07 12:26:34 -07:00
Rich Trott
098a4d6551
test: skip test-crypto-dh-keys on armv6 and armv7
...
The test is too slow to run on the Raspberry Pi bots. (It takes over 500
seconds to run on Pi 3 bots and over 900 seconds on Pi 2 bots.) Skip
it on armv6 and armv7.
Refs: https://github.com/nodejs/node/pull/34289
PR-URL: https://github.com/nodejs/node/pull/38076
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-07 12:11:47 -07:00
Richard Lau
f9b63b8530
test: update parallel/test-crypto-keygen for OpenSSL 3
...
OpenSSL 3 returns a different error code.
PR-URL: https://github.com/nodejs/node/pull/38136
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2021-04-07 11:36:44 -07:00
Arkerone
4bc8f7542f
doc: fix typo in crypto
...
-change "keyLenth" to "keyLength"
-change "ivLenth" to "ivLength"
PR-URL: https://github.com/nodejs/node/pull/38130
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Harshitha K P <harshitha014@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-07 11:29:29 -07:00
Tobias Nießen
6a6cdfad03
test: fix skip message for test-macos-app-sandbox
...
PR-URL: https://github.com/nodejs/node/pull/38114
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-04-07 11:25:50 -07:00
Rich Trott
038608d401
tools: relax max-len lint rule for template strings
...
Splitting template strings across multiple lines can make them harder to
read.
PR-URL: https://github.com/nodejs/node/pull/38097
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-07 04:16:35 -07:00
Nitzan Uziely
6986fa07eb
worker: fix exit code for error thrown in handler
...
Change worker exit code when the unhandled exception
handler throws from 0 to 7
fixes: https://github.com/nodejs/node/issues/37996
PR-URL: https://github.com/nodejs/node/pull/38012
Fixes: https://github.com/nodejs/node/issues/37996
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 15:01:46 -07:00
Rich Trott
1e4a2bcbee
crypto: remove check for condition that is always true
...
The value of `key` will always be `!= null` because earlier in the
function, `ERR_CRYPTO_SIGN_KEY_REQUIRED` is thrown if `key` is falsy.
Remove condition that subsequently checks that `key != null`.
PR-URL: https://github.com/nodejs/node/pull/38072
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 14:58:46 -07:00
Myles Borins
78b6f389d0
2021-04-06, Version 15.14.0 (Current)
...
Notable Changes:
This is a security release.
Vulnerabilities fixed:
- **CVE-2021-3450**: OpenSSL - CA certificate check bypass with X509_V_FLAG_X509_STRICT (High)
- **CVE-2021-3449**: OpenSSL - NULL pointer deref in signature_algorithms processing (High)
- **CVE-2020-7774**: npm upgrade - Update y18n to fix Prototype-Pollution (High)
Other Notable changes:
fs:
* (SEMVER-MINOR) add support for async iterators to `fsPromises.writeFile` (HiroyukiYagihashi) https://github.com/nodejs/node/pull/37490
net:
* (SEMVER-MINOR) allow net.BlockList to use net.SocketAddress objects (James M Snell) https://github.com/nodejs/node/pull/37917
* (SEMVER-MINOR) add SocketAddress class (James M Snell) https://github.com/nodejs/node/pull/37917
* (SEMVER-MINOR) make net.BlockList cloneable (James M Snell) https://github.com/nodejs/node/pull/37917
net,tls:
* (SEMVER-MINOR) add abort signal support to connect (Nitzan Uziely) https://github.com/nodejs/node/pull/37735
readline:
* (SEMVER-MINOR) add AbortSignal support to interface (Nitzan Uziely) https://github.com/nodejs/node/pull/37932
PR-URL: https://github.com/nodejs/node/pull/38084
2021-04-06 15:55:23 -04:00
Myles Borins
1522a93646
2021-04-06, Version 14.16.1 'Fermium' (LTS)
...
This is a security release.
Notable Changes:
Vulnerabilities fixed:
- **CVE-2021-3450**: OpenSSL - CA certificate check bypass with X509_V_FLAG_X509_STRICT (High)
- **CVE-2021-3449**: OpenSSL - NULL pointer deref in signature_algorithms processing (High)
- **CVE-2020-7774**: npm upgrade - Update y18n to fix Prototype-Pollution (High)
PR-URL: https://github.com/nodejs/node/pull/38082
2021-04-06 15:55:23 -04:00
Myles Borins
d318ec7fc3
2021-04-06, Version 12.22.1 'Erbium' (LTS)
...
This is a security release.
Notable changes:
Vulnerabilities fixed:
- **CVE-2021-3450**: OpenSSL - CA certificate check bypass with X509_V_FLAG_X509_STRICT (High)
- **CVE-2021-3449**: OpenSSL - NULL pointer deref in signature_algorithms processing (High)
- **CVE-2020-7774**: npm upgrade - Update y18n to fix Prototype-Pollution (High)
PR-URL: https://github.com/nodejs/node/pull/38083
2021-04-06 15:55:22 -04:00
Myles Borins
cd15b1cde2
2021-04-06, Version 10.24.1 'Dubnium' (LTS)
...
This is a security release.
Notable changes:
Vulnerabilities fixed:
- **CVE-2021-3450**: OpenSSL - CA certificate check bypass with X509_V_FLAG_X509_STRICT (High)
- **CVE-2021-3449**: OpenSSL - NULL pointer deref in signature_algorithms processing (High)
- **CVE-2020-7774**: npm upgrade - Update y18n to fix Prototype-Pollution (High)
PR-URL: https://github.com/nodejs/node/pull/38085
2021-04-06 15:55:22 -04:00
Darshan Sen
24fd791184
fs: move constants to internal/fs/utils.js
...
Refs: https://github.com/nodejs/node/pull/38004#discussion_r604951958
PR-URL: https://github.com/nodejs/node/pull/38061
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 12:24:15 -07:00
Evan Lucas
e155b1f2f7
test: correct test comment
...
This corrects a comment on the signal type used in the test.
PR-URL: https://github.com/nodejs/node/pull/38095
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 13:32:56 -05:00
Luigi Pinca
d61977f03e
test: remove dead code
...
`console.trace()` was used when printing the warning for a possible
event listeners leak. It is no longer used since commit c6656db352 that
introduced the `process.emitWarning()` API and used it to print the
warning.
PR-URL: https://github.com/nodejs/node/pull/38016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 18:49:13 +02:00
Rich Trott
8b05e32519
test: fix flaky test-net-timeout
...
The check for an 800ms window makesw assumptions about a setTimeout()
not running late etc. Remove it.
Refs: https://github.com/nodejs/node/pull/34289
PR-URL: https://github.com/nodejs/node/pull/38060
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 09:24:24 -07:00
Rich Trott
a0492ba391
test: fix test-vm-memleak for high baseline platforms
...
test-vm-memleak always fails on AIX in CI because the test checks that
total memory consumption is less than 64 Mb, but AIX uses over 100 Mb
just as a baseline. So instead, let's compare the memory consumption to
the baseline and make sure it is within 32 Mb.
PR-URL: https://github.com/nodejs/node/pull/38062
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Ash Cripps <acripps@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 09:23:31 -07:00
Juan José Arboleda
30d7f05fef
test: improve code coverage in webcrypto API
...
PR-URL: https://github.com/nodejs/node/pull/38052
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 09:21:20 -07:00
Rich Trott
005ebafbd1
doc: improve security text in collaborators guide
...
PR-URL: https://github.com/nodejs/node/pull/38107
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
2021-04-06 07:50:12 -07:00
Akhil Marsonya
54322b8d8b
doc: apply consistent punctuation to header contributing guide
...
PR-URL: https://github.com/nodejs/node/pull/38047
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 07:47:41 -07:00
Michaël Zasso
8dd5dd8a4b
process: do not lazily load AsyncResource
...
It doesn't seem necessary.
PR-URL: https://github.com/nodejs/node/pull/38041
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 07:46:45 -07:00
Hassaan Pasha
0d34767c4c
doc: sending http request to localhost to avoid https redirect
...
In the JSON fetching example, http.get request is being sent to
an http url that redirects to https. This causes the http.get
request to fail. To avoid redirect errors, a local http server
is set up that returns a json response.
Fixes: https://github.com/nodejs/node/issues/37907
PR-URL: https://github.com/nodejs/node/pull/38036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 07:45:31 -07:00
marsonya
f851efd2e1
doc: apply sentence case to backporting-to-release-lines.md headers
...
PR-URL: https://github.com/nodejs/node/pull/37617
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 07:41:25 -07:00
Antoine du Hamel
36bc8b905c
doc: fix typo in fs.md
...
PR-URL: https://github.com/nodejs/node/pull/38100
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-06 16:37:54 +02:00
Brian White
e38d62a8c9
path: fix POSIX path.resolve() perf regression
...
PR-URL: https://github.com/nodejs/node/pull/38064
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2021-04-06 00:00:20 -07:00
Richard Lau
cbe3b27166
doc,tools: allow stability table to be updated
...
Keep markers for the stability table so that it can be updated on
subsequent runs of the doc tooling. Only overwrite the files if
they have been changed.
PR-URL: https://github.com/nodejs/node/pull/38048
Fixes: https://github.com/nodejs/node/issues/37886
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2021-04-06 06:14:44 +02:00
Akhil Marsonya
a9332e84bf
lib: refactor to use primordials in lib/internal/cli_table
...
PR-URL: https://github.com/nodejs/node/pull/38046
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-05 18:20:38 -07:00
Tobias Nießen
66c8f76c2c
src: remove KeyObjectData::CreateSecret overload
...
This function is unused and there is not much potential for using
it in the current codebase.
PR-URL: https://github.com/nodejs/node/pull/38067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-05 18:16:55 -07:00
Bradley Farias
f52c92134c
doc: internal/test/binding for testing
...
PR-URL: https://github.com/nodejs/node/pull/38026
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-04-05 18:14:01 -07:00
Rich Trott
ab42ef3930
doc: add parentheses to function and move reference
...
Add parentheses as `unref()` is a function. Move it to the correct
lexically-sorted location in the reference list.
PR-URL: https://github.com/nodejs/node/pull/38066
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-04-05 17:26:09 -07:00
Nitzan Uziely
d75543d8b5
test: fix flaky timeout-delayed-body and headers tests
...
fix the flaky test-http-server-request-timeout-delayed-body
and test-http-server-request-timeout-delayed-headers which
sometimes fail on slow systems.
PR-URL: https://github.com/nodejs/node/pull/38045
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-05 07:49:01 -07:00
Rich Trott
4f387c25cb
test: fix flaky test-vm-memleak
...
Force garbage collection so that the memory leak is more easily
differentiated from ordinary not-garbage-collected memory.
Refs: https://github.com/nodejs/node/pull/34289
PR-URL: https://github.com/nodejs/node/pull/38054
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-04-04 22:01:26 -07:00
Akhil Marsonya
2861778ecd
doc: change wording in doc/api/domain.md comment
...
Change the wording to make the language more Inclusive.
PR-URL: https://github.com/nodejs/node/pull/38044
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-04 21:12:32 -07:00
Tobias Nießen
17a527ec07
src: fix typo in node_mutex
...
PR-URL: https://github.com/nodejs/node/pull/38011
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-04 18:38:13 +05:30
HiroyukiYagihashi
49580910db
fs: add support for async iterators to fsPromises.writeFile
...
Fixes: https://github.com/nodejs/node/issues/37391
PR-URL: https://github.com/nodejs/node/pull/37490
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-04 12:24:53 +02:00
Tobias Nießen
f562ec64e8
src: fix typos in crypto comments
...
PR-URL: https://github.com/nodejs/node/pull/38024
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2021-04-04 00:10:13 +02:00
Filip Skokan
c81d0fa9bc
crypto: use correct webcrypto RSASSA-PKCS1-v1_5 algorithm name
...
PR-URL: https://github.com/nodejs/node/pull/38029
Refs: https://www.w3.org/TR/WebCryptoAPI/#rsassa-pkcs1
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2021-04-04 00:08:37 +02:00
Darkripper214
a44392d7dd
doc: fix asyncLocalStorage.run() description
...
The description that store is not available
when asynchronous operation is created within
the callback is not accurate
Fixes: https://github.com/nodejs/node/issues/38022
PR-URL: https://github.com/nodejs/node/pull/38023
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2021-04-03 20:09:02 +02:00
Qingyu Deng
a59b6a1bc6
test: add extra space in test failure output
...
PR-URL: https://github.com/nodejs/node/pull/37957
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-04-03 20:07:34 +02:00