Ryuhei Shima
cecfdceed3
zlib: accept ArrayBuffer dictionary in Zstd
...
Fixes: https://github.com/nodejs/node/issues/64598
Signed-off-by: islandryu <shimaryuhei@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64599
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-21 15:03:54 +00:00
Md Muhtasim Munif Fahim
8cf16b31f6
doc: use promote wording in release guide
...
Signed-off-by: Muhtasim-Munif-Fahim <s1911024120@ru.ac.bd >
PR-URL: https://github.com/nodejs/node/pull/64371
Fixes: https://github.com/nodejs/node/issues/64360
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Stewart X Addison <sxa@redhat.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2026-07-21 10:15:37 +00:00
Muhammad Zeeshan
4efa0c6311
doc: fix import.meta example for vm.SourceTextModule
...
The import.meta example for new vm.SourceTextModule() in vm.md does not
run as written. It fails in two separate ways.
First, the constructor is missing the context: contextifiedObject
option, so the module evaluates in the top context where secret is not
defined, and the snippet throws ReferenceError: secret is not defined.
Second, the trailing note suggests replacing meta.prop = {} with
vm.runInContext('{}', contextifiedObject), but '{}' is parsed as an
empty block and evaluates to undefined. That makes the following
Object.getPrototypeOf(import.meta.prop) throw TypeError. Wrapping it as
'({})' returns an object, which is what the note intends.
This adds the context option and corrects the suggested replacement to
'({})' in both the mjs and cjs variants.
Fixes: https://github.com/nodejs/node/issues/64076
Signed-off-by: Muhammad Zeeshan <61280174+zeeshan56656@users.noreply.github.com >
PR-URL: https://github.com/nodejs/node/pull/64112
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2026-07-21 07:33:45 +00:00
Steven
f3ecafac44
doc: mention crypto.hash() for better perf
...
Signed-off-by: Steven <steven@ceriously.com >
PR-URL: https://github.com/nodejs/node/pull/63420
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2026-07-21 07:33:36 +00:00
Node.js GitHub Bot
c76aff4e0a
tools: update nixpkgs-unstable to 20535e48e12c86043b577b8518234ff5dbb
...
PR-URL: https://github.com/nodejs/node/pull/64589
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2026-07-21 06:37:50 +00:00
AkshatOP
4bec1915dc
vfs: make recursive readdir iterative
...
MemoryProvider recursive readdir walked the directory tree with a
recursive helper. Rewrite it to traverse iteratively with an explicit
stack so a deeply nested tree can no longer exhaust the call stack.
The set of directories on the active traversal path is still tracked, so
a circular symlink stops descending while its entry remains listed; the
output and observable behavior are unchanged.
Refs: https://github.com/nodejs/node/pull/64168
Signed-off-by: AkshatOP <hunterdevil0987@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64149
Fixes: https://github.com/nodejs/node/issues/64148
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2026-07-21 06:37:41 +00:00
Maxence Robinet
0bf185c566
doc: update sea example by fixing wrong code example
...
The SEA configuration defines the output binary as `sea`, but the
signing and run steps still referenced `hello`. Update the example
to use `sea` consistently so the commands match the generated
binary.
Signed-off-by: Maxence Robinet <107369283+saint-james-fr@users.noreply.github.com >
PR-URL: https://github.com/nodejs/node/pull/64025
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2026-07-21 06:37:30 +00:00
Archkon
8c1d1284cd
zlib: reject truncated zstd input
...
Treat an unfinished Zstd frame as an unexpected end of file when the
stream is finalized with ZSTD_e_end.
Avoid reporting an error while the output buffer still needs to be
drained or when an empty final write follows a completed frame. Preserve
partial decompression when ZSTD_e_flush is used.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com >
PR-URL: https://github.com/nodejs/node/pull/64593
Fixes: https://github.com/nodejs/node/issues/64592
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com >
2026-07-21 05:41:42 +00:00
Adrián Estrada
51c09eae6c
src,permission: do not throw on denied access in audit mode
...
The THROW_IF_INSUFFICIENT_PERMISSIONS and
ASYNC_THROW_IF_INSUFFICIENT_PERMISSIONS macros called
ThrowAccessDenied/AsyncThrowAccessDenied unconditionally and only
guarded the `return` with `warning_only()`.
ERR_ACCESS_DENIED_IF_INSUFFICIENT_PERMISSIONS had no `warning_only()`
guard at all — it always set the access-denied error and returned.
As a result, running with `--permission-audit` still produced
ERR_ACCESS_DENIED on any denied operation (fs, net, child_process,
worker, addon, ffi, inspector, wasi), defeating the audit-only purpose
of the flag.
Guard the denied-error path behind `!warning_only()` in all three
macros. In audit mode, the diagnostics-channel message is published
(already done in Permission::is_scope_granted) and execution continues;
in enforce mode (`--permission`), behavior is unchanged — the error is
raised and the call returns.
The tests cover both the direct (top-level) call and an `eval()`-wrapped
call: the direct call exercises the normal script path, and the
`eval()`-wrapped call exercises the V8 script-context boundary (the
diagnostics subscriber is registered in the outer module context while
the denied operation runs inside an eval'd string).
Refs: https://github.com/nodejs/node/commit/9ddd1a9c27c253f46d587a8c906ccd83417b4606
Signed-off-by: Adrian Estrada <edsadr@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64426
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2026-07-21 05:41:30 +00:00
Chengzhong Wu
69e982f70d
build: merge multiple on download artifact
...
When there are multiple artifacts, `actions/download-artifact` creates
subdirectories for each artifact, and results in incorrect folder
structure assumptions in later steps.
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net >
PR-URL: https://github.com/nodejs/node/pull/64633
Fixes: https://github.com/nodejs/node/issues/64554
Refs: https://github.com/actions/download-artifact#download-all-artifacts
Refs: https://github.com/nodejs/node/actions/runs/29768247349/job/88454933457?pr=64565#step:2:24
Reviewed-By: Aviv Keller <me@aviv.sh >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2026-07-21 01:22:16 +00:00
Node.js GitHub Bot
607190701a
deps: update timezone to 2026c
...
PR-URL: https://github.com/nodejs/node/pull/64588
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-21 01:21:50 +00:00
Trivikram Kamat
4991131590
stream: fix drop-newest behavior in share()
...
Discard upstream pull results when the shared buffer has reached its
highWaterMark instead of allowing the buffer to grow beyond its limit.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com >
PR-URL: https://github.com/nodejs/node/pull/64417
Fixes: https://github.com/nodejs/node/issues/64416
Reviewed-By: James M Snell <jasnell@gmail.com >
2026-07-21 00:52:34 +00:00
YuSheng Chen
1b42f7600e
doc: fix socket.readyState state descriptions
...
Signed-off-by: yusheng <samuel871211@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64468
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2026-07-20 21:51:40 +00:00
Filip Skokan
5b27fb976f
doc: replace large tables in crypto.md and webcrypto.md with lists
...
Signed-off-by: Filip Skokan <panva.ip@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64582
Reviewed-By: Aviv Keller <me@aviv.sh >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2026-07-20 18:25:05 +00:00
Aviv Keller
fe3b3b8b72
meta: lower stale to 3 months
...
Signed-off-by: Aviv Keller <me@aviv.sh >
PR-URL: https://github.com/nodejs/node/pull/64569
Refs: https://github.com/nodejs/node/pull/62105/changes#r3182288004
Refs: https://openjs-foundation.slack.com/archives/C019Y2T6STH/p1784126065845719
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2026-07-20 06:34:17 +00:00
Trivikram Kamat
00917ba54c
ffi: evaluate function signatures once
...
Function signatures were read by the native implementation and then
read again while creating JavaScript wrappers. Accessors, proxies,
or mutations could therefore produce different native and JavaScript
signatures.
Build wrappers from signature metadata captured by native code instead.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com >
Assisted-by: openai:gpt-5.6-sol
PR-URL: https://github.com/nodejs/node/pull/64559
Fixes: https://github.com/nodejs/node/issues/64558
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
2026-07-20 05:24:57 +00:00
Paul Bouchon
c286592321
doc: note --env-file is not applied to --run
...
Environment variables loaded with `--env-file` are not applied to the
command executed by `--run`. Document this limitation under `--run`.
Fixes: https://github.com/nodejs/node/issues/62988
Signed-off-by: Paul Bouchon <mail@bitpshr.net >
PR-URL: https://github.com/nodejs/node/pull/64442
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-19 21:06:20 +00:00
Adrián Estrada
0bcc6ef01e
cli: style node --help output with util.styleText
...
Apply util.styleText to the `node --help` output for improved visual
hierarchy and scannability. Styling is applied only when the output
stream supports color (detected via util.styleText's built-in
shouldColorize), so piped/redirected output and NO_COLOR remain plain
text with no behavior change.
- Bold: Usage lines, Options:, Environment variables: headers
- Bold green: CLI option names (e.g. --inspect, -e, --eval)
- Bold magenta: environment variable names (e.g. NODE_PATH)
- Dim: "(currently set)" annotation
- Blue underline: documentation URL
Column-width math uses unstyled string lengths to preserve alignment
regardless of styling. The "(currently set)" annotation is styled via
post-processing after layout to avoid breaking the fold() width
calculation.
Signed-off-by: Adrian Estrada <edsadr@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64484
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day >
2026-07-19 20:38:29 +00:00
Matteo Collina
d25cde436d
timers: do not retain a reference to the async store after firing
...
After firing timers, we can clean them up by iterating over all active
stores and setting the relevant symbols to undefined.
Fixes #53408
Signed-off-by: Matteo Collina <hello@matteocollina.com >
PR-URL: https://github.com/nodejs/node/pull/53443
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2026-07-19 18:30:06 +00:00
Filip Skokan
d90d9d55ad
crypto: limit KangarooTwelveParams customization to 512 bytes
...
To align with a future OpenSSL-imposed limit.
Signed-off-by: Filip Skokan <panva.ip@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64557
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2026-07-19 15:58:25 +00:00
avivkeller
4f844f4380
repl: use inspector over vm
...
Signed-off-by: Aviv Keller <me@aviv.sh >
PR-URL: https://github.com/nodejs/node/pull/64034
Fixes: https://github.com/nodejs/node/issues/64523
Closes: https://github.com/nodejs/node/pull/64534
Fixes: https://github.com/nodejs/node/issues/39387
Closes: https://github.com/nodejs/node/pull/39392
Fixes: https://github.com/nodejs/node/issues/61390
Fixes: https://github.com/nodejs/node/issues/63126
Fixes: https://github.com/nodejs/node/issues/38503
Fixes: https://github.com/nodejs/node/issues/37445
Fixes: https://github.com/nodejs/node/issues/38145
Fixes: https://github.com/nodejs/node/issues/33369
Fixes: https://github.com/nodejs/node/issues/48131
Fixes: https://github.com/nodejs/node/issues/8309
Fixes: https://github.com/nodejs/node/issues/39689
Fixes: https://github.com/nodejs/node/issues/18931
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2026-07-18 12:59:37 -07:00
Mahin Anowar
39f427d3cc
stream: resume flow when an errored pipe destination is removed
...
When a source is piped to multiple destinations and one destination
errors synchronously in `_write()`, `write()` returns false without
setting `needDrain` (since the "avoid unnecessary drain for sync
stream" change). The pipe cleanup only re-invoked the source's drain
handler when the destination still had `needDrain` set, so the errored
destination was never removed from the source's `awaitDrainWriters`
set. The source stayed paused forever and any remaining healthy
destination stopped receiving data.
Always invoke the drain handler during cleanup. `pipeOnDrain` only
removes this destination from the awaiting-drain set and resumes the
source once nothing else is awaiting a drain, so it is safe to call
unconditionally and no-ops when this destination was not awaiting a
drain.
Fixes: https://github.com/nodejs/node/issues/53185
Signed-off-by: Mahin Anowar <86069420+MahinAnowar@users.noreply.github.com >
PR-URL: https://github.com/nodejs/node/pull/64310
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2026-07-18 19:08:26 +00:00
Rich Trott
8dc337dfbd
test: apply correction to comment
...
The subsequent test checks for an invalid groupAddress, not
sourceAddress as the comment say. Adjust the comment to correctly
reflect what the test does.
Signed-off-by: Rich Trott <rtrott@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64524
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-18 18:17:49 +00:00
Paul Bouchon
9df0e9b4d4
assert,util: fix TypeError on Maps with null keys
...
`assert.deepStrictEqual`, `assert.notDeepStrictEqual`, and
`util.isDeepStrictEqual` threw a `TypeError` instead of returning a
result when one Map had a `null` key with an object value, the other
had an object key with a deeply-equal value but no `null` key, and
both maps were the same size.
In that case `mapObjectEquiv` skipped its primitive and `null` key
handling, which was gated on `array.length !== a.size`, and passed
the `null` key (which is `typeof 'object'`) to the object comparator.
That comparator reads `key.constructor` without a null guard, so it
threw. Handle primitive and `null` keys unconditionally, resolving
them directly against the other map.
Fixes: https://github.com/nodejs/node/issues/64433
Signed-off-by: Paul Bouchon <mail@bitpshr.net >
PR-URL: https://github.com/nodejs/node/pull/64441
Reviewed-By: Jordan Harband <ljharb@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Aviv Keller <me@aviv.sh >
2026-07-18 16:38:07 +00:00
Matteo Collina
fb5d01f2d1
http2: don't throw when destroying socket proxy
...
Calling destroy() on the http2session.socket proxy now destroys the
session instead of throwing ERR_HTTP2_NO_SOCKET_MANIPULATION.
Refs: https://github.com/nodejs/undici/issues/5525
Signed-off-by: Matteo Collina <hello@matteocollina.com >
PR-URL: https://github.com/nodejs/node/pull/64427
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2026-07-18 12:27:51 +02:00
greenhead
3c88785f34
doc: fix typo in embedding.md
...
Signed-off-by: greenhead <shren0812@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64425
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2026-07-18 10:18:51 +00:00
bq
b8f81e9760
fs: add pattern cache for matchGlobPattern()
...
Signed-off-by: Adam Haglund <adam@haglund.dev >
PR-URL: https://github.com/nodejs/node/pull/63915
Reviewed-By: Aviv Keller <me@aviv.sh >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2026-07-17 21:34:39 +00:00
bq
0a32b56f82
path: add benchmarks for path.matchesGlob()
...
Signed-off-by: Adam Haglund <adam@haglund.dev >
PR-URL: https://github.com/nodejs/node/pull/63915
Reviewed-By: Aviv Keller <me@aviv.sh >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2026-07-17 21:34:38 +00:00
Trivikram Kamat
1d4e86ec7f
vfs: make lchmod update symlink mode
...
Use a non-following provider operation for lchmod so it updates the
symbolic link metadata instead of changing the target file mode.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com >
Assisted-by: openai:gpt-5.5
PR-URL: https://github.com/nodejs/node/pull/64350
Fixes: https://github.com/nodejs/node/issues/64349
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2026-07-17 20:47:53 +00:00
Tim Perry
89df046a21
test: keep finalization before-exit ref alive
...
Signed-off-by: Tim Perry <pimterry@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64521
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-17 16:39:25 +00:00
Donghoon Kang
050fc39882
doc: fix typos in contributing docs
...
Signed-off-by: HoonDongKang <d159123@naver.com >
PR-URL: https://github.com/nodejs/node/pull/64520
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com >
2026-07-17 15:01:35 +00:00
esgor
46de80de88
http2: avoid uaf while receiving and sending rst_stream
...
Mark the session as receiving around nghttp2_session_mem_recv() and
defer RST_STREAM handling while receive is in progress. This prevents
closing a stream while nghttp2 still processes it and avoids
heap-use-after-free in nghttp2_session_mem_recv2().
Fixes: https://github.com/nodejs/node/issues/64113
Signed-off-by: Evgeniy Gorbanev <gorbanev.es@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64166
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Tim Perry <pimterry@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2026-07-17 12:39:42 +00:00
Antoine du Hamel
5520388f3b
lib: use assignFunctionName util where it makes sense
...
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64515
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Tim Perry <pimterry@gmail.com >
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
Reviewed-By: Jordan Harband <ljharb@gmail.com >
2026-07-17 11:00:54 +00:00
한만욱
c1bd1c4c7e
quic: preserve session stats after close
...
Signed-off-by: manNomi <hanmw110@naver.com >
PR-URL: https://github.com/nodejs/node/pull/64489
Reviewed-By: Tim Perry <pimterry@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2026-07-17 11:00:41 +00:00
Jungwon Sohn
358adc80e2
src: fix comment typos
...
Correct typos in builtin, platform, and QUIC source comments.
Signed-off-by: sjungwon03 <sjungwon03@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64509
Reviewed-By: Tim Perry <pimterry@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-17 09:36:11 +00:00
Tim Perry
ed2d7f4528
doc: document TLS alpnProtocol and servername fields
...
Signed-off-by: Tim Perry <pimterry@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64362
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-17 09:35:56 +00:00
Y1D7NG
a27fe2198a
vfs: fix VirtualReadStream race with async iteration
...
Fixes: https://github.com/nodejs/node/issues/64377
Signed-off-by: y1d7ng <y1d7ng@yeah.net >
PR-URL: https://github.com/nodejs/node/pull/64394
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2026-07-16 18:52:19 +00:00
Stewart X Addison
61b8e12451
tools: reference 'git node land' in PR-URL: error message in merge.sh
...
Signed-off-by: Stewart X Addison <sxa@ibm.com >
PR-URL: https://github.com/nodejs/node/pull/64495
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2026-07-16 19:13:41 +01:00
Sebastian Beltran
cc8594a9b1
quic: add support for TLS certificate compression
...
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64434
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tim Perry <pimterry@gmail.com >
2026-07-16 17:10:24 +00:00
Matteo Collina
cf882a7904
stream: fold desired-size check into WHATWG backpressure update
...
writableStreamUpdateBackpressure ran two release-mode assertions and
took a precomputed backpressure value that every caller derived with a
separate GetBackpressure/GetDesiredSize call pair. All callers already
hold the 'writable', not-close-queued invariant the assertions checked,
so derive the backpressure from the desired size inside the function and
drop the assertions and the helper. This runs up to twice per write.
writer.write() loop: +10%, pipe-to: +4.6% avg over 16 configs (local
harness / benchmark, all configs positive).
Signed-off-by: Matteo Collina <hello@matteocollina.com >
PR-URL: https://github.com/nodejs/node/pull/64451
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2026-07-16 13:34:09 +02:00
Kirill Saied
75692197e6
fs: fix cp symlink and EEXIST handling on Windows
...
Fixes: https://github.com/nodejs/node/issues/59636
Signed-off-by: Kirill Saied <sayed.kirill@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64353
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com >
2026-07-16 11:27:35 +00:00
Trivikram Kamat
874e96ee4c
stream: validate writer options signal
...
Validate options.signal for stream/iter writer write(), writev(),
and end() methods across push, broadcast, and fromWritable.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com >
Assisted-by: openai:gpt-5.5
PR-URL: https://github.com/nodejs/node/pull/64385
Fixes: https://github.com/nodejs/node/issues/64384
Reviewed-By: James M Snell <jasnell@gmail.com >
2026-07-16 06:41:15 +00:00
Trivikram Kamat
608112affa
stream: reject push iterator.throw() with error
...
Keep the existing consumer cancellation side effects, but
reject the iterator.throw() call with the supplied error
instead of resolving with done: true.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com >
Assisted-by: openai:gpt-5.5
PR-URL: https://github.com/nodejs/node/pull/64380
Fixes: https://github.com/nodejs/node/issues/64378
Reviewed-By: James M Snell <jasnell@gmail.com >
2026-07-16 03:43:34 +00:00
René
f2ba101259
build: extract temporal_capi crate directory name into gyp variable
...
This is a no-op for current builds, but will allow the crate updater in
node-core-utils to update the include path with the new crate location,
as the crate directory names will include a version string.
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk >
PR-URL: https://github.com/nodejs/node/pull/64482
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2026-07-16 00:56:52 +00:00
Guy Bedford
39ed68cd7c
net: support sync connect for BoundSocket
...
When a net.Socket is constructed from a net.BoundSocket, support
synchronous connect().
Signed-off-by: Guy Bedford <guybedford@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64375
Reviewed-By: James M Snell <jasnell@gmail.com >
2026-07-16 00:56:40 +00:00
Matteo Collina
34c28d5a69
Revert "http: do not emit socket errors after complete response"
...
This reverts commit 17163ead33 .
Signed-off-by: Matteo Collina <hello@matteocollina.com >
PR-URL: https://github.com/nodejs/node/pull/64511
Reviewed-By: Tim Perry <pimterry@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-15 14:04:02 +00:00
한만욱
b4dfc784f9
doc: fix spelling in devcontainer guide
...
Signed-off-by: manNomi <hanmw110@naver.com >
PR-URL: https://github.com/nodejs/node/pull/64459
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-15 13:18:14 +00:00
Antoine du Hamel
824bc6616f
test: copyedit test-tls-psk-alpn-callback-exception-handling
...
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/63485
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2026-07-15 10:59:57 +00:00
Antoine du Hamel
bf5c221704
stream: simplify nested PromisePrototypeThens
...
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64470
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2026-07-15 08:42:05 +00:00
Harjoth Khara
5d68eb44ba
doc: clarify PEM format for signing keys
...
Signed-off-by: harjoth <harjoth.khara@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/64404
Fixes: https://github.com/nodejs/node/issues/35331
Reviewed-By: Tim Perry <pimterry@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2026-07-15 08:41:50 +00:00