Commit Graph
72 Commits
Author SHA1 Message Date
RedYetiDev 1aa71351fa test: update performance-timeline wpt
PR-URL: https://github.com/nodejs/node/pull/55197
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2024-11-06 10:59:52 +01:00
RedYetiDevandAntoine du Hamel 772b35bdc4 module: support loading entrypoint as url
Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/54933
Refs: https://github.com/nodejs/node/pull/49975
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-09-27 15:26:48 +08:00
RedYetiDev b264cbe5e8 test_runner: use test: symbol on second print of parent test
PR-URL: https://github.com/nodejs/node/pull/54956
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-21 09:38:31 -07:00
RedYetiDev 941635473d test: add util.stripVTControlCharacters test
PR-URL: https://github.com/nodejs/node/pull/54865
Refs: https://github.com/chalk/ansi-regex/pull/58
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-21 09:27:59 -07:00
Aviv Keller b23d1c37b9 test: improve coverage for timer promises schedular
PR-URL: https://github.com/nodejs/node/pull/53370
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-21 09:22:17 -07:00
Aviv Keller 415b82d8b8 build: support up to python 3.13 in android-configure
PR-URL: https://github.com/nodejs/node/pull/54529
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2024-09-21 09:20:53 -07:00
RedYetiDev a65e4418e5 test: remove getCallSite from common
PR-URL: https://github.com/nodejs/node/pull/54947
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-21 09:20:11 -07:00
RedYetiDev 5116578b8a test: remove unused common utilities
PR-URL: https://github.com/nodejs/node/pull/54825
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2024-09-21 09:11:17 -07:00
Aviv Keller 5de919b652 test: use node:test in test-cli-syntax.bad
PR-URL: https://github.com/nodejs/node/pull/54513
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-10 08:50:19 -07:00
Aviv Keller 342b501cb0 doc: fix information about including coverage files
PR-URL: https://github.com/nodejs/node/pull/54527
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2024-08-27 19:11:04 +00:00
Aviv Keller 3a71ccf6c4 tools: remove unused python files
PR-URL: https://github.com/nodejs/node/pull/53928
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2024-08-26 20:43:19 +00:00
Aviv KellerandJim B 22daeba24d build: update required python version to 3.8
Co-Authored-By: Jim B <d3x0r@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/54358
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-23 21:20:32 +00:00
Aviv KellerandMarco Ippolito 9edf4a0856 test_runner: add support for coverage thresholds
Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/54429
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-08-23 17:02:11 +00:00
Aviv Keller d5dc540f10 meta: remind users to use a supported version in bug reports
PR-URL: https://github.com/nodejs/node/pull/54481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-08-23 12:29:47 +00:00
Aviv Keller 99f4a73b81 meta: add more labels to dep-updaters
PR-URL: https://github.com/nodejs/node/pull/54454
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-22 22:16:16 +00:00
Aviv Keller 746e2875f7 meta: run coverage-windows when vcbuild.bat updated
PR-URL: https://github.com/nodejs/node/pull/54412
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-08-19 14:01:20 +00:00
Aviv Keller 28c4f869be doc, meta: add missing , to BUILDING.md
PR-URL: https://github.com/nodejs/node/pull/54409
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-19 14:01:06 +00:00
Aviv Keller 59da1df009 cli: allow --test-[name/skip]-pattern in NODE_OPTIONS
PR-URL: https://github.com/nodejs/node/pull/53001
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2024-08-16 12:58:39 +00:00
Aviv Keller 53c5322c6a tools: remove header from c-ares license
PR-URL: https://github.com/nodejs/node/pull/54335
Refs: https://github.com/c-ares/c-ares/commit/595cf2133488d2e02c6389577a1b511971dba1ba
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2024-08-14 15:43:24 +00:00
Aviv KellerandCedric Staniewski 880c446d95 src: don't match after -- in Dotenv::GetPathFromArgs
Co-Authored-By: Cedric Staniewski <cedric@gmx.ca>
PR-URL: https://github.com/nodejs/node/pull/54237
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-08-13 23:56:56 +00:00
Aviv Keller 123693ccbf build: update ruff to 0.5.2
PR-URL: https://github.com/nodejs/node/pull/53909
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-13 17:21:59 +00:00
Aviv Keller 66c807693e doc, test: simplify test README table
PR-URL: https://github.com/nodejs/node/pull/53971
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-08-11 18:04:31 +00:00
Aviv Keller dc86592f20 meta: add module label for the lib/internal/modules folder
PR-URL: https://github.com/nodejs/node/pull/52858
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-06 18:34:11 +00:00
Aviv Keller 0260bbeefa benchmark: support --help in CLI
PR-URL: https://github.com/nodejs/node/pull/53358
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-06 18:21:27 +00:00
Aviv Keller 2b41c237c0 doc: add links to security steward companies
PR-URL: https://github.com/nodejs/node/pull/52981
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-08-06 07:51:07 +00:00
Aviv Keller accf2acdfb build: support lint-js-fix in vcbuild.bat
PR-URL: https://github.com/nodejs/node/pull/53695
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
2024-08-06 05:57:35 +00:00
Aviv Keller 981b5e3279 doc, meta: replace command with link to keys
PR-URL: https://github.com/nodejs/node/pull/53745
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-08-05 16:39:58 +00:00
Aviv Keller fa0fde7157 process: unify experimental warning messages
PR-URL: https://github.com/nodejs/node/pull/53704
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-07-23 11:56:03 +00:00
Aviv Keller 4b8000c66c doc: fix documentation for --run
PR-URL: https://github.com/nodejs/node/pull/53976
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2024-07-22 19:13:00 +00:00
Aviv Keller 1c5fe040a0 meta: remove license for hljs
PR-URL: https://github.com/nodejs/node/pull/53970
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-07-22 16:54:32 +00:00
Aviv Keller 96a614d63a meta: make more bug-report information required
PR-URL: https://github.com/nodejs/node/pull/53718
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2024-07-22 13:21:27 +00:00
Aviv Keller 85fded51df doc: update boxstarter README
PR-URL: https://github.com/nodejs/node/pull/53785
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-07-21 22:23:31 +00:00
Aviv Keller e8c2acf5de meta: reword linter messages
PR-URL: https://github.com/nodejs/node/pull/53949
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-07-22 00:21:42 +02:00
Aviv Keller 79759fa0ac meta: store actions secrets in environment
PR-URL: https://github.com/nodejs/node/pull/53930
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-07-20 19:33:29 +00:00
Aviv Keller 6fc0218e3e doc: add --experimental-sqlite note
PR-URL: https://github.com/nodejs/node/pull/53907
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-07-19 19:28:19 +00:00
Aviv Keller 86f79e6e7c doc: update api_assets README for new files
PR-URL: https://github.com/nodejs/node/pull/53676
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
2024-07-19 10:44:56 +00:00
Aviv Keller c0c7e866dc Revert "fs: add v8 fast api to closeSync"
This reverts commit ed6f45bef8.

PR-URL: https://github.com/nodejs/node/pull/53904
Refs: https://github.com/yarnpkg/berry/issues/6398
Refs: https://github.com/npm/cli/issues/7657
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2024-07-18 22:25:20 +00:00
Aviv Keller 3d019ce6af cli: document --inspect port 0 behavior
PR-URL: https://github.com/nodejs/node/pull/53782
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
2024-07-18 14:28:44 +00:00
RedYetiDev 50901664ad fs: correctly pass dirent to exclude withFileTypes
PR-URL: https://github.com/nodejs/node/pull/53823
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2024-07-17 16:21:48 +03:00
Aviv Keller 4174b73153 test: support glob matching coverage files
PR-URL: https://github.com/nodejs/node/pull/53553
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2024-07-14 22:37:45 +00:00
Aviv Keller 7d07c95f55 meta: remove redudant logging from dep updaters
PR-URL: https://github.com/nodejs/node/pull/53783
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2024-07-14 18:02:12 +00:00
Aviv Keller 53dead8912 doc, meta: add PTAL to glossary
PR-URL: https://github.com/nodejs/node/pull/53770
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2024-07-14 17:53:46 +00:00
Aviv Keller 38b7ce3b1e meta: add node_sqlite.c to PR label config
PR-URL: https://github.com/nodejs/node/pull/53797
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-07-12 20:42:49 +00:00
Aviv Keller 53483a1344 meta: use HTML entities in commit-queue comment
PR-URL: https://github.com/nodejs/node/pull/53744
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-07-08 16:29:43 +00:00
Aviv Keller c86ecfa94a cli: update node.1 to reflect Atom's sunset
PR-URL: https://github.com/nodejs/node/pull/53734
Refs: https://github.blog/2022-06-08-sunsetting-atom/
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-07-06 21:27:55 +00:00
Aviv Keller 0e70d0b6ee doc: document addition testing options
PR-URL: https://github.com/nodejs/node/pull/53569
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2024-06-26 12:05:14 +00:00
Aviv Keller eca806b54a meta: prevent constant references to issues in versioning
PR-URL: https://github.com/nodejs/node/pull/53564
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-06-26 01:24:00 +00:00
Aviv Keller 92a25abca9 path: add matchGlob method
PR-URL: https://github.com/nodejs/node/pull/52881
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2024-06-23 06:08:59 +00:00
Aviv Keller 69abdcd1bd doc, meta: organize contributing to Node-API guide
PR-URL: https://github.com/nodejs/node/pull/53243
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2024-06-22 16:55:02 +00:00
Aviv Keller 9e535b609f meta: use correct source for workflow in PR
PR-URL: https://github.com/nodejs/node/pull/53490
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2024-06-20 14:49:37 +00:00
Aviv Keller 99b01c7105 meta: fix typo in dependency updates
PR-URL: https://github.com/nodejs/node/pull/53471
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
2024-06-18 15:28:49 +00:00
Aviv Keller 2333573f39 doc: remove first timer badge
PR-URL: https://github.com/nodejs/node/pull/53338
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
2024-06-17 09:40:27 +02:00
Aviv Keller e30928485e doc, meta: use markdown rather than HTML in CONTRIBUTING.md
PR-URL: https://github.com/nodejs/node/pull/53235
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-06-08 19:16:44 +00:00
Aviv Keller 0b020089d9 doc: define more cases for stream event emissions
PR-URL: https://github.com/nodejs/node/pull/53317
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-06-08 15:52:46 +00:00
Aviv Keller d6921500cc doc: remove mentions of policy model from security info
PR-URL: https://github.com/nodejs/node/pull/53249
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-06-08 00:39:52 +00:00
Aviv Keller 78485280ca doc: include ESM import for HTTP
PR-URL: https://github.com/nodejs/node/pull/53165
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2024-05-30 00:46:42 +00:00
Aviv Keller dc609f5a81 meta: remove initializeCommand from devcontainer
PR-URL: https://github.com/nodejs/node/pull/53137
Fixes: https://github.com/nodejs/node/issues/53129
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-05-26 12:34:11 +00:00
Aviv Keller aaca18b54e doc: add note for windows users and symlinks
PR-URL: https://github.com/nodejs/node/pull/53117
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2024-05-25 19:00:10 +00:00
Aviv Keller d0a7272b57 build: use broader detection for 'help'
PR-URL: https://github.com/nodejs/node/pull/53045
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-05-25 19:00:02 +00:00
Aviv Keller ccceae091a tools: update error message for Type Error
PR-URL: https://github.com/nodejs/node/pull/53047
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-05-25 01:20:02 +00:00
Aviv Keller 29884d1d5c doc: update hljs with the latest styles
PR-URL: https://github.com/nodejs/node/pull/52911
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
2024-05-13 10:47:45 +00:00
Aviv Keller 9e5f0b690d doc: add names next to release key bash commands
PR-URL: https://github.com/nodejs/node/pull/52878
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2024-05-09 16:46:50 +00:00
Aviv Keller 303c80c50b fs: allow 'withFileTypes' to be used with globs
PR-URL: https://github.com/nodejs/node/pull/52837
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
2024-05-07 11:12:42 +00:00
Aviv KellerandHarshitha KP f5001070dd doc: add more definitions to GLOSSARY.md
Co-Authored-By: Harshitha KP <harshi46@in.ibm.com>
PR-URL: https://github.com/nodejs/node/pull/52798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-05-05 22:30:31 +00:00
Aviv Keller 4ddacbaa82 meta: standardize regex
PR-URL: https://github.com/nodejs/node/pull/52693
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-04-29 20:30:14 +00:00
Aviv Keller 172820342b vm: fix ASCII-betical order
PR-URL: https://github.com/nodejs/node/pull/52686
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2024-04-25 19:14:16 +00:00
Aviv Keller fa62544a3e test: fix backtick usage in docs
PR-URL: https://github.com/nodejs/node/pull/52643
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2024-04-24 18:56:49 +00:00
Aviv Keller ac9aa37bcb lib, url: add a windows option to path parsing
PR-URL: https://github.com/nodejs/node/pull/52509
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
2024-04-24 15:47:48 +00:00
Aviv Keller 2bd3081cb6 doc: add RedYetiDev to triage team
PR-URL: https://github.com/nodejs/node/pull/52556
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
2024-04-20 12:46:34 +00:00
Aviv Keller e9c233cd6b test_runner: add --test-skip-pattern cli option
PR-URL: https://github.com/nodejs/node/pull/52529
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2024-04-18 20:59:50 +00:00
Aviv Keller f8e325ea8a lib, doc: rename readme.md to README.md
PR-URL: https://github.com/nodejs/node/pull/52471
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-04-14 10:30:31 +00:00
Aviv Keller bb7d7487f5 lib: replace string prototype usage with alternatives
PR-URL: https://github.com/nodejs/node/pull/52440
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-04-11 21:46:46 +00:00