BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-14 10:26:26 -04:00
Code Issues Packages Projects Releases Wiki Activity
35,709 Commits 236 Branches 964 Tags
dc28d6315dca01acf824af655fc0adaa8db2d0bf
Commit Graph
24 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Mithun Sasidharan 062a6e20e3 test: added coverage for fs/promises API 
PR-URL: https://github.com/nodejs/node/pull/20219
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
 2018-04-26 19:46:26 +02:00
Mithun Sasidharan 0c55abf5d1 doc: added missing reference to test coverage info 
Added a reference to test coverage doc since its useful to have it here
as well

PR-URL: https://github.com/nodejs/node/pull/19825
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2018-04-06 14:44:44 -07:00
Mithun Sasidharan 3a53f7cc74 test: coverage for emitExperimentalWarning 
PR-URL: https://github.com/nodejs/node/pull/17635
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2017-12-17 13:23:03 -05:00
Mithun Sasidharan f86427eae8 test: improve coverage for util.promisify 
Add a test that confirms that non-function arguments
passed to util.promisify throw an ERR_INVALID_ARG_TYPE
error.

PR-URL: https://github.com/nodejs/node/pull/17591
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
 2017-12-14 13:16:10 -05:00
Mithun Sasidharan f3aaaa52b7 test: refactored to remove unnecessary variables 
PR-URL: https://github.com/nodejs/node/pull/17553
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2017-12-11 15:19:11 -05:00
Mithun Sasidharan 146a9b1a8a test: replace assert.throws w/ common.expectsError 
PR-URL: https://github.com/nodejs/node/pull/17483
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-12-08 16:23:32 -05:00
Mithun Sasidharan d8c896cac5 test: use common.expectsError in tests 
PR-URL: https://github.com/nodejs/node/pull/17484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
 2017-12-08 16:21:47 -05:00
Mithun Sasidharan eae0c05697 test: replace assert.throws w/ common.expectsError 
PR-URL: https://github.com/nodejs/node/pull/17498
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
 2017-12-08 16:02:07 -05:00
Mithun Sasidharan b681d8d1a1 test: use Number.isNaN instead of global isNaN 
PR-URL: https://github.com/nodejs/node/pull/17515
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2017-12-08 14:16:27 -05:00
Mithun Sasidharan 0a0fbd5498 fs: use rest param & Reflect.apply in makeCallback 
PR-URL: https://github.com/nodejs/node/pull/17486
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
 2017-12-08 13:42:39 -05:00
Mithun Sasidharan acd4277134 test: replace assert.throws w/ common.expectsError 
PR-URL: https://github.com/nodejs/node/pull/17497
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2017-12-08 13:37:33 -05:00
Mithun Sasidharan 20a8e83e44 test: replace assert.throws w/ common.expectsError 
PR-URL: https://github.com/nodejs/node/pull/17494
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2017-12-08 13:34:54 -05:00
Mithun Sasidharan 817d4adb47 doc: use arrow functions in util.md sample code 
PR-URL: https://github.com/nodejs/node/pull/17459
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2017-12-06 11:16:52 -05:00
Mithun Sasidharan bb59063807 test: refactor code to use common.mustCall 
PR-URL: https://github.com/nodejs/node/pull/17437
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2017-12-06 09:26:43 -05:00
Mithun Sasidharan 00c5b06317 test: update test-http-request-dont-override-options to use common.mustCall 
PR-URL: https://github.com/nodejs/node/pull/17438
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2017-12-05 19:27:49 -05:00
Mithun Sasidharan f6b2839bc3 test: use common.mustCall in test-http-malformed-request 
PR-URL: https://github.com/nodejs/node/pull/17439
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-12-05 16:36:03 -05:00
Mithun Sasidharan 90b257eafe test: use Countdown in http test 
PR-URL: https://github.com/nodejs/node/pull/17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2017-12-05 10:22:35 +01:00
Mithun Sasidharan 996bfccd17 test: update test-http-timeout to use countdown 
PR-URL: https://github.com/nodejs/node/pull/17341
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
 2017-12-04 17:40:17 -05:00
Mithun Sasidharan eb19c6b39f test: update test-http-upgrade-client to use countdown 
PR-URL: https://github.com/nodejs/node/pull/17339
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
 2017-12-03 14:26:34 -05:00
Mithun Sasidharan 2afd4e779c test: update test-http-status-reason-invalid-chars to use countdown 
PR-URL: https://github.com/nodejs/node/pull/17342
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
 2017-12-03 14:23:48 -05:00
Mithun Sasidharan f6926d5d00 test: refactored test-http-allow-req-after-204-res to countdown 
PR-URL: https://github.com/nodejs/node/pull/17211
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2017-12-01 20:59:06 +01:00
Mithun Sasidharan 0f3fd79ee9 test: refactored test-http-response-splitting to use countdown 
PR-URL: https://github.com/nodejs/node/pull/17348
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2017-12-01 20:54:09 +01:00
Mithun Sasidharan cd625e0658 test: refactored http test to use countdown 
PR-URL: https://github.com/nodejs/node/pull/17241
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2017-11-28 02:43:20 +01:00
Mithun Sasidharan 841e305e4c doc : mention constant-time in crypto doc 
Included reference to 'constant time' in
crypto.timingSafeEqual description.

The Node website would score higher on a Google search
and the API would be more discoverable if it used the words
"constant time" in its description.

PR-URL: https://github.com/nodejs/node/pull/16604
Fixes: https://github.com/nodejs/node/issues/16504
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-11-02 18:38:17 +08:00