James M Snell
ee2e7fcd5f
http2: remember sent headers
...
Add sentHeaders, sentTrailers, and sentInfoHeaders properties
on `Http2Stream`.
PR-URL: https://github.com/nodejs/node/pull/18045
Fixes: https://github.com/nodejs/node/issues/16619
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2018-01-11 11:55:19 -08:00
James M Snell
20fe04f113
perf_hooks,http2: add performance.clear()
...
Add missing clear() method to `perf_hooks.performance` to
remove the entries from the master timeline to prevent
that from being a memory leak.
PR-URL: https://github.com/nodejs/node/pull/18046
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2018-01-11 10:41:49 -08:00
James M Snell
47a282293f
doc: fix s/rstStream/close in example
...
PR-URL: https://github.com/nodejs/node/pull/18088
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com >
2018-01-11 10:14:20 -08:00
James M Snell
078b7a2a65
doc: update pushStream docs to use err first
...
Refs: https://github.com/nodejs/node/pull/17406#issuecomment-356661798
PR-URL: https://github.com/nodejs/node/pull/18088
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com >
2018-01-11 10:14:14 -08:00
Kyle Farnung
7c84f19455
test: remove orphaned entries from status
...
PR-URL: https://github.com/nodejs/node/pull/18092
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com >
2018-01-11 09:59:44 -08:00
Rich Trott
470bd39390
doc: be less tentative about undefined behavior
...
In the documentation for the buffer module, change instances of "the
result is considered undefined behavior" to "the resulting behavior is
undefined". It's less ambiguous in meaning and less awkward
stylistically.
PR-URL: https://github.com/nodejs/node/pull/18091
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com >
Reviewed-By: Minwoo Jung <minwoo@nodesource.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2018-01-11 09:51:40 -08:00
Jeremiah Senkpiel
0812ebda88
http2: fix kUpdateTimer timer refresh
...
Fixes an oversight from
93eb68e6d2
Wasn't caught by a test.
PR-URL: https://github.com/nodejs/node/pull/18062
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2018-01-11 12:14:44 -05:00
Tobias Nießen
ba076996a9
lib: fix spelling in comments
...
PR-URL: https://github.com/nodejs/node/pull/18018
Reviewed-By: Jon Moss <me@jonathanmoss.me >
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
Reviewed-By: Weijia Wang <starkwang@126.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com >
2018-01-11 16:49:42 +01:00
Tobias Nießen
e890344d18
test: fix spelling in test case comments
...
PR-URL: https://github.com/nodejs/node/pull/18018
Reviewed-By: Jon Moss <me@jonathanmoss.me >
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
Reviewed-By: Weijia Wang <starkwang@126.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com >
2018-01-11 16:49:38 +01:00
Matteo Collina
61b4d60c5d
stream: added experimental support for for-await
...
Adds support for Symbol.asyncIterator into the Readable class.
The stream is destroyed when the loop terminates with break or throw.
Fixes: https://github.com/nodejs/node/issues/15709
PR-URL: https://github.com/nodejs/node/pull/17755
Fixes: https://github.com/nodejs/node/issues/15709
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2018-01-11 12:34:41 +01:00
Michaël Zasso
4d96c17e05
tools: use babel-eslint as ESLint parser
...
PR-URL: https://github.com/nodejs/node/pull/17820
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2018-01-11 09:50:50 +01:00
Michaël Zasso
b043a70201
tools: add babel-eslint
...
Create tools/update-babel-eslint.sh script and execute it to do the
first installation of the package.
Update tools/license-builder.sh and execute it to add babel-eslint's
license to our LICENSE file.
PR-URL: https://github.com/nodejs/node/pull/17820
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2018-01-11 09:50:47 +01:00
Michaël Zasso
7a52c51e81
tools: update ESLint to 4.15.0
...
PR-URL: https://github.com/nodejs/node/pull/17820
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2018-01-11 09:50:42 +01:00
Michaël Zasso
3dc3063275
tools: move eslint from tools to tools/node_modules
...
This is required because we need to add the babel-eslint dependency
and it has to be able to resolve "eslint".
babel-eslint is required to support future ES features such as async
iterators and import.meta.
Refs: https://github.com/nodejs/node/pull/17755
PR-URL: https://github.com/nodejs/node/pull/17820
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2018-01-11 09:48:05 +01:00
Yang Guo
a2c7085dd4
build: fix Makefile wrt finding node executable
...
Not all shells set PWD, so use CURDIR instead.
`which node` may return the empty string, so guard against
that too. Consider:
if [ -x `which velociraptor` ] && [ -e `which velociprator` ];\
then echo "run"; else echo "keep calm"; fi;
PR-URL: https://github.com/nodejs/node/pull/18040
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2018-01-11 07:52:21 +01:00
Weijia Wang
315d1f553d
path: fix path.normalize for relative paths
...
After slicing, the `lastSegmentLength` should be calculated again,
instead of assigning value `j`.
PR-URL: https://github.com/nodejs/node/pull/17974
Fixes: https://github.com/nodejs/node/issues/17928
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
2018-01-11 11:11:22 +08:00
Jon Moss
8aec3638ce
fs: extract out validateUint32 and validateLen functions
...
PR-URL: https://github.com/nodejs/node/pull/17682
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2018-01-11 09:04:09 +08:00
Jon Moss
46e1d69bd1
fs: extract out validatePath function
...
PR-URL: https://github.com/nodejs/node/pull/17682
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2018-01-11 09:04:02 +08:00
Jon Moss
300ea7396f
fs: extract out validateOffsetLengthWrite function
...
PR-URL: https://github.com/nodejs/node/pull/17682
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2018-01-11 09:03:56 +08:00
Jon Moss
8983405508
fs: extract out validateBuffer function
...
PR-URL: https://github.com/nodejs/node/pull/17682
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2018-01-11 09:03:50 +08:00
Jon Moss
fc8c1b1ded
fs: extract out validateOffsetLengthRead function
...
PR-URL: https://github.com/nodejs/node/pull/17682
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2018-01-11 09:03:44 +08:00
Jon Moss
b9b8294dda
fs: extract out validateFd function
...
PR-URL: https://github.com/nodejs/node/pull/17682
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2018-01-11 09:03:36 +08:00
Anna Henningsen
6e3818f2a2
doc: un-mark Socket#write “removal” as notable change
...
Since the method is inherited from `Writable`, usage of the method
does not change at all after its removal as an explicit method.
Calling it out as notable might therefore be more confusing than
helpful.
PR-URL: https://github.com/nodejs/node/pull/18083
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2018-01-10 17:21:40 +01:00
Myles Borins
e688175c50
2019-01-10 Version 9.4.0 (Current)
...
Notable change:
* async_hooks:
- deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither
API were documented. (Andreas Madsen)
https://github.com/nodejs/node/pull/16972
* deps:
- update nghttp2 to 1.29.0 (James M Snell)
https://github.com/nodejs/node/pull/17908
- upgrade npm to 5.6.0 (Kat Marchán)
https://github.com/nodejs/node/pull/17535
- cherry-pick 50f7455 from upstream V8 (Michaël Zasso)
https://github.com/nodejs/node/pull/16591
* events:
- remove reaches into _events internals (Anatoli Papirovski)
https://github.com/nodejs/node/pull/17440
* http:
- add rawPacket in err of `clientError` event (XadillaX)
https://github.com/nodejs/node/pull/17672
* http2:
- implement maxSessionMemory (James M Snell)
https://github.com/nodejs/node/pull/17967
- add initial support for originSet (James M Snell)
https://github.com/nodejs/node/pull/17935
- add altsvc support (James M Snell)
https://github.com/nodejs/node/pull/17917
- perf_hooks integration (James M Snell)
https://github.com/nodejs/node/pull/17906
- Refactoring and cleanup of Http2Session and Http2Stream destroy
(James M Snell) https://github.com/nodejs/node/pull/17406
* net:
- remove Socket.prototype.write (Anna Henningsen)
https://github.com/nodejs/node/pull/17644
- remove Socket.prototype.listen (Ruben Bridgewater)
https://github.com/nodejs/node/pull/13735
* repl:
- show lexically scoped vars in tab completion (Michaël Zasso)
https://github.com/nodejs/node/pull/16591
* stream:
- rm {writeable/readable}State.length (Calvin Metcalf)
https://github.com/nodejs/node/pull/12857
- add flow and buffer properties to streams (Calvin Metcalf)
https://github.com/nodejs/node/pull/12855
* util:
- allow wildcards in NODE_DEBUG variable (Tyler)
https://github.com/nodejs/node/pull/17609
* zlib:
- add ArrayBuffer support (Jem Bezooyen)
https://github.com/nodejs/node/pull/16042
* Addedew collaborator**
- [starkwang](https://github.com/starkwang ) Weijia Wang
* Addedew TSC member**
- [danbev](https://github.com/danbev ) Daniel Bevenius
PR-URL: https://github.com/nodejs/node/pull/18069
2018-01-10 10:24:22 -05:00
Matteo Collina
1e0f3315c7
stream: always defer 'readable' with nextTick
...
Emit 'readable' always in the next tick, resulting in a single
call to _read() per microtick. This removes the need for the
user to implement buffering if they wanted to call this.push()
multiple times in an asynchronous fashion, as this.push() triggers
this._read() call.
PR-URL: https://github.com/nodejs/node/pull/17979
Fixes: https://github.com/nodejs/node/issues/3203
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2018-01-10 10:48:03 +01:00
James M Snell
800caac236
doc: add descriptions of state properties
...
Fixes: https://github.com/nodejs/node/issues/15268
PR-URL: https://github.com/nodejs/node/pull/18044
Fixes: https://github.com/nodejs/node/issues/15268
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2018-01-09 16:38:06 -08:00
Refael Ackermann
4c8bedf8b4
doc: examples for fast-tracking regression fixes
...
PR-URL: https://github.com/nodejs/node/pull/17379
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2018-01-09 16:27:12 -08:00
Jinho Bang
91c1ccd84f
n-api: throw RangeError in napi_create_dataview() with invalid range
...
The API is required that `byte_length + byte_offset` is less than or
equal to the size in bytes of the array passed in. If not, a RangeError
exception is raised[1].
[1] https://nodejs.org/api/n-api.html#n_api_napi_create_dataview
PR-URL: https://github.com/nodejs/node/pull/17869
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2018-01-09 16:20:19 -08:00
Ben Noordhuis
71203f5230
lib: handle throw undefined in assert.throws()
...
And make `assert.doesNotThrow()` handle it as well.
PR-URL: https://github.com/nodejs/node/pull/18029
Fixes: https://github.com/nodejs/node/issues/18027
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com >
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2018-01-09 16:14:50 -08:00
Anna Henningsen
7a18f093e4
benchmark: add JSStreamWrap benchmark
...
This is made to mirror the connection-bound net benchmarks.
PR-URL: https://github.com/nodejs/node/pull/17983
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2018-01-09 16:10:26 -08:00
Rich Trott
ec00ee89f5
doc: multiple updates to BUILDING.md
...
* remove spaces around slash in BUILDING.md
* hyphenate _end-of-life_ in BUILDING.md
* add missing comma in BUILDING.md
* add missing backticks in BUILDING.md
* add missing comma to BUILDING.md
PR-URL: https://github.com/nodejs/node/pull/17985
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com >
Reviewed-By: Jon Moss <me@jonathanmoss.me >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
2018-01-09 16:03:04 -08:00
Rich Trott
bf2e96460c
test: use smaller input file for test-zlib.js
...
PR-URL: https://github.com/nodejs/node/pull/17988
Fixes: https://github.com/nodejs/node/issues/17986
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
2018-01-09 15:59:43 -08:00
Rich Trott
0e98f2971f
doc: multiple updates to child_process.md
...
* use serial comma in child_process.md
* use American spelling of unsanitized in child_process.md
* hyphenate general-purpose in child_process.md
* remove errant commas in child_process.md
PR-URL: https://github.com/nodejs/node/pull/17990
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Jon Moss <me@jonathanmoss.me >
Reviewed-By: Weijia Wang <starkwang@126.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2018-01-09 15:57:50 -08:00
Qingyan Li
23c9597b92
build: fix cctest target with --enable-static
...
Currently the cctest target build will fail if configured with --enable-static
$ ./configure --enable-static
$ make
There're some function multiple definition errors such as:
out/Release/obj.target/node/src/node_crypto.o: In function `node::crypto::RandomBytesWork(uv_work_s*)':
node_crypto.cc:(.text+0x60): multiple definition of `node::crypto::RandomBytesWork(uv_work_s*)'
out/Release/obj.target/node/src/node_crypto.o:node_crypto.cc:(.text+0x60): first defined here
It's caused by repetition objects in libraries and libnode.a.
This CL makes those libraries guarded by 'node_target_type!="static_library"'.
PR-URL: https://github.com/nodejs/node/pull/17992
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2018-01-09 15:54:31 -08:00
sreepurnajasti
7969811a88
test: replace assert.throws with expectsError
...
PR-URL: https://github.com/nodejs/node/pull/17997
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2018-01-09 15:32:50 -08:00
Mykola Bilochub
bcb01de515
doc: fix incorrect argument type in fs.readSync
...
The `buffer` argument must be either Buffer or Uint8Array, string
values are not supported.
PR-URL: https://github.com/nodejs/node/pull/18022
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Weijia Wang <starkwang@126.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2018-01-09 15:26:32 -08:00
James M Snell
a02fcd2716
http2: use aliased buffer for perf stats, add stats
...
Add an aliased buffer for session and stream statistics,
add a few more metrics
PR-URL: https://github.com/nodejs/node/pull/18020
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com >
2018-01-09 12:33:13 -08:00
Anatoli Papirovski
ececdd3167
perf_hooks: fix scheduling regression
...
Scheduling a PerformanceGCCallback should not keep the
loop alive but due to the recent switch to using the
native SetImmediate method, it does. Go back to using
uv_async_t and add a regression test.
PR-URL: https://github.com/nodejs/node/pull/18051
Fixes: https://github.com/nodejs/node/issues/18047
Refs: https://github.com/nodejs/node/pull/18020
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2018-01-09 08:25:37 -08:00
Anatoli Papirovski
f3f3f8890c
lib: enable dot-notation eslint rule
...
PR-URL: https://github.com/nodejs/node/pull/18007
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Jon Moss <me@jonathanmoss.me >
2018-01-09 10:52:18 -05:00
Anatoli Papirovski
fbad8bb1fa
async_hooks: update defaultTriggerAsyncIdScope for perf
...
The existing version of defaultTriggerAsyncIdScope creates an Array
for the callback's arguments which is highly inefficient. Instead,
use rest syntax and allow V8 to do that work for us. This yields
roughly 2x performance for this particular function.
PR-URL: https://github.com/nodejs/node/pull/18004
Reviewed-By: Andreas Madsen <amwebdk@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2018-01-09 10:43:00 -05:00
Yang Guo
5a1aeab2db
tools: do not override V8's gitignore
...
The root .gitignore contains "node", which causes all of
deps/v8/tools/node to be ignored. That is somewhat inconvenient when
updating V8.
PR-URL: https://github.com/nodejs/node/pull/18010
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2018-01-09 11:20:46 +01:00
Joyee Cheung
89d865715a
doc: add guide on maintaining build files
...
PR-URL: https://github.com/nodejs/node/pull/16975
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Rod Vagg <rod@vagg.org >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
2018-01-09 17:07:26 +08:00
Joyee Cheung
d64279b4ee
build: document targets in the Makefile
...
PR-URL: https://github.com/nodejs/node/pull/16975
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Rod Vagg <rod@vagg.org >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
2018-01-09 17:07:19 +08:00
Michael Dawson
c91bd2f24f
src: update make for new code coverage locations
...
The files for code coverage are moving to the build
repository. Update the references to reflect this.
PR-URL: https://github.com/nodejs/node/pull/17987
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com >
Reviewed-By: Jon Moss <me@jonathanmoss.me >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2018-01-08 18:20:13 -05:00
James M Snell
33039871c9
http2: verify flood error and unsolicited frames
...
* verify protections against ping and settings flooding
* Strictly handle and verify handling of unsolicited ping and
settings frame acks.
PR-URL: https://github.com/nodejs/node/pull/17969
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2018-01-08 13:10:45 -08:00
Andreas Madsen
6aac05bf47
trace_events: stop tracing agent in process.exit()
...
PR-URL: https://github.com/nodejs/node/pull/18005
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2018-01-08 11:54:24 +01:00
Matteo Collina
acf56be536
fs: guarantee order of callbacks in ws.close
...
Refactor WriteStream.prototype.close and WriteStream.prototype._destroy
to always call the callback passed to close in order. Protects from
calling .close() without a callback.
Fixes: https://github.com/nodejs/node/issues/17951
See: https://github.com/nodejs/node/pull/15407
PR-URL: https://github.com/nodejs/node/pull/18002
Fixes: https://github.com/nodejs/node/issues/17951
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
2018-01-08 09:17:16 +01:00
Anna Henningsen
46f783d74f
tls: remove cleartext input data queue
...
The TLS implementation previously kept a separate buffer for
incoming pieces of data, into which buffers were copied
before they were up for writing.
This removes this buffer, and replaces it with a simple list
of `uv_buf_t`s:
- The previous implementation copied all incoming data into
that buffer, both allocating new storage and wasting time
with copy operations. Node’s streams/net implementation
already has to make sure that the allocated memory stays
fresh until the write is finished, since that is what
libuv streams rely on anyway.
- The fact that a separate kind of buffer, `crypto::NodeBIO`
was used, was confusing: These `BIO` instances are
only used to communicate with openssl’s streams system
otherwise, whereas this one was purely for internal
memory management.
- The name `clear_in_` was not very helpful.
PR-URL: https://github.com/nodejs/node/pull/17883
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2018-01-07 22:36:08 +01:00
Anna Henningsen
d5fa4de00f
tls: refactor write queues away
...
The TLS implementation previously had two separate queues for
WriteWrap instances, one for currently active and one for
finishing writes (i.e. where the encrypted output is being written
to the underlying socket).
However, the streams implementation in Node doesn’t allow for
more than one write to be active at a time; effectively,
the only possible states were that:
- No write was active.
- The first write queue had one item, the second one was empty.
- Only the second write queue had one item, the first one was empty.
To reduce overhead and implementation complexity, remove these
queues, and instead store a single `WriteWrap` pointer and
keep track of whether its write callback should be called
on the next invocation of `InvokeQueued()` or not
(which is what being in the second queue previously effected).
PR-URL: https://github.com/nodejs/node/pull/17883
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2018-01-07 22:35:59 +01:00
Anna Henningsen
b171adc4d1
lib: remove queue implementation from JSStreamWrap
...
The streams implementation generally ensures that only one write()
call is active at a time. `JSStreamWrap` instances still kept
queue of write reqeuests in spite of that; refactor it away.
Also, fold `isAlive()` into a constant function on the native side.
PR-URL: https://github.com/nodejs/node/pull/17918
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Minwoo Jung <minwoo@nodesource.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2018-01-07 21:21:32 +01:00