Rich Trott 8c305e1c2f test: fix flaky watchFile() ...

The regression that test-fs-watch-file-enoent-after-deletion was written
to test for involves whether or not the callback runs or not. Checking
what the file watcher reports unfortunately is subject to race
conditions on Windows (and possibly elsewhere) because the file watcher
returns control to the event loop before it may be receiving data from
the OS. So remove those assertions. The test still checks what it is
supposed to check, but is no longer subject to race conditions.

Fixes: https://github.com/nodejs/node/issues/21692

PR-URL: https://github.com/nodejs/node/pull/21694
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

2018-07-13 18:38:52 -07:00

..

sequential.status

test: mark test-inspector-port-zero-cluster flaky

2018-06-11 16:10:16 -07:00

test-async-wrap-getasyncid.js

src: refactor timers to remove TimerWrap

2018-06-24 21:35:05 -07:00

test-benchmark-buffer.js

test: fix long-running buffer benchmarks

2018-04-22 11:06:30 +02:00

test-benchmark-child-process.js

test: create shared runBenchmark function

2017-09-11 11:26:15 -04:00

test-benchmark-dgram.js

test: move benchmark-dgram to sequential

2018-06-05 18:55:24 -07:00

test-benchmark-http.js

http: refactor outgoing headers processing

2018-04-27 20:31:25 +02:00

test-benchmark-net.js

test: create shared runBenchmark function

2017-09-11 11:26:15 -04:00

test-benchmark-path.js

test: move test-benchmark-path to sequential

2018-06-19 00:06:39 -07:00

test-benchmark-tls.js

benchmark: add tls benchmark for legacy SecurePair

2018-05-16 08:54:36 +04:00

test-buffer-creation-regression.js

test,tools: enable running tests under workers

2018-06-06 19:44:11 +02:00

test-child-process-emfile.js

test: simplify test skipping

2017-07-04 12:41:49 +03:00

test-child-process-execsync.js

test: remove assert.doesNotThrow()

2018-02-16 16:53:47 +01:00

test-child-process-exit.js

tools: add 'spaced-comment' into eslint rules

2018-04-01 22:33:13 +08:00

test-child-process-fork-getconnections.js

lib,src: fix consistent spacing inside braces

2017-07-21 15:13:47 -04:00

test-child-process-pass-fd.js

test: fix flaky test-child-process-pass-fd

2017-12-12 21:14:43 -08:00

test-cluster-inspect-brk.js

test: skipIfInspectorDisabled cluster-inspect-brk

2017-05-02 07:50:16 +02:00

test-cluster-send-handle-large-payload.js

test: fix test-cluster-send-handle-large-payload

2018-03-14 22:28:18 -07:00

test-crypto-timing-safe-equal.js

lib: always show ERR_INVALID_ARG_TYPE received part

2018-03-25 01:45:37 +01:00

test-debug-prompt.js

test: refactor test-debug-prompt

2017-09-13 17:12:57 -03:00

test-debugger-debug-brk.js

test: added a test comment

2017-10-11 22:55:15 -07:00

test-debugger-repeat-last.js

test: continue normalizing fixtures use

2017-08-27 21:14:34 -03:00

test-deprecation-flags.js

test: use fixtures module over fixturesDir

2017-10-15 00:04:54 +08:00

test-dgram-bind-shared-ports.js

test: adjust indentation for stricter linting

2017-07-27 09:24:20 -07:00

test-dgram-implicit-bind-failure.js

test: move common.PORT tests to sequential

2017-09-10 23:56:30 -03:00

test-dgram-pingpong.js

test: reduce string concatenations

2017-05-05 17:39:05 +03:00

test-fs-readfile-tostring-fail.js

src: rename ERR_STRING_TOO_LARGE to ERR_STRING_TOO_LONG

2018-04-10 01:08:10 +02:00

test-fs-stat-sync-overflow.js

test: address nits and rename the corresponding fixture

2018-03-08 10:37:29 -06:00

test-fs-watch.js

lib,src: make StatWatcher a HandleWrap

2018-06-14 13:19:17 +02:00

test-http2-max-session-memory.js

http2: destroy the socket properly and add tests

2018-05-13 19:47:40 +02:00

test-http2-ping-flood.js

test: fix flaky test-http2-ping-flood

2018-03-19 10:17:58 -07:00

test-http2-session-timeout.js

test: improve reliability of http2-session-timeout

2018-05-16 08:57:49 +04:00

test-http2-settings-flood.js

test: fix flaky test-http2-settings-flood

2018-03-16 10:26:55 -07:00

test-http2-timeout-large-write-file.js

test: move tmpdir to submodule of common

2018-01-31 22:11:07 -08:00

test-http2-timeout-large-write.js

http2: cleanup Http2Stream/Http2Session destroy

2017-12-18 10:19:21 -08:00

test-http-econnrefused.js

test: rename test-regress-GH-784.js

2018-03-08 10:37:37 -06:00

test-http-keep-alive-large-write.js

net,src: refactor writeQueueSize tracking

2017-12-18 09:58:02 -05:00

test-http-keepalive-maxsockets.js

test: move test-http-keepalive-maxsockets to sequential

2017-11-07 16:34:55 +00:00

test-http-max-sockets.js

test: rename test-regress-GH-877.js

2018-03-08 10:37:43 -06:00

test-http-regr-gh-2928.js

test: s/assert.equal/assert.strictEqual/

2017-01-11 14:19:26 +00:00

test-http-server-consumed-timeout.js

test: remove undefined function

2017-12-26 10:26:07 +08:00

test-http-server-keep-alive-timeout-slow-client-headers.js

test: move timing-dependent tests to sequential

2017-07-22 07:53:27 +03:00

test-http-server-keep-alive-timeout-slow-server.js

test: move timing-dependent tests to sequential

2017-07-22 07:53:27 +03:00

test-https-keep-alive-large-write.js

net,src: refactor writeQueueSize tracking

2017-12-18 09:58:02 -05:00

test-https-server-keep-alive-timeout.js

test: move timing-sensitive test to sequential

2017-11-17 21:04:53 -08:00

test-init.js

test,tools: enable running tests under workers

2018-06-06 19:44:11 +02:00

test-inspector-async-call-stack-abort.js

src: fix inspector nullptr deref on abrupt exit

2017-12-12 12:48:37 -02:00

test-inspector-async-call-stack.js

inspector: track async stacks when necessary

2017-10-29 09:38:37 -07:00

test-inspector-async-hook-setup-at-inspect-brk.js

inspector: --inspect-brk for es modules

2018-01-22 18:39:21 +02:00

test-inspector-async-hook-setup-at-signal.js

inspector: --inspect-brk for es modules

2018-01-22 18:39:21 +02:00

test-inspector-async-stack-traces-promise-then.js

test: fix inspector test after V8 upgrade

2018-01-24 15:03:03 -08:00

test-inspector-async-stack-traces-set-interval.js

inspector: --inspect-brk for es modules

2018-01-22 18:39:21 +02:00

test-inspector-bindings.js

inspector: allow concurrent inspector sessions

2018-04-26 12:48:48 -07:00

test-inspector-break-e.js

inspector: --inspect-brk for es modules

2018-01-22 18:39:21 +02:00

test-inspector-break-when-eval.js

inspector: --inspect-brk for es modules

2018-01-22 18:39:21 +02:00

test-inspector-console.js

inspector: expose original console

2018-07-07 00:04:52 +02:00

test-inspector-contexts.js

test: fix spelling in test case comments

2018-01-11 16:49:38 +01:00

test-inspector-debug-brk-flag.js

inspector: --inspect-brk for es modules

2018-01-22 18:39:21 +02:00

test-inspector-debug-end.js

inspector: --inspect-brk for es modules

2018-01-22 18:39:21 +02:00

test-inspector-enabled.js

test: move inspector tests to parallel/sequential

2017-10-17 19:35:50 -04:00

test-inspector-exception.js

inspector: --inspect-brk for es modules

2018-01-22 18:39:21 +02:00

test-inspector-invalid-args.js

test: fix inspector tests

2017-10-17 23:10:20 -07:00

test-inspector-ip-detection.js

test,benchmark,doc: enable dot-notation rule

2018-02-16 19:37:43 +01:00

test-inspector-module.js

inspector: allow concurrent inspector sessions

2018-04-26 12:48:48 -07:00

test-inspector-not-blocked-on-idle.js

inspector: --inspect-brk for es modules

2018-01-22 18:39:21 +02:00

test-inspector-open.js

test: fix inspector tests

2017-10-17 23:10:20 -07:00

test-inspector-overwrite-config.js

test,tools: enable running tests under workers

2018-06-06 19:44:11 +02:00

test-inspector-port-cluster.js

fs,cluster,net: assign error codes to remaining errors

2018-03-21 20:14:57 +01:00

test-inspector-port-zero-cluster.js

cluster: fix inspector port assignment

2018-02-22 11:06:21 +01:00

test-inspector-port-zero.js

assert: stricter ifError

2018-01-24 13:16:09 +01:00

test-inspector-scriptparsed-context.js

inspector: --inspect-brk for es modules

2018-01-22 18:39:21 +02:00

test-inspector-stop-profile-after-done.js

test: fix assertion argument order

2018-03-12 08:42:21 -07:00

test-inspector-stops-no-file.js

test: remove unused parameter

2017-11-21 07:49:29 -08:00

test-inspector-stress-http.js

test: move inspector-stress-http to sequential

2018-06-10 19:36:07 -07:00

test-inspector.js

inspector: allow concurrent inspector sessions

2018-04-26 12:48:48 -07:00

test-module-loading.js

test: avoid empty fixture in module test

2018-06-01 23:44:02 +02:00

test-net-better-error-messages-port.js

test: use dynamic port instead of common.PORT

2017-05-09 13:25:05 -07:00

test-net-bytes-per-incoming-chunk-overhead.js

test: move net bytes-per-chunk test to sequential

2018-06-24 15:55:27 +02:00

test-net-connect-local-error.js

test: fix sequential test-net-connect-local-error

2017-05-22 14:11:57 -04:00

test-net-GH-5504.js

test: clean up inappropriate language

2017-11-22 16:48:04 +02:00

test-net-listen-shared-ports.js

lib,src: fix consistent spacing inside braces

2017-07-21 15:13:47 -04:00

test-net-localport.js

test: move common.PORT tests to sequential

2017-09-10 23:56:30 -03:00

test-net-reconnect-error.js

test: move net reconnect error test to sequential

2017-05-20 08:08:13 -04:00

test-net-response-size.js

test: address nits and rename the corresponding fixture

2018-03-08 10:37:29 -06:00

test-net-server-address.js

test: simplify test skipping

2017-07-04 12:41:49 +03:00

test-net-server-bind.js

test: refactor test-net-server-bind

2017-05-31 22:09:54 -07:00

test-next-tick-error-spin.js

tools: add 'spaced-comment' into eslint rules

2018-04-01 22:33:13 +08:00

test-performance.js

perf_hooks: remove less useful bootstrap marks

2018-06-15 09:05:19 -07:00

test-pipe.js

test: add common.noop, default for common.mustCall()

2017-03-26 12:47:15 -07:00

test-process-warnings.js

test: use fixtures in test-process-warnings

2017-10-12 18:18:39 -07:00

test-repl-timeout-throw.js

test: fix flaky repl-timeout-throw

2018-02-10 16:08:32 +01:00

test-require-cache-without-stat.js

test: improve to use template string

2018-01-17 08:50:02 +08:00

test-stream2-fs.js

test: use ES6 classes instead of util.inherits

2017-11-12 10:29:45 -08:00

test-stream2-stderr-sync.js

test: improve to use template string

2018-01-17 08:50:02 +08:00

test-stream-writable-clear-buffer.js

stream: fix disparity between buffer and the count

2017-10-01 23:37:15 -03:00

test-timers-block-eventloop.js

test: fix flaky timers-block-eventloop test

2018-02-08 15:33:02 -05:00

test-timers-blocking-callback.js

src: refactor timers to remove TimerWrap

2018-06-24 21:35:05 -07:00

test-timers-set-interval-excludes-callback-duration.js

src: refactor timers to remove TimerWrap

2018-06-24 21:35:05 -07:00

test-tls-connect.js

tls: throw error on bad ciphers option

2018-07-03 16:30:30 -04:00

test-tls-lookup.js

test: remove assert.doesNotThrow()

2018-02-16 16:53:47 +01:00

test-util-debug.js

util: allow wildcards in NODE_DEBUG variable

2017-12-15 19:31:07 -02:00

test-vm-timeout-rethrow.js

src: assign ERR_SCRIPT_EXECUTION_* codes in C++

2018-04-25 23:46:08 +08:00

testcfg.py

test: split test in parallel/sequential

2014-12-17 20:45:02 +07:00