mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Ben Noordhuis
f674b09f40
* Change calls to String::New() and String::NewSymbol() to their respective one-byte, two-byte and UTF-8 counterparts. * Add a FIXED_ONE_BYTE_STRING macro that takes a string literal and turns it into a v8::Local<v8::String>. * Add helper functions that make v8::String::NewFromOneByte() easier to work with. Said function expects a `const uint8_t*` but almost every call site deals with `const char*` or `const unsigned char*`. Helps us avoid doing reinterpret_casts all over the place. * Code that handles file system paths keeps using UTF-8 for backwards compatibility reasons. At least now the use of UTF-8 is explicit. * Remove v8::String::NewSymbol() entirely. Almost all call sites were effectively minor de-optimizations. If you create a string only once, there is no point in making it a symbol. If you are create the same string repeatedly, it should probably be cached in a persistent handle.
59 lines
2.0 KiB
C++
59 lines
2.0 KiB
C++
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
#include "node.h"
|
|
#include "node_natives.h"
|
|
#include "v8.h"
|
|
|
|
#include <string.h>
|
|
#if !defined(_MSC_VER)
|
|
#include <strings.h>
|
|
#endif
|
|
|
|
namespace node {
|
|
|
|
using v8::Handle;
|
|
using v8::HandleScope;
|
|
using v8::Local;
|
|
using v8::Object;
|
|
using v8::String;
|
|
|
|
Handle<String> MainSource() {
|
|
return OneByteString(node_isolate, node_native, sizeof(node_native) - 1);
|
|
}
|
|
|
|
void DefineJavaScript(Handle<Object> target) {
|
|
HandleScope scope(node_isolate);
|
|
|
|
for (int i = 0; natives[i].name; i++) {
|
|
if (natives[i].source != node_native) {
|
|
Local<String> name = String::NewFromUtf8(node_isolate, natives[i].name);
|
|
Handle<String> source = String::NewFromUtf8(node_isolate,
|
|
natives[i].source,
|
|
String::kNormalString,
|
|
natives[i].source_len);
|
|
target->Set(name, source);
|
|
}
|
|
}
|
|
}
|
|
|
|
} // namespace node
|