Anna Henningsen 06666305da http2: keep session objects alive during Http2Scope ...

Keep a local handle as a reference to the JS `Http2Session`
object so that it will not be garbage collected
when inside an `Http2Scope`, because the presence of the
latter usually indicates that further actions on
the session object are expected.

Strictly speaking, storing the `session_handle_` as a
property on the scope object is not necessary, but
this is not very costly and makes the code more
obviously correct.

Fixes: https://github.com/nodejs/node/issues/17840

PR-URL: https://github.com/nodejs/node/pull/17863
Fixes: https://github.com/nodejs/node/issues/17840
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

2017-12-27 16:04:22 -08:00

..

res

…

tracing

src: use nullptr instead of NULL

2017-12-01 07:45:00 +01:00

aliased_buffer.h

async_hooks: use typed array stack as fast path

2017-12-27 19:48:07 +01:00

async_wrap-inl.h

src: rename base-object -> base_object

2017-11-17 12:49:10 +01:00

async_wrap.cc

async_hooks: use typed array stack as fast path

2017-12-27 19:48:07 +01:00

async_wrap.h

async_hooks: use typed array stack as fast path

2017-12-27 19:48:07 +01:00

backtrace_posix.cc

src: remove superfluous check in backtrace_posix.cc

2017-11-18 20:58:12 +01:00

backtrace_win32.cc

src: implement backtrace-on-abort for windows

2017-11-15 19:28:13 +01:00

base64.h

src: make base64.h self-contained

2017-11-27 07:21:08 +01:00

base_object-inl.h

src: use std::unique_ptr in base-object-inl.h

2017-11-19 09:20:26 +01:00

base_object.h

src: rename base-object -> base_object

2017-11-17 12:49:10 +01:00

cares_wrap.cc

dns: fix crash while setting server during query

2017-12-06 04:22:31 +01:00

CNNICHashWhitelist.inc

…

connect_wrap.cc

src: rename req-wrap -> req_wrap

2017-11-17 12:49:20 +01:00

connect_wrap.h

src: rename req-wrap -> req_wrap

2017-11-17 12:49:20 +01:00

connection_wrap.cc

async_hooks: use scope for defaultTriggerAsyncId

2017-12-19 18:04:52 +01:00

connection_wrap.h

src: rename StreamWrap to LibuvStreamWrap

2017-10-13 13:05:49 -07:00

env-inl.h

async_hooks: use typed array stack as fast path

2017-12-27 19:48:07 +01:00

env.cc

async_hooks: use typed array stack as fast path

2017-12-27 19:48:07 +01:00

env.h

async_hooks: use typed array stack as fast path

2017-12-27 19:48:07 +01:00

freelist.h

http2: introducing HTTP/2

2017-08-04 12:55:44 -07:00

fs_event_wrap.cc

src: make FSEventWrap/StatWatcher::Start more robust

2017-12-13 06:32:55 +01:00

handle_wrap.cc

src: rename async-wrap -> async_wrap

2017-11-17 12:49:00 +01:00

handle_wrap.h

src: rename async-wrap -> async_wrap

2017-11-17 12:49:00 +01:00

inspector_agent.cc

vm: allow modifying context name in inspector

2017-12-23 14:05:18 +08:00

inspector_agent.h

vm: allow modifying context name in inspector

2017-12-23 14:05:18 +08:00

inspector_io.cc

inspector: Fix crash for WS connection

2017-12-11 15:53:21 -08:00

inspector_io.h

inspector: Fix crash for WS connection

2017-12-11 15:53:21 -08:00

inspector_js_api.cc

src: rename base-object -> base_object

2017-11-17 12:49:10 +01:00

inspector_socket_server.cc

src: fix compile warnings introduced in 73ad3f9bea

2017-12-15 07:47:11 +01:00

inspector_socket_server.h

inspector: Fix crash for WS connection

2017-12-11 15:53:21 -08:00

inspector_socket.cc

inspector: make Coverity happy

2017-12-27 19:41:08 +01:00

inspector_socket.h

inspector: Fix crash for WS connection

2017-12-11 15:53:21 -08:00

js_stream.cc

src: remove redundant JSStream::DoAfterWrite

2017-12-21 20:56:13 +01:00

js_stream.h

src: remove redundant JSStream::DoAfterWrite

2017-12-21 20:56:13 +01:00

module_wrap.cc

module: print better message on esm import error

2017-12-24 17:38:36 +01:00

module_wrap.h

module: Set dynamic import callback

2017-11-29 14:16:43 -08:00

node_api_types.h

n-api: check against invalid handle scope usage

2017-10-18 11:29:45 +02:00

node_api.cc

n-api: fix memory leak in napi_async_destroy()

2017-12-18 21:33:44 +02:00

node_api.h

tools: add cpplint rule for NULL usage

2017-12-01 07:45:05 +01:00

node_buffer.cc

buffer: optimize readDouble and readFloat methods

2017-12-27 19:47:16 +01:00

node_buffer.h

src: do not include internals from node_buffer.h

2017-09-22 16:28:52 +02:00

node_config.cc

lib, src: use process.config instead of regex

2017-12-23 22:20:30 -05:00

node_constants.cc

fs: move type checking to js

2017-12-22 12:49:10 -08:00

node_constants.h

…

node_contextify.cc

vm: allow modifying context name in inspector

2017-12-23 14:05:18 +08:00

node_counters.cc

src: do not include x.h if x-inl.h is included

2017-10-30 18:56:38 +08:00

node_counters.h

src: refactor #include handling

2017-09-14 17:38:38 +02:00

node_crypto_bio.cc

crypto: remove BIO_set_shutdown

2017-12-11 07:19:55 +01:00

node_crypto_bio.h

crypto: make node_crypto_bio compat w/ OpenSSL 1.1

2017-11-11 20:42:49 +11:00

node_crypto_clienthello-inl.h

crypto: add ocsp_request ClientHelloParser::Reset

2017-12-27 19:46:48 +01:00

node_crypto_clienthello.cc

src: do not include x.h if x-inl.h is included

2017-10-30 18:56:38 +08:00

node_crypto_clienthello.h

crypto: remove unused header in clienthello.h

2017-12-19 14:36:55 +01:00

node_crypto_groups.h

…

node_crypto.cc

crypto: warn on invalid authentication tag length

2017-12-22 15:50:06 +01:00

node_crypto.h

src: replace SetAccessor w/ SetAccessorProperty

2017-12-17 12:45:39 -05:00

node_debug_options.cc

src,lib,test,doc: correct misspellings

2017-06-17 19:17:46 +02:00

node_debug_options.h

inspector: allow --inspect=host:port from js

2017-06-06 14:41:17 -07:00

node_dtrace.cc

src: do not include x.h if x-inl.h is included

2017-10-30 18:56:38 +08:00

node_dtrace.h

src: refactor #include handling

2017-09-14 17:38:38 +02:00

node_file.cc

fs: throw fs.close errors in JS

2017-12-28 03:08:25 +08:00

node_file.h

fs: refactor After for easier maintainability

2017-12-18 11:11:19 -08:00

node_http2_state.h

http2: convert Http2Settings to an AsyncWrap

2017-12-22 12:54:13 -08:00

node_http2.cc

http2: keep session objects alive during Http2Scope

2017-12-27 16:04:22 -08:00

node_http2.h

http2: keep session objects alive during Http2Scope

2017-12-27 16:04:22 -08:00

node_http_parser.cc

src: use non-deprecated versions of ->To*() utils

2017-12-01 20:37:58 +01:00

node_i18n.cc

src: use nullptr instead of NULL

2017-12-01 07:45:00 +01:00

node_i18n.h

src: refactor #include handling

2017-09-14 17:38:38 +02:00

node_internals.h

src: refactor and harden ProcessEmitWarning()

2017-12-12 17:47:37 -02:00

node_javascript.h

src: refactor #include handling

2017-09-14 17:38:38 +02:00

node_lttng_provider.h

…

node_lttng_tp.h

…

node_lttng.cc

src: do not include x.h if x-inl.h is included

2017-10-30 18:56:38 +08:00

node_lttng.h

…

node_main.cc

src: refactor #include handling

2017-09-14 17:38:38 +02:00

node_mutex.h

…

node_object_wrap.h

…

node_os.cc

src: use nullptr instead of NULL

2017-12-01 07:45:00 +01:00

node_perf_common.h

src: fix build on certain platforms

2017-08-23 19:01:19 -07:00

node_perf.cc

perf_hooks: refactor internals

2017-12-27 19:44:40 +01:00

node_perf.h

perf_hooks: refactor internals

2017-12-27 19:44:40 +01:00

node_platform.cc

src: implement getting current time in NodePlatform

2017-12-06 12:52:07 +01:00

node_platform.h

src: implement getting current time in NodePlatform

2017-12-06 12:52:07 +01:00

node_provider.d

…

node_revert.h

meta: merge TSC and CTC back into a single body

2017-08-29 08:39:25 -07:00

node_root_certs.h

crypto: update root certificates

2017-05-29 08:45:07 -07:00

node_serdes.cc

src: rename base-object -> base_object

2017-11-17 12:49:10 +01:00

node_stat_watcher.cc

src: make FSEventWrap/StatWatcher::Start more robust

2017-12-13 06:32:55 +01:00

node_stat_watcher.h

src: rename async-wrap -> async_wrap

2017-11-17 12:49:00 +01:00

node_trace_events.cc

trace_events: add executionAsyncId to init events

2017-11-24 21:52:11 +01:00

node_url.cc

url: added url fragment lookup table

2017-12-15 09:26:12 -08:00

node_url.h

src: improve module loader readability

2017-11-03 01:10:31 +01:00

node_util.cc

src: explicitly register built-in modules

2017-11-13 23:17:34 +00:00

node_v8.cc

src: explicitly register built-in modules

2017-11-13 23:17:34 +00:00

node_version.h

src: update NODE_MODULE_VERSION to 60

2017-12-06 12:52:07 +01:00

node_watchdog.cc

src: refactor #include handling

2017-09-14 17:38:38 +02:00

node_watchdog.h

vm: fix race condition with timeout param

2017-05-23 21:00:40 +02:00

node_win32_etw_provider-inl.h

tools: add cpplint rule for NULL usage

2017-12-01 07:45:05 +01:00

node_win32_etw_provider.cc

src: fix etw provider include on Windows

2017-10-31 07:53:49 -07:00

node_win32_etw_provider.h

…

node_win32_perfctr_provider.cc

src: fix size of CounterSet

2017-11-18 20:53:38 +01:00

node_win32_perfctr_provider.h

…

node_wrap.h

src: remove unused includes from node_wrap.h

2017-10-15 15:18:08 -07:00

node_zlib.cc

src: use non-deprecated versions of ->To*() utils

2017-12-01 20:37:58 +01:00

node.cc

timers: make setImmediate() immune to tampering

2017-12-26 12:37:19 -05:00

node.d

…

node.h

tools: add cpplint rule for NULL usage

2017-12-01 07:45:05 +01:00

node.stp

…

nolttng_macros.py

…

noperfctr_macros.py

src: rename perfctr_macros.py->noperfctr_macros.py

2017-10-11 07:42:02 +02:00

notrace_macros.py

…

pipe_wrap.cc

async_hooks: use scope for defaultTriggerAsyncId

2017-12-19 18:04:52 +01:00

pipe_wrap.h

async_wrap: add provider types for net server

2017-11-28 02:50:54 +01:00

process_wrap.cc

src: use non-deprecated versions of ->To*() utils

2017-12-01 20:37:58 +01:00

req_wrap-inl.h

domain: re-implement domain over async_hook

2017-11-19 17:39:19 +01:00

req_wrap.h

src: rename req-wrap -> req_wrap

2017-11-17 12:49:20 +01:00

signal_wrap.cc

src: rename async-wrap -> async_wrap

2017-11-17 12:49:00 +01:00

spawn_sync.cc

src: make ownership of stdio_pipes explicit

2017-11-16 16:54:00 +01:00

spawn_sync.h

src: make ownership of stdio_pipes explicit

2017-11-16 16:54:00 +01:00

StartComAndWoSignData.inc

…

stream_base-inl.h

async_hooks: use scope for defaultTriggerAsyncId

2017-12-19 18:04:52 +01:00

stream_base.cc

async_hooks: use scope for defaultTriggerAsyncId

2017-12-19 18:04:52 +01:00

stream_base.h

net,src: refactor writeQueueSize tracking

2017-12-18 09:58:02 -05:00

stream_wrap.cc

net,src: refactor writeQueueSize tracking

2017-12-18 09:58:02 -05:00

stream_wrap.h

net,src: refactor writeQueueSize tracking

2017-12-18 09:58:02 -05:00

string_bytes.cc

src: do not include internals from node_buffer.h

2017-09-22 16:28:52 +02:00

string_bytes.h

src: remove unused includes in string_bytes.h

2017-11-01 08:44:46 +01:00

string_search.cc

…

string_search.h

module: speed up package.json parsing more

2017-11-15 12:01:20 +01:00

tcp_wrap.cc

async_hooks: use scope for defaultTriggerAsyncId

2017-12-19 18:04:52 +01:00

tcp_wrap.h

async_wrap: add provider types for net server

2017-11-28 02:50:54 +01:00

timer_wrap.cc

timers: make setImmediate() immune to tampering

2017-12-26 12:37:19 -05:00

tls_wrap.cc

net,src: refactor writeQueueSize tracking

2017-12-18 09:58:02 -05:00

tls_wrap.h

src: remove nonexistent method from header file

2017-12-19 03:04:56 +01:00

tty_wrap.cc

net,src: refactor writeQueueSize tracking

2017-12-18 09:58:02 -05:00

tty_wrap.h

src: remove unused include in tty_wrap.h

2017-10-25 07:43:41 +02:00

udp_wrap.cc

async_hooks: use scope for defaultTriggerAsyncId

2017-12-19 18:04:52 +01:00

udp_wrap.h

src: replace SetAccessor w/ SetAccessorProperty

2017-12-17 12:45:39 -05:00

util-inl.h

…

util.cc

src: use uv_os_getpid() to get process id

2017-12-04 10:34:28 -05:00

util.h

src: introduce USE() for silencing compiler warnings

2017-11-29 15:58:42 +01:00

uv.cc

src: expose uv.errmap to binding

2017-12-28 03:08:25 +08:00

v8abbr.h

src: fix rename of entry frame in v8abbr.h

2017-10-18 17:03:45 -07:00

v8ustack.d

src: update ustack offset identifiers

2017-10-18 17:03:11 -07:00