Anna Henningsen e1df6881c5 src: do not cache NumberOfHeapSpaces() globally ...

While `NumberOfHeapSpaces()` currently returns a constant value,
that is not strictly guaranteed by the V8 API as far as I can tell.
Therefore, caching it globally does not seem appropriate.

(The motivation here is that this squelches warnings which are
produced by concurrency debugging tooling due to the apparent
race conditions when accessing the global variable.)

PR-URL: https://github.com/nodejs/node/pull/20971
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

2018-06-01 11:22:31 +02:00

..

inspector

inspector: get rid of the make_unique

2018-05-22 16:29:31 -07:00

res

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

tracing

src: remove unused private data member

2018-05-30 15:00:11 +02:00

aliased_buffer.h

src: fix warnings in aliased_buffer

2018-03-30 22:56:19 -07:00

async_wrap-inl.h

src: move v8::HandleScope call to Emit

2018-04-20 10:58:06 +05:30

async_wrap.cc

src: implement debug output utilities

2018-05-31 09:54:48 +02:00

async_wrap.h

src: implement debug output utilities

2018-05-31 09:54:48 +02:00

backtrace_posix.cc

src: remove superfluous check in backtrace_posix.cc

2017-11-18 20:58:12 +01:00

backtrace_win32.cc

src: implement backtrace-on-abort for windows

2017-11-15 19:28:13 +01:00

base64.h

src: make base64.h self-contained

2017-11-27 07:21:08 +01:00

base_object-inl.h

src: use cleanup hooks to tear down BaseObjects

2018-05-10 14:15:17 +02:00

base_object.h

src: use cleanup hooks to tear down BaseObjects

2018-05-10 14:15:17 +02:00

bootstrapper.cc

src: refactor bootstrap to use bootstrap object

2018-05-31 14:05:53 -07:00

callback_scope.cc

src: add CHECK_IMPLIES macro

2018-05-26 12:29:12 +02:00

cares_wrap.cc

src: replace template< → template <

2018-05-14 18:09:23 +02:00

connect_wrap.cc

src: refactor BaseObject internal field management

2018-05-04 00:57:39 +02:00

connect_wrap.h

src: refactor BaseObject internal field management

2018-05-04 00:57:39 +02:00

connection_wrap.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

connection_wrap.h

src: make CleanupHandles() tear down handles/reqs

2018-05-10 14:15:16 +02:00

debug_utils.h

src: implement debug output utilities

2018-05-31 09:54:48 +02:00

env-inl.h

src: implement debug output utilities

2018-05-31 09:54:48 +02:00

env.cc

src: fix GetCpuProfiler() deprecation warning

2018-06-01 09:59:42 +02:00

env.h

Revert "src: fix GetCpuProfiler() deprecation warning"

2018-06-01 09:59:40 +02:00

exceptions.cc

src: re-integrate headers into node.h

2018-05-24 08:49:23 -07:00

fs_event_wrap.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

handle_wrap.cc

src: make CleanupHandles() tear down handles/reqs

2018-05-10 14:15:16 +02:00

handle_wrap.h

src: always call ReadStop() before Close()

2018-05-10 14:15:18 +02:00

inspector_agent.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

inspector_agent.h

inspector: add a "NodeTracing" domain support

2018-05-17 13:14:26 -07:00

inspector_io.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

inspector_io.h

inspector: add a "NodeTracing" domain support

2018-05-17 13:14:26 -07:00

inspector_js_api.cc

src: replace template< → template <

2018-05-14 18:09:23 +02:00

inspector_socket_server.cc

src: replace template< → template <

2018-05-14 18:09:23 +02:00

inspector_socket_server.h

inspector: report client-visible host and port

2018-04-02 10:20:30 -07:00

inspector_socket.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

inspector_socket.h

inspector: report client-visible host and port

2018-04-02 10:20:30 -07:00

js_stream.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

js_stream.h

src: refactor BaseObject internal field management

2018-05-04 00:57:39 +02:00

module_wrap.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

module_wrap.h

src: prevent persistent handle resource leaks

2018-02-21 15:24:18 +01:00

node_api_types.h

n-api: add methods to open/close callback scope

2018-02-05 17:10:19 -05:00

node_api.cc

n-api: throw when entry point is null

2018-05-23 22:14:52 -04:00

node_api.h

src: add environment cleanup hooks

2018-05-10 14:15:16 +02:00

node_buffer.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

node_buffer.h

buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength

2018-04-04 14:09:51 +08:00

node_config.cc

module: add --preserve-symlinks-main

2018-05-13 00:28:16 +03:00

node_constants.cc

fs: refactor fs module

2018-05-20 14:15:56 -07:00

node_constants.h

crypto: add sign/verify support for RSASSA-PSS

2017-04-01 13:27:52 +02:00

node_context_data.h

vm: add code generation options

2018-03-12 14:39:21 -05:00

node_contextify.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

node_contextify.h

src: make env_ and context_ private

2018-05-14 05:51:16 +02:00

node_counters.cc

src: add node_internal.h includes for arraysize

2018-04-12 15:28:11 +02:00

node_counters.h

src: refactor #include handling

2017-09-14 17:38:38 +02:00

node_crypto_bio.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

node_crypto_bio.h

crypto: make node_crypto_bio compat w/ OpenSSL 1.1

2017-11-11 20:42:49 +11:00

node_crypto_clienthello-inl.h

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

node_crypto_clienthello.cc

src: do not include x.h if x-inl.h is included

2017-10-30 18:56:38 +08:00

node_crypto_clienthello.h

crypto: remove unused header in clienthello.h

2017-12-19 14:36:55 +01:00

node_crypto_groups.h

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

node_crypto.cc

crypto: throw in setAuthTag on invalid length

2018-06-01 09:52:27 +02:00

node_crypto.h

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

node_debug_options.cc

src,lib,test,doc: correct misspellings

2017-06-17 19:17:46 +02:00

node_debug_options.h

inspector: allow --inspect=host:port from js

2017-06-06 14:41:17 -07:00

node_domain.cc

domain: further abstract usage in C++

2018-01-29 11:37:29 -05:00

node_dtrace.cc

src: throw ERR_INVALID_ARG_TYPE in C++ argument checks

2018-04-19 12:09:26 +08:00

node_dtrace.h

src: refactor #include handling

2017-09-14 17:38:38 +02:00

node_errors.h

src: order C++ error list alphabetically

2018-05-16 09:01:23 +04:00

node_file.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

node_file.h

src: refactor BaseObject internal field management

2018-05-04 00:57:39 +02:00

node_http2_state.h

http2: rename http2_state class to Http2State

2018-05-06 21:37:55 +02:00

node_http2.cc

http2: force through RST_STREAM in destroy

2018-06-01 10:58:26 +02:00

node_http2.h

http2: force through RST_STREAM in destroy

2018-06-01 10:58:26 +02:00

node_http_parser.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

node_i18n.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

node_i18n.h

src: refactor #include handling

2017-09-14 17:38:38 +02:00

node_internals.h

src: refactor bootstrap to use bootstrap object

2018-05-31 14:05:53 -07:00

node_javascript.h

src: move internal loaders out of bootstrap_node.js

2018-03-06 22:12:46 +08:00

node_main.cc

test: shared lib build doesn't handle SIGPIPE

2018-03-12 16:56:04 -07:00

node_mutex.h

…

node_object_wrap.h

src: remove MarkIndependent() calls

2018-04-22 11:23:29 +02:00

node_os.cc

src: use nullptr instead of NULL

2017-12-01 07:45:00 +01:00

node_perf_common.h

perf_hooks,trace_events: emit perf milestone trace events

2018-03-16 10:54:05 -07:00

node_perf.cc

perf_hooks: simplify perf_hooks

2018-04-03 13:57:41 -07:00

node_perf.h

perf_hooks,trace_events: emit perf milestone trace events

2018-03-16 10:54:05 -07:00

node_persistent.h

src: prevent persistent handle resource leaks

2018-02-21 15:24:18 +01:00

node_platform.cc

src: trace_events: background thread events

2018-05-21 11:16:44 -07:00

node_platform.h

src: limit foreground tasks draining loop

2018-04-25 10:40:16 +02:00

node_postmortem_metadata.cc

src: standardise context embedder indices

2018-03-07 12:19:38 -06:00

node_provider.d

…

node_revert.h

meta: merge TSC and CTC back into a single body

2017-08-29 08:39:25 -07:00

node_root_certs.h

src: drop CNNIC+StartCom certificate whitelisting

2018-03-26 18:20:16 -04:00

node_serdes.cc

src: refactor BaseObject internal field management

2018-05-04 00:57:39 +02:00

node_stat_watcher.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

node_stat_watcher.h

fs: improve errors in watchFile and unwatchFile

2018-03-19 07:40:47 +08:00

node_trace_events.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

node_types.cc

util: add type check function for BigIntObject

2018-06-01 09:59:37 +02:00

node_url.cc

url: introduce URL_FLAGS_IS_DEFAULT_SCHEME_PORT flag

2018-05-18 15:24:05 +02:00

node_url.h

url: introduce URL_FLAGS_IS_DEFAULT_SCHEME_PORT flag

2018-05-18 15:24:05 +02:00

node_util.cc

lib,src: use V8 API for collection inspection

2018-05-19 01:02:14 +02:00

node_v8.cc

src: do not cache NumberOfHeapSpaces() globally

2018-06-01 11:22:31 +02:00

node_version.h

2018-04-24, Version 10.0.0 (Current)

2018-04-24 12:02:31 -07:00

node_watchdog.cc

src: refactor #include handling

2017-09-14 17:38:38 +02:00

node_watchdog.h

vm: fix race condition with timeout param

2017-05-23 21:00:40 +02:00

node_win32_etw_provider-inl.h

tools: add cpplint rule for NULL usage

2017-12-01 07:45:05 +01:00

node_win32_etw_provider.cc

src: fix etw provider include on Windows

2017-10-31 07:53:49 -07:00

node_win32_etw_provider.h

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

node_win32_perfctr_provider.cc

src: fix inconsistency in extern declaration

2018-05-05 13:47:43 +02:00

node_win32_perfctr_provider.h

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

node_wrap.h

src: refactor BaseObject internal field management

2018-05-04 00:57:39 +02:00

node_zlib.cc

src: add override to ThreadPool methods in zlib

2018-05-18 06:17:16 +02:00

node.cc

src: refactor bootstrap to use bootstrap object

2018-05-31 14:05:53 -07:00

node.d

…

node.h

src: re-integrate headers into node.h

2018-05-24 08:49:23 -07:00

node.stp

src: fix Systemtap node_gc_stop probe

2018-04-25 12:22:47 -03:00

noperfctr_macros.py

src: rename perfctr_macros.py->noperfctr_macros.py

2017-10-11 07:42:02 +02:00

notrace_macros.py

…

pipe_wrap.cc

net: allow IPC servers be accessible by all

2018-05-24 11:06:12 +02:00

pipe_wrap.h

net: allow IPC servers be accessible by all

2018-05-24 11:06:12 +02:00

process_wrap.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

req_wrap-inl.h

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

req_wrap.h

src: keep track of open requests

2018-05-10 14:15:16 +02:00

signal_wrap.cc

src: rename async-wrap -> async_wrap

2017-11-17 12:49:00 +01:00

spawn_sync.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

spawn_sync.h

src: make ownership of stdio_pipes explicit

2017-11-16 16:54:00 +01:00

stream_base-inl.h

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

stream_base.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

stream_base.h

src: refactor BaseObject internal field management

2018-05-04 00:57:39 +02:00

stream_pipe.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

stream_pipe.h

src: introduce native-layer stream piping

2018-03-15 12:53:13 +01:00

stream_wrap.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

stream_wrap.h

src: always call ReadStop() before Close()

2018-05-10 14:15:18 +02:00

string_bytes.cc

src: rename ERR_STRING_TOO_LARGE to ERR_STRING_TOO_LONG

2018-04-10 01:08:10 +02:00

string_bytes.h

src: fix fs.write() externalized string handling

2018-01-23 19:17:39 +01:00

string_decoder-inl.h

string_decoder: reimplement in C++

2018-02-10 14:38:56 +01:00

string_decoder.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

string_decoder.h

string_decoder: reimplement in C++

2018-02-10 14:38:56 +01:00

string_search.h

src: remove static variables from string_search

2018-05-09 20:18:27 +02:00

tcp_wrap.cc

src: store fd for libuv streams on Windows

2018-05-10 14:15:17 +02:00

tcp_wrap.h

src: remove unnecessary Reset() calls

2018-02-21 15:24:18 +01:00

timer_wrap.cc

src: break out of timers loop if !can_call_into_js()

2018-05-31 11:53:30 +02:00

tls_wrap.cc

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

tls_wrap.h

src: remove unused util.h from tls_wrap.h

2018-04-09 16:37:12 +02:00

tty_wrap.cc

src: remove unused req_wrap-inl.h

2018-05-30 05:19:13 +02:00

tty_wrap.h

src: remove unused include in tty_wrap.h

2017-10-25 07:43:41 +02:00

udp_wrap.cc

src: unify ReqWrap libuv calling

2018-05-10 14:15:16 +02:00

udp_wrap.h

src: remove unused req_wrap-inl.h

2018-05-30 05:19:13 +02:00

util-inl.h

src: implement debug output utilities

2018-05-31 09:54:48 +02:00

util.cc

src: use uv_os_getpid() to get process id

2017-12-04 10:34:28 -05:00

util.h

src: implement debug output utilities

2018-05-31 09:54:48 +02:00

uv.cc

src: name all builtin init functions Initialize

2018-03-26 08:23:49 +02:00

v8abbr.h

src: update postmortem constant name

2018-06-01 09:59:50 +02:00

v8ustack.d

src: update ustack offset identifiers

2017-10-18 17:03:11 -07:00