BackPup/Linux
1
0 Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-07 05:31:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

PCI: Prevent out of bounds access in numa_node override

Browse Source 
Commit 1266963170 ("PCI: Prevent out of bounds access in numa_node
override") missed that the user-provided node could also be negative.
Handle this case as well to avoid out-of-bounds accesses to the
node_states[] array.  However, allow the special value -1, i.e.
NUMA_NO_NODE, to be able to set the 'no specific node' configuration.

Fixes: 1266963170 ("PCI: Prevent out of bounds access in numa_node override")
Fixes: 63692df103 ("PCI: Allow numa_node override via sysfs")
Signed-off-by: Mathias Krause <[email protected]>
Signed-off-by: Bjorn Helgaas <[email protected]>
CC: Sasha Levin <[email protected]>
CC: Prarit Bhargava <[email protected]>
CC: [email protected]	# v3.19+
This commit is contained in:
Mathias Krause authored and Bjorn Helgaas committed 2015-11-24 12:33:13 -06:00
1 parent 1ec218373b
commit 3dcc8d39cf
1 file changed
+4 -1
Download Patch File Download Diff File Expand all files Collapse all files
drivers/pci/pci-sysfs.c
+4 -1
View File
@@ -216,7 +216,10 @@ static ssize_t numa_node_store(struct device *dev,
if (ret)
return ret;
if (node >= MAX_NUMNODES || !node_online(node))
if ((node < 0 && node != NUMA_NO_NODE) || node >= MAX_NUMNODES)
return -EINVAL;
if (node != NUMA_NO_NODE && !node_online(node))
return -EINVAL;
add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);