BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-14 10:26:26 -04:00
Code Issues Packages Projects Releases Wiki Activity
23,522 Commits 236 Branches 964 Tags
eef072fa083f05f84fa6ca1908472eb228095a38
Commit Graph
97 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Refael Ackermann 8569f4a417 test: refacor spawn[Sync]Pwd 
* extract the gist into common.pwdCommand
* Merge test-child-process-buffering.js into test-child-process-stdio.js

PR-URL: https://github.com/nodejs/node/pull/22522
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2018-08-29 17:32:13 -04:00
Refael Ackermann 3579ec4171 test: flaky everywhere test-trace-events-fs-sync 
Refs: https://github.com/nodejs/node/issues/21038

PR-URL: https://github.com/nodejs/node/pull/22483
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2018-08-24 19:13:30 +02:00
Refael Ackermann 9acf4c5492 build,tools: tweak the travis config 
PR-URL: https://github.com/nodejs/node/pull/22417
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2018-08-23 11:29:59 -04:00
Refael Ackermann d32051147c build: use npm ci 
* remove obsolete `node_modules/js-yaml/package.json` target
* remove `@touch` since `npm ci` is always destructive

PR-URL: https://github.com/nodejs/node/pull/22399
Refs: https://github.com/nodejs/node/pull/21802
Refs: https://github.com/nodejs/node/pull/21490
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Sam Ruby <rubys@intertwingly.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
 2018-08-22 20:19:54 -04:00
Refael Ackermann 73b8ddee04 doc: Windows building supported on x64 
Since we are CI testing on x64 hosts, we can only commit to x64 hosts.

PR-URL: https://github.com/nodejs/node/pull/21443
Refs: https://github.com/nodejs/node/issues/21402
Refs: https://github.com/nodejs/node/pull/21437
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: João Reis <reis@janeasystems.com>
 2018-08-16 19:07:52 -04:00
Refael Ackermann 4ce744a24b test: call gc() explicitly to avoid OOM 
PR-URL: https://github.com/nodejs/node/pull/22301
Refs: https://github.com/nodejs/reliability/issues/12
Refs: https://github.com/nodejs/node/issues/16354
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
 2018-08-14 02:27:32 -04:00
Refael Ackermann be8cfc7f7e build: don't change locale on smartos 
PR-URL: https://github.com/nodejs/node/pull/21220
Fixes: https://github.com/nodejs/build/issues/1327
Refs: https://github.com/nodejs/node/pull/20394
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2018-06-08 16:34:41 -07:00
Refael Ackermann a3db1cc514 tools: include exit code in TAP log 
PR-URL: https://github.com/nodejs/node/pull/19855
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
 2018-04-11 21:04:09 -07:00
Refael Ackermann 53035b142b build,windows: make vcbuild fail if upload fails 
Refs: https://github.com/nodejs/build/issues/1211
 2018-04-08 12:32:21 -04:00
Refael Ackermann 4c8bedf8b4 doc: examples for fast-tracking regression fixes 
PR-URL: https://github.com/nodejs/node/pull/17379
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2018-01-09 16:27:12 -08:00
Refael Ackermann 15016f227b test: add more asserts to test-internal-errors 
PR-URL: https://github.com/nodejs/node/pull/13686
Fixes: https://github.com/nodejs/node/issues/13682
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2018-01-06 04:04:29 +01:00
Refael Ackermann 29d99c1885 test: fix common.expectsError 
The function should strictly test for the error class and only accept
the correct one. Any other error class should fail.

PR-URL: https://github.com/nodejs/node/pull/13686
Fixes: https://github.com/nodejs/node/issues/13682
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2018-01-06 04:04:29 +01:00
Refael Ackermann 51a7d97625 tools: don't lint-md as part of main lint target 
PR-URL: https://github.com/nodejs/node/pull/17587
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2017-12-11 11:53:28 -05:00
Refael Ackermann 9fb390a1c6 build,win: vcbuild refactoring call configure 
PR-URL: https://github.com/nodejs/node/pull/17299
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2017-12-02 18:01:39 -05:00
Refael Ackermann fff3792e71 tools,test: use Execute instead of check_output 
subprocess.check_output is a python2.7 only feature. Using Execute
allows keeping python2.6 compatibility

PR-URL: https://github.com/nodejs/node/pull/17381
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
 2017-11-29 20:33:38 -05:00
Refael Ackermann 41c45fd6d2 doc: clarify fast-track of reversions 
PR-URL: https://github.com/nodejs/node/pull/17332
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
 2017-11-28 17:39:53 -05:00
Refael Ackermann 283b949404 test: bypass dns for IPv6 net tests 
PR-URL: https://github.com/nodejs/node/pull/16976
Refs: https://github.com/nodejs/node/pull/16248
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2017-11-21 16:37:39 -05:00
Refael Ackermann 66e2751e0a tools: bump remark-cli to 4.0 
PR-URL: https://github.com/nodejs/node/pull/17028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
 2017-11-18 20:44:17 +01:00
Refael Ackermann 61793dffe3 tools: speed up lint-md-build 
by using package-lock.json

PR-URL: https://github.com/nodejs/node/pull/16945
Fixes: https://github.com/nodejs/node/issues/16628
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-11-14 15:53:15 -05:00
Refael Ackermann dbb3c00d9d meta: 32 bit linux is experimental 
PR-URL: https://github.com/nodejs/node/pull/16723
Refs: https://github.com/nodejs/build/issues/885
Refs: https://github.com/nodejs/nodejs.org/pull/1446
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2017-11-13 14:56:31 -05:00
Refael Ackermann 074a5c79d4 test: flag known flake 
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017
 2017-11-11 12:00:04 +05:30
Refael Ackermann e6245030b1 tools,build: allow build without remark-cli 
PR-URL: https://github.com/nodejs/node/pull/16893
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2017-11-10 17:09:28 -05:00
Refael Ackermann 75095d7001 test: mark test-async-wrap-uncaughtexception as flaky 
`parallel/test-async-wrap-uncaughtexception.js` has become flaky.
At this time investigating the cause is still on going, but this issue
become has prevalent. In order to restore CI status to be relevant,
this marks the test as explicitly FLAKY.

PR-URL: https://github.com/nodejs/node/pull/16694
Refs: https://github.com/nodejs/node/issues/16210
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2017-11-02 22:49:53 -04:00
Refael Ackermann 9ab648120c build: improve make clean 
also undocument the `vcbuild.bat` command since it's broken
and seems to only be relevant to release builds

PR-URL: https://github.com/nodejs/node/pull/16372
Refs: https://github.com/nodejs/node/pull/16010
Refs: https://github.com/nodejs/node/issues/16278
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-10-26 18:38:36 -04:00
Refael Ackermann 2be9198097 test: change tmp directories prefix 
`.tmp` prefix allows easier exclusion

PR-URL: https://github.com/nodejs/node/pull/16372
Refs: https://github.com/nodejs/node/pull/16010
Refs: https://github.com/nodejs/node/issues/16278
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-10-26 18:38:34 -04:00
Refael Ackermann 748f5d848f tools: no trailing slash in ignore patterns 
Makes eslint exclude directories without enumerating their content

PR-URL: https://github.com/nodejs/node/pull/16372
Refs: https://github.com/nodejs/node/pull/16010
Refs: https://github.com/nodejs/node/issues/16278
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-10-26 18:38:32 -04:00
Refael Ackermann 7671f253f2 doc: add recommendations for first timers 
PR-URL: https://github.com/nodejs/node/pull/16350
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
 2017-10-24 10:26:20 -04:00
Refael Ackermann c3ae57f253 build: revert "call setlocal in vcbuild.bat" 
This reverts commit b9a55a93c9.

PR-URL: https://github.com/nodejs/node/pull/16270
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2017-10-19 18:35:28 -04:00
Refael Ackermann 88d05aa43b build: restore mistakenly dropped suites 
suites dropped during the last commit by a typo
restore $(CI_JS_SUITES) to test-ci-js
restore $(CI_NATIVE_SUITES) for `test-ci`
and var assignment tweak

PR-URL: https://github.com/nodejs/node/pull/16132
Fixes: https://github.com/nodejs/node/issues/16129
Fixes: https://github.com/nodejs/build/issues/910
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin E. Coe <ben@npmjs.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
 2017-10-12 10:56:12 -04:00
Refael Ackermann 5f469446e1 errors,tools: ASCIIbetical instead of alphabetical 
PR-URL: https://github.com/nodejs/node/pull/15578
Fixes: https://github.com/nodejs/node/issues/15576
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2017-09-28 09:16:20 -04:00
Refael Ackermann 64e97b2c26 doc: improve fs.utimes 
PR-URL: https://github.com/nodejs/node/pull/14154
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2017-09-28 02:16:22 -03:00
Refael Ackermann 01c680b92a test: refactor test for readability 
PR-URL: https://github.com/nodejs/node/pull/13003
Fixes: https://github.com/nodejs/node/issues/12951
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2017-09-20 16:41:31 -04:00
Refael Ackermann b8d532c4bd test: allow adding known-globals through ENV 
PR-URL: https://github.com/nodejs/node/pull/15187
Refs: https://youtrack.jetbrains.com/issue/WEB-27528
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2017-09-13 17:07:00 -04:00
Refael Ackermann 94be2b1793 test: kill subprocess only after last ACK 
* Add multiple comments.
* Switch to a persistent fixture for subprocess.
* Assert that `send` queue is drained.

PR-URL: https://github.com/nodejs/node/pull/15186
Fixes: https://github.com/nodejs/node/issues/15176
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-09-10 20:23:04 -04:00
Refael Ackermann 86e7c61a07 test: split test-cli-node-options 
* partitioning the subprocess groups
* use `-e` instead of module
* reduce maxBuffer

PR-URL: https://github.com/nodejs/node/pull/14195
Fixes: https://github.com/nodejs/node/issues/14191
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2017-09-04 17:52:32 -04:00
Refael Ackermann 233d1e276a test,process: run 'abort' suite on Windows 
PR-URL: https://github.com/nodejs/node/pull/15056
Fixes: https://github.com/nodejs/node/issues/14012
Refs: https://github.com/nodejs/node/pull/14013
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2017-09-03 17:20:20 -04:00
Refael Ackermann 98d8db3299 tools: bump vswhere helper to 2.0.0 
* enable explicit detection of prerelease VS versions with
  `set VSWHERE_WITH_PRERELEASE=1`

PR-URL: https://github.com/nodejs/node/pull/14557
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
 2017-09-03 17:15:27 -04:00
Refael Ackermann 0babb12494 doc: building - note on Windows SDK 15063 
PR-URL: https://github.com/nodejs/node/pull/14394
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2017-08-27 11:00:49 -03:00
Refael Ackermann 327077ce43 tools: update GYP to 324dd166 
PR-URL: https://github.com/nodejs/node/pull/14718
Refs: https://chromium.googlesource.com/external/gyp/+/324dd166b7c0b39d513026fa52d6280ac6d56770
Refs: https://github.com/refack/GYP/commit/324dd166b7c0b39d513026fa52d6280ac6d56770
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-08-23 16:24:28 -04:00
Refael Ackermann 0ce54a7ec9 test: improve assertion fail messages 
PR-URL: https://github.com/nodejs/node/pull/14949
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-08-23 10:25:44 -07:00
Refael Ackermann 85d7d97d81 doc: delint 
PR-URL: https://github.com/nodejs/node/pull/14707
Refs: https://github.com/nodejs/node/pull/12756
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2017-08-14 08:13:07 -04:00
Refael Ackermann 6d84e30087 doc: fix header level typo 
PR-URL: https://github.com/nodejs/node/pull/14707
Refs: https://github.com/nodejs/node/pull/12756
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2017-08-14 08:13:07 -04:00
Refael Ackermann ac8126749c doc: error message are still major 
PR-URL: https://github.com/nodejs/node/pull/14375
Refs: https://github.com/nodejs/node/issues/13937
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2017-07-21 15:36:28 -04:00
Refael Ackermann 95ab966a74 test: disable MultipleEnvironmentsPerIsolate 
This is a temporary measure until the issue is fixed.

PR-URL: https://github.com/nodejs/node/pull/14246
Refs: https://github.com/nodejs/node/issues/14206
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
 2017-07-15 18:57:48 -07:00
Refael Ackermann c34ae48083 test: make common.PIPE process unique 
* includes a tiny bit of refactoring in adjacent lines.
* fixes 1 test and 1 benchmark that depended on PIPE being constant.

PR-URL: https://github.com/nodejs/node/pull/14168
Fixes: https://github.com/nodejs/node/issues/14128
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-07-14 19:36:10 -04:00
Refael Ackermann 4d7946aec3 test: ignore connection errors for hostname check 
PR-URL: https://github.com/nodejs/node/pull/14073
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2017-07-09 14:01:59 -04:00
Refael Ackermann 8206a01c99 build,win: skip vcvarsall.bat if env is set 
PR-URL: https://github.com/nodejs/node/pull/13806
Fixes: https://github.com/nodejs/node/issues/13765
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-07-09 13:21:33 -04:00
Refael Ackermann d69ecc6f51 Revert "test: improve test-process-kill-null for Windows" 
This reverts commit 44483b6898.

PR-URL: https://github.com/nodejs/node/pull/14142
Fixes: https://github.com/nodejs/node/issues/14141
Refs: https://github.com/nodejs/node/pull/14099
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2017-07-09 13:08:17 -04:00
Refael Ackermann 46d7cb88c7 tools: eslint - use error and off 
PR-URL: https://github.com/nodejs/node/pull/14061
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2017-07-05 16:41:19 -04:00
Refael Ackermann 4b276e985f http: guard against failed sockets creation 
PR-URL: https://github.com/nodejs/node/pull/13839
Fixes: https://github.com/nodejs/node/issues/13045
Fixes: https://github.com/nodejs/node/issues/13831
Refs: https://github.com/nodejs/node/issues/13352
Refs: https://github.com/nodejs/node/issues/13548#issuecomment-307177400
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
 2017-07-03 15:15:43 -04:00
Refael Ackermann ed19a18b72 test: mark test-npm-install flaky on arm 
PR-URL: https://github.com/nodejs/node/pull/14035
Refs: https://github.com/nodejs/node/issues/14015
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2017-07-02 18:29:27 -04:00
Refael Ackermann 7022260b55 build: add async-hooks testing to vcbuild.bat 
PR-URL: https://github.com/nodejs/node/pull/13381
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
 2017-07-01 22:02:45 -04:00
Refael Ackermann 372b85df4b test,async_hooks: stabilize tests on Windows 
PR-URL: https://github.com/nodejs/node/pull/13381
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
 2017-07-01 22:02:39 -04:00
Refael Ackermann 9e5a2118cc build,windows: restore DISTTYPEDIR 
* rename :exit to :distexit

PR-URL: https://github.com/nodejs/node/pull/13969
Refs: https://github.com/nodejs/node/pull/13900#pullrequestreview-46906389
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
 2017-06-30 16:12:07 -04:00
Refael Ackermann 614dbbd728 build,windows: implement PEP514 python detection 
PR-URL: https://github.com/nodejs/node/pull/13900
Fixes: https://github.com/nodejs/node/issues/13882
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2017-06-28 11:46:24 -04:00
Refael Ackermann 0526f84ad3 src,fs: calculate times as unsigned long 
PR-URL: https://github.com/nodejs/node/pull/13281
Fixes: https://github.com/nodejs/node/issues/13255
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-06-27 17:04:16 -04:00
Refael Ackermann e3ea0fc97b doc: update backporting guide 
* also update STYLE_GUIDE comment about Em dashes

PR-URL: https://github.com/nodejs/node/pull/13749
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
 2017-06-23 15:21:54 -04:00
Refael Ackermann 32c7f114c5 test: improve async-hooks/test-callback-error 
PR-URL: https://github.com/nodejs/node/pull/13559
Fixes: https://github.com/nodejs/node/issues/13527
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
 2017-06-21 06:13:04 -04:00
Refael Ackermann fe2caf6fb5 test: fix test-inspector-port-zero-cluster 
* re-implemented test to parse args instead of post binding (exit 12)
* saved failing case as known issue

PR-URL: https://github.com/nodejs/node/pull/13373
Fixes: https://github.com/nodejs/node/issues/13343
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-06-16 07:14:25 -04:00
Refael Ackermann af3aa682ac util: add callbackify 
Add `util.callbackify(function)` for creating callback style functions
from functions returning a `Thenable`

PR-URL: https://github.com/nodejs/node/pull/12712
Fixes: https://github.com/nodejs/CTC/issues/109
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2017-06-10 22:49:28 -04:00
Refael Ackermann 780acc2208 build,windows: check for VS version and arch 
PR-URL: https://github.com/nodejs/node/pull/13485
Fixes: https://github.com/nodejs/node/issues/13398
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-06-10 16:56:28 -04:00
Refael Ackermann df02f391aa build: merge test suite groups 
PR-URL: https://github.com/nodejs/node/pull/13378
Refs: https://github.com/nodejs/node/pull/13340
Refs: https://github.com/nodejs/node/pull/13336
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
 2017-06-10 13:22:16 -04:00
Refael Ackermann c9d45c4505 test: harden test-dgram-bind-shared-ports 
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

PR-URL: https://github.com/nodejs/node/pull/13100
Refs: https://github.com/nodejs/node/issues/13055
Refs: https://github.com/nodejs/node/pull/12999
Refs: https://github.com/nodejs/node/issues/13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2017-06-09 17:14:44 -04:00
Refael Ackermann d958bf88b8 doc: update new CTC members 
Ref: https://github.com/nodejs/node/issues/12789
Ref: https://github.com/nodejs/node/issues/12790
PR-URL: https://github.com/nodejs/node/pull/13534
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2017-06-08 18:51:17 +02:00
Refael Ackermann 8d2bd5fa88 test,benchmark: stabilize child-process 
also some cleanup

PR-URL: https://github.com/nodejs/node/pull/13457
Refs: https://github.com/nodejs/node/issues/12817
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2017-06-07 16:27:00 -04:00
Refael Ackermann 47b9772f52 fs: expose Stats times as Numbers 
PR-URL: https://github.com/nodejs/node/pull/13173
Fixes: https://github.com/nodejs/node/issues/8276
Refs: https://github.com/nodejs/node/pull/12607
Refs: https://github.com/nodejs/node/pull/12818
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
 2017-06-07 16:15:45 -04:00
Refael Ackermann c05561eb05 test,fs: test fs.watch for filename 
PR-URL: https://github.com/nodejs/node/pull/13411
Refs: https://github.com/nodejs/node/pull/13385
Refs: https://github.com/nodejs/node/issues/13248
Refs: https://github.com/nodejs/node/issues/13377
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-06-07 08:49:04 -04:00
Refael Ackermann f06c05cf5a src: remove ' print modifier 
It is not supported on Windows so it emits:
warning C4476: 'fprintf' :
  unknown type field character ''' in format specifier
warning C4474: 'fprintf' :
  too many arguments passed for format string

PR-URL: https://github.com/nodejs/node/pull/13447
Fixes: https://github.com/nodejs/node/issues/13463
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
 2017-06-06 11:16:58 -04:00
Refael Ackermann 30a20bda7d test,module: make message check MUI dependent 
PR-URL: https://github.com/nodejs/node/pull/13393
Fixes: https://github.com/nodejs/node/issues/13376
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2017-06-05 17:20:16 -04:00
Refael Ackermann 45d78393a9 test: mark inspector-port-zero-cluster as flaky 
Ref: https://github.com/nodejs/node/issues/13343
 2017-06-01 18:22:06 -04:00
Refael Ackermann 16689e30ae inspector: --debug* deprecation and invalidation 
PR-URL: https://github.com/nodejs/node/pull/12949
Fixes: https://github.com/nodejs/node/issues/12364
Fixes: https://github.com/nodejs/node/issues/12630
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2017-05-29 11:33:59 -04:00
Refael Ackermann c1a4b531fb build: ignore more VC++ artifacts 
PR-URL: https://github.com/nodejs/node/pull/13208
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-05-27 17:07:37 -04:00
Refael Ackermann 6bfdeedce5 async_wrap: add asyncReset to TLSWrap 
When using an Agent for HTTPS, `TLSSocket`s are reused and need to
have the ability to `asyncReset` from JS.

PR-URL: https://github.com/nodejs/node/pull/13092
Fixes: https://github.com/nodejs/node/issues/13045
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2017-05-19 23:27:44 -04:00
Refael Ackermann fccc0bf6e6 test: add mustCallAtLeast 
PR-URL: https://github.com/nodejs/node/pull/12935
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-05-19 15:22:44 -04:00
Refael Ackermann 6f216710eb test: ignore spurious 'EMFILE' 
According to the explanation in #3635#issuecomment-157714683
And as a continuation to #5422 we also ignore EMFILE
"No more file descriptors are available,so no more files can be opened"

PR-URL: https://github.com/nodejs/node/pull/12698
Fixes: https://github.com/nodejs/node/issues/10286
Refs: https://github.com/nodejs/node/issues/3635#issuecomment-157714683
Refs: https://github.com/nodejs/node/pull/5178
Refs: https://github.com/nodejs/node/pull/5179
Refs: https://github.com/nodejs/node/pull/4005
Refs: https://github.com/nodejs/node/pull/5121
Refs: https://github.com/nodejs/node/pull/5422
Refs: https://github.com/nodejs/node/pull/12621#issuecomment-297701459
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2017-05-19 12:07:10 -04:00
Refael Ackermann 80355271c3 build: simplify if in setting of arg_paths 
PR-URL: https://github.com/nodejs/node/pull/12653
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
 2017-05-16 15:26:20 -04:00
Refael Ackermann 4aff0563aa build: reduce one level of spawning in node_gyp 
`configure` will now call `node_gyp` as a module instead of forking
makes it easier to debug

PR-URL: https://github.com/nodejs/node/pull/12653
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
 2017-05-16 15:26:14 -04:00
Refael Ackermann e1cabf6fbd doc, test: add note to response.getHeaders 
* also correct language for the same note for querystring.parse
* add assertions for said note

PR-URL: https://github.com/nodejs/node/pull/12887
Fixes: https://github.com/nodejs/node/issues/12885
Refs: https://github.com/nodejs/node/pull/12883
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2017-05-10 11:07:15 -04:00
Refael Ackermann 68c933c01e test: fix flakyness with yes.exe 
PR-URL: https://github.com/nodejs/node/pull/12821
Fixes: https://github.com/nodejs/node/issues/12817
Refs: https://github.com/nodejs/node/pull/12658
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-05-06 08:20:07 -04:00
Refael Ackermann 1c93e8c94b win: make buildable on VS2017 
* Set default to `vs2015` since `vs2017` is not CI-green yet
* changes vcbuild.bat arg from `vc2015` to `vs2015`/`vs2017`
  `vc` as in Visual C++ is actually versions 14.0 or 14.10
  `vs` as in Visual Studio is 2015 or 2017
  Ref: http://lists.boost.org/Archives/boost/2017/03/233597.php 🤦
* keep `vc2015` for backward compatibility but "undocumented"
* tools: transplant vswhere wrapper from `msvs-com-helper`
  Ref: https://github.com/node4good/msvs-com-helper

PR-URL: https://github.com/nodejs/node/pull/11852
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
 2017-05-05 10:36:05 +02:00
Refael Ackermann aa3eab00da doc: fix formatting of TOC 
PR-URL: https://github.com/nodejs/node/pull/12731
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
 2017-04-30 11:50:09 +01:00
Refael Ackermann 14c6ae81fb build: fix case in lib names 
ninja on Windows chokes if libs are named .Lib (Capital L)

PR-URL: https://github.com/nodejs/node/pull/12522
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
 2017-04-21 09:24:13 -04:00
Refael Ackermann 3a334b1280 tools: update gyp to eb296f6 
* [win] Add support for MS VS2017 (via Registry)

REF: https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161
PR-URL: https://github.com/nodejs/node/pull/12450
Reviewed-By: João Reis <reis@janeasystems.com>
 2017-04-18 13:22:28 -04:00
Refael Ackermann fbe946bb63 benchmark,windows: TCP.readStart() meaningful only after completion 
fixes #11972

PR-URL: https://github.com/nodejs/node/pull/12258
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-04-14 00:04:27 -04:00
Refael Ackermann ca8ccb9176 doc: add refack to collaborators 
PR-URL: https://github.com/nodejs/node/pull/12277
Refs: https://github.com/nodejs/node/blob/master/doc/onboarding.md
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
 2017-04-07 18:29:28 -04:00
Refael Ackermann e139dae157 build: fix path voodoo in icu-generic.gyp 
Intention was to get to `PRODUCT_DIR` so no need to do path voodoo
Also added `'msvs_quote_cmd': 0` and more precise quoting

PR-URL: https://github.com/nodejs/node/pull/11217
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
 2017-04-06 08:21:46 +01:00
Refael Ackermann 394b6ac5cb test: more robust check for location of node.exe 
look for the actual produced `exe` not just the directory

PR-URL: https://github.com/nodejs/node/pull/12120
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
 2017-04-04 10:57:35 -07:00
Refael Ackermann f6ddbaff8a test: performance, remove Popen(shell=True) on Win 
not needed according to official python docs -
https://docs.python.org/2/library/subprocess.html#index-2

PR-URL: https://github.com/nodejs/node/pull/12138
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-04-04 09:48:12 -07:00
Refael Ackermann 5a438489f0 deps: fix postmortem-metadata generator in v8 
Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/joyent/node/pull/8476
 2014-11-14 16:34:58 +01:00
Refael Ackermann b2e519983f deps: fix postmortem-metadata generator in v8 
Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/joyent/node/pull/8476
 2014-10-12 02:05:02 +04:00
Refael Ackermann 8efcc7f456 deps: fix postmortem-metadata generator in v8 
Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/joyent/node/pull/8476
 2014-10-08 15:44:40 +04:00
Refael Ackermann 9116b240c9 deps: update v8 to 3.28.73 
Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/joyent/node/pull/8476
 2014-10-08 15:44:38 +04:00
Refael Ackermann d71dd638c6 deps: fix postmortem-metadata generator in v8 
Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/joyent/node/pull/8476
 2014-10-08 15:36:07 +04:00
Refael Ackermann 939278ac05 deps: update v8 to 3.28.73 
Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/joyent/node/pull/8476
 2014-10-08 15:35:57 +04:00
Refael Ackermann 573e6afc09 tools: fix for testing openssl integrations 
Windows doesn't resolve ".." the way we expect it for symlinks and
junctions.

PR-URL: https://github.com/joyent/node/pull/8489
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Fedor Indutny <fedor@indutny.com>
 2014-10-08 01:19:25 -07:00
Refael Ackermann 423725b34d configure: better detect windows 'bitness' (WOW64) 
Signed-off-by: Fedor Indutny <fedor@indutny.com>
 2014-07-01 15:48:42 +04:00
Refael Ackermann 9b7888ef88 src: fix StringBytes::Write if string is external 
Signed-off-by: Fedor Indutny <fedor@indutny.com>
 2014-05-12 14:59:16 +04:00