Anna Henningsen 76ecec2082 buffer: fix crash for invalid index types ...

2555cb4a40 introduced a crash
when a non-number value was passed to `ParseArrayIndex()`.

We do not always have JS typechecking for that in place, though.
This returns back to the previous behavior of coercing values
to integers, which is certainly questionable.

Refs: https://github.com/nodejs/node/pull/22129
Fixes: https://github.com/nodejs/node/issues/23668

PR-URL: https://github.com/nodejs/node/pull/25154
Reviewed-By: James M Snell <jasnell@gmail.com>

2018-12-31 01:13:00 +01:00

..

inspector

src: introduce DCHECK macro

2018-12-26 12:25:32 -05:00

large_pages

src: fix fully-static & large-pages combination

2018-10-31 18:43:53 -04:00

res

src: deprecate global COUNTER_* and remove perfctr

2018-09-19 11:07:01 +02:00

tracing

tracing: fix static destruction order issue

2018-11-10 12:07:43 +01:00

aliased_buffer.h

src: introduce DCHECK macro

2018-12-26 12:25:32 -05:00

async_wrap-inl.h

src: do proper error checking in AsyncWrap::MakeCallback

2018-06-14 00:43:45 +02:00

async_wrap.cc

src: schedule destroy hooks in BeforeExit early during bootstrap

2018-12-18 10:56:49 -08:00

async_wrap.h

src: schedule destroy hooks in BeforeExit early during bootstrap

2018-12-18 10:56:49 -08:00

base64.h

src: change macro to fn

2018-10-15 15:38:36 +02:00

base_object-inl.h

src: introduce DCHECK macro

2018-12-26 12:25:32 -05:00

base_object.h

src: name EmbededderGraph edges and use class names for nodes

2018-10-04 15:32:30 +02:00

callback_scope.cc

src: use maybe version v8::Function::Call

2018-10-25 20:28:50 +02:00

cares_wrap.cc

dns: fix TTL value for AAAA replies to resolveAny()

2018-12-26 14:45:16 +01:00

connect_wrap.cc

src: refactor BaseObject internal field management

2018-05-04 00:57:39 +02:00

connect_wrap.h

src: name EmbededderGraph edges and use class names for nodes

2018-10-04 15:32:30 +02:00

connection_wrap.cc

src: make req_wrap a unique_ptr in AfterConnect

2018-10-01 08:26:30 +02:00

connection_wrap.h

src: remove unused UVHandle methods

2018-10-15 12:00:00 +02:00

debug_utils.cc

src: port GetLoadedLibraries for freebsd

2018-12-20 12:16:11 +05:30

debug_utils.h

src: use DCHECK_* macros where possible

2018-12-26 12:25:19 -05:00

env-inl.h

src: add DCHECK macros

2018-12-24 10:41:15 +01:00

env.cc

src: add DCHECK macros

2018-12-24 10:41:15 +01:00

env.h

src: add .code and SSL specific error properties

2018-12-27 14:28:33 -08:00

exceptions.cc

src: elevate v8 namespaces of repeated references

2018-11-18 20:12:55 -08:00

fs_event_wrap.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

handle_wrap.cc

src: use JS inheritance for AsyncWrap

2018-10-03 13:43:42 -07:00

handle_wrap.h

src: use JS inheritance for AsyncWrap

2018-10-03 13:43:42 -07:00

heap_utils.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

http_parser_adaptor.h

deps: introduce llhttp

2018-11-10 17:54:21 -05:00

inspector_agent.cc

src: create env->inspector_console_api_object earlier

2018-12-12 19:30:20 -08:00

inspector_agent.h

inspector: split the HostPort being used and the one parsed from CLI

2018-12-09 06:26:53 +08:00

inspector_io.cc

inspector: split the HostPort being used and the one parsed from CLI

2018-12-09 06:26:53 +08:00

inspector_io.h

inspector: split the HostPort being used and the one parsed from CLI

2018-12-09 06:26:53 +08:00

inspector_js_api.cc

inspector: move process.binding to internalBinding

2018-12-13 05:30:51 +01:00

inspector_socket_server.cc

inspector: split main thread interface from transport

2018-07-13 23:42:50 +02:00

inspector_socket_server.h

src: add missing NODE_WANT_INTERNALS guards

2018-08-28 16:54:07 +02:00

inspector_socket.cc

http: switch default parser to llhttp

2018-12-09 21:57:39 +01:00

inspector_socket.h

src: add missing NODE_WANT_INTERNALS guards

2018-08-28 16:54:07 +02:00

js_native_api_types.h

src: factor out Node.js-agnostic N-APIs

2018-11-17 14:38:51 -08:00

js_native_api_v8_internals.h

src: add include for standalone compile

2018-11-21 16:37:59 -08:00

js_native_api_v8.cc

src: use Local version of ToBoolean()

2018-12-11 16:00:22 -05:00

js_native_api_v8.h

n-api: handle reference delete before finalize

2018-11-23 10:01:54 -05:00

js_native_api.h

src: factor out Node.js-agnostic N-APIs

2018-11-17 14:38:51 -08:00

js_stream.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

js_stream.h

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

memory_tracker-inl.h

src: name EmbededderGraph edges and use class names for nodes

2018-10-04 15:32:30 +02:00

memory_tracker.h

src: bundle persistent-to-local methods as class

2018-11-13 05:27:40 +01:00

module_wrap.cc

src: pass along MaybeLocal<> state from URL::ToObject()

2018-12-31 01:10:36 +01:00

module_wrap.h

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

node_api_types.h

src: factor out Node.js-agnostic N-APIs

2018-11-17 14:38:51 -08:00

node_api.cc

src: move C++ binding/addon related code into node_binding{.h, .cc}

2018-11-30 20:14:24 -08:00

node_api.h

src: factor out Node.js-agnostic N-APIs

2018-11-17 14:38:51 -08:00

node_binding.cc

src: move process.nextTick and promise setup into node_task_queue.cc

2018-12-24 07:57:15 +08:00

node_binding.h

src: unload addons when environment quits

2018-12-19 18:35:38 -08:00

node_buffer.cc

buffer: fix crash for invalid index types

2018-12-31 01:13:00 +01:00

node_buffer.h

src: remove public API for option variables

2018-10-03 14:08:06 -07:00

node_code_cache_stub.cc

src: remove code cache integrity check

2018-12-18 18:02:08 +08:00

node_config.cc

src: remove icuDataDir from node config

2018-12-15 09:43:03 -08:00

node_constants.cc

tls: add min/max protocol version options

2018-11-22 09:14:58 -08:00

node_constants.h

src: refactor options parsing

2018-08-22 23:37:19 +02:00

node_context_data.h

src: refactor Environment::GetCurrent() usage

2018-09-17 17:20:27 +02:00

node_contextify.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

node_contextify.h

src: use custom TryCatch subclass

2018-12-03 10:25:06 -06:00

node_credentials.cc

process: move POSIX credential accessors into node_credentials.cc

2018-12-19 02:44:03 +08:00

node_crypto_bio.cc

src: avoid possible race during NodeBIO initialization

2018-08-12 03:58:49 -07:00

node_crypto_bio.h

src: name EmbededderGraph edges and use class names for nodes

2018-10-04 15:32:30 +02:00

node_crypto_clienthello-inl.h

tls: remove unused ocsp extension parsing

2018-12-28 12:57:24 -08:00

node_crypto_clienthello.cc

tls: remove unused ocsp extension parsing

2018-12-28 12:57:24 -08:00

node_crypto_clienthello.h

tls: remove unused ocsp extension parsing

2018-12-28 12:57:24 -08:00

node_crypto_groups.h

…

node_crypto.cc

crypto: fix zero byte allocation assertion failure

2018-12-30 18:18:40 +01:00

node_crypto.h

crypto: add key object API

2018-12-24 14:50:16 +01:00

node_domain.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

node_dtrace.cc

src: fix v8 compiler warnings in src

2018-11-11 08:02:30 +01:00

node_dtrace.h

src: refactor #include handling

2017-09-14 17:38:38 +02:00

node_encoding.cc

src: rework (mostly internal) functions to use Maybes

2018-09-02 14:25:16 +02:00

node_env_var.cc

process: move environment variable proxy code into node_env_var.cc

2018-12-17 16:21:25 -08:00

node_errors.cc

src: ignore termination exceptions in fatal TryCatch

2018-12-31 01:10:35 +01:00

node_errors.h

src: use custom TryCatch subclass

2018-12-03 10:25:06 -06:00

node_file.cc

src: mark some global state as const

2018-12-16 20:21:45 -08:00

node_file.h

src: clean clang-tidy errors in node_file.h

2018-10-24 11:52:29 -04:00

node_http2_state.h

http2: add RFC 8441 extended connect protocol support

2018-10-08 08:41:35 -07:00

node_http2.cc

src: use isolate version of BooleanValue()

2018-12-08 22:42:05 -08:00

node_http2.h

http2: make Http2Settings constructors delegate

2018-10-11 05:21:18 +02:00

node_http_parser_impl.h

cli: add --max-http-header-size flag

2018-12-20 09:31:52 -05:00

node_http_parser_llhttp.cc

src: move the declaration of http parser versions into node_metadata.h

2018-12-21 07:46:30 +08:00

node_http_parser_traditional.cc

src: move the declaration of http parser versions into node_metadata.h

2018-12-21 07:46:30 +08:00

node_i18n.cc

src: initialize ICU version in per_process::metadata.versions

2018-12-21 07:46:47 +08:00

node_i18n.h

src: refactor options parsing

2018-08-22 23:37:19 +02:00

node_internals.h

src: move process.nextTick and promise setup into node_task_queue.cc

2018-12-24 07:57:15 +08:00

node_main.cc

process: move POSIX credential accessors into node_credentials.cc

2018-12-19 02:44:03 +08:00

node_messaging.cc

worker: fix nullptr deref after MessagePort deser failure

2018-12-19 05:30:31 +01:00

node_messaging.h

src: name EmbededderGraph edges and use class names for nodes

2018-10-04 15:32:30 +02:00

node_metadata.cc

src: initialize ICU version in per_process::metadata.versions

2018-12-21 07:46:47 +08:00

node_metadata.h

src: initialize ICU version in per_process::metadata.versions

2018-12-21 07:46:47 +08:00

node_mutex.h

src: add missing NODE_WANT_INTERNALS guards

2018-08-28 16:54:07 +02:00

node_native_module.cc

src: always compile and store code cache for native modules

2018-12-18 18:02:11 +08:00

node_native_module.h

src: always compile and store code cache for native modules

2018-12-18 18:02:11 +08:00

node_object_wrap.h

src: remove MarkIndependent() calls

2018-04-22 11:23:29 +02:00

node_options-inl.h

src: add kUInteger parsing

2018-12-20 09:31:52 -05:00

node_options.cc

cli: add --max-http-header-size flag

2018-12-20 09:31:52 -05:00

node_options.h

cli: add --max-http-header-size flag

2018-12-20 09:31:52 -05:00

node_os.cc

os: use uv_os_gethostname() in hostname()

2018-12-20 13:44:28 -05:00

node_perf_common.h

perf_hooks: make GC tracking state per-Environment

2018-12-17 02:29:10 +01:00

node_perf.cc

perf_hooks: make GC tracking state per-Environment

2018-12-17 02:29:10 +01:00

node_perf.h

perf_hooks,trace_events: emit perf milestone trace events

2018-03-16 10:54:05 -07:00

node_persistent.h

src: bundle persistent-to-local methods as class

2018-11-13 05:27:40 +01:00

node_platform.cc

src: reduce platform worker barrier lifetime

2018-10-12 22:30:53 -07:00

node_platform.h

src: reduce platform worker barrier lifetime

2018-10-12 22:30:53 -07:00

node_postmortem_metadata.cc

src: mark some global state as const

2018-12-16 20:21:45 -08:00

node_process.cc

src: move more process methods initialization in bootstrap/node.js

2018-12-21 16:33:09 +08:00

node_provider.d

…

node_revert.h

meta: merge TSC and CTC back into a single body

2017-08-29 08:39:25 -07:00

node_root_certs.h

crypto: update root certificates

2018-12-21 15:54:43 +01:00

node_serdes.cc

src: use isolate version of BooleanValue()

2018-12-08 22:42:05 -08:00

node_stat_watcher.cc

src: fix v8 compiler warnings in src

2018-11-11 08:02:30 +01:00

node_stat_watcher.h

src: name EmbededderGraph edges and use class names for nodes

2018-10-04 15:32:30 +02:00

node_symbols.cc

src: move symbols binding into node_symbols.cc

2018-12-24 07:57:13 +08:00

node_task_queue.cc

src: move process.nextTick and promise setup into node_task_queue.cc

2018-12-24 07:57:15 +08:00

node_trace_events.cc

trace_events: move SetupTraceCategoryState into node_trace_events.cc

2018-12-21 16:48:25 +08:00

node_types.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

node_union_bytes.h

process: specialize building and storage of process.config

2018-12-11 06:40:09 +08:00

node_url.cc

src: pass along MaybeLocal<> state from URL::ToObject()

2018-12-31 01:10:36 +01:00

node_url.h

src: pass along MaybeLocal<> state from URL::ToObject()

2018-12-31 01:10:36 +01:00

node_util.cc

process: make internal/queue_microtask.js more self-contained

2018-12-29 18:58:39 +08:00

node_v8.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

node_version.h

src: update NODE_MODULE_VERSION to 68

2018-12-06 15:25:10 +01:00

node_watchdog.cc

src: do not alias new and old signal masks

2018-12-07 10:13:51 -08:00

node_watchdog.h

vm: fix race condition with timeout param

2017-05-23 21:00:40 +02:00

node_win32_etw_provider-inl.h

src, tools: add check for left leaning pointers

2018-06-07 05:46:51 +02:00

node_win32_etw_provider.cc

src: fix etw provider include on Windows

2017-10-31 07:53:49 -07:00

node_win32_etw_provider.h

src, tools: add check for left leaning pointers

2018-06-07 05:46:51 +02:00

node_worker.cc

inspector: split the HostPort being used and the one parsed from CLI

2018-12-09 06:26:53 +08:00

node_worker.h

src: name EmbededderGraph edges and use class names for nodes

2018-10-04 15:32:30 +02:00

node_zlib.cc

src: bundle persistent-to-local methods as class

2018-11-13 05:27:40 +01:00

node.cc

process: make internal/queue_microtask.js more self-contained

2018-12-29 18:58:39 +08:00

node.d

…

node.h

src: fix Set() usage in node.h

2018-11-07 12:29:37 -05:00

node.stp

src: fix Systemtap node_gc_stop probe

2018-04-25 12:22:47 -03:00

notrace_macros.py

test: do not lint macros files (again)

2018-12-11 12:16:40 +01:00

pipe_wrap.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

pipe_wrap.h

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

process_wrap.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

req_wrap-inl.h

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26 12:29:31 +02:00

req_wrap.h

src: keep track of open requests

2018-05-10 14:15:16 +02:00

sharedarraybuffer_metadata.cc

benchmark,doc,lib,src,test,tools: fix typos

2018-10-09 16:53:12 +03:00

sharedarraybuffer_metadata.h

worker: add SharedArrayBuffer sharing

2018-06-06 19:43:46 +02:00

signal_wrap.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

spawn_sync.cc

src: use isolate version of BooleanValue()

2018-12-08 22:42:05 -08:00

spawn_sync.h

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

stream_base-inl.h

src: add DCHECK macros

2018-12-24 10:41:15 +01:00

stream_base.cc

src: add DCHECK macros

2018-12-24 10:41:15 +01:00

stream_base.h

src: improve StreamBase write throughput

2018-10-28 15:15:15 +01:00

stream_pipe.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

stream_pipe.h

src: name EmbededderGraph edges and use class names for nodes

2018-10-04 15:32:30 +02:00

stream_wrap.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

stream_wrap.h

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

string_bytes.cc

src: allow UTF-16 in generic StringBytes decode call

2018-09-03 22:33:42 +02:00

string_bytes.h

src: fulfill Maybe contract in InlineDecoder

2018-12-30 20:15:39 +01:00

string_decoder-inl.h

string_decoder: reimplement in C++

2018-02-10 14:38:56 +01:00

string_decoder.cc

src: introduce DCHECK macro

2018-12-26 12:25:32 -05:00

string_decoder.h

string_decoder: reimplement in C++

2018-02-10 14:38:56 +01:00

string_search.h

src: use DCHECK_* macros where possible

2018-12-26 12:25:19 -05:00

tcp_wrap.cc

src: extract common Bind method

2018-12-17 16:40:39 -05:00

tcp_wrap.h

src: extract common Bind method

2018-12-17 16:40:39 -05:00

timers.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

tls_wrap.cc

src: add .code and SSL specific error properties

2018-12-27 14:28:33 -08:00

tls_wrap.h

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

tty_wrap.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

tty_wrap.h

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

udp_wrap.cc

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

udp_wrap.h

src: fix type mismatch warnings from missing priv

2018-12-03 19:44:15 -08:00

util-inl.h

src: bundle persistent-to-local methods as class

2018-11-13 05:27:40 +01:00

util.cc

src: fix warning for potential snprintf truncation

2018-12-07 10:13:44 -08:00

util.h

src: introduce DCHECK macro

2018-12-26 12:25:32 -05:00

uv.cc

src: lazily load internalBinding('uv') and build the errmap lazily

2018-12-29 19:22:23 +08:00

v8abbr.h

src: update postmortem constant

2018-12-06 15:25:59 +01:00

v8ustack.d

src: update ustack offset identifiers

2017-10-18 17:03:11 -07:00